Commit graph

19 commits

Author SHA1 Message Date
Kate Hsuan
fbafcc77a0 firmware-security: improve datetime format parsing
Showing the datetime string using cc_util_get_smart_date_time().
2022-10-25 23:49:16 +00:00
Jake Dane
89443fe550 desktop: Remove obsolete Bugzilla entries
The `X-GNOME-Bugzilla-*` entries were for use by bug-buddy, a GNOME 2
technology that's been gone for over a decade. These entries are
obsolete and can be removed from all desktop files.

The `X-GNOME-Settings-Panel` entry is also obsolete as far as I can
tell and only these panels had it in their desktop file: notifications,
sharing, sound and user-accounts. These entries can also be removed.

After removing the `X-GNOME-Bugzilla-*` entries, the desktop files have
no more variables in them. The meson `configure_file` step is therefor
pointless—there are no variables to configure. As such the
`*.desktop.in.in` files are renamed to `*.desktop.in` to reflect this
and `meson.build` files are modified to remove `configure_file` step.
2022-10-20 13:20:09 +00:00
Alexander Mikhaylenko
53fd0d69e2 firmware-security: Don't use .view on rows
I'm not sure what the intention was here, but it didn't work. It made rows
white in light variant (same as other rows), but even darker than they were
before in dark.
2022-09-22 15:34:56 +00:00
Kate Hsuan
ac74cf695c firmware-security: hide expander arrow when event description is unavailable
Showing an arrow for an empty expander row for the event confuses the user.
The user may misunderstand there is the information behind the arrow and then
the user will click it but will not get any response from the panel.
Therefore, to prevent confusing the user, the expander will be hidden for a
event with an empty description.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2031

Signed-off-by: Kate Hsuan <hpa@redhat.com>
2022-08-29 16:11:14 +00:00
Richard Hughes
12352f8c1a firmware-security: Move the workaround for UEFI Secure Boot lower
This fixes the toplevel security level to correctly show failed.
2022-08-25 14:37:14 +00:00
Kate Hsuan
0245329949 firmware-security: Hide the panel when chassis type is an empty string
When requesting the chassis type through systemd-hostnamed, it sometimes
returns an empty string "" not the "vm" to present the virtual machine.
Since this panel will not be shown in the VM environment, if systemd-hostnamed
returns an empty string or "vm", the panel will be hidden.

Signed-off-by: Kate Hsuan <hpa@redhat.com>
2022-08-24 14:39:33 +00:00
Richard Hughes
be3d9752bc firmware-security: Handle platforms that do not have a valid set of HSI tests
This affects aarch64 and older AMD devices.

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2014
2022-08-24 14:39:58 +01:00
Richard Hughes
941fdeaa05 firmware-security: Only show events that have changed value 2022-08-24 14:27:59 +01:00
Kate Hsuan
82b6e2c7bb firmware-security: Tweak panel style
Fix the spacing issues of several widgets, including the status icon,
label, and subtitle in a expander row.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1999
Signed-off-by: Kate Hsuan <hpa@redhat.com>
2022-08-10 16:31:26 -03:00
Kate Hsuan
57fb0e28ae panels: firmware-security: Fix incorrect secure boot icon
If Secure boot is enabled, secure_boot_icon should be channel-secure-symbolic.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1998
Signed-off-by: Kate Hsuan <hpa@redhat.com>
2022-08-10 11:47:52 +08:00
Kate Hsuan
784f83eb44 panels: firmware-security: new panel UX design implementation
The new UX implementation includes
1. Showing the security level using a number.
2. Showing descriptions of events and HSI checking items.
3. Change the style of the security level number.
4. Add the status icon and label for each HSI checking item.

Signed-off-by: Kate Hsuan <hpa@redhat.com>
2022-08-04 19:46:28 +00:00
Richard Hughes
e0d599bb40 firmware-security: Do not show the 'Processor Supported' attribute
This is really just saying "the HSI tests make sense" and is not really
useful to show in the UI.
2022-08-01 19:53:15 +00:00
Kate Hsuan
68ca4e5a3f Show a description for each event
Show the HSI event description to improve the UX and match the new mockups.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1938

Signed-off-by: Kate Hsuan <hpa@redhat.com>
Signed-off-by: Richard Hughes <richard@hughsie.com>
2022-07-29 07:35:30 +01:00
Kate Hsuan
1e53da4720 panels: firmware-security: Reduce the length of description
The descriptions of secure boot status were made simpler to improve the
user friendly.

Link: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1937
Signed-off-by: Kate Hsuan <hpa@redhat.com>
2022-07-21 22:50:06 +08:00
Richard Hughes
e11929e0c1 firmware-security: Hide the panel when using a VM
Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1972
2022-07-21 13:21:12 +01:00
Kate Hsuan
d38a570efa firmware-security: Set the HSI row icon correctly for higher HSI levels
Set icon image to "emblem-default-symbolic" for higher HSI value.
2022-07-20 15:58:07 +00:00
Richard Hughes
032f8a4556 firmware-security: Correctly show SecureBoot status with new fwupd versions
Adapt to the org.fwupd.hsi.Uefi.SecureBoot HSI being fixed in
https://github.com/fwupd/fwupd/pull/4835 (level 0 isn't a valid number
unless it is a runtime issue, and the docs have always said HSI-1).

The org.fwupd.hsi.Uefi.Pk attribute has always been HSI-1, and so the
wrong hashtable was being queried -- which is probably my fault for
making SecureBoot an invalid value in the first place.

We also do not have to track the HSI-0 failures now, so delete the
hashtable completely.
2022-07-20 15:58:07 +00:00
Richard Hughes
5954dffda4 firmware-security: Set the HSI row colors correctly for higher HSI levels
If we get HSI-2 then the HS1-2 row should be 'success', as should HSI-1.
2022-07-20 15:58:07 +00:00
Kate Hsuan
69598b9e08 Add Firmware Security panel
The Firmware Security panel exposes the host security levels
and details. The information is generated by fwupd. The panel
also exposes hardware configuration changes to pinpoint the
configuration changing time.

Currently this panel shows:

 - HSI and secure boot status
 - Details of HSI and secure boot
 - Configuration changelog
 - Digested security level
 - Extended protection
2022-06-27 13:53:30 -03:00