Commit graph

4863 commits

Author SHA1 Message Date
Mohammed Sadiq
572f9fe8c3 info-overview: Simplify UI code
Increasing width of a column makes column in each row to have the same
width. So it is unnecessary to set 3rd column of each row separately to
have the same width. Let's do it just once.

https://bugzilla.gnome.org/show_bug.cgi?id=779216
2017-06-10 08:35:46 -03:00
Mohammed Sadiq
4a06cff5c1 removable-media: Replace GtkTable with GtkGrid
https://bugzilla.gnome.org/show_bug.cgi?id=779216
2017-06-09 12:18:53 -03:00
Mohammed Sadiq
695887c7a0 info-overview: replace GtkTable with GtkGrid
GtkTable has been deprecated. So let it be replaced with
GtkGrid.

https://bugzilla.gnome.org/show_bug.cgi?id=779216
2017-06-09 12:18:52 -03:00
Mohammed Sadiq
d6db504945 info: Remove dead ui code
https://bugzilla.gnome.org/show_bug.cgi?id=779216
2017-06-09 11:22:33 -03:00
Silvère Latchurié
5508226405 background: handle EXIF orientation in chooser
The chooser ignores EXIF orientations embedded in the pictures when the
thumbnails are generated.

Because the EXIF informations are available after the file has been
loaded, it has to be reloaded if the transformed dimensions don't
match the thumbnails constraints.

The transformations are directly applied for EXIF orientations 1, 2,
3 and 4. For EXIF orientations 5, 6, 7 and 8, the pictures are reloaded
with swapped dimensions before the transformations are applied.

https://bugzilla.gnome.org/show_bug.cgi?id=783200
2017-06-07 18:24:26 +02:00
Bastien Nocera
99acb323d2 background: Add more information to run-time warning
It was impossible to know which background XML had an error with the
original message.
2017-06-07 18:24:26 +02:00
Bastien Nocera
60ad6a35b4 wacom: Fix compile-time warning
expected ‘GtkWidget * {aka struct _GtkWidget *}’ but argument is of type ‘CcWacomNavButton * {aka struct _CcWacomNavButton *}’
2017-06-07 18:17:33 +02:00
Mohammed Sadiq
8713eac981 details: Split removable media as a separate panel
As part of the preparation to split all these pages as
separate panels in the future.

https://bugzilla.gnome.org/show_bug.cgi?id=779216
2017-06-04 10:39:16 -03:00
Debarshi Ray
ebdaa85ba4 online-accounts: Increase the spacing above the "Remove Account" button
https://bugzilla.gnome.org/show_bug.cgi?id=779368
2017-05-31 16:38:16 +02:00
Rui Matos
4bb33fd878 region: Avoid starting with a gap at the bottom of the input chooser
We can simply let the natural size request determine the dialog's
height.

https://bugzilla.gnome.org/show_bug.cgi?id=783058
2017-05-30 18:31:00 +02:00
Rui Matos
c99f6b58aa region: Don't return the input chooser dialog if nothing is selected
In some cases we end up getting an input source row activated without
it being selected. This seems like a GtkListBox bug but we can easily
avoid it.

https://bugzilla.gnome.org/show_bug.cgi?id=783058
2017-05-30 18:31:00 +02:00
Rui Matos
6e4b4e944a region: Make the input source chooser back button activate on click
We lost this behavior with commit
3b14056a01 to fix keyboard navigation
but we can add it back by handling button events ourselves.

https://bugzilla.gnome.org/show_bug.cgi?id=783058
2017-05-30 18:31:00 +02:00
Georges Basile Stavracas Neto
e63accbf82 online-accounts: Move the margins and spacing lower down the hierarchy
The expired credentials GtkButton is going to be replaced with a
GtkInfoBar touching the top, start and end edges of the GtkDialog.
Therefore, the margins around the account details and GtkSwitches
cannot be set on the higher level GtkBoxes. Instead, they need to be
set lower down the hierarchy closer to the actual widgets that need
them.

Bump required GOA version for the new goa_provider_show_account
behaviour.

https://bugzilla.gnome.org/show_bug.cgi?id=779368
2017-05-30 17:06:44 +02:00
Felipe Borges
00a45b3d70 printers: Use headerbar in PpOptionsDialog
https://bugzilla.gnome.org/show_bug.cgi?id=779708
2017-05-29 19:29:28 +02:00
Felipe Borges
ca2d97f76a printers: Drop PpOptionsDialog action_area
There's no need for the dialog action_area since we are moving
towards a header bar dialog.

https://bugzilla.gnome.org/show_bug.cgi?id=779708
2017-05-29 19:29:28 +02:00
Michael Catanzaro
50160be2c6 printers: Move options dialog spinner out of the action area
For an infinitesimal amount of time after opening the options dialog, a
spinner is displayed at the start of the action area while the dialog
loads asynchronously. Display the spinner in the center of the dialog
instead, using a GtkStack to switch between spinner mode and normal
mode. Test by removing the calls to printer_get_ppd_async(),
get_named_dest_async(), and get_ipp_attributes_async() from the bottom
of populate_options().

Why? (1) It looks better this way. (2) Need to stop using the action
area in order to switch to a header bar.

https://bugzilla.gnome.org/show_bug.cgi?id=755713

https://bugzilla.gnome.org/show_bug.cgi?id=779708
2017-05-29 19:25:51 +02:00
Felipe Borges
6dcf057a53 printers: Scroll view to show newly added Printer
In scenarios with a long list of printers, it might be difficult
to find a newly added printer.

This patch make the view scroll to the allocated position of the
printer entry.

https://bugzilla.gnome.org/show_bug.cgi?id=779506
2017-05-29 17:49:11 +02:00
Felipe Borges
f3141e430b printers: Drop "select_new_printer" property leftover
The select_new_printer property used to be an indicator whether
the view should change to present the newly added printer.

With the Printers presented as a list in the new design, there's
no need for this flag.

https://bugzilla.gnome.org/show_bug.cgi?id=779506
2017-05-29 17:34:55 +02:00
Mohammed Sadiq
84ccb364c5 info: Remove unused struct members
These struct members has been moved to overview panel and is
no longer used here.

https://bugzilla.gnome.org/show_bug.cgi?id=779216
2017-05-27 12:07:30 -03:00
Piotr Drąg
21d697cbe5 printers: Use Unicode quotation marks in a translatable string
See https://developer.gnome.org/hig/stable/typography.html

https://bugzilla.gnome.org/show_bug.cgi?id=772199
2017-05-26 16:10:47 +02:00
Felipe Borges
e5624f90bf printers: Add 10s timeout for printer removal
Dismisses the Printer removal notification after 10 seconds,
removing the printer permanently.

The 10 seconds value is taken from the online-accounts panel.

https://bugzilla.gnome.org/show_bug.cgi?id=693187
2017-05-26 13:16:39 +02:00
Felipe Borges
f065f5005f printers: Allow undoing deletion of a printer
Instead of directly applying the deletion of a printer, we should
follow the GNOME in-app notification deletion guidelines.

This patch introduces the in-app notification following the HIG[0]
for the deletion of a printer. It allows to "undo" the deletion.

The default behavior for these notification is to dismiss a previous
notification. In doing so, when deleting multiple printers, the
"Undo" button only restores the last deleted one. We don't do batch/
bulk removal in the printers panel.

[0] https://developer.gnome.org/hig/stable/in-app-notifications.html.en

https://bugzilla.gnome.org/show_bug.cgi?id=693187
2017-05-26 13:16:39 +02:00
Felipe Borges
5aca01cd65 printers: Remove printers asynchronously
Introduce pp_printer_delete_async ()

https://bugzilla.gnome.org/show_bug.cgi?id=693187
2017-05-26 13:16:36 +02:00
Changwoo Ryu
fb2989dca4 region: Use locale aware date time formats for previewing
%x for date, %X for time, %c for date&time.

https://bugzilla.gnome.org/show_bug.cgi?id=687923
2017-05-25 12:12:10 +02:00
Mohammed Sadiq
1154658cd9 details: Split default apps as a separate panel
https://bugzilla.gnome.org/show_bug.cgi?id=779216
2017-05-24 10:56:13 -03:00
Georges Basile Stavracas Neto
4ac4f4a04e network: Make the history dialog use a headerbar
In order to start moving towards the new redesigned Network
panel [1], it is necessary to make the dialogs use a headerbar.

Currently, however, they don't, making the dialog sinconsistent
with the rest of the panels, and the GNOME desktop as a whole.

Fix that by setting the headerbar to the History dialog, and
adjusting the elements so hat they match the "Known Wi-Fi Networks"
dialog in the mockup [1].

[1] https://github.com/gnome-design-team/gnome-mockups/blob/master/system-settings/network/aday2/network-wires.png

https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-22 12:40:13 -03:00
Jonathan Kang
9cc065bb04 network: Update the hotspot dialog
Update the hotspot dialog according to the new redesigned Network
panel[1].

[1] https://github.com/gnome-design-team/gnome-mockups/blob/master/system-settings/network/aday2/network-wires.png

https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-22 12:28:32 -03:00
Georges Basile Stavracas Neto
fe2a21e696 network: Make connection editor dialog use a headerbar
In order to start moving towards the new redesigned connection
editor [1], it is necessary to make the dialog use a headerbar.

Currently, however, it doesn't, making the connection editor
dialog inconsistent with the rest of the panels, and the GNOME
desktop as a whole.

Fix that by exporting the buttons as action buttons, and setting
the use-header-bar property to TRUE.

[1] https://github.com/gnome-design-team/gnome-mockups/blob/master/system-settings/network/aday2/network-wires.png

https://bugzilla.gnome.org/show_bug.cgi?id=779841
2017-05-21 10:41:43 -03:00
Mohammed Sadiq
7bebbc0099 info: Remove unused code
The GraphicsData structure wasn't being used
in CcInfoPanel's code, and can be safely dropped.

https://bugzilla.gnome.org/show_bug.cgi?id=779216
2017-05-21 10:15:34 -03:00
Rui Matos
585b1fdd9c network: Remove remaining traces of firewalld zones support
These were overlooked in commit
b36924567e.
2017-05-18 18:57:26 +02:00
Rui Matos
8bf07fc414 display: Handle monitor scales on the arrange displays dialog
We need to simply scale monitors' width and height where appropriate
and the API allows us.

https://bugzilla.gnome.org/show_bug.cgi?id=782785
2017-05-18 18:57:26 +02:00
Rui Matos
4b30ecb758 display: Add a slider to select a monitor's scale when available
Mutter's new display configuration API allows configurable per-monitor
scales within a finite set determined by mutter. We expose the
available values in a simple slider widget for each monitor.

https://bugzilla.gnome.org/show_bug.cgi?id=782785
2017-05-18 18:57:26 +02:00
Rui Matos
39c6db2772 display: Don't do automatic layout adjustments with the new API
The new API checks with mutter every time update_apply_button() is
called and mutter is very strict about this so it already does these
adjustments internally.

https://bugzilla.gnome.org/show_bug.cgi?id=782785
2017-05-18 18:57:26 +02:00
Rui Matos
e1d5885ad4 display: Unset primary from a turned off monitor
When setting the primary monitor off we were setting all other
monitors as non-primary which is clearly wrong. It only worked
correctly because the backend code in GnomeRR would implicitly
select a primary for us.

https://bugzilla.gnome.org/show_bug.cgi?id=782785
2017-05-18 18:57:26 +02:00
Rui Matos
d83d613103 display: Choose config manager implementation according to DBus API
Use mutter's new display configuration API if it's available or
fallback to the old API via GnomeRR. The new API requires a new way to
identify outputs so we also need to use an alternative monitor labeler
API.

https://bugzilla.gnome.org/show_bug.cgi?id=782785
2017-05-18 18:57:26 +02:00
Rui Matos
8a175d1106 display: Provide an implementation for mutter's new display config API
This adapts as much as possible mutter's new display config API to the
current display panel's expectations. In particular we keep the
concept of logical monitors hidden from the panel. They will later be
exposed when we re-design the panel to make full use of the new API.

https://bugzilla.gnome.org/show_bug.cgi?id=782785
2017-05-18 18:57:26 +02:00
Rui Matos
71aef22ae0 display: Port the display panel to the new abstract API
This removes the direct dependency on GnomeRR while keeping the
existing functionality.

All the tiled monitor special casing was removed since the new API
doesn't expose tiled monitors in the first place.

A check for virtual size limits was removed but it wasn't being
enforced anyway.

We also introduce a blank error state for when the backend API isn't
available.

https://bugzilla.gnome.org/show_bug.cgi?id=782785
2017-05-18 18:57:26 +02:00
Rui Matos
f82bd7d7db display: Provide a GnomeRR based implementation for the new api
This allows us to keep the panel working with GnomeRR while the new
mutter api develops.

https://bugzilla.gnome.org/show_bug.cgi?id=782785
2017-05-18 18:57:26 +02:00
Rui Matos
918fd9a333 display: Introduce an abstract API for display configuration
This will allow us to switch the display panel away from using the
GnomeRR api directly in order to gracefully move to a new DBus display
configuration API to be provided by mutter while still keeping the
existing functionality on top of the GnomeRR api while the new one
is developed.

https://bugzilla.gnome.org/show_bug.cgi?id=782785
2017-05-18 18:57:26 +02:00
Silvère Latchurié
c890872843 datetime: Fix the style of the date/time selection dialog
Fix the size of the AM/PM button. Add padding to the time widgets and to the panel.

https://bugzilla.gnome.org/show_bug.cgi?id=778146
2017-05-17 17:30:07 +02:00
Benjamin Berg
2c95c6a5d0 network: Include the connection title in the sort string
The list of networks is sorted by connection type. If a user has e.g. a
lot of VPN connections, then the unsorted list is hard to browse.
To fix this, include the title of the connection in the sort order and
ensure the list is kept sorted when a title is changed.

Reported-by: Oliver Haessler <oliver@redhat.com>

https://bugzilla.gnome.org/show_bug.cgi?id=778685
2017-05-17 15:14:10 +02:00
Benjamin Berg
f70ac1d863 network: Re-render connection title whenever it changes
The title of network connections may change if the user edits it or if
it was changed programatically by another program. This worked fine, but
the UI was not updated. This patch ensures the network list in the UI is
updated.

Reported-by: Oliver Haessler <oliver@redhat.com>

https://bugzilla.gnome.org/show_bug.cgi?id=778685
2017-05-17 11:24:39 +02:00
Benjamin Berg
93fc508061 network: Remove unused "title" column from devices liststore
The title column is not used as the title is fetched from the net object
on the fly when it is needed.

https://bugzilla.gnome.org/show_bug.cgi?id=778685
2017-05-17 11:24:39 +02:00
Silvère Latchurié
7bd7fcdf2c user-accounts: Handle EXIF orientation
Apply the EXIF orientation of the picture that has been picked.

https://bugzilla.gnome.org/show_bug.cgi?id=706547
2017-05-15 11:51:08 +02:00
Georges Basile Stavracas Neto
7c405d77a7 keyboard: Inform that 'backspace' is the clear key
The Keyboard shortcut editor dialog gives no clue on how
to disable a shortcut, and users were confused by this
lack of information.

Fix that by informing the user about the Backspace role
when editing a shortcut.

https://bugzilla.gnome.org/show_bug.cgi?id=777401
2017-05-10 20:45:07 -03:00
Felipe Borges
870b4e7190 printers: Filter the printer-location in the search
Show printer search results where the searched string matches
the printer-location.

https://bugzilla.gnome.org/show_bug.cgi?id=779656
2017-05-10 11:04:29 +02:00
Felipe Borges
34aedbe992 printers: Add search capabilities to the panel
Due to the recent changes towards the new design, it became slightly
harder to find a printer given a long list of entries.

This patch introduces search capabilities to the panel, filtering
based on the printer name.

https://bugzilla.gnome.org/show_bug.cgi?id=779656
2017-05-09 15:52:12 +02:00
Felipe Borges
e26756d7e3 printers: Make printers-list a GtkListBox
By making the printers list a GtkListBox instead of a GtkBox, we
can use listbox's capabilities for sorting and filter.

https://bugzilla.gnome.org/show_bug.cgi?id=779656
2017-05-09 15:47:04 +02:00
Bastien Nocera
4ee2055027 network: Better debug when creating a hotspot 2017-05-05 19:05:45 +02:00
Georges Basile Stavracas Neto
f981eb58ac keyboard: Add more key aliases
To improve even more the search feature, add the
following new key aliases:

Option  → Alt
Command → Super
Apple   → Super

https://bugzilla.gnome.org/show_bug.cgi?id=772565
2017-05-04 10:42:14 +02:00