applications/gnome-control-center
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
20761 commits 324 branches 641 tags 195 MiB
Commit graph

563 commits

Author SHA1 Message Date
Felipe Borges
909eb2ac31 printers: Make the dialogs independent of the PpPrinterEntry lifetime 
https://bugzilla.gnome.org/show_bug.cgi?id=779846
 2017-03-13 09:20:23 +01:00
Allan Day
aa2b98b0ea printers: improve panel layout 
Increase spacing in various places and reduce the icon size. This
makes spacing more even and makes the rows feels more open.

https://bugzilla.gnome.org/show_bug.cgi?id=779700
 2017-03-10 16:22:08 +01:00
Felipe Borges
1df4da54fc printers: Drop cups_get_jobs_async 
pp_printer_get_jobs_async does the job with more modern GLib API
(GTask).

https://bugzilla.gnome.org/show_bug.cgi?id=779313
 2017-03-06 16:07:07 +01:00
Felipe Borges
2ad93bc0b2 printers: Properly free pp_jobs_dialog 
Since now we have proper async implementation for getting jobs, we
do not need to increment/decrement the objects ref_count manually.

https://bugzilla.gnome.org/show_bug.cgi?id=779313
 2017-03-06 16:06:24 +01:00
Felipe Borges
c40772a862 printers: Port PpJobsDialog to pp_printer_get_jobs_async 
https://bugzilla.gnome.org/show_bug.cgi?id=779313
 2017-03-06 16:05:29 +01:00
Felipe Borges
1d0ae49685 printers: Introduce pp_printer_get_jobs_async () 
It is a PpPrinter method to query asychronously for printing jobs
information.

It should replace cups_get_jobs_async ()

https://bugzilla.gnome.org/show_bug.cgi?id=779313
 2017-03-06 16:05:29 +01:00
Georges Basile Stavracas Neto
726dcfee91 printers: Allow printer model label to ellipsize 
In the Printers panel, the model label of a given printer
may be a long string, specially when it's composed of the
versioning and specifics of the printer.

Because the model label doesn't ellipsize, we may have very
long labels, making the entire Control Center very wide and
unresizeable.

Fix that by making the model label ellipsize.

https://bugzilla.gnome.org/show_bug.cgi?id=779376
 2017-02-28 18:57:31 +01:00
Felipe Borges
5dd8e58585 printers: Free the PpJobsDialog after closing it 
Now we can safely pp_jobs_dialog_free () the PpJobsDialog.

https://bugzilla.gnome.org/show_bug.cgi?id=779079
 2017-02-27 16:52:17 +01:00
Felipe Borges
fe51a743c3 printers: Count only current users job 
Instead of querying for all the jobs, query just for jobs belonging
to the current user.

https://bugzilla.gnome.org/show_bug.cgi?id=779079
 2017-02-27 16:29:44 +01:00
Felipe Borges
89ff6a610e printers: Store PpPrinterEntry instances for individual manipulation 
We were actualizing the whole printers collection everytime
something should change.

These patch introduces a HashTable keyed by the unique printer.name,
which allows us to access individual instances of PpPrinterEntry.

https://bugzilla.gnome.org/show_bug.cgi?id=779079
 2017-02-27 16:29:43 +01:00
Felipe Borges
5302047ff1 printers: Subscribe to jobs notifications 
The previous implementation of the panel was unable to individually
update a PpPrinterEntry jobs count and its PpJobsDialog.

These changes make the job notifications trigger updates in the
PpPrinterEntry UIs, keeping track of job events on the go.

https://bugzilla.gnome.org/show_bug.cgi?id=779079
 2017-02-27 16:29:43 +01:00
Felipe Borges
86c028ff9b printers: Fill the supply_frame background when supply is empty 
According to the mockups at
https://wiki.gnome.org/Design/SystemSettings/Printers#Guidelines
The supply level bar should have a grey background when there are
no colors in the supply bar.

This patch sets the "background" css name to the supply_frame when
there's not a single color in the supply bar.

https://bugzilla.gnome.org/show_bug.cgi?id=779075
 2017-02-26 12:52:29 +01:00
Felipe Borges
2c7fc8653d printers: Tweak the printer supply level bar 
Make the supply level bar size, margin, border, background, and
saturation match the mockups at
https://wiki.gnome.org/Design/SystemSettings/Printers#Guidelines

Even though we would obtain primary colors by querying the printer
supply info, it is more eye-candy to desaturate (tone down) the
colors in the UI.

https://bugzilla.gnome.org/show_bug.cgi?id=779075
 2017-02-26 12:52:29 +01:00
Felipe Borges
1de145a10b printers: Ellipsize the "location" in the printer entry 
Long location names were causing the whole dialog to expand
horizontally.

This patch ellipsizes the "location" string just like the
other fields of a printer entry.

https://bugzilla.gnome.org/show_bug.cgi?id=779071
 2017-02-26 12:50:03 +01:00
Felipe Borges
4cfb211761 printers: Ellipsize the "Details Dialog" title 
Printers with long names were causing the "Printer Details Dialog"
to expande horizontally.

This patch ellipsizes the custom title of the dialog.

https://bugzilla.gnome.org/show_bug.cgi?id=779071
 2017-02-26 12:49:43 +01:00
Felipe Borges
ca30e0ead9 printers: Use async rename method 
pp_printer_rename_async is better than the old printer_rename
utility.

The PpDetailsDialog doesn't need to do anything in the callback
since we are emiting the "printer-changed" signal when the dialog
is closed.

https://bugzilla.gnome.org/show_bug.cgi?id=769114
 2017-02-22 17:05:50 +01:00
Felipe Borges
5fa1dede21 printers: Do not apply rename/location changes in focus-out-event 
Since we are already applying the changing in the PpDetailsDialog
when it gets closed, there's no need to apply these changes in
the focus-out-event of its respective GtkEntries.

https://bugzilla.gnome.org/show_bug.cgi?id=769114
 2017-02-22 17:05:50 +01:00
Felipe Borges
6bfc60b779 printers: Make the printer address always sensitive 
This patch individually updates the sensitivity of the
PpDetailsDialog child widgets, so we can leave the printer
address label always sensitive.

https://bugzilla.gnome.org/show_bug.cgi?id=778682
 2017-02-15 15:56:32 +01:00
Jeremy Bicha
479f04904c printers: Use ellipsis for "Add a Printer" 
https://bugzilla.gnome.org/show_bug.cgi?id=778568
 2017-02-14 19:09:33 +01:00
Felipe Borges
ae17ba1f47 printers: Set min-content-height on the scrolled window 
Set a minimum content height of 490px for the panel when the
allocated height is smaller than 490px.

490 is an estimated value for the panels to properly fit on netbook
screens. See https://wiki.gnome.org/Design/SystemSettings#Notes

https://bugzilla.gnome.org/show_bug.cgi?id=767600
 2017-02-13 19:45:35 +01:00
Felipe Borges
378e04125d printers: Make the printers panel a single column 
This patch purges all the former TreeView machinery and makes the
Printers panel have the printers listed in a scrolled window, as
designed at https://wiki.gnome.org/Design/SystemSettings/Printers

https://bugzilla.gnome.org/show_bug.cgi?id=767600
 2017-02-13 19:45:35 +01:00
Felipe Borges
7e3d89e13a printers: Introduce PpDetailsDialog 
This dialog handles the editing of printer properties such as
name, location, automatic discovery of driver, manual selection
of printer driver, and manual selection of ppd file.

https://bugzilla.gnome.org/show_bug.cgi?id=767600
 2017-02-13 19:40:09 +01:00
Felipe Borges
37e37961e5 printers: introduce PpPrinterEntry widget 
This commit introduces the following regressions:
- no possibility of renaming properties such as printer names,
location, or changing model/driver. This issue is going to be
solved nextly by the introduction of the PpDetailsDialog.

https://bugzilla.gnome.org/show_bug.cgi?id=767600
 2017-02-13 19:27:49 +01:00
Piotr Drąg
555e230508 Remove no longer necessary contexts from translatable strings 
These strings changed recently and now their contexts don't disambiguate
anything.
 2017-02-12 16:02:22 +01:00
Bastien Nocera
8a7d987ab0 build: libsmbclient is not optional 
As the printers panel is not optional either.
 2017-02-08 19:36:57 +01:00
Bastien Nocera
3f0510cac8 build: Better libm checks 
Use AC_CHECK_LIBM instead of AC_CHECK_LIB(m,...
and use $(LIBM) instead of hardcoding "-lm" in Makefiles.
 2017-02-08 19:21:53 +01:00
Felipe Borges
fc073f2185 printers: Authenticate samba server also on double-click 
The "Add Printer" dialog should be smart enough to know whether
an item listed in the dialog is a samba server or just a printer.
If it is a samba server, it should go for the authentication page
instead of emitting a GTK_RESPONSE_*.

https://bugzilla.gnome.org/show_bug.cgi?id=778277
 2017-02-07 13:14:40 +01:00
Felipe Borges
1504a4d576 printers: Resize the "Add Printer" dialog 
In order to keep the dialog size in the same aspect ratio of the
mockups as https://wiki.gnome.org/Design/SystemSettings/Printers

The "height-request" property should never go higher than 490px.

490 is an estimated value for the panels to properly fit on netbook
screens. See https://wiki.gnome.org/Design/SystemSettings#Notes

https://bugzilla.gnome.org/show_bug.cgi?id=778266
 2017-02-07 12:55:46 +01:00
Felipe Borges
cc738c8223 printers: Update "Add Printer" button to just "Add" 
The mockups at https://wiki.gnome.org/Design/SystemSettings/Printers
show just the word "Add" for the button which opens the "Add Printer"
dialog.

https://bugzilla.gnome.org/show_bug.cgi?id=778268
 2017-02-07 12:16:18 +01:00
Felipe Borges
6f3ed9087d printers: Allow dismissing authentication in "Add New Printer" dialog 
Introduce a "go-back" button allowing to get back to the list of
printers when the user is exposed to the authentication form in
the "Add New Printer" dialog.

This is a redesign based on the newest mockups available at
https://wiki.gnome.org/Design/SystemSettings/Printers#Guidelines

https://bugzilla.gnome.org/show_bug.cgi?id=760783
 2017-02-01 17:53:40 +01:00
Piotr Drąg
9e14dd2c6f Add context to "Add Printer" to disambiguate the string 
Many languages may need to translate a button differently than
a window title.
 2017-01-18 15:42:41 +01:00
Felipe Borges
bd10fb5284 printers: Drop PpAuthenticationDialog 
This dialog is no longer necessary since the authentication form
is now handled in the PpNewPrinterDialog itself.

https://bugzilla.gnome.org/show_bug.cgi?id=760783
 2017-01-18 15:21:38 +01:00
Felipe Borges
e8cdaea332 printers: Decouple PpSamba and the PpNewPrinterDialog 
PpSamba no longer needs to hold a reference to the dialog window.

https://bugzilla.gnome.org/show_bug.cgi?id=760783
 2017-01-18 15:21:38 +01:00
Felipe Borges
ebe21b68ab printers: Use "hostname" in the "Add Printer" dialog 
https://bugzilla.gnome.org/show_bug.cgi?id=760783
 2017-01-18 15:21:38 +01:00
Felipe Borges
afac6d5340 printers: Merge authentication dialog into "Add Printer" 
This is a redesign based on the newest mockups available at
https://wiki.gnome.org/Design/SystemSettings/Printers#Guidelines

https://bugzilla.gnome.org/show_bug.cgi?id=760783
 2017-01-18 10:20:20 +01:00
Felipe Borges
66c7f45307 printers: List new printers ASAP in the "Add Printer" dialog 
List a printer in the "Add Printer" dialog as soon as it is
discovered. The header subtitle "Searching for Printers"
denotes that the Search is not done yet.

https://bugzilla.gnome.org/show_bug.cgi?id=760783
 2016-12-02 15:10:56 +01:00
Felipe Borges
e980b192d8 printers: Make PpSamba a derivated class of PpHost 
https://bugzilla.gnome.org/show_bug.cgi?id=760783
 2016-11-16 15:53:42 +01:00
Felipe Borges
af9fd3e995 printers: Introduce the "authentication-required" signal in PpHost 
This signal should be emitted by hosts and derivated classes when
it is required to authenticate hosts (ask for credentials).

https://bugzilla.gnome.org/show_bug.cgi?id=760783
 2016-11-15 18:54:28 +01:00
Felipe Borges
116f763831 printers: Redesign loading page in the "Add Printer" dialog 
This is a redesign based on the newest mockups available at
https://wiki.gnome.org/Design/SystemSettings/Printers#Guidelines

The spinner is displayed while search is taking place AND nothing
has been found. Ongoing search is indicated by the sub-heading.

https://bugzilla.gnome.org/show_bug.cgi?id=760783
 2016-10-11 16:55:11 +02:00
Felipe Borges
9eedd9fce8 printers: Update "No Printers Found" page in "Add Printers" dialog 
This is a redesign based on the newest mockups available at
https://wiki.gnome.org/Design/SystemSettings/Printers#Guidelines

https://bugzilla.gnome.org/show_bug.cgi?id=760783
 2016-10-11 16:54:45 +02:00
Piotr Drąg
1a38c240d1 printers: use Unicode in translatable strings 
See https://developer.gnome.org/hig/stable/typography.html

https://bugzilla.gnome.org/show_bug.cgi?id=772199
 2016-10-03 15:21:07 +02:00
Felipe Borges
debb21d254 printers: Add grid lines between items in "Add Printer" dialog 
This is a redesign based on the newest mockups available at
https://wiki.gnome.org/Design/SystemSettings/Printers#Guidelines

https://bugzilla.gnome.org/show_bug.cgi?id=760783
 2016-09-22 11:36:10 +02:00
Felipe Borges
a0e75d5d52 printers: Drop "Add Printer" dialog internal borders 
This is a redesign based on the newest mockups available at
https://wiki.gnome.org/Design/SystemSettings/Printers#Guidelines

https://bugzilla.gnome.org/show_bug.cgi?id=760783
 2016-09-22 11:35:42 +02:00
Felipe Borges
bd25c8d1e4 printers: Rename "Add a New Printer" dialog title to "Add Printer" 
This is a redesign based on the newest mockups available at
https://wiki.gnome.org/Design/SystemSettings/Printers#Guidelines

https://bugzilla.gnome.org/show_bug.cgi?id=760783
 2016-09-22 11:32:53 +02:00
Felipe Borges
8f57e4dfc7 printers: Move "Add Printer" dialog buttons to header bar 
It also renames the "Authenticate" button to "Unlock".
This is a redesign based on the newest mockups available at
https://wiki.gnome.org/Design/SystemSettings/Printers#Guidelines

https://bugzilla.gnome.org/show_bug.cgi?id=760783
 2016-09-22 11:32:53 +02:00
Felipe Borges
cf99cebfb9 printers: Move "Add Printer" button to header bar 
This patch introduces a change to the Lock/Unlock logic. From now
on, unlocking the panel causes the "Lock" button to turn into the
"Add Printer" button.

https://bugzilla.gnome.org/show_bug.cgi?id=767600
 2016-09-20 15:23:20 +02:00
Marek Kasik
77750c5076 printers: Fix compilation warning 
We need to include cups/ppd.h explicitly due to some modification
of structure of CUPS headers
 2016-09-20 12:35:42 +02:00
Mario Sanchez Prada
bbe6b6309d Migrate the remaining bits of PpMaintenanceCommand to GTask 
They were still using the deprecated GSimpleAsyncResult and throwing
a lot of warnings when building.

https://bugzilla.gnome.org/show_bug.cgi?id=766861
 2016-08-02 12:42:37 -06:00
Mario Sanchez Prada
c41bbfa7d0 printers: Check all supported CUPS commands, not just the first one 
Use an array of strings to store every supported command and check
the desired command against the elements in that list, instead of
simply checking the first one.

https://bugzilla.gnome.org/show_bug.cgi?id=766861
 2016-08-02 12:42:21 -06:00
Mario Sanchez Prada
4b91972f2c printers: Added new async API to check availability of maintenance commands 
This cleans the code up a bit so that we can extract part of the logic
from _pp_maintenance_command_execute_thread() before getting into fixing
the problem in the logic checking whether a CUPS command is available.

Besides, it will be useful to have this logic extracted as it will be used
later on from pp-printer-entry.c to know whether the "Clean" command is
available, in order to show a menu item "Clean Print Heads" (bug 764620).

https://bugzilla.gnome.org/show_bug.cgi?id=766861
 2016-08-02 12:42:21 -06:00