Commit graph

7578 commits

Author SHA1 Message Date
Robert Ancell
5d65e8df9e firmware-security: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
b041c9df6d notifications: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
f756184e3b display: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
3bd3f82bca thunderbolt: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
39ccf2c610 user-accounts: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
a06914a60c keyboard: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
ae93ded618 search: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
c78eb3d2f8 region: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
89c054a31b network: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
644df7697b datetime: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
f23218e037 background: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
642833509b applications: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Automeris naranja
901f395e9e user-add-dialog: Use CCListRowInfoButton for the "Administrator" AdwActionRow
Follow-up from Follow-up from https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1571
2023-05-30 08:35:12 +00:00
Timotej Šulík
4102a16b40 display: Fix stuck window subtitle in the Displays panel
In case an inapplicable display configuration
is attempted, and the issue is then resolved,
the warning window subtitle remains displayed
even under the "Apply Changes?" title.

Closes #2512.
2023-05-30 00:58:16 +02:00
Timotej Šulík
4fe26944d8 display: Fix gaps when numbering unusable displays 2023-05-28 22:16:10 +00:00
Felipe Borges
e6336ec433 network: Add ToastOverlay to connection-editor 2023-05-26 02:04:52 +00:00
Felipe Borges
3f482559ea network: Make "Import VPN from file" use GtkFileDialog
Since the gtk_file_chooser_dialog APIs are deprecated.
2023-05-26 02:04:52 +00:00
Felipe Borges
e580c309e8 network: Drop legacy vpn_export function
This was a leftover from the old connection-editor.
2023-05-26 02:04:52 +00:00
Ismael
497f599517 network-panel: fix crash when importing wrong vpn file 2023-05-26 02:04:52 +00:00
Felipe Borges
bb351a1b51 common: Fix time entry for RTL languages
While GTK will flip most things for RTL languages, that shouldn't be
the case for displaying time.

These changes make sure that the time-entry/editor behave as expected
in RTL languages.

Fixes #2504
2023-05-26 01:03:45 +00:00
Felipe Borges
e97429f0f6 Make dialogs close when pressing the Escape key
Fixes #2503
2023-05-25 23:24:00 +00:00
Timotej Šulík
4ed1af010a display: Allow mirroring for any number of displays 2023-05-25 21:35:30 +00:00
Felipe Borges
8d2a315c3a thunderbolt: Modernize Device Dialog UI
The device name is now shown on the dialog's titlebar and not in
a row.
2023-05-24 14:27:22 +00:00
Lukáš Tyrychtr
3f47fd0dea common: Make the info button labels selectable
That allows a screen reader to read the information, which was previously
unreachable in any meaningful way.
2023-05-24 12:55:12 +02:00
Lukáš Tyrychtr
41cb03db76 a11y: Present the checked state on the list row itself
That allows the visually impaired user to get the information quicker,
and, as a result of that, we can simplify the focus chain as well.
2023-05-24 09:04:02 +00:00
Gotam Gorabh
f9c75e6694 user-accounts:updated the remove user dialog with AdwMessageDialog
This commit will update the GUI of remove user dialog with AdwMessageDialog which
doesn't follow design guidelines. Re-desined according to https://gitlab.gnome.org/Teams/Design/settings-mockups/-/blob/master/users/users.png

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2093
, https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2341
2023-05-24 08:57:30 +00:00
Pablo Correa Gómez
a2b9620b1b network: keep track of radio buttons in connection editor with action
Hooking to all the toggled signals from all the buttons for executing
the same action is inneficient, and can potenticall end up in a segmentation
 fault due to some race in the signal emmission, where the active button
 gets deactivated before the clicked button is activated

Looking at the GTK4 code, in a radio group:

- The button which was previously active gets de-activated, emitting its
corresponding toggled signal.
- The active property for the clicked button gets set.
- The clicked button emits its toggled signal.

Therefore, if the first toggle signal gets processed before the active
property is set, there can be a race condition. We are seeing this downstream
at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816

Instead of this racy behavior, follow upstream recommendation and keep track
of the state through a stateful signal.
2023-05-24 08:54:06 +00:00
Pablo Correa Gómez
7f7b65545c all: meson: do not specify resources from gresource files as dependencies
Meson extracts them by itself and add them as dependencies for the target.
It means one less location to keep track of files, and a lot less boilerplate
around the meson files
2023-05-24 08:34:14 +00:00
Felipe Borges
2cf57ffb10 datetime: Merge "Clock" and "Calendar" sections
According to mockups at
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/raw/master/date-and-time/date-and-time.png
2023-05-22 13:18:31 +00:00
Felipe Borges
79636a8eb9 datetime: Move "Time Format" row out of "Clock" section
https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1277#note_1751622
2023-05-22 13:18:31 +00:00
Lains
7615bb5ccb datetime: Add top bar clock and calendar switches
For changing the clock display (weekday, seconds, date) and week numbers on the calendar

These switches should change:
- Whether or not the clock display has the week day (e.g. Mon).
- Whether or not the clock display has the date (e.g. Jun 6).
- Whether or not the clock display has seconds (e.g. 12:30:45).
- Whether or not the clock's popup calendar should show the week's number.

Fixes #257
2023-05-22 13:18:31 +00:00
Mpho Jele
483a5f3e8d user-accounts: Use AdwEntryRow for user full name 2023-05-17 11:14:29 +02:00
Markus Göllnitz
98c47cee10 mouse: ensure type CcListRowInfoButton is available to GtkBuilder
The newly introduced CcListRowInfoButton is not available
to GtkBuilder and henceforth building the mouse panel
currently fails.

Therefore, it CcListRowInfoButton has to be declared to
be a type that needs to be available to this panel.

Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
2023-05-16 20:49:28 +02:00
Felipe Borges
b2d5e78934 mouse: Use CcListRowInfoButton for mouse_aceleration row 2023-05-16 13:32:21 +00:00
Felipe Borges
45931c783f user-accounts: Make Administrator row use info button widget
Instead of recreating the menu button and popover.
2023-05-16 13:32:21 +00:00
Felipe Borges
d586df5c87 user-accounts: Add a popover describing the autologin functionality
Fixes #2235
2023-05-16 13:32:21 +00:00
Felipe Borges
00a71d46da common: Introduce CcListRowInfoButton widget
This simplifies the display of additional text information for our
rows.

See #1571
2023-05-16 13:32:21 +00:00
Mario Limonciello
aa46ae53a1 firmware-security: Skip security attributes that have been obsoleted by others
Fixes: #2481
2023-05-15 18:11:56 +00:00
Felipe Borges
073cf028a2 sharing: Add subtitle to each panel row
Fixes #2407
2023-05-15 13:37:17 +02:00
Felipe Borges
36938d53d6 sharing: Add icons next to each row
See #2407
2023-05-15 13:37:17 +02:00
Emad Saadat
813a5f838c wi-fi: Remove extraneous list box in Airplane Mode group
and give parent AdwPreferencesGroup the id of rfkill_widget
to preserve previous behavior (hiding widget when no
airplane mode available).
2023-05-15 10:50:09 +00:00
Emad Saadat
216a7619b7 wi-fi: Have page contents clamped like other pages
Achieved by making the container widget for all other widgets
in the content section of the panel an AdwPreferencesPage and
having each group of widgets (e.g. the airplane mode toggle
and the stack that shows the list of wi-fi networks or a status
message) be in its own AdwPreferencesGroup.

Much along the lines of !1739 and !1740

Also fixes #2420
2023-05-15 10:50:09 +00:00
sunflowerskater
1300d4b2d7 add-user-dialog: Add popover explaining about the "Administrator" option
This change adds a GtkPopover to explain about the "Administrator" option like in the mockups below:
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/blob/master/users/add-user.png
2023-05-10 09:37:04 +00:00
sunflowerskater
1ba63a360c user-panel: Add popover explaining about the "Administrator" option
This change adds a GtkPopover to explain about the "Administrator" option like in the mockups below:
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/raw/master/users/users.png
2023-05-10 09:37:04 +00:00
Balázs Úr
754283c2c2 firmware-security: Mark button label as translatable 2023-05-10 05:33:38 +00:00
velsinki
efc595cccd sharing: Fix visual bug for active indicators
The switch for the current network was only updated to TRUE after a
network change. However, if a new network was not enabled, the switch
should be set to FALSE. This is now properly handled.

Furthermore, the Off/Enabled/Active indicator was also inconsistent
after network changes due to the is_visible check failing sometimes,
even after changing to an already enabled network. Because the actual
current network state is now better tracked, we can just check the state
of the switch instead.
2023-05-05 09:35:01 +00:00
Felipe Borges
6179d585a6 color: Make it easier to translate panel description string
This helps translators understand what are the placeholders in
the visible string.

+#. Translators: This will be presented as the text of a link to the documentation
+#. translators: Text used in link to privacy policy
+#: panels/color/cc-color-panel.c:2021
+#: panels/diagnostics/cc-diagnostics-panel.c:137
+msgid "Learn more"

+#. Translators: %s is a link to the documentation with the label "Learn more"
+#: panels/color/cc-color-panel.c:2023
+msgid "Each device needs an up to date color profile to be color managed. %s"
2023-05-04 10:06:26 +00:00
sunflowerskater
2d310918fa color: Dim information text & fix "Learn more" link alignment 2023-05-04 10:06:26 +00:00
Automeris naranja
8dd0abeaa4 network: Rename "Other Devices" to "Bluetooth"
Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2102
2023-05-04 09:54:49 +00:00
Automeris naranja
13e4e0c242 general: Set a minimum size for various dialogs
This change prevents some dialogs from being shrunk
to a really small size by setting a minimum size for them.
2023-05-04 09:54:07 +00:00