Commit graph

255 commits

Author SHA1 Message Date
Matthias Clasen
1c7188caa7 Fixes #467552
2007-08-20  Matthias Clasen <mclasen@redhat.com>

	Fixes #467552

	* gnome-theme-info.c (gnome_theme_init): avoid double-freed for cursor
	theme infos.

svn path=/trunk/; revision=8023
2007-08-20 11:02:37 +00:00
Jens Granseuer
2f48b99c2a fix double-free, and make the builtins non-static to save relocations
2007-08-17  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (read_cursor_fonts): fix double-free, and make
	the builtins non-static to save relocations

svn path=/trunk/; revision=8013
2007-08-17 17:33:05 +00:00
Jens Granseuer
3b08e16e7f don't leak the cursor font
2007-08-17  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (read_cursor_fonts): don't leak the cursor font

svn path=/trunk/; revision=8010
2007-08-17 15:48:27 +00:00
Jens Granseuer
2a25f23559 various small tweaks and optimizations
2007-08-12  Jens Granseuer  <jensgr@gmx.net>

	* theme-thumbnail.c: (create_folder_icon),
	(create_gtk_theme_pixbuf), (handle_bytes), (message_from_capplet),
	(message_from_child), (read_pixbuf), (generate_theme_thumbnail):
	various small tweaks and optimizations

svn path=/trunk/; revision=7991
2007-08-12 15:30:07 +00:00
Jens Granseuer
4279e8b062 Create the icon theme representative before the GTK stock button. Since we
2007-08-08  Jens Granseuer  <jensgr@gmx.net>

	* theme-thumbnail.c: (create_meta_theme_pixbuf):
	Create the icon theme representative before the GTK stock button. Since
	we explicitly set the icon theme for the first, this ensures both are
	drawn with the same icon theme. Before it was possible when changing
	icon themes (especially on slower machines) that the GtkSettings were
	not yet updated and the stock button still used the old theme.

svn path=/trunk/; revision=7981
2007-08-08 21:46:28 +00:00
Jens Granseuer
3d0bb8f59d make sure we don't run off the end of the array
2007-08-07  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (read_cursor_theme): make sure we don't run off
	the end of the array

svn path=/trunk/; revision=7972
2007-08-07 20:16:18 +00:00
Jens Granseuer
69749b7dcb copy the name for the default cursor, too, lest we crash on free, and only
2007-08-07  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (read_cursor_theme),
	(gnome_theme_cursor_info_free): copy the name for the default cursor,
	too, lest we crash on free, and only unref the thumbnail if we have
	one

svn path=/trunk/; revision=7971
2007-08-07 19:44:18 +00:00
Denis Washington
5cfe0df8a6 Also load the "default" cursor theme as GnomeThemeCursorInfo so we know
2007-08-04  Denis Washington  <denisw@svn.gnome.org>

	* common/gnome-theme-info.c: (read_cursor_theme), (look_for_cursor_theme):
	Also load the "default" cursor theme as GnomeThemeCursorInfo so
	we know about the available sizes. (bug #462409)

	* appearance/appearance-style.c: (prepare_list):
	Only add a "Default Pointer" list item if there is
	no such GnomeThemeCursorInfo.

svn path=/trunk/; revision=7960
2007-08-04 13:05:24 +00:00
Jens Granseuer
aa9ddd3739 reduce metatheme thumbnail size to 128x128 in preparation of using
2007-08-03  Jens Granseuer  <jensgr@gmx.net>

	* data/appearance.glade:
	* data/theme-thumbnailing.png: reduce metatheme thumbnail size to
	128x128 in preparation of using gnome-thumbnail-factory

2007-08-03  Jens Granseuer  <jensgr@gmx.net>

	* theme-thumbnail.c: reduce metatheme thumbnail size to 128x128

svn path=/trunk/; revision=7954
2007-08-03 19:49:32 +00:00
Jens Granseuer
d31c4f7b75 no need for an expensive parse to initialize the colors
2007-08-02  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gnome_theme_color_scheme_parse): no need for an
	expensive parse to initialize the colors

svn path=/trunk/; revision=7949
2007-08-02 21:26:03 +00:00
Jens Granseuer
1ab61b2bbc don't generate GTK thumbnails when we want metacity or icon (bug #462724)
2007-08-02  Jens Granseuer  <jensgr@gmx.net>

	* theme-thumbnail.c: (generate_metacity_theme_thumbnail),
	(generate_icon_theme_thumbnail): don't generate GTK thumbnails when we
	want metacity or icon (bug #462724)

svn path=/trunk/; revision=7948
2007-08-02 18:26:43 +00:00
Jens Granseuer
147912ed01 fix cut'n'paste errors for the tooltip colors and use new color enum
2007-07-30  Jens Granseuer  <jensgr@gmx.net>

	* appearance-style.c: (color_button_clicked_cb): fix cut'n'paste errors
	for the tooltip colors and use new color enum

	* data/appearance.glade: repair the mess glade3 made of the file

2007-07-30  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gnome_theme_color_scheme_parse),
	(gnome_theme_color_scheme_equal):
	* gnome-theme-info.h: add symbolic colors enum and use it

svn path=/trunk/; revision=7936
2007-07-30 18:22:00 +00:00
Thomas Wood
12faf7f40e Add tooltip foreground and background colours to the list of recognised
2007-07-30  Thomas Wood  <thos@gnome.org>

	* appearance-style.c: (update_color_buttons_from_string),
	(check_color_schemes_enabled), (color_button_clicked_cb),
	(style_init):
	* data/appearance.glade:

	Add tooltip foreground and background colours to the list of recognised
	symbolic colours.

2007-07-30  Thomas Wood  <thos@gnome.org>

	* gnome-theme-info.c: (gnome_theme_color_scheme_parse): Add tooltip foreground
	and background colours to the list of recognised symbolic colours.

svn path=/trunk/; revision=7933
2007-07-30 16:49:28 +00:00
Thomas Wood
a316e82ccc Expand check for empty metatheme colour scheme to include blank colour
2007-07-29  Thomas Wood  <thos@gnome.org>

	* gnome-theme-info.c: (gnome_theme_read_meta_theme): Expand check for empty
	metatheme colour scheme to include blank colour scheme strings.

svn path=/trunk/; revision=7926
2007-07-29 17:26:47 +00:00
Thomas Wood
23c161aa35 Prevent some memory leaks
2007-07-29  Thomas Wood  <thos@gnome.org>

	* appearance-style.c: (cursor_theme_sort_func), (prepare_list),
	(style_init): Prevent some memory leaks

2007-07-29  Thomas Wood  <thos@gnome.org>

	* gnome-theme-apply.c: (gnome_meta_theme_set):
	* gtkrc-utils.c: (gtkrc_get_details), (gtkrc_get_color_scheme):

	Prevent some memory leaks

svn path=/trunk/; revision=7920
2007-07-29 13:05:29 +00:00
Denis Washington
2834baf127 Read a cursor theme's name from it's index.theme file if it has one.
2007-07-28  Denis Washington  <denisw@svn.gnome.org>

	* common/gnome-theme-info.h:
	* common/gnome-theme-info.c: (look_in_cursor_theme),
	(gnome_theme_cursor_info_free):
	Read a cursor theme's name from it's index.theme file if it has one.

	* appearance/appearance-style.c: (prepare_list):
	Show readable_name in cursor theme list instead of name.

svn path=/trunk/; revision=7914
2007-07-28 13:53:15 +00:00
Denis Washington
b608a53acb Prevent cursor themes from being recognized as icon themes.
2007-07-28  Denis Washington  <denisw@svn.gnome.org>

	* gnome-theme-info.c: (read_icon_theme):
	Prevent cursor themes from being recognized as icon themes.

svn path=/trunk/; revision=7913
2007-07-28 13:05:59 +00:00
Thomas Wood
f437b8f99d Add missing include
2007-07-28  Thomas Wood  <thos@gnome.org>

	* gnome-theme-info.h: Add missing include

2007-07-28  Thomas Wood  <thos@gnome.org>

	* theme-util.c: Add missing include

svn path=/trunk/; revision=7906
2007-07-28 10:53:57 +00:00
Jens Granseuer
307679f2e2 connect to the GtkTreeViewSelection::changed signal instead of
2007-07-26  Jens Granseuer  <jensgr@gmx.net>

	* gconf-property-editor.c: (peditor_tree_view_widget_changed),
	(gconf_peditor_new_tree_view): connect to the GtkTreeViewSelection::changed
	signal instead of GtkTreeView::cursor_changed, so we actually get notified
	whenever the selection changes

svn path=/trunk/; revision=7899
2007-07-26 21:13:45 +00:00
Jens Granseuer
abd1b52762 move some utility code here from appearance
2007-07-26  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gnome_theme_read_meta_theme),
	(gnome_theme_color_scheme_parse), (gnome_theme_color_scheme_equal):
	* gnome-theme-info.h:
	* gtkrc-utils.c: (str_nequal), (gtkrc_get_color_scheme),
	(gtkrc_get_color_scheme_for_theme):
	* gtkrc-utils.h: move some utility code here from appearance

	* gnome-theme-apply.c: (gnome_meta_theme_set): when applying a metatheme,
	check whether to set/unset the color scheme gconf key (should fix bug
	#421866)

svn path=/trunk/; revision=7897
2007-07-26 19:48:14 +00:00
Denis Washington
78b4743519 Re-add basic support for cursor themes for X servers without the Xcursor
2007-07-26  Denis Washington <denisw@svn.gnome.org>

	* appearance/data/appearance.glade:
	* appearance/appearance-style.c: 
	* appearance/appearance-themes.c: (theme_load_from_gconf),
	(cursor_theme_changed), (prepare_list), (style_init):
	* appearance/theme-save.c: (write_theme_to_disk):
	* appearance/theme-util.h:
	* common/gnome-theme-apply.c: (gnome_meta_theme_set):
	* common/gnome-theme-info.c: 
(add_common_icon_theme_dir_monitor),
	(gnome_theme_init):
	* common/gnome-theme-info.h:
	Re-add basic support for cursor themes for X servers without the Xcursor
	extension, like the one on Solaris.

svn path=/trunk/; revision=7890
2007-07-26 16:15:35 +00:00
Denis Washington
2126b49c6e ChangeLog whitespace fix.
svn path=/trunk/; revision=7884
2007-07-25 17:31:25 +00:00
Denis Washington
ce7f03bdc3 Add support for cursor theme names saved in metathemes.
2007-07-25  Denis Washington <denisw@svn.gnome.org>

  * gnome-theme-info.h:
  * gnome-theme-info.c: (gnome_theme_read_meta_theme):
  * gnome-theme-apply.c: (gnome_meta_theme_set):
  Add support for cursor theme names saved in metathemes.

svn path=/trunk/; revision=7883
2007-07-25 17:30:21 +00:00
Denis Washington
222d100c2d Fix abug introduced by the changes in revision 7856 which caused cursor
2007-07-25  Denis Washington <denisw@svn.gnome.org>

	* gnome-theme-info.c: (add_common_icon_theme_dir_monitor),
	(look_for_cursor_theme):
	Fix abug introduced by the changes in revision 7856 which caused
	cursor themes to not being found anymore.

svn path=/trunk/; revision=7882
2007-07-25 15:43:51 +00:00
Jens Granseuer
2286497f8e general cleanup and leak-plugging add cursor theme info
2007-07-13  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gdk_pixbuf_from_xcursor_image),
	(look_for_cursor_theme), (add_common_icon_theme_dir_monitor),
	(gnome_theme_cursor_info_new): general cleanup and leak-plugging
	* gnome-theme-test.c: (main): add cursor theme info

svn path=/trunk/; revision=7856
2007-07-13 18:32:25 +00:00
Frederic Crozat
e62cc67971 Fix crash when no cursor is specified in theme (fixes bug #455952).
2007-07-13  Frederic Crozat  <fcrozat@mandriva.com>

        * gnome-theme-info.c: (look_for_cursor_theme):
        Fix crash when no cursor is specified in theme (fixes bug #455952).


svn path=/trunk/; revision=7854
2007-07-13 07:35:29 +00:00
Jens Granseuer
fa41845299 include gdk-pixbuf.h (fixes bug #454634)
2007-07-08  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.h: include gdk-pixbuf.h (fixes bug #454634)

svn path=/trunk/; revision=7833
2007-07-08 15:23:08 +00:00
Denis Washington
df0060e59d Silly me...
svn path=/trunk/; revision=7826
2007-07-05 17:51:07 +00:00
Denis Washington
bbee377d3f Add support for cursor themes (GnomeThemeCursorInfo); probably still a bit
2007-07-01  Denis Washington  <denisw@svn.gnome.org>

	* gnome-theme-info.[ch]:
	Add support for cursor themes (GnomeThemeCursorInfo); probably still a bit
	rough around the edges, but it works.

svn path=/trunk/; revision=7823
2007-07-05 17:43:09 +00:00
Jens Granseuer
2d521a0b6e add safeguards for NULL values (closes bug #441036)
2007-07-01  Jens Granseuer  <jensgr@gmx.net>

	* gconf-property-editor.c: (peditor_string_value_changed),
	(peditor_color_value_changed): add safeguards for NULL values (closes
	bug #441036)

svn path=/trunk/; revision=7810
2007-07-01 15:01:23 +00:00
Jens Granseuer
87fb51d921 compare the string from the widget against the converted gconf value, not
2007-06-29  Jens Granseuer  <jensgr@gmx.net>

	* gconf-property-editor.c: (peditor_string_value_changed): compare the
	string from the widget against the converted gconf value, not the
	unmodified one

svn path=/trunk/; revision=7807
2007-06-29 20:53:25 +00:00
Michael Terry
6b9550b491 use icon theme for app icons, bug #450777
svn path=/trunk/; revision=7784
2007-06-26 23:29:58 +00:00
Denis Washington
443068f132 Remove redundant newline in ChangeLog.
svn path=/trunk/; revision=7775
2007-06-25 15:11:22 +00:00
Denis Washington
4ac577360b Generate all types of thumbnails in a seperate process, not just those for
2007-06-25  Denis Washington  <denisw@svn.gnome.org>

	* theme-thumbnail.[ch]:
	Generate all types of thumbnails in a seperate process, not just those for
	metathemes.

svn path=/trunk/; revision=7774
2007-06-25 15:10:21 +00:00
Denis Washington
34adc6a2db Make metatheme thumbnails original-sized and add check box + radio button.
2007-06-22  Denis Washington  <denisw@svn.gnome.org>

	* theme-thumbnail.c: (create_image):
	Make metatheme thumbnails original-sized and add check box + radio button.

svn path=/trunk/; revision=7758
2007-06-22 15:32:44 +00:00
Jens Granseuer
33dd3f654a fix function signatures
2007-06-20  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gnome_theme_icon_info_find,
	gnome_theme_is_writable):
	* gnome-theme-info.h: fix function signatures

svn path=/trunk/; revision=7754
2007-06-20 20:14:18 +00:00
Jens Granseuer
4d5c158170 remove obsolete files
2007-06-18  Jens Granseuer  <jensgr@gmx.net>

	* Makefile.am: remove obsolete files

svn path=/trunk/; revision=7745
2007-06-18 17:56:39 +00:00
Jens Granseuer
556f49a625 plug leak fix comment
2007-06-12  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (gnome_theme_icon_info_free): plug leak
	* theme-thumbnail.c: (message_from_child): fix comment

svn path=/trunk/; revision=7722
2007-06-12 20:57:39 +00:00
Denis Washington
3b1d45c537 Stop the GdkDisplay mess and let gnome-appearance-properties handle gtk+
2007-06-09  Denis Washington  <denisw@svn.gnome.org>

	* theme-thumbnail.c: (generate_gtk_theme_thumbnail):
	Stop the GdkDisplay mess and let gnome-appearance-properties handle
	gtk+ theme changes manually instead.

svn path=/trunk/; revision=7720
2007-06-12 17:05:17 +00:00
Jens Granseuer
934b33e8c7 make it possible to skip engine information if we're not interested and
2007-06-10  Jens Granseuer  <jensgr@gmx.net>

	* gtkrc-utils.c: (gtkrc_get_details), (gtkrc_get_color_scheme):
	make it possible to skip engine information if we're not interested
	and fix a warning

svn path=/trunk/; revision=7712
2007-06-10 18:10:38 +00:00
Jens Granseuer
19cfd08b3d add some more checks so we don't try to strcmp NULL strings (fixes bug
2007-06-10  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-apply.c: (gnome_meta_theme_set): add some more checks so
	we don't try to strcmp NULL strings (fixes bug #445908)

svn path=/trunk/; revision=7710
2007-06-10 17:22:16 +00:00
Denis Washington
f4ee5fb273 Fix the appearance capplet windows not reacting to gtk+ theme changes.
2007-06-09  Denis Washington  <denisw@svn.gnome.org>

	* theme-thumbnail.c: (generate_gtk_theme_thumbnail):
	Fix the appearance capplet windows not reacting to gtk+ theme changes.

svn path=/trunk/; revision=7707
2007-06-09 14:17:58 +00:00
Jens Granseuer
7144393cbc modify the theme change callback to return more useful information and add
2007-06-07  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (handle_change_signal),
	(gnome_theme_is_writable),
	(gnome_theme_info_register_theme_change):
	* gnome-theme-info.h:
	modify the theme change callback to return more useful
	information and add a function to determine whether a given
	theme is writable

svn path=/trunk/; revision=7703
2007-06-07 19:08:19 +00:00
Jens Granseuer
5a510b1c3f remove obsolete files
2007-06-06  Jens Granseuer  <jensgr@gmx.net>

	* Bonobo_Control_Capplet_generic.oaf.in:
	* wrapper-script.in: remove obsolete files

svn path=/trunk/; revision=7700
2007-06-06 16:24:17 +00:00
Jens Granseuer
94e474bcd7 remove caching from the thumbnailer since all of the current users work
2007-06-06  Jens Granseuer  <jensgr@gmx.net>

	* theme-thumbnail.c: (message_from_child),
	(generate_theme_thumbnail), (generate_theme_thumbnail_async),
	(theme_thumbnail_factory_init):
	* theme-thumbnail.h: remove caching from the thumbnailer since
	all of the current users work around it anyway, and resources
	aren't managed properly

svn path=/trunk/; revision=7699
2007-06-06 16:22:51 +00:00
Jens Granseuer
f7873f1304 some more house-keeping
2007-06-06  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (safe_strcmp), (get_data_from_hash_by_name),
	(read_icon_theme), (handle_change_signal), (update_theme_index),
	(gnome_theme_meta_info_compare):
	* gnome-theme-info.h: some more house-keeping

svn path=/trunk/; revision=7698
2007-06-06 16:05:55 +00:00
Jens Granseuer
e57c99d8e0 add a parameter to circumvent the internal thumbnail cache to the
2007-06-06  Jens Granseuer  <jensgr@gmx.net>

	* theme-thumbnail.c: (generate_theme_thumbnail_async):
	* theme-thumbnail.h: add a parameter to circumvent the internal
	thumbnail cache to the asynchronous generator

svn path=/trunk/; revision=7695
2007-06-05 22:16:51 +00:00
Jens Granseuer
76d0c77d85 simplify, clean up, and fix a few leaks
2007-05-30  Jens Granseuer  <jensgr@gmx.net>

	* gnome-theme-info.c: (safe_strcmp), (add_data_to_hash_by_name),
	(handle_change_signal), (update_common_theme_dir_index),
	(gtk2_dir_changed), (keybinding_dir_changed),
	(metacity_dir_changed), (common_theme_dir_changed),
	(common_icon_theme_dir_changed), (top_theme_dir_changed),
	(top_icon_theme_dir_changed), (real_add_top_theme_dir_monitor),
	(gnome_theme_info_find_by_type_helper),
	(gnome_theme_info_find_by_type),
	(gnome_theme_icon_info_find_all_helper),
	(gnome_theme_icon_info_find_all), (gnome_theme_icon_info_compare),
	(gnome_theme_meta_info_new),
	(gnome_theme_meta_info_find_all_helper),
	(gnome_theme_meta_info_find_all), (gnome_theme_meta_info_compare),
	(gnome_theme_info_register_theme_change): simplify, clean up, and fix
	a few leaks

svn path=/trunk/; revision=7677
2007-05-29 23:17:39 +00:00
Jens Granseuer
6fc827db4d recognize both "gtk-color-scheme" and "gtk_color_scheme" (fixes thumbnail
2007-05-29  Jens Granseuer  <jensgr@gmx.net>

	* gtkrc-utils.c: (gtkrc_get_color_scheme): recognize both
	"gtk-color-scheme" and "gtk_color_scheme" (fixes thumbnail generation
	for e.g. the Mist metatheme)

svn path=/trunk/; revision=7676
2007-05-29 19:20:07 +00:00
Jens Granseuer
8ad25db4a1 remove property editor for the deprecated GtkOptionMenu, now that all
2007-05-28  Jens Granseuer  <jensgr@gmx.net>

	* gconf-property-editor.c:
	* gconf-property-editor.h: remove property editor for the deprecated
	GtkOptionMenu, now that all users are upgraded to GtkComboBox

svn path=/trunk/; revision=7674
2007-05-28 20:19:32 +00:00