Commit graph

8332 commits

Author SHA1 Message Date
Automeris naranja
7e4a5e0295 color: Use CCListRowInfoButton to show color profile info
CcListRowInfoButton is used in several places in Settings,
so this change will improve UI/UX consistency.
2024-04-02 16:34:49 +00:00
Automeris naranja
08ea9efe77 wifi: Port "Saved Wi-Fi Networks" dialog to AdwDialog 2024-04-02 16:25:46 +00:00
Automeris naranja
09e533d645 input-chooser: Tweak search entry placeholder text
Use "Search languages and countries" as the
search entry placeholder, like in the latest
mockups[1].

[1] 1855a1ecbe
2024-04-02 16:21:47 +00:00
Automeris naranja
3e7eedcb98 input-chooser: Port to AdwPreferencesPage/Group 2024-04-02 16:21:47 +00:00
Automeris naranja
5b55700eec input-chooser: Port to AdwDialog 2024-04-02 16:21:47 +00:00
Automeris naranja
38e5092b1a firmware-security-help-dialog: Port to AdwDialog 2024-04-02 18:13:42 +02:00
Automeris naranja
b126b05247 firmware-security-dialog: Port to AdwDialog 2024-04-02 18:12:34 +02:00
Automeris naranja
a588f23002 firmware-security-boot-dialog: Port to AdwDialog 2024-04-02 18:11:47 +02:00
Automeris naranja
d31f8aeea6 volume-levels-window: Port to AdwDialog 2024-04-02 16:09:35 +00:00
Automeris naranja
e40880f7cb output-test-window: Port to AdwDialog 2024-04-02 16:09:35 +00:00
Automeris naranja
88a964fe15 alert-chooser-window: Port to AdwDialog 2024-04-02 16:09:35 +00:00
Automeris naranja
3f3327a9f3 xkb-modifier-dialog: Remove custom CSS
.xkb-option-button style class is no longer used,
so remove the custom CSS that was made for it.
2024-04-02 16:07:11 +00:00
Automeris naranja
3741baceba xkb-modifier-dialog: Port to AdwDialog 2024-04-02 16:07:11 +00:00
Automeris naranja
fef18e73b6 qr-code-dialog: Port to AdwDialog 2024-04-02 16:03:43 +00:00
Automeris naranja
17f2daaa9a users: Port "Add Enterprise User" dialog to AdwDialog 2024-04-02 16:00:56 +00:00
Automeris naranja
21bc6c5bb7 add-user-dialog: Port to AdwDialog 2024-04-02 15:16:00 +00:00
Automeris naranja
29f4fc46b0 system-details-dialog: Add top margin to "Software Information"
When the window is small, which makes the
"Hardware Information" and "Software Information"
sections to show vertically, the latter doesn't
properly separate from the first visually. Add a
top margin to fix that.
2024-04-02 15:11:40 +00:00
Automeris naranja
9ae687d827 system-details-window: Port to AdwDialog 2024-04-02 15:11:40 +00:00
Automeris naranja
fb1d55f3b3 online-account-row: Implement the new error status design
- Add the "Error" label next to the icon
- Make the label and icon to use @error_color

Reference:
0a16d3ce2b
2024-04-02 15:02:51 +00:00
Felipe Borges
d1c3711fe6 network: Add CcWifiConnectionList.set_placeholder_text
This allows for CcWifiConnectionList to be reused in different locations
where the placeholder might differ.

For example, the main wifi connections list vs. the saved network
connections (forget dialog).

See !2384, !2397, and !2418

Fixes #2574
2024-04-02 12:09:57 +02:00
Automeris naranja
62564c623f users: Don't use another style class for the remove avatar button
The "destructive-action" style class will already make
the button to have a red background.
2024-04-02 10:07:58 +00:00
Automeris naranja
df0c3a79d5 users: Use a single CSS for the entire panel
This also fixes the ".cutout-button" style being
set in "user-accounts-dialog.css", which is wrong
because this widget is located in the main panel
and not in the add user dialog.
2024-04-02 10:07:58 +00:00
Automeris naranja
49de7620b9 power: Update some strings
Update some strings from the power profile info row:

- Update a string to follow the latest mockups[1]
- Remove periods from phrases that are written as
a complete sentence, as recommended by HIG

[1] 1bb482ed19
[2] https://developer.gnome.org/hig/guidelines/writing-style.html#periods
2024-04-02 09:56:56 +00:00
Automeris naranja
3b93511dac power-profile-info-row: Use AdwActionRow
Transforming power-profile-info-row into an
AdwActionRow helps to decrease the
power-profile-info-row.ui code considerably.

Also, make the info icon smaller and not dimmed,
like in the mockups[1].

[1] 1bb482ed19
2024-04-02 09:56:56 +00:00
Automeris naranja
524261c710 power: Use a single CSS file
Use a single CSS file for the entire panel.
This will make easier to set custom style
for specific widgets without having to create
a bunch of CSS files for each widget type.
2024-04-02 09:56:56 +00:00
Felipe Borges
591b655be5 privacy, help: Link to "Screen Lock" documentation
When in the "Screen Lock" page, hitting F1 or going for Help should
open help:gnome-help/privacy-screen-lock
2024-04-02 09:11:31 +00:00
Felipe Borges
7d963db243 privacy, help: Fix broken link to "Location Services" docs
The subpage tag name AND the correspondent docs page name were wrong.
2024-04-02 09:11:31 +00:00
Felipe Borges
7f01aa79b3 privacy, help: Remove links to pages without correspondent docs 2024-04-02 09:11:31 +00:00
Felipe Borges
c2a7ebbd5f privacy, help: Default to opening "Privacy Settings" help page
When in the main page or in a subpage without docs, the Help link
should open the "Privacy Settings" page at help:gnome-help/privacy
2024-04-02 09:11:31 +00:00
Felipe Borges
1a54cbf15a privacy: Remove Microphone page
See commit f46fbd18.

This panel can't really be useful at this point since there's no
portal for apps to access microphones.

See #2848
Fixes #2958
2024-03-28 15:56:55 +01:00
Automeris naranja
1578ebefc7 wifi: Don't show "No Wi-Fi Adapter Found" when Wi-Fi is off
Use "nm_client_wireless_hardware_get_enabled" to check if
Wi-Fi is enabled or not at the hardware level. Then, show
a different AdwStatusPage when the Wi-Fi adapter is absent
and when Wi-Fi is off.

Reference:
cfb7cae4a9

Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1514
2024-03-27 22:46:01 +00:00
Automeris naranja
5192d9ef36 mouse-test: Make some UI tweaks to follow the latest mockups
- Use "select-mode-symbolic" in the "Clicking"
view switcher

- Ditch the border radius from the scroll test
image

- Make click-status-emblem indicator indicator
to show a more prominent green color when the
test passes

- Don't use @borders for the click-status-emblems
background color because this named color isn't
meant for backgrounds

- Make non-green click-status-emblems dimmed

Reference: 6d5e1813ca
2024-03-27 18:10:44 -03:00
Felipe Borges
994a540bfc system, datetime: Don't set datetime when auto time sync is enabled
The timedate1_call will fail because network time synchronization is enabled:

GDBus.Error:org.freedesktop.timedate1.AutomaticTimeSyncEnabled: Automatic time synchronization is enabled

Let's not set_time when NTP is not available, neither set time by
accident at the widget construction stage. When widgets signals are connected
in the UI file their respective callback was getting called. By moving
the signal connection to callbacks to the widget's _init method we
avoid the unwanted callback call.

Fixes #2945
2024-03-27 13:13:13 +00:00
Felipe Borges
2cf5b90cce common: Check for valid GDateTime object before comparing
Avoids the critical below at runtime
11:14:36.7796                   **[873815]:CRITICAL: cc_util_get_smart_date: assertion 'date != NULL' failed
11:14:36.7802                   **[873815]:CRITICAL: cc_util_get_smart_date: assertion 'date != NULL' failed

Which comes from the location panel passing a NULL date object.

\#0  _g_log_abort (breakpoint=1) at ../shell/cc-log.c:72
        debugger_present = 1
\#1  0x000000000045c3c4 in cc_log_write
    (log_level=10, log_domain=0x7ffff7d592eb "GLib", log_message=0x234c400 "g_date_time_difference: assertion 'begin != NULL' failed", fields=0x7fffffffd740, n_fields=4, user_data=0x0)
    at ../shell/cc-log.c:315
        log_str = 0x234b8d0
        stream = 0x7ffff5dbb4e0 <_IO_2_1_stderr_>
        can_color = 1
\#2  0x000000000045c4f5 in cc_log_handler (log_level=G_LOG_LEVEL_CRITICAL, fields=0x7fffffffd740, n_fields=4, user_data=0x0) at ../shell/cc-log.c:348
        log_domain = 0x7ffff7d592eb "GLib"
        log_message = 0x234c400 "g_date_time_difference: assertion 'begin != NULL' failed"
\#3  0x00007ffff7c9f534 in g_log_structured_array () at /lib64/libglib-2.0.so.0
\#4  0x00007ffff7ca4f57 in g_log_default_handler () at /lib64/libglib-2.0.so.0
\#5  0x00007ffff7c9be29 in g_logv () at /lib64/libglib-2.0.so.0
\#6  0x00007ffff7c9c193 in g_log () at /lib64/libglib-2.0.so.0
\#7  0x00007ffff7c787fa in g_date_time_difference () at /lib64/libglib-2.0.so.0
\#8  0x000000000059c186 in cc_util_get_smart_date (date=0x0) at ../panels/common/cc-util.c:124
        today = 0x2350130
        local = 0x2350100
        span = 10791504
\#9  0x00000000004f8a20 in add_location_app (self=0x1dee1c0, app_id=0x232fef0 "org.gnome.Calendar", enabled=1, last_used=459618461810) at ../panels/privacy/cc-location-page.c:209
        data = 0xffffda80
        app_info = 0x2341c50
        t = 0x0
        row = 0x2348280
        w = 0x234fe00
        icon = 0x2345310
        last_used_str = 0x0
        desktop_id = 0x7fffcc034c30 "DL\310\375\a"
\#10 0x00000000004f8db4 in update_perm_store (self=0x1dee1c0, permissions=0x7fffcc04e2c0, permissions_data=0x7fffcc04ee80) at ../panels/privacy/cc-location-page.c:282
        enabled = 1
        last_used = 459618461810
        iter = {x = {140736616260288, 2, 0, 6386038, 140736616096608, 36922576, 16, 3579507750, 140737488345904, 140737350561909, 33733184, 36922576, 140737488345936, 140737350702366, 36922576, 3278251457363369984}}
        key = 0x232fef0 "org.gnome.Calendar"
        value = 0x7fffcc04e090
\#11 0x00000000004f8f4e in on_perm_store_lookup_done (source_object=0x1e24040, res=0x202ba40, user_data=0x1dee1c0) at ../panels/privacy/cc-location-page.c:324
        error = 0x0
        ret = 0x7fffcc04eef0
        permissions = 0x7fffcc04e2c0
        permissions_data = 0x7fffcc04ee80
\#12 0x00007ffff7e9082c in g_task_return_now () at /lib64/libgio-2.0.so.0
\#13 0x00007ffff7e944c3 in g_task_return () at /lib64/libgio-2.0.so.0
\#14 0x00007ffff7efe88b in reply_cb () at /lib64/libgio-2.0.so.0
\#15 0x00007ffff7e9082c in g_task_return_now () at /lib64/libgio-2.0.so.0
\#16 0x00007ffff7e944c3 in g_task_return () at /lib64/libgio-2.0.so.0
2024-03-27 13:13:13 +00:00
Automeris naranja
4a986072ce app-notifications-dialog: Port to AdwDialog
Also, remove the ESC shortcut, since AdwDialogs
already close with ESC by default.
2024-03-27 13:51:08 +01:00
Automeris naranja
f366102d89 removable-media-settings: Port "Other Media" to AdwDialog 2024-03-27 12:20:47 +00:00
Felipe Borges
4525890c27 multitasking, accessibility: Remove spaces from desktop file keywords
Spaces are not supported in .desktop file keywords[0] as gnome-shell
splits the search term by spaces, and then prefix-matches each word separately
against the candidate keywords.

Inspired by commit 7bd8dd69cf
2024-03-27 10:24:02 +00:00
Automeris naranja
6e3f7c6055 secure-shell-page: Use "Command copied to clipboard" string
When copying the login command, a toast appear
saying "Command copied". However, these kind of toasts
usually says that the text was copied *to the clipboard*,
like the toast from System > About > System Details > Copy.
2024-03-26 20:46:35 -03:00
Automeris naranja
2b1a66d7ce users: Rename "Add Enterprise User" to "Add Enterprise Login"
This button is labelled as "Add Enterprise Login" in
the mockups[1].

Also:
- Add missing mnemonic
- Add ellipsis to the button label, since it's required
when the button triggers further user interaction[2]

[1] a0e4f828ec
[2] https://developer.gnome.org/hig/guidelines/writing-style.html#ellipses
2024-03-25 15:08:29 +00:00
Philip Withnall
7bd8dd69cf users: Simplify parental controls keywords to remove spaces
Spaces aren’t supported in .desktop file keywords, as gnome-shell splits
the search term by spaces, and then prefix-matches each word separately
against the candidate keywords.

So a search term of ‘parental’ would match the ‘Parental Controls’
keyword, but a search term of ‘parental controls’ would not, as
‘controls’ doesn’t prefix-match anything.

Avoid that by removing spaces from the keywords.

Signed-off-by: Philip Withnall <pwithnall@gnome.org>

Helps: https://gitlab.freedesktop.org/pwithnall/malcontent/-/issues/48
2024-03-25 14:17:45 +00:00
Automeris naranja
f00dc11f38 privacy: Separate subpages files in their respective folders
Accessibility and System panel folders also
have this folder structure, which is way more organized.
2024-03-25 14:43:32 +01:00
Felipe Borges
942461d0d8 system, remote-desktop: Rename "RemoteSession" code to "RemoteLogin"
To be consistent with what we show in the UI and conciliate the
confusion with Secure Shell, which was formerly named "RemoteLogin".
2024-03-25 12:33:23 +00:00
Felipe Borges
9a05b542e2 system, secure-shell: Rename internal name from RemoteLogin
As the user facing name of this setting changed to "Secure Shell",
let's change its internal name to match it.

This avoids confusion with the Remote Desktop "Remote Session" setting,
which is now named "Remote Login" in the UI and should get its code
renamed to follow that consistently.
2024-03-25 12:33:23 +00:00
Felipe Borges
96cf88c68f system, remote-login: Fix header name typo
Fixes
https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2211#note_2061610
2024-03-25 10:40:30 +00:00
Felipe Borges
5323020102 privacy: Fix Thunderbolt page tag name
The main panel was looking for a page with tag "bolt" when the panel
is actually using the "thunderbolt" tag.

Fixes #2973
2024-03-25 11:19:43 +01:00
Peter Hutterer
33c49dc125 wacom: Check for the right output connector name
Otherwise we just return the first output with the corresponding vendor
and serial number.

Fixes: 75ce02e202 ("wacom: Provide connector name for disambiguation")
2024-03-22 13:02:22 +00:00
Peter Hutterer
ebd2b013dd wacom: Accept 4-value output settings
We now store the connector name as fourth value.

Fixes: 75ce02e202 ("wacom: Provide connector name for disambiguation")
2024-03-22 13:02:22 +00:00
Felipe Borges
0787182dd0 search: Prevent listbox placeholder from being treated like a row
The Search panel providers listbox has a placeholder label that is
visible when there are no listbox items.

The placeholder label is being considered in the list of children
of the listbox while estimating whether "Moving down" is allowed for
the listbox reorder feature.
2024-03-22 12:43:24 +00:00
Automeris naranja
1d00a94009 search: Tweak "No Apps Found" placeholder
The current placeholder that appears when no
providers are available has some problems:

- The row is activatable, but this is unnecessary
- The row has no padding
- The "No Apps Found" string doesn't use header
capitalization

Fix this by using a GtkListBox placeholder widget, with
margins and with header capitalization in the string.
2024-03-22 12:43:24 +00:00
Felipe Borges
49e35600c9 power: Load a different list for suspend-times when on mobile
Using the systemd-hostnamed chassis-type to detect when running on
"tablet", "handset", or "watch" and setting a more reasonable list
of suspend time options for them.
2024-03-21 16:01:11 +00:00