Commit graph

1473 commits

Author SHA1 Message Date
Bastien Nocera
7f5733b454 common: Fix handling of <Primary>
As used in the new GTK+ 3.2.1.

https://bugzilla.redhat.com/show_bug.cgi?id=748444
2011-10-24 19:06:27 +01:00
Bastien Nocera
eacbe935d3 keyboard: Remove unused variable 2011-10-24 17:25:14 +01:00
Bastien Nocera
9770f2a332 info: Avoid re-using a non-NULL error 2011-10-24 17:22:34 +01:00
Bastien Nocera
d453a9841d sound: Add a minimum height for the output list
Combined with the changes to the output list to only
use a single line instead of multi-line status, this should
make it easier to see multiple devices listed.

https://bugzilla.gnome.org/show_bug.cgi?id=660582
2011-10-24 14:41:44 +01:00
Richard Hughes
8283232b44 color: Fix a critical warning in the new GtkTreeIter code 2011-10-21 16:01:37 +01:00
Bastien Nocera
f625fbbb59 sound: Fix possible infinite loop in combo box 2011-10-20 16:10:06 +01:00
Bastien Nocera
bafe9c4020 sound: volume is unsigned so cannot be <= 0 2011-10-20 16:08:53 +01:00
Bastien Nocera
3d3cfa7304 keyboard: Check for NULL value first
Then try to access item->type
2011-10-20 15:53:25 +01:00
Bastien Nocera
34dadb5ac3 printers: Avoid dereferencing NULL variable
If line is NULL, then buffer is NULL, and buffer[0] points
to nowhere.
2011-10-20 15:50:00 +01:00
Bastien Nocera
ff59277c91 color: Don't return pointer to local variables
We were returning the address of a variable allocated on the stack
inside the function to outside.
2011-10-20 15:46:32 +01:00
Bastien Nocera
7f8b2153c8 color: Remove useless NULL check
It cannot be NULL when we get to that point.
2011-10-20 15:39:05 +01:00
Bastien Nocera
e9f95249a9 printers: Fix crasher if a or b are NULL in cmp
If a or b are NULL then (c && d) fails, and both a_normalized
and b_normalized are left uninitialised, possibly causing a crash
when we try to free them later.
2011-10-20 15:36:04 +01:00
Bastien Nocera
474abc5272 color: Use a switch statement
A little bit cleaner.
2011-10-20 15:30:14 +01:00
Bastien Nocera
0bc99bdda3 color: Fix warning about uninitialised variable 2011-10-20 15:26:51 +01:00
Bastien Nocera
cb5924adb1 keyboard: Remove broken allowed_keys checks
The only thing it was doing was disabling the add button,
which was promptly re-enabled when you selected the custom
shortcuts section.
2011-10-20 10:36:21 +01:00
Bastien Nocera
62cb5236b2 keyboard: Make the '+' button work all the time
We shouldn't need to select the "Custom Shortcuts" section
of the keyboard shortcuts before the add button is made sensitive.

Make it sensitive all the time, and switch to the section as needed.

https://bugzilla.gnome.org/show_bug.cgi?id=662253
2011-10-20 10:36:21 +01:00
Matthias Clasen
85b0c9c92c Drop duplicate code
Static analyzers complain about this kind of thing.
2011-10-19 18:57:33 -04:00
Bastien Nocera
7575e38599 keyboard: Fix ATK description
As mentioned in:
https://bugzilla.gnome.org/show_bug.cgi?id=574073
2011-10-19 14:43:41 +01:00
Bastien Nocera
7b3f942318 mouse: Fix ATK descriptions 2011-10-19 14:43:30 +01:00
Bastien Nocera
89a9a66554 universal-access: Fix ATK descriptions 2011-10-19 14:43:16 +01:00
Bastien Nocera
49e81242ca common: Update linkage rules for static libs
No point in limiting the exports symbols for a static library
2011-10-18 19:06:38 +01:00
Bastien Nocera
844dd9e321 bluetooth: Move Bluetooth panel from gnome-bluetooth 2011-10-18 18:46:15 +01:00
Bastien Nocera
6d38216573 region: Small style fix 2011-10-18 18:46:15 +01:00
Marek Kasik
86532624eb Printers: Make +/- buttons insensitive when can not connect to CUPS
Check whether sad computer is displayed and set sensitivity accordingly.
The check doesn't try to connect to CUPS because of performance reasons.
2011-10-14 19:23:50 +02:00
Marek Kasik
619364ff1a Printers: Don't add redundant prefix
Don't add prefix "-default" to options set by
PrinterAddOptionDefault method, it is added automatically.
2011-10-14 14:47:39 +02:00
Richard Hughes
00fb703054 color: After removing a profile select the device so the UI is correct
Resolves https://bugzilla.gnome.org/show_bug.cgi?id=661658
2011-10-13 17:03:51 +01:00
Richard Hughes
5f6b8f0da9 color: Show 'Uncalibrated' when a device has a test profile assigned 2011-10-13 16:40:29 +01:00
Richard Hughes
d25fe273d2 color: Don't show profile ages for EDID, test and colorspace profiles
Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=661669
2011-10-13 16:28:19 +01:00
Richard Hughes
9e1fa3c900 color: Prefix all the test profiles in the 'Add profile' UI 2011-10-13 16:08:29 +01:00
Richard Hughes
c9647e530d color: Do not show standard colorspaces in the 'Add profile' UI
NOTE: You need colord >= 0.1.4 and shared-color-profiles >= 0.1.5 for this
to work.
2011-10-13 15:58:02 +01:00
Richard Hughes
f4ac4f1a0f color: Improve the 'Add profile' modal dialog
Remove the 'Only profiles that are compatible with...' lightbulb helper and
instead just set the dialog title to include the device class, e.g.
'Available Profiles for Printers'.

Resolves https://bugzilla.gnome.org/show_bug.cgi?id=661657
2011-10-13 14:07:16 +01:00
Richard Hughes
886b4463a7 color: Fix the button placement in the 'Add profile' dialog 2011-10-13 13:34:30 +01:00
Richard Hughes
bc97442238 color: Do not allow the 'Add profile' modal dialog to be resizable 2011-10-13 13:31:18 +01:00
Bastien Nocera
0df2ab0da7 online-accounts: Add title for "Add Account" dialogue
https://bugzilla.gnome.org/show_bug.cgi?id=661573
2011-10-13 10:33:37 +01:00
Bastien Nocera
ada3a05386 power: Use "Power off" instead of "Shutdown"
(1) The correct verb is "Shut down". (2) It doesn't matter
because the preferred term is "Power off", verified with the
design team.

Spotted by Shaun McCance <shaunm@gnome.org>

https://bugzilla.gnome.org/show_bug.cgi?id=661559
2011-10-13 10:19:43 +01:00
Bastien Nocera
c703944fc5 power: Remove unused ListStore definitions 2011-10-13 10:18:55 +01:00
Bastien Nocera
50093b49ff keyboard: Don't load duplicate keybindings
When building out of the main tree, it's useful not to have
duplicate keybindings showing up in the UI.
2011-10-12 16:14:14 +01:00
Gary Ching-Pang Lin
45a9b2cb1f network: show wireless dialog even if there is no active AP
The network panel ignored the request of showing the wireless
dialog if there is no active AP, and the user was not able to
set up the advanced wireless settings, such as WPA-EAP settings.

https://bugzilla.gnome.org/show_bug.cgi?id=661526
2011-10-12 15:40:23 +01:00
Bastien Nocera
f7eb52a68b network: Remove unneeded initialisations
Don't set those variables to NULL, they should be correctly
initialised later in the code, and it might hide uninitialised ones.
2011-10-12 15:36:03 +01:00
Gary Ching-Pang Lin
73b0fe159d network: allocate nm-connection for nma-wireless-dialog
https://bugzilla.gnome.org/show_bug.cgi?id=648174
2011-10-12 15:35:59 +01:00
Marek Kasik
4665e84df4 Printers: Don't hide address entry
Don't hide address entry when there is not firewalld available.
It is still possible that firewall is set up correctly and user
should be able to enter address of his network printer and
install it (rhbz #743694).
2011-10-11 16:32:06 +02:00
Rodrigo Moya
95d9cffaaa region: Always add English to the list, as it should always be available 2011-10-11 16:18:45 +02:00
Bastien Nocera
1a2845dfa4 common: Always collect locales from the directory
Even if those locales do not exist in the locale-archive file,
their definition could be in the locale directories. The glibc
will look in directories as well when the locale-archive doesn't
contain it, so both behaviours match.

See also:
http://repo.or.cz/w/glibc.git/blob/HEAD:/locale/findlocale.c#l62

https://bugzilla.gnome.org/show_bug.cgi?id=660725
2011-10-11 12:30:54 +01:00
Rodrigo Moya
3c34c0f029 region: Only show locales for languages that have translations 2011-10-11 13:24:25 +02:00
Tomas Bzatek
befa8cc748 datetime: Fix showing actual clock format on panel open
A small regression after recent switch to radio buttons.
2011-10-07 17:51:20 +02:00
Rodrigo Moya
051a2d188e screen: Don't set gnome-session's idle-delay to 1 never 2011-10-06 12:19:08 +02:00
Ming Han Teh
cdfe63a3b2 background: Added D'n'D support for adding wallpapers.
https://bugzilla.gnome.org/show_bug.cgi?id=655375
2011-10-06 09:47:09 +01:00
Alberto Ruiz
3630015d94 Update icon cache only on MAINTAINER_MODE 2011-10-05 16:45:13 +01:00
Cosimo Cecchi
281136faee info: really use x-content/unix-software for the Software combobox
The content-type property is actually set in the UI file, not in the C
source.

https://bugzilla.gnome.org/show_bug.cgi?id=660803
2011-10-03 15:44:11 -04:00
Cosimo Cecchi
4a02849325 info: use x-content/unix-software as mime for the Software combobox
Instead of x-content/software, as the nautilus autorun handler only
claims the x-content/unix-software mimetype now.
2011-10-03 12:11:44 -04:00