Commit graph

7739 commits

Author SHA1 Message Date
Felipe Borges
f444852449 common: Fix name of internal InfoButton get/set functions
This was a copy-pasta mistake when creating the CcListRowInfoButton
class from the CcListRow class.

The mistake was harmless but fixing it is good for the sake of
consistency and to avoid confusion in backtraces.
2023-05-31 21:34:03 +00:00
Michael Catanzaro
718af17905 info-overview: show only the GNOME major version
What we have is the GNOME Shell version, which is NOT the same as the
GNOME version. I thought it'd be nicest to rename this to "GNOME Shell
Version" but it seems we want to keep that as an internal codename not
exposed to users. So instead, let's just show only the major version,
which should hopefully match. This is very generic and much less useful
but I don't see a better solution.

See previous discussion in:

https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1481
https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1805

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1814>
2023-05-31 21:03:23 +00:00
Gunnar Hjalmarsson
d5becccc7c keyboard: Drop "Left Alt" as compose key option
Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2509
2023-05-31 20:43:24 +00:00
Marcos Miller
478b3b4346 keyboard: change message dialog in 'reset all shortcuts'
The class Gtk.MessageDialog is deprecated in gtk 4.10.

This change remove class deprecated and uses the new class
AdwMessageDialog for view the message of 'reset all shortcut'.

keyboard: fix white space in function

keyboard: align arguments

keyboard: fix alignment of arguments in function
2023-05-31 13:51:26 +00:00
Robert Ancell
dc988e476b notifications: Fix panel object reference never being dereferenced 2023-05-31 08:17:01 +00:00
Marcos Miller
b0063d015f keyboard: fix "Add Custom Shortcut" in others sections
Clicking on the 'Custom Shortcuts' row when there are no custom
shortcuts causes the 'Add Custom Shortcuts' dialog to be shown for
all subsequent sessions. This is because the first stack defined was
'Add Custom Shortcuts', it would always be visible, as it was no
longer defined which stack was going to be shown.

Fixes (https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2479)
2023-05-31 08:15:59 +00:00
Felipe Borges
b80f154f80 network: Close Connection Editor dialog when clicking Apply button
Fixes #2499
2023-05-31 08:15:32 +00:00
Robert Ancell
e1c8f9b291 firmware: Fix capitalization in class name 2023-05-30 08:36:22 +00:00
Robert Ancell
426f9a9302 common: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
543f24a754 wacom: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
3ad1f01b34 online-accounts: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
5d65e8df9e firmware-security: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
b041c9df6d notifications: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
f756184e3b display: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
3bd3f82bca thunderbolt: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
39ccf2c610 user-accounts: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
a06914a60c keyboard: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
ae93ded618 search: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
c78eb3d2f8 region: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
89c054a31b network: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
644df7697b datetime: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
f23218e037 background: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Robert Ancell
642833509b applications: Do signal handlers in swapped form 2023-05-30 08:36:22 +00:00
Automeris naranja
901f395e9e user-add-dialog: Use CCListRowInfoButton for the "Administrator" AdwActionRow
Follow-up from Follow-up from https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1571
2023-05-30 08:35:12 +00:00
Timotej Šulík
4102a16b40 display: Fix stuck window subtitle in the Displays panel
In case an inapplicable display configuration
is attempted, and the issue is then resolved,
the warning window subtitle remains displayed
even under the "Apply Changes?" title.

Closes #2512.
2023-05-30 00:58:16 +02:00
Timotej Šulík
4fe26944d8 display: Fix gaps when numbering unusable displays 2023-05-28 22:16:10 +00:00
Felipe Borges
e6336ec433 network: Add ToastOverlay to connection-editor 2023-05-26 02:04:52 +00:00
Felipe Borges
3f482559ea network: Make "Import VPN from file" use GtkFileDialog
Since the gtk_file_chooser_dialog APIs are deprecated.
2023-05-26 02:04:52 +00:00
Felipe Borges
e580c309e8 network: Drop legacy vpn_export function
This was a leftover from the old connection-editor.
2023-05-26 02:04:52 +00:00
Ismael
497f599517 network-panel: fix crash when importing wrong vpn file 2023-05-26 02:04:52 +00:00
Felipe Borges
bb351a1b51 common: Fix time entry for RTL languages
While GTK will flip most things for RTL languages, that shouldn't be
the case for displaying time.

These changes make sure that the time-entry/editor behave as expected
in RTL languages.

Fixes #2504
2023-05-26 01:03:45 +00:00
Felipe Borges
e97429f0f6 Make dialogs close when pressing the Escape key
Fixes #2503
2023-05-25 23:24:00 +00:00
Timotej Šulík
4ed1af010a display: Allow mirroring for any number of displays 2023-05-25 21:35:30 +00:00
Felipe Borges
8d2a315c3a thunderbolt: Modernize Device Dialog UI
The device name is now shown on the dialog's titlebar and not in
a row.
2023-05-24 14:27:22 +00:00
Lukáš Tyrychtr
3f47fd0dea common: Make the info button labels selectable
That allows a screen reader to read the information, which was previously
unreachable in any meaningful way.
2023-05-24 12:55:12 +02:00
Lukáš Tyrychtr
41cb03db76 a11y: Present the checked state on the list row itself
That allows the visually impaired user to get the information quicker,
and, as a result of that, we can simplify the focus chain as well.
2023-05-24 09:04:02 +00:00
Gotam Gorabh
f9c75e6694 user-accounts:updated the remove user dialog with AdwMessageDialog
This commit will update the GUI of remove user dialog with AdwMessageDialog which
doesn't follow design guidelines. Re-desined according to https://gitlab.gnome.org/Teams/Design/settings-mockups/-/blob/master/users/users.png

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2093
, https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2341
2023-05-24 08:57:30 +00:00
Pablo Correa Gómez
a2b9620b1b network: keep track of radio buttons in connection editor with action
Hooking to all the toggled signals from all the buttons for executing
the same action is inneficient, and can potenticall end up in a segmentation
 fault due to some race in the signal emmission, where the active button
 gets deactivated before the clicked button is activated

Looking at the GTK4 code, in a radio group:

- The button which was previously active gets de-activated, emitting its
corresponding toggled signal.
- The active property for the clicked button gets set.
- The clicked button emits its toggled signal.

Therefore, if the first toggle signal gets processed before the active
property is set, there can be a race condition. We are seeing this downstream
at pmOS: https://gitlab.com/postmarketOS/pmaports/-/issues/1816

Instead of this racy behavior, follow upstream recommendation and keep track
of the state through a stateful signal.
2023-05-24 08:54:06 +00:00
Pablo Correa Gómez
7f7b65545c all: meson: do not specify resources from gresource files as dependencies
Meson extracts them by itself and add them as dependencies for the target.
It means one less location to keep track of files, and a lot less boilerplate
around the meson files
2023-05-24 08:34:14 +00:00
Felipe Borges
2cf57ffb10 datetime: Merge "Clock" and "Calendar" sections
According to mockups at
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/raw/master/date-and-time/date-and-time.png
2023-05-22 13:18:31 +00:00
Felipe Borges
79636a8eb9 datetime: Move "Time Format" row out of "Clock" section
https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1277#note_1751622
2023-05-22 13:18:31 +00:00
Lains
7615bb5ccb datetime: Add top bar clock and calendar switches
For changing the clock display (weekday, seconds, date) and week numbers on the calendar

These switches should change:
- Whether or not the clock display has the week day (e.g. Mon).
- Whether or not the clock display has the date (e.g. Jun 6).
- Whether or not the clock display has seconds (e.g. 12:30:45).
- Whether or not the clock's popup calendar should show the week's number.

Fixes #257
2023-05-22 13:18:31 +00:00
Mpho Jele
483a5f3e8d user-accounts: Use AdwEntryRow for user full name 2023-05-17 11:14:29 +02:00
Markus Göllnitz
98c47cee10 mouse: ensure type CcListRowInfoButton is available to GtkBuilder
The newly introduced CcListRowInfoButton is not available
to GtkBuilder and henceforth building the mouse panel
currently fails.

Therefore, it CcListRowInfoButton has to be declared to
be a type that needs to be available to this panel.

Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
2023-05-16 20:49:28 +02:00
Felipe Borges
b2d5e78934 mouse: Use CcListRowInfoButton for mouse_aceleration row 2023-05-16 13:32:21 +00:00
Felipe Borges
45931c783f user-accounts: Make Administrator row use info button widget
Instead of recreating the menu button and popover.
2023-05-16 13:32:21 +00:00
Felipe Borges
d586df5c87 user-accounts: Add a popover describing the autologin functionality
Fixes #2235
2023-05-16 13:32:21 +00:00
Felipe Borges
00a71d46da common: Introduce CcListRowInfoButton widget
This simplifies the display of additional text information for our
rows.

See #1571
2023-05-16 13:32:21 +00:00
Mario Limonciello
aa46ae53a1 firmware-security: Skip security attributes that have been obsoleted by others
Fixes: #2481
2023-05-15 18:11:56 +00:00
Felipe Borges
073cf028a2 sharing: Add subtitle to each panel row
Fixes #2407
2023-05-15 13:37:17 +02:00