Commit graph

72 commits

Author SHA1 Message Date
Felipe Borges
1b81221092 sharing: Set new shared folder visible as soon as it gets added
When adding a Shared Folder row to the listbox, we were not settings
it to visible. Causing it to be hidden until the next time the panel
gets populated.

Fixes #580
2019-09-12 11:04:57 +02:00
Robert Ancell
a57a85a1db sharing: Fix warning when disabling sharing
The warning is:
(gnome-control-center:29760): Gtk-CRITICAL **: 11:45:48.076: gtk_widget_is_visible: assertion 'GTK_IS_WIDGET (widget)' failed

This is due to the code trying to disable switches that only exist if support
for that feature is available.
2019-07-15 14:38:52 +12:00
Stefano Facchini
b47ada9b76 sharing: Fix master switch
Since the switches for media, personal file, and screen sharing are in the header bar of the
respective dialogs, they are not visible when we click on the master switch. This caused the
check in OFF_IF_VISIBLE to always fail.

Fix it by checking if the corresponding button in the main list box is visible, instead.

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/240
2019-07-15 00:05:23 +00:00
Georges Basile Stavracas Neto
75f150d5a2 shell: Add position to cc_shell_embed_widget_in_header()
So we can control where the widget should be added to. The
main window only supports left and right positions.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/528
2019-05-21 12:59:36 -03:00
Robert Ancell
41d2eff314 sharing: Make .ui filename match the .c filename 2018-11-12 16:41:01 +00:00
Robert Ancell
c058f15d10 sharing: Don't use gtk_widget_show_all
It is removed in GTK+ 4
2018-10-18 01:18:57 +00:00
Benjamin Berg
2bd03bbb6d sharing: Bind hostname_entry from UI
The entry was not bound. Due to this we could run into a segfault trying
to query the hostname_entry. This would only happen if avahi is not
running.

Fixes #178
2018-09-21 16:59:25 +00:00
Jonas Ådahl
49ef965dc7 sharing: Enable settings widget for gnome-remote-desktop
Enable support for manipulating GNOME Remote Desktop settings. Settings
are done via the org.gnome.desktop.remote-desktop.vnc schema.
Configuring the VNC password is done via libsecret, thus libsecret is
added as a dependency.
2018-07-10 19:59:51 +00:00
Robert Ancell
eff88ab2f1 sharing: Use GtkTemplate 2018-06-07 00:58:22 +00:00
Robert Ancell
a30f660db9 sharing: Use g_auto for variables 2018-06-03 01:11:17 +00:00
Robert Ancell
394797025f sharing: Replace GObject boilerplace with G_DECLARE_TYPE 2018-06-01 21:21:05 +00:00
Benjamin Berg
c2f601a9d4 Move common panel code from shell/ to panel/common
This creates a new static library called libwidget which the shell links
against.
2018-04-17 15:26:59 +02:00
Jeremy Bicha
40fe964a65 sharing: Drop the "Personal" from "Personal File Sharing" description
https://bugzilla.gnome.org/show_bug.cgi?id=772355
2018-01-21 12:37:01 -02:00
Felipe Borges
afbdddc2ed sharing: properly resize listbox rows
https://bugzilla.gnome.org/show_bug.cgi?id=767646
2018-01-17 23:54:33 -02:00
Georges Basile Stavracas Neto
eca7f39782 sharing: Use gtk_menu_popup_at_pointer
Instead of the deprecated gtk_menu_popup().
2018-01-17 23:23:59 -02:00
Georges Basile Stavracas Neto
0af9a5ad64 sharing: Ensure CcHostnameEntry GType before initialization
The exact same reasoning of 35e670c6da.
2018-01-17 23:18:37 -02:00
Rui Matos
2556fd5e2c sharing: Make use of the cancellable for async hostname calls
We have it initialized and disposed and the async calls already handle
being cancelled. We just forgot to actually use it.

https://bugzilla.gnome.org/show_bug.cgi?id=786984
2017-08-29 19:26:58 +02:00
Rui Matos
94045b8418 sharing: Remove an unused variable
https://bugzilla.gnome.org/show_bug.cgi?id=786984
2017-08-29 19:26:58 +02:00
Rui Matos
f959b9127b sharing: Make panel initialization asynchronous
https://bugzilla.gnome.org/show_bug.cgi?id=786984
2017-08-29 19:26:58 +02:00
Rui Matos
58bad723ee sharing: Show the networks widget in the screen sharing dialog
The way it works is independent of the service so there's no reason
not to show it. We should also hide the remote-control-box widget
hierarchy since those can't be used here.

https://bugzilla.gnome.org/show_bug.cgi?id=786565
2017-08-29 19:26:58 +02:00
Jonas Ådahl
ecb0e6dd23 sharing: Add Wayland screen sharing support
This allows enabling screen sharing support under Wayland, as long as
the org.gnome.Mutter.RemoteDesktop D-Bus name is exported by mutter /
gnome-shell. That name will currently only be exported if the
corresponding experimental features has been added to mutter.

So far nothing is configurable, as gnome-remote-desktop is yet to be
configureable.

https://bugzilla.gnome.org/show_bug.cgi?id=786565
2017-08-29 18:55:42 +02:00
Mohammed Sadiq
4c0928f324 sharing: Don't leak path
g_file_get_path() allocates new memory for path.
So using g_strdup() later would leak the previous allocation.

https://bugzilla.gnome.org/show_bug.cgi?id=782045
2017-05-02 12:55:26 +02:00
Felipe Borges
02ab69bd8f sharing: Hide Vino when using Wayland
Since we don't support "Screen Sharing" under Wayland yet.

https://bugzilla.gnome.org/show_bug.cgi?id=774553
2016-11-17 16:04:32 +01:00
Felipe Borges
da1d8f0d39 sharing: Update "Remote Login" dialog description
To match the new designs at
https://wiki.gnome.org/Design/SystemSettings/Sharing

https://bugzilla.gnome.org/show_bug.cgi?id=767646
2016-06-15 14:19:36 +02:00
Felipe Borges
8b68961431 sharing: Use a checkbutton in the "Screen Sharing" dialog
According to the new designs at
https://wiki.gnome.org/Design/SystemSettings/Sharing
We should use a checkbutton instead of a switch for
the "Allow connections to control the screen" option.
Also, this commit changes this option label accordingly.

https://bugzilla.gnome.org/show_bug.cgi?id=767646
2016-06-14 16:00:01 +02:00
Felipe Borges
612ac49205 sharing: Update "Screen Sharing" dialog description
To match the new designs at
https://wiki.gnome.org/Design/SystemSettings/Sharing

https://bugzilla.gnome.org/show_bug.cgi?id=767646
2016-06-14 15:59:19 +02:00
Bastien Nocera
70672c3658 sharing: Fix "format not a string literal" error
https://bugzilla.gnome.org/show_bug.cgi?id=764150
2016-03-24 17:01:37 +01:00
Bastien Nocera
9315eb0251 sharing: Fix crash when disabling sharing
Left-over code from 9d45904f3c meant that
we'd try to disable a non-existent switch.

https://bugzilla.gnome.org/show_bug.cgi?id=756391
2015-10-11 17:41:04 +02:00
Bastien Nocera
9d45904f3c sharing: Remove "Bluetooth" (Obex) sharing
It will be moved to the Bluetooth panel instead.

https://bugzilla.gnome.org/show_bug.cgi?id=740369
2015-07-30 20:13:29 +02:00
Joanmarie Diggs
cfb12e4e22 sharing: Accessibility improvements
* Add label-for/labelled-by AtkRlation pair between the "Computer Name"
  label and its entry.
* Give an accessible name to the switch in the header bar. In order to
  not break string freeze, used "Sharing" since that's what's shown in
  the header bar.
* Fix the incorrect mnemonic widget for media sharing so that Orca speaks
  the label in the main sharing panel, and the name in the media sharing
  dialog

https://bugzilla.gnome.org/show_bug.cgi?id=746759
2015-07-27 19:48:49 +02:00
David King
b4c02fa3b3 sharing: Update help URI
https://bugzilla.redhat.com/show_bug.cgi?id=1193806
https://bugzilla.gnome.org/show_bug.cgi?id=745590
2015-03-04 15:49:53 +00:00
Rui Matos
38180662cd sharing: Don't add the folder if the dialog isn't explicity accepted
E.g. selecting a folder and then dismissing the dialog via the cancel
button or by pressing escape would still add the folder to the shared
folders list.
2015-02-09 17:25:36 +01:00
Rui Matos
7d1a8db47e sharing: Drop deprecated API usage
https://bugzilla.gnome.org/show_bug.cgi?id=740986
2014-12-05 16:13:29 +01:00
Bastien Nocera
884bf3b2dc sharing: Make it possible to share remote folders
rygel can actually share media if the remote folder is mounted.
2014-08-07 13:05:01 +02:00
Rui Matos
c2ad24e804 sharing: Use the selected URI from the file chooser
Using the current folder is counter-intuitive. The chooser already
only allows users to select folders.
2014-06-26 16:17:19 +02:00
Bastien Nocera
bd531b477e sharing: Update for list box API change 2014-06-26 16:00:45 +02:00
Rui Matos
61a6c6f0cb shell: Fix list box scrolling helper
GtkListBox doesn't implement GtkScrollable so it needs to be added to
a GtkViewport. Instead of having to do this in all .ui files, add a
new helper function to setup the widget tree correctly.

https://bugzilla.gnome.org/show_bug.cgi?id=732175
2014-06-25 17:29:30 +02:00
Bastien Nocera
1f1bfa5459 sharing: Use new listbox helpers
https://bugzilla.gnome.org/show_bug.cgi?id=732106
2014-06-24 11:35:31 +02:00
Bastien Nocera
cbeba7c6bf sharing: Add per-network sharing
Using the new D-Bus service from gnome-settings-daemon.

https://bugzilla.gnome.org/show_bug.cgi?id=727580
2014-06-24 11:35:30 +02:00
Bastien Nocera
9b4fcd6266 sharing: Use GtkListBox instead of treeview for media folders
As per mockups

https://bugzilla.gnome.org/show_bug.cgi?id=731580
2014-06-23 12:09:01 +02:00
Thomas Wood
ab4a5230be sharing: address ambiguity in the screen sharing dialog
https://bugzilla.gnome.org/show_bug.cgi?id=723280
2014-02-18 12:08:42 +01:00
Bastien Nocera
4847cc401d sharing: Use g-s-d's rfkill for Bluetooth
https://bugzilla.gnome.org/show_bug.cgi?id=719500
2013-12-06 11:59:03 +01:00
Bastien Nocera
959e0c0d6a sharing: Switch between bonded and ask for Bluetooth
Instead of bonded and always.
2013-11-15 13:40:09 +01:00
Bastien Nocera
4e4fd87c45 sharing: Fix compile time warning
Another warning in cc_sharing_panel_add_folder()
2013-11-15 00:02:53 +01:00
Bastien Nocera
70a4183168 sharing: Fix crash when turning off Sharing
Another fallout from:
05a4f6d3d9

https://bugzilla.gnome.org/show_bug.cgi?id=712338
2013-11-15 00:02:53 +01:00
Bastien Nocera
53391fedbc sharing: Make it possible to add new folders
The media panel wouldn't let you add more folder because the
test for equality was reversed.

https://bugzilla.gnome.org/show_bug.cgi?id=710580
2013-11-14 09:27:10 +01:00
Bastien Nocera
ec60137db5 sharing: Add more debug for duplicate folders 2013-11-14 09:24:06 +01:00
Bastien Nocera
b0b43d1494 sharing: Fix Bluetooth label always being off
https://bugzilla.gnome.org/show_bug.cgi?id=712252
2013-11-14 09:24:06 +01:00
Bastien Nocera
05a4f6d3d9 sharing: Remove OBEX FTP support
As it's been removed from gnome-user-share.

https://bugzilla.gnome.org/show_bug.cgi?id=711730
2013-11-12 15:02:35 +01:00
Thomas Wood
1288d64952 sharing: ensure the hostname in labels is updated
https://bugzilla.gnome.org/show_bug.cgi?id=698421
2013-10-04 10:12:01 +01:00