Commit graph

7551 commits

Author SHA1 Message Date
Pablo Correa Gómez
7f7b65545c all: meson: do not specify resources from gresource files as dependencies
Meson extracts them by itself and add them as dependencies for the target.
It means one less location to keep track of files, and a lot less boilerplate
around the meson files
2023-05-24 08:34:14 +00:00
Felipe Borges
2cf57ffb10 datetime: Merge "Clock" and "Calendar" sections
According to mockups at
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/raw/master/date-and-time/date-and-time.png
2023-05-22 13:18:31 +00:00
Felipe Borges
79636a8eb9 datetime: Move "Time Format" row out of "Clock" section
https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1277#note_1751622
2023-05-22 13:18:31 +00:00
Lains
7615bb5ccb datetime: Add top bar clock and calendar switches
For changing the clock display (weekday, seconds, date) and week numbers on the calendar

These switches should change:
- Whether or not the clock display has the week day (e.g. Mon).
- Whether or not the clock display has the date (e.g. Jun 6).
- Whether or not the clock display has seconds (e.g. 12:30:45).
- Whether or not the clock's popup calendar should show the week's number.

Fixes #257
2023-05-22 13:18:31 +00:00
Mpho Jele
483a5f3e8d user-accounts: Use AdwEntryRow for user full name 2023-05-17 11:14:29 +02:00
Markus Göllnitz
98c47cee10 mouse: ensure type CcListRowInfoButton is available to GtkBuilder
The newly introduced CcListRowInfoButton is not available
to GtkBuilder and henceforth building the mouse panel
currently fails.

Therefore, it CcListRowInfoButton has to be declared to
be a type that needs to be available to this panel.

Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
2023-05-16 20:49:28 +02:00
Felipe Borges
b2d5e78934 mouse: Use CcListRowInfoButton for mouse_aceleration row 2023-05-16 13:32:21 +00:00
Felipe Borges
45931c783f user-accounts: Make Administrator row use info button widget
Instead of recreating the menu button and popover.
2023-05-16 13:32:21 +00:00
Felipe Borges
d586df5c87 user-accounts: Add a popover describing the autologin functionality
Fixes #2235
2023-05-16 13:32:21 +00:00
Felipe Borges
00a71d46da common: Introduce CcListRowInfoButton widget
This simplifies the display of additional text information for our
rows.

See #1571
2023-05-16 13:32:21 +00:00
Mario Limonciello
aa46ae53a1 firmware-security: Skip security attributes that have been obsoleted by others
Fixes: #2481
2023-05-15 18:11:56 +00:00
Felipe Borges
073cf028a2 sharing: Add subtitle to each panel row
Fixes #2407
2023-05-15 13:37:17 +02:00
Felipe Borges
36938d53d6 sharing: Add icons next to each row
See #2407
2023-05-15 13:37:17 +02:00
Emad Saadat
813a5f838c wi-fi: Remove extraneous list box in Airplane Mode group
and give parent AdwPreferencesGroup the id of rfkill_widget
to preserve previous behavior (hiding widget when no
airplane mode available).
2023-05-15 10:50:09 +00:00
Emad Saadat
216a7619b7 wi-fi: Have page contents clamped like other pages
Achieved by making the container widget for all other widgets
in the content section of the panel an AdwPreferencesPage and
having each group of widgets (e.g. the airplane mode toggle
and the stack that shows the list of wi-fi networks or a status
message) be in its own AdwPreferencesGroup.

Much along the lines of !1739 and !1740

Also fixes #2420
2023-05-15 10:50:09 +00:00
sunflowerskater
1300d4b2d7 add-user-dialog: Add popover explaining about the "Administrator" option
This change adds a GtkPopover to explain about the "Administrator" option like in the mockups below:
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/blob/master/users/add-user.png
2023-05-10 09:37:04 +00:00
sunflowerskater
1ba63a360c user-panel: Add popover explaining about the "Administrator" option
This change adds a GtkPopover to explain about the "Administrator" option like in the mockups below:
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/raw/master/users/users.png
2023-05-10 09:37:04 +00:00
Balázs Úr
754283c2c2 firmware-security: Mark button label as translatable 2023-05-10 05:33:38 +00:00
velsinki
efc595cccd sharing: Fix visual bug for active indicators
The switch for the current network was only updated to TRUE after a
network change. However, if a new network was not enabled, the switch
should be set to FALSE. This is now properly handled.

Furthermore, the Off/Enabled/Active indicator was also inconsistent
after network changes due to the is_visible check failing sometimes,
even after changing to an already enabled network. Because the actual
current network state is now better tracked, we can just check the state
of the switch instead.
2023-05-05 09:35:01 +00:00
Felipe Borges
6179d585a6 color: Make it easier to translate panel description string
This helps translators understand what are the placeholders in
the visible string.

+#. Translators: This will be presented as the text of a link to the documentation
+#. translators: Text used in link to privacy policy
+#: panels/color/cc-color-panel.c:2021
+#: panels/diagnostics/cc-diagnostics-panel.c:137
+msgid "Learn more"

+#. Translators: %s is a link to the documentation with the label "Learn more"
+#: panels/color/cc-color-panel.c:2023
+msgid "Each device needs an up to date color profile to be color managed. %s"
2023-05-04 10:06:26 +00:00
sunflowerskater
2d310918fa color: Dim information text & fix "Learn more" link alignment 2023-05-04 10:06:26 +00:00
Automeris naranja
8dd0abeaa4 network: Rename "Other Devices" to "Bluetooth"
Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2102
2023-05-04 09:54:49 +00:00
Automeris naranja
13e4e0c242 general: Set a minimum size for various dialogs
This change prevents some dialogs from being shrunk
to a really small size by setting a minimum size for them.
2023-05-04 09:54:07 +00:00
Automeris naranja
fe36282b26 network: AdwStatusPage consistency tweaks
Both Wi-Fi and Network panels shows a status page when Network Manager isn't running.
However, they don't use the same writing style:

- https://gitlab.gnome.org/GNOME/gnome-control-center/-/blob/gnome-44/panels/network/cc-wifi-panel.ui#L221
- https://gitlab.gnome.org/GNOME/gnome-control-center/-/blob/gnome-44/panels/network/cc-network-panel.c#L672

This change makes both status pages to use the same writing style.
2023-05-03 11:25:24 +00:00
Nelson Benítez León
6fb6ba1dc9 meson: improve comment and fix deprecated functions
- Clarify that 'mm-glib' dep is for ModemManager (not Network
   Manager which is below). The comment also helps people
   which may confuse it with glibmm library.

 - Fix following Meson warning about two deprecated functions:
   WARNING: Deprecated features used:
   * 0.56.0: {'dependency.get_pkgconfig_variable', 'meson.source_root'}
2023-05-02 11:33:31 +00:00
Ray Strode
b1850b5c8a background: Clear out dconf if user picks defaults
If a user chooses the default background in control-center, then
they still end up with a change in dconf. This change means that
on upgrades, they'll keep the old distro background configured.

That's probably unexpected and may lead them to believe the upgrade
didn't work.

This commit checks if the user goes back to the distro defaults and
clears out dconf in that case, so that when the disto defaults change
they get the new defaults.
2023-05-02 11:32:49 +00:00
Felipe Borges
15145bd20e universal-access: Make Hearing page string translatable
Fixes #2457
2023-04-25 07:00:06 +00:00
Automeris naranja
1a0bf81cad format-chooser: Drop ellipsis from placeholder text of search entry
None of the placeholders suggested by Allan Day have ellipsis, so
this change drops the ellipsis from the placeholder text of the search entry
from format-chooser, thus keeping consistency.

https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1526#note_1609984
2023-04-21 12:40:42 +00:00
sunflowerskater
c95dcf2a9a general: Add placeholder text to various search entries
Acc. HIG, "text fields should have placeholder text or a label".

https://developer.gnome.org/hig/patterns/controls/text-fields.html

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2190
2023-04-21 12:40:42 +00:00
Felipe Borges
58a0d8fd32 network: Add quotes to network name in Forget Connection dialog
See https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1765#note_1726456
2023-04-20 17:30:55 +02:00
Felipe Borges
e0dc75bcfc mouse: Hide entire "Touchpad" row when touchpad cannot be disabled
The touchpad row has a switch suffix that allows enabling/disabling
touchpad.

To prevent users from being left with no pointer device, we were
hiding the suffix switch of the touchpad row, making the row look
weird with a label and no action.

Let's hide the entire row instead, as suggested by designers in
comment https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1649#note_1643002

Fixes #1649
2023-04-20 14:09:04 +00:00
Felipe Borges
7e12d653ba common: Don't set the CcHostnameEntry widget sensitivity twice 2023-04-20 14:08:29 +00:00
Felipe Borges
61ba210c99 user-accounts: Remove autologin row tooltip when unlocked
Fixes #2451
2023-04-20 09:24:48 +00:00
Felipe Borges
e3965a6586 wifi: Include network name in the Forget dialog
See https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1701#note_1719089
2023-04-20 09:24:21 +00:00
Chris Mayo
bd6c61ab06 wacom: Fix WacomPage crash due to unknown type in UI description
Error building template class 'CcWacomPage' for an instance of type 'CcWacomPage': .:0:0 Invalid object type 'CcListRow'
2023-04-17 12:14:58 +00:00
Chris Mayo
0d1ae3d4f4 datetime: Fix Time Format ComboRow
Failed to set property AdwEnumListModel.enum-type to GDesktopClockFormat: Unsupported GType 'GDesktopClockFormat' for value of type 'GType'

meson.build code adapted from background/meson.build.
2023-04-17 12:14:58 +00:00
Chris Mayo
92c4b6a706 Fix panel crashes due to unknown types in UI descriptions
Error building template class 'CcSearchPanel' for an instance of type 'CcSearchPanel': .:0:0 Invalid object type 'CcListRow'

Error building template class 'CcDisplayPanel' for an instance of type 'CcDisplayPanel': .:0:0 Invalid object type 'CcListRow'

Error building template class 'CcMousePanel' for an instance of type 'CcMousePanel': .:0:0 Invalid object type 'CcIllustratedRow'

Error building template class 'CcKeyboardPanel' for an instance of type 'CcKeyboardPanel': .:0:0 Invalid object type 'CcListRow'

Error building template class 'CcRegionPanel' for an instance of type 'CcRegionPanel': .:0:0 Invalid object type 'CcListRow'

Error building template class 'CcUaPanel' for an instance of type 'CcUaPanel': .:0:0 Invalid object type 'CcListRow'

Error building template class 'CcUserPanel' for an instance of type 'CcUserPanel': .:0:0 Invalid object type 'CcAvatarChooser'
Error building template class 'CcUserPanel' for an instance of type 'CcUserPanel': .:0:0 Invalid object type 'CcListRow'

Error building template class 'CcDateTimePanel' for an instance of type 'CcDateTimePanel': .:0:0 Invalid object type 'CcTzDialog'
cc_tz_dialog_get_selected_location: assertion 'CC_IS_TZ_DIALOG (self)' failed
dumped core
Error building template class 'CcDateTimePanel' for an instance of type 'CcDateTimePanel': .:0:0 Invalid object type 'CcListRow'

Error building template class 'CcInfoOverviewPanel' for an instance of type 'CcInfoOverviewPanel': .:0:0 Invalid object type 'CcHostnameEntry'
2023-04-17 12:14:58 +00:00
Automeris naranja
9b940c27ca network: Use the "labelled-by" property to avoid repeating strings unnecessarily 2023-04-12 18:35:20 -03:00
Automeris naranja
fe5257bc9e general: Remove a11y labels when they aren't needed
A11y labels aren't needed when using the "activatable-widget"
property, because the relation is set automatically:

https://gitlab.gnome.org/GNOME/libadwaita/-/blob/main/src/adw-action-row.c#L661
2023-04-12 18:34:20 -03:00
Automeris naranja
fe435b9e93 general: Use the "activatable-widget" property in several rows 2023-04-12 18:27:37 -03:00
Gotam Gorabh
8cb77b4d3a sharing:removed global master switch
These changes remove the global master switch from
sharing panel and set main_list_box active.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2415
2023-04-12 13:47:31 +00:00
Jonathan Kang
14b3652289 network/connection-editor: fix crash when removing a connection
This was caused by commit 6f1567f23.
2023-04-12 16:01:51 +08:00
Christopher Davis
74e6964fd1 region: Use AdwBanner instead of GtkInfoBar
AdwBanner is a new adaptive widget that should be used
in place of GtkInfoBar. It provides an API close
to how we use InfoBars in GNOME, and fits better at smaller
window sizes.

This commit swaps out the GtkInfoBar used in the Region panel
for an AdwBanner.
2023-04-11 12:23:16 +00:00
Christopher Davis
d25c0e345d general: Use AdwBanner in CcPermissionInfobar
AdwBanner is a new adaptive widget that replaces GtkInfoBar.
AdwBanner adapts better to mobile sizes and has an API
that fits with how we use infobars.

This commit changes CcPermissionInfobar to use an AdwBanner
internally instead of a GtkInfoBar. It also re-implements
part of GtkLockButton, as AdwBanner does not support adding
arbitrary widgets.
2023-04-11 12:23:16 +00:00
Timotej Šulík
4702757b93 display: Fix display enabled toggle visibility 2023-04-11 12:16:54 +00:00
Gotam Gorabh
ad063dfa55 wi-fi:Updated Forget Connection dialog of saved networks with AdwMessageDialog
This changes update the Forget Connection dialog of saved networks
using AdwMessageDialog instead of GtkMessageDialog. And set Cancel
as a default responce instead of Forget to overcome accidental forget.
2023-04-11 11:56:05 +00:00
iampkumar02
27d5e7dd26 wifi: Center panel title when subtitle isn't visible
We used to have a custom title widget containing a label for the
title and another for the subtitle (status). When the subtitle label
wasn't visible, the title label wouldn't get centered vertically in
the headerbar.

By porting the custom title widget to AdwWindowTitle we get the title
centered for free.

Fixes #1891
2023-04-11 13:49:09 +02:00
Cyber Phantom
4b450409c5 wifi: Add a confirmation dialog when forgetting a connection
Destructive actions are supposed to have a dialog asking the user for confirmation.

This commit adds the confirmation dialog when user tries to forget a wifi network.

Fixes #2371
2023-04-11 11:28:26 +00:00
Sayan Bhattacharjee
0524a6eee6 info-overview: Show each GPU in it's own line
When having multiple GPUs, each GPUs are now seperated by a newline
instead of the previously used seperator: " / ".
This particular fix works ONLY for systems that use switcheroo-control.

Also, this commit allows the 'secondary_label' of 'CcListRow' to have
'lines' set to '4' and 'wrap' to 'True', along with 'hexpand'
and 'halign' set to 'True' to accommodate long strings on all labels
which previously suffered from a issue of getting truncated if
the strings are too long.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2125
2023-04-11 11:20:28 +00:00
Felipe Borges
ff4394da40 Revert "cc-wifi-connection-list: Don't show empty listbox"
This causes the "Saved Networks" list to never show rows.

This reverts commit ba13ca1f4a.
2023-04-07 13:37:23 +00:00