Commit graph

5361 commits

Author SHA1 Message Date
Robert Ancell
85604ab4f0 printers: Simplify finalize/dispose methods
Use g_clear_* functions to simplify code and ensure values are set to NULL after freeing.
2019-01-30 11:33:28 +13:00
Robert Ancell
4042cb5d33 printers: Replace GObject boilerplace with G_DECLARE_TYPE 2019-01-30 11:33:28 +13:00
Adrien Plazas
28302948d3 info: Ellipsize the overview labels
This allows the panel to reach narrower widths.
2019-01-29 17:30:13 +01:00
Adrien Plazas
f970e9199e info: Adapt the indentation
This adapts the indentation of the children of HdyColumn, which were
deliberately left intact in the previous commit to make it more
readable.
2019-01-29 17:30:13 +01:00
Adrien Plazas
d4daa8d2c7 info: Add a scrolled window and a column to the overview
This will allow the panel to reach smaller sizes.

This deliberately doesn't adapt the indentation of the contained widget
to help this commit to be more readable and easier to review, it will be
adapted in the next commit.
2019-01-29 17:30:13 +01:00
Adrien Plazas
ba6106dfca display: Use a HdyColumn
This allows the panel to better adapt to the available width.
2019-01-29 17:23:20 +01:00
Benjamin Berg
d9a7c84905 display: Rewrite as a template widget 2019-01-29 12:05:43 +01:00
Benjamin Berg
e5925f5eb6 display: Hookup new CcDisplaySettings 2019-01-29 12:05:43 +01:00
Benjamin Berg
8503dab530 display: Add settings widget for output configuration
This widget now uses libhandy for the rows.
2019-01-29 12:05:43 +01:00
Benjamin Berg
b789a1cda2 common: Add CcValueObject until HdyValueObject is available
libhandy now has HdyValueObject, this simply copies the class over as it
will only become available in libhandy 0.8.
2019-01-29 12:05:43 +01:00
Benjamin Berg
afe8661704 display: Allow config to be modified in arrangement widget 2019-01-29 12:05:43 +01:00
Benjamin Berg
9025f79b5f display: Add helper that returns the monitor name as new string 2019-01-29 12:05:43 +01:00
Benjamin Berg
4360288c74 display: Move setter for cloning mode into CcDisplayConfig
It will be used from multiple files in the future.
2019-01-29 12:05:43 +01:00
Benjamin Berg
be3fbd8bef display: Redraw arrangement widget after monitor selection change 2019-01-29 12:05:43 +01:00
Benjamin Berg
5b53f026c8 display: Chain up CcDisplayConfig finalize handler 2019-01-29 12:05:43 +01:00
Benjamin Berg
e520ab8952 display: Chain up CcDisplayArrangement finalize handler 2019-01-29 12:05:43 +01:00
Benjamin Berg
713e209783 display: Add missing finalize handler for CcDisplayMonitor
This caused the UI related strings to be leaked.
2019-01-29 12:05:43 +01:00
Benjamin Berg
41717253c8 display: Fix leak in night light dialog 2019-01-29 12:05:43 +01:00
Benjamin Berg
d9aab36609 display: Compare configurations without monitor offset
When comparing configurations, the monitor positions are compared
directly. This comparison will not work properly if one of the
configurations has an offset.

This results in the "Apply" button to show up incorrectly after moving
the top/left monitor position.
2019-01-29 12:05:43 +01:00
Jeremy Bicha
dde97ecb2e mouse: Don't use a separate box for touchpad switch
The Touchpad section looks like a single listbox
so let's handle it that way too.

This eliminates an unnecessary split in the touchpad
section that is noticeable when navigating with a keyboard.
2019-01-29 10:43:23 +00:00
Jeremy Bicha
783918aaf5 mouse: fix misplaced mnemonic labels 2019-01-29 10:43:23 +00:00
Adrien Plazas
b4520d07b5 color: Make the row labels ellipsizable
This better allows to better handle a narrow window.
2019-01-29 10:35:18 +00:00
Adrien Plazas
eaeb64d85e color: Use a HdyColumn
This helps the panel to fit in narrower windows.
2019-01-29 10:35:18 +00:00
Adrien Plazas
3c65262a05 datetime: Use HdyActionRow
This better handles the available space and simplifies the code.
2019-01-29 10:28:28 +00:00
Adrien Plazas
fd0b45d6c3 datetime: Use a scrolled window and a column
This better allows to handle short windows and better handle the
available width.
2019-01-29 10:28:28 +00:00
Adrien Plazas
91af270cce connection-editor: Use GtkTemplate 2019-01-27 21:03:13 +00:00
Philip Withnall
1ca4104844 user-accounts: Allow ‘Remove User’ button to be focused
Otherwise it isn’t included in the tab focus cycle, and can’t be
navigated to with the tab key.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
2019-01-22 16:50:24 +00:00
Adrien Plazas
358dbe3ce8 applications: Emit sidebar-activated on sidebar row activation
This will let the window know it should focus on the panel rather than
on the sidebar.
2019-01-21 21:53:21 +00:00
Adrien Plazas
b94496703e applications: Update the panel on activation, not selection
This allows to activate the already selected panel with a single click
rather than a double click, which will be needed to simply focus the
panel when the window will use a leaflet.
2019-01-21 21:53:21 +00:00
Benjamin Berg
4db431d7f1 display: Correctly round scaled monitor size
We were converting the floating point numbers to integers using a cast,
which causes them to be always rounded down. The result is that a
monitor may be too small by a pixel, creating broken configurations.

Also fix the same issue when calculating whether a scale should be
supported.

See https://gitlab.gnome.org/GNOME/mutter/issues/412
2019-01-18 11:19:16 +01:00
Jeremy Bicha
f5600cf9d6 applications: Don't use symbolic icon name in .desktop
gnome-control-center's shell uses the -symbolic version
automatically. Use the icon name without the -symbolic
suffix to match what we do with other panels.
2019-01-17 21:36:34 +00:00
Adrien Plazas
cccb12a6de notifications: Do not vertically expand the listbox
This avoids the list box to not look stupidly long and empty and matches
the design of the other list boxes.
2019-01-10 16:43:36 +00:00
Jeremy Bicha
ae75ebcafb universal-access: Reverse Repeat Keys Speed direction
Since the gsettings is for the repeat-interval but the
GUI is for Speed, we need to reverse the mapped direction.

We have to turn off the fill indicator (has_origin) for Speed
since it fills the right side instead of the left. We turn
off the indicator for Delay to match.

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/311
2019-01-10 11:58:42 +00:00
Jeremy Bicha
a9d6ed149b online-accounts: Set label relationship for listboxes
Set the label relationships so that screen readers
read the headers for the listboxes.
2019-01-10 11:53:00 +00:00
Jeremy Bicha
0f92ffb01a universal-access: Remove redundant label-for relations
The appropriate relation is already set with the mnemonic_widget property.

In particular, this also fixes an issue where a screenreader would
emit "Crosshairs" every time a new tab was entered in the Zoom dialog
because of some incorrect labelled-by relations.
2019-01-10 11:46:34 +00:00
Christian Kellner
06894e020a thunderbolt: fix double free in bolt client
In the async version of the client creation, i.e. when a new client
is created via bolt_client_new_async and an error happens it will be
passed to g_task_return_error which takes ownership of it but the very
same error will also be free'd via g_autoptr; remove the latter.

This is a port of bolt commit e96f8bd47587b167ae46c8ac9347003f69f931dd
2019-01-08 17:29:05 +01:00
Jeremy Bicha
dfcc2ba83d Revert "applications: Remove markup from a translatable string"
This reverts commit d2c759fcae.

The commit caused the Applications panel to crash with
Unhandled tag: <attributes>

Apparently CInfoRow doesn't know how to handle attributes.
2019-01-07 21:34:33 -05:00
Carlos Garnacho
67c8ef42d7 wacom: Align buttons/links to the left side
Looks more natural this way. All buttons and links have been moved
into the main grid so this is possible. The links additionally had
to be removed all the padding so they actually align visually.

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/238
2019-01-07 21:24:15 +00:00
Piotr Drąg
d2c759fcae applications: Remove markup from a translatable string 2019-01-07 20:06:03 +01:00
Jeremy Bicha
d9e07460ae night-light: Add a frame around Schedule section for accessibility
This way the Schedule label is correctly read as a header
for the section by screen readers
2019-01-07 10:57:17 -05:00
Jeremy Bicha
7f6d19441f night-light: Add mnemonic_widget and ATK descriptions for a11y 2019-01-07 10:41:32 -05:00
Benjamin Berg
0209694978 wifi: Show WEP with a broken security icon
WEP is rather insecure, and using it is a bad idea in general. So show
it as insecure rather than falsely advertising it as being secure.
2019-01-07 15:30:06 +01:00
Benjamin Berg
d126b3db5e wifi: Hook up new connection list widget 2019-01-07 15:29:23 +01:00
Benjamin Berg
fb7e09eb46 wifi: Add new connection list widget
This widget keep track of connections and APs and automatically
creates/refreshes the corresponding list entries.
2019-01-07 15:29:23 +01:00
Benjamin Berg
eec7841027 wifi: Add set_checked function to connection row 2019-01-07 15:29:23 +01:00
Benjamin Berg
5c81b12647 wifi: Handle multiple APs in a connection row
Note that this also changes the way to detect that the connection is
currently active. This change is not required but but does simplify the
code a little bit.
2019-01-07 15:29:23 +01:00
Benjamin Berg
3962aa3028 wifi: Show the connection name when it is different to SSID
In almost all cases, the SSID will be identical with the connection name
(in fact, we do not even allow modifying the connection name). However,
as it is now, we can end up with multiple connections with the same name
in the list.

Change the list to indicate the SSID separately in a way that will not
result in any changes in the usual case.
2019-01-07 15:29:23 +01:00
Benjamin Berg
8f706f45bd wifi: Remove unused code in wireless_try_to_connect
The code tries to establish a connect by using an existing connection.
However, if that is possible the function will not even be called.

Remove the code in question.
2019-01-07 15:29:23 +01:00
Benjamin Berg
fb089b7c55 wifi: Use new CcWifiConnectionRow widget
This is in preparation to optimise the AP list updating.
2019-01-07 15:29:23 +01:00
Benjamin Berg
0fb86c82d2 wifi: Add new CcWifiConnectionRow widget for the AP list
This is in preparation to optimize list to not be rebuild completely for
every change.
2019-01-07 15:29:20 +01:00