Commit graph

193 commits

Author SHA1 Message Date
Felipe Borges
4d001f7989 sharing: Update "Media Sharing" dialog description
To match the new designs at
https://wiki.gnome.org/Design/SystemSettings/Sharing

https://bugzilla.gnome.org/show_bug.cgi?id=767646
2016-06-14 15:58:55 +02:00
Bastien Nocera
5c10ce45b8 panels: Fix translators comments being truncated
Commit b3be076 added soft hyphens along with a comment for translators
to use those soft hyphens. Except that gettext would only grab the one
line out of the four we wrote for translators to read. Put them all on
the same line so that gettext actually extracts those.

https://bugzilla.gnome.org/show_bug.cgi?id=765778
2016-04-28 23:38:00 +02:00
Bastien Nocera
b3be07609a panels: Fix truncated panel names for larger fonts
Note that this fix will not automatically fix translations, which will
need to add soft-hyphens (U+00AD) to their translations themselves, and
will not fix larger fonts for which the split up syllables end up
being bigger than the maximum text width.

It's the best we can do without redesigning the Settings shell, which is
already something planned.

https://bugzilla.gnome.org/show_bug.cgi?id=647087#c13
2016-04-07 16:06:35 +02:00
Bastien Nocera
70672c3658 sharing: Fix "format not a string literal" error
https://bugzilla.gnome.org/show_bug.cgi?id=764150
2016-03-24 17:01:37 +01:00
Jiro Matsuzawa
a3a8255b97 sharing: Give mnemonic to labelled widgets
https://bugzilla.gnome.org/show_bug.cgi?id=736606
2016-01-18 17:21:17 +01:00
Bastien Nocera
0d4b2bc49b sharing: Ensure Tracker rygel plugin is disabled
The Tracker plugin is enabled by default, and will replace the
MediaExport plugin is enabled. This means that instead of sharing files
listed in the paths set in the UI, we'd be sharing the user's files as
configured in the Search panel. Not what we want to do if this contains
private files.
2016-01-10 10:24:41 +01:00
Bastien Nocera
9315eb0251 sharing: Fix crash when disabling sharing
Left-over code from 9d45904f3c meant that
we'd try to disable a non-existent switch.

https://bugzilla.gnome.org/show_bug.cgi?id=756391
2015-10-11 17:41:04 +02:00
Bastien Nocera
9d45904f3c sharing: Remove "Bluetooth" (Obex) sharing
It will be moved to the Bluetooth panel instead.

https://bugzilla.gnome.org/show_bug.cgi?id=740369
2015-07-30 20:13:29 +02:00
Joanmarie Diggs
cfb12e4e22 sharing: Accessibility improvements
* Add label-for/labelled-by AtkRlation pair between the "Computer Name"
  label and its entry.
* Give an accessible name to the switch in the header bar. In order to
  not break string freeze, used "Sharing" since that's what's shown in
  the header bar.
* Fix the incorrect mnemonic widget for media sharing so that Orca speaks
  the label in the main sharing panel, and the name in the media sharing
  dialog

https://bugzilla.gnome.org/show_bug.cgi?id=746759
2015-07-27 19:48:49 +02:00
Michael Biebl
1f4f6ded0f Make it possible to override SSHD_SERVICE
Upstream of openssh does not yet ship a systemd service file, so distros
add them downstream and unfortunately use different names: E.g. on
Fedora the unit is called sshd.service, on Debian/Ubuntu it is called
ssh.service.

Therefore make it possible to override SSHD_SERVICE via CFLAGS.

https://bugzilla.gnome.org/show_bug.cgi?id=751326
2015-06-28 23:20:03 +02:00
Mario Sanchez Prada
fd7d7d4c10 sharing: Use g_variant_get_{string|variant}() instead of g_variant_get()
Besides being a better practice, this changes also fixes 2 memory leaks
when handling strings boxed inside GVariant objects.

https://bugzilla.gnome.org/show_bug.cgi?id=748411
2015-04-27 15:55:20 +01:00
David King
b4c02fa3b3 sharing: Update help URI
https://bugzilla.redhat.com/show_bug.cgi?id=1193806
https://bugzilla.gnome.org/show_bug.cgi?id=745590
2015-03-04 15:49:53 +00:00
Rui Matos
38180662cd sharing: Don't add the folder if the dialog isn't explicity accepted
E.g. selecting a folder and then dismissing the dialog via the cancel
button or by pressing escape would still add the folder to the shared
folders list.
2015-02-09 17:25:36 +01:00
Yosef Or Boczko
d6c7e67d4f sharing: Put a real description string in the media dialog
https://bugzilla.gnome.org/show_bug.cgi?id=736537
2015-01-18 11:32:25 -05:00
Rui Matos
7d1a8db47e sharing: Drop deprecated API usage
https://bugzilla.gnome.org/show_bug.cgi?id=740986
2014-12-05 16:13:29 +01:00
Rui Matos
7121f03564 sharing: Prevent an endless loop and resulting stack overflow
We need to block ourselves around the gtk_switch_set_active() call in
the error path, when we can't speak to the sharing dbus service, or we
end up in an endless loop since we're the ::state-set handler.

https://bugzilla.gnome.org/show_bug.cgi?id=739886
2014-11-13 11:28:24 +01:00
Bastien Nocera
658bcc86e6 sharing: Fix empty folder list by default
https://bugzilla.gnome.org/show_bug.cgi?id=736536
2014-09-12 12:04:58 +02:00
Bastien Nocera
884bf3b2dc sharing: Make it possible to share remote folders
rygel can actually share media if the remote folder is mounted.
2014-08-07 13:05:01 +02:00
Bastien Nocera
22c4db538f sharing: Avoid truncated folders list in media sharing
When XDG user dirs are badly setup, and the folders list contains items
such as @VIDEOS@ or @MUSIC@, g_get_user_special_dir() returns NULL and
we would insert NULL into the string array. That would cause the code
reading it to assume the end of the array was reached.

Go through a temporary array instead to build it.

https://bugzilla.gnome.org/show_bug.cgi?id=733489
2014-07-24 12:39:08 +02:00
Bastien Nocera
056784e60e sharing: Fix crash in media preferences
When XDG user dirs are badly setup, g_get_user_special_dir() will return
NULL, causing us to crash. Use g_strcmp0() instead.

https://bugzilla.gnome.org/show_bug.cgi?id=733489
2014-07-24 12:39:08 +02:00
Yosef Or Boczko
da22bddc1a Mark a string as translatable 2014-06-27 12:52:20 +03:00
Rui Matos
c2ad24e804 sharing: Use the selected URI from the file chooser
Using the current folder is counter-intuitive. The chooser already
only allows users to select folders.
2014-06-26 16:17:19 +02:00
Bastien Nocera
bd531b477e sharing: Update for list box API change 2014-06-26 16:00:45 +02:00
Bastien Nocera
5eca0f898c sharing: Add maximum height for the networks list box 2014-06-26 16:00:45 +02:00
Bastien Nocera
73f3e17bee sharing: Use listbox header helper 2014-06-26 16:00:27 +02:00
Rui Matos
61a6c6f0cb shell: Fix list box scrolling helper
GtkListBox doesn't implement GtkScrollable so it needs to be added to
a GtkViewport. Instead of having to do this in all .ui files, add a
new helper function to setup the widget tree correctly.

https://bugzilla.gnome.org/show_bug.cgi?id=732175
2014-06-25 17:29:30 +02:00
Bastien Nocera
b54dfef668 sharing: Align the listboxes in media sharing 2014-06-25 16:44:02 +02:00
Bastien Nocera
ff8a8a6baa sharing: Update for sharing plugin API changes
See https://bugzilla.gnome.org/show_bug.cgi?id=732218
2014-06-25 16:21:21 +02:00
Bastien Nocera
1f1bfa5459 sharing: Use new listbox helpers
https://bugzilla.gnome.org/show_bug.cgi?id=732106
2014-06-24 11:35:31 +02:00
Bastien Nocera
cbeba7c6bf sharing: Add per-network sharing
Using the new D-Bus service from gnome-settings-daemon.

https://bugzilla.gnome.org/show_bug.cgi?id=727580
2014-06-24 11:35:30 +02:00
Bastien Nocera
e526257020 sharing: Fix long "file sharing" explanatory label 2014-06-24 11:35:30 +02:00
Bastien Nocera
9b4fcd6266 sharing: Use GtkListBox instead of treeview for media folders
As per mockups

https://bugzilla.gnome.org/show_bug.cgi?id=731580
2014-06-23 12:09:01 +02:00
Bastien Nocera
ca84ceed79 sharing: Rename header label in Media Sharing
As per mockups

https://bugzilla.gnome.org/show_bug.cgi?id=731580
2014-06-23 12:09:01 +02:00
Bastien Nocera
f81398c0d2 sharing: Move Media Sharing master toggle to header bar
As per mockups

https://bugzilla.gnome.org/show_bug.cgi?id=731580
2014-06-23 12:09:01 +02:00
Bastien Nocera
c5f991f390 sharing: Change explanatory text to match mockups
https://bugzilla.gnome.org/show_bug.cgi?id=731580
2014-06-23 12:09:01 +02:00
Chris Johns
4def21caf1 sharing: Minor cosmetic changes
The top label is now has character limited width, and a small amount of
bottom padding.

https://bugzilla.gnome.org/show_bug.cgi?id=724629
2014-04-29 14:33:59 +02:00
Yosef Or Boczko
ecea570ee8 sharing: Use header bar in all the dialogs
https://bugzilla.gnome.org/show_bug.cgi?id=724299
2014-04-28 17:29:17 +03:00
Thomas Wood
ab4a5230be sharing: address ambiguity in the screen sharing dialog
https://bugzilla.gnome.org/show_bug.cgi?id=723280
2014-02-18 12:08:42 +01:00
Daniel Mustieles
2c5951819d Updated FSF's address 2014-01-29 11:27:38 +01:00
Bastien Nocera
4847cc401d sharing: Use g-s-d's rfkill for Bluetooth
https://bugzilla.gnome.org/show_bug.cgi?id=719500
2013-12-06 11:59:03 +01:00
Yosef Or Boczko
10cfda4620 sharing: Use margin-start/end instead of margin-left/right
https://bugzilla.gnome.org/show_bug.cgi?id=712661
2013-11-19 22:31:50 +02:00
Jasper St. Pierre
dd52ac9417 Add NoDisplay to all gnome-control-center panel .desktop files
These aren't apps -- they're simply launchers for gnome-control-center.
They should not be shown as apps in the UI at all.

https://bugzilla.gnome.org/show_bug.cgi?id=712246
2013-11-15 08:44:53 -05:00
Bastien Nocera
959e0c0d6a sharing: Switch between bonded and ask for Bluetooth
Instead of bonded and always.
2013-11-15 13:40:09 +01:00
Bastien Nocera
4e4fd87c45 sharing: Fix compile time warning
Another warning in cc_sharing_panel_add_folder()
2013-11-15 00:02:53 +01:00
Bastien Nocera
70a4183168 sharing: Fix crash when turning off Sharing
Another fallout from:
05a4f6d3d9

https://bugzilla.gnome.org/show_bug.cgi?id=712338
2013-11-15 00:02:53 +01:00
Bastien Nocera
53391fedbc sharing: Make it possible to add new folders
The media panel wouldn't let you add more folder because the
test for equality was reversed.

https://bugzilla.gnome.org/show_bug.cgi?id=710580
2013-11-14 09:27:10 +01:00
Bastien Nocera
ec60137db5 sharing: Add more debug for duplicate folders 2013-11-14 09:24:06 +01:00
Bastien Nocera
b0b43d1494 sharing: Fix Bluetooth label always being off
https://bugzilla.gnome.org/show_bug.cgi?id=712252
2013-11-14 09:24:06 +01:00
Bastien Nocera
05a4f6d3d9 sharing: Remove OBEX FTP support
As it's been removed from gnome-user-share.

https://bugzilla.gnome.org/show_bug.cgi?id=711730
2013-11-12 15:02:35 +01:00
Thomas Wood
1288d64952 sharing: ensure the hostname in labels is updated
https://bugzilla.gnome.org/show_bug.cgi?id=698421
2013-10-04 10:12:01 +01:00