Commit graph

7397 commits

Author SHA1 Message Date
Alessandro Bono
e7458ff1b4 sharing: Set active property instead of state
The ability to tweak the state property was mainly introduced in
order to implement delayed state change via the state-set signal.
Since GTK 4.9.3[1] the active and state properties are no more
interchangeable.

[1] https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5442
2023-03-03 18:16:57 +00:00
Alessandro Bono
7c356d8c7d datetime: Decouple active and state properties usage
The ability to tweak the state property was mainly introduced in
order to implement delayed state change via the state-set signal.
Since GTK 4.9.3[1] the active and state properties are no more
interchangeable.

[1] https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5442

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2330
2023-03-03 18:16:57 +00:00
Alessandro Bono
9af0a2d15e bluetooth: Decouple active and state properties usage
The ability to tweak the state property was mainly introduced in
order to implement delayed state change via the state-set signal.
Since GTK 4.9.3[1] the active and state properties are no more
interchangeable.

[1] https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5442
2023-03-03 18:16:57 +00:00
Alessandro Bono
f275c3a53c bluetooth: Properly fetch changing state
Since commit 75c3e11708 user_data does not
contain the state anymore. Assume that the active value is what the state
is going to be.
2023-03-03 18:16:57 +00:00
Alessandro Bono
b236b72fb2 bluetooth: Return TRUE for state-set callback
From the documentation[1]: "The signal handler should return TRUE to
prevent the default handler from running."

[1] https://docs.gtk.org/gtk4/signal.Switch.state-set.html
2023-03-03 18:16:57 +00:00
Jonas Ådahl
b612179cdb panels/remote-desktop: Popuplate address label
This means the address will displayed as intended, and clicking the copy
icon will copy it again.

Related: https://bugzilla.redhat.com/show_bug.cgi?id=2173136
2023-03-03 13:57:09 +01:00
Automeris naranja
ce212d9d06 firmware-security-dialog: Increase the dialog height
This change increases the dialog height to avoid
showing an unnecessary scrollbar.

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2369
2023-03-02 15:53:07 +00:00
Felipe Borges
0e7ad06da3 mouse: Rename "Pointer Assistance" to "Mouse Acceleration"
This is the popular term  for this feature and we would be confusing
users by inserting new terminology.
2023-03-02 15:51:22 +00:00
Mohammed Sadiq
e155979dc2 keyboard: shortcut-dialog: Set custom title for subview
So that we can have different titles for main view and subview,
and so the title won't be broken when swiping back from subview.
2023-03-01 16:12:19 +00:00
Mohammed Sadiq
287ab748a1 keyboard: shortcut-dialog: Pack content in a single leaflet
Don't pack headerbar and content separately, keep them together.
So that navigating back shall work right.
2023-03-01 16:12:19 +00:00
Mohammed Sadiq
f86fc38ef4 keyboard: shortcut-dialog: Remove separator between headerbar and search
Since we now uses GtkSearchBar, we no longer requires a separator in
between as GtkSearchBar has one already.
2023-03-01 16:12:19 +00:00
Mohammed Sadiq
d978d51c96 keyboard: shortcut-dialog: Don't update search results in sub-view
Since the main view is not visible, there is no point in updating
search results when we are in a sub-view.  This will happen as we
always listen to keyboard events for the whole window - regardless
of whether the search entry has focus or not.
2023-03-01 16:12:19 +00:00
Mohammed Sadiq
73c76a7e85 keyboard: shortcut-dialog: Pack search inside a SearchBar
So that they are shown distinct from the rest of the content and
have proper margins

Fixes #2202
2023-03-01 16:12:19 +00:00
Mohammed Sadiq
587a1b05ae keyboard: shortcut-dialog: Add margins around search entry
So that they won't get too close to the window borders.  Also adjust
width-chars so that the window width can reach smaller sizes
2023-03-01 16:12:19 +00:00
Mohammed Sadiq
76707bb701 keyboard: shortcut-dialog: Align status pages to the center of the page
Fixes #2202
2023-03-01 16:12:19 +00:00
Mohammed Sadiq
40cf37590f keyboard: shortcut-dialog: Remove sub-view search code
We have had removed support for searching in sub-sections.
Remove related code which is no longer used
2023-03-01 16:12:19 +00:00
Mohammed Sadiq
80ff36d18c keyboard: shortcut-dialog: Don't update search visibility in custom shortcuts
Now we never show search entry in subpages, so don't hide search entry
when switching to subviews.  Otherwise, the search entry will be hidden
when the user switches back to the main view.
2023-03-01 16:12:19 +00:00
Mohammed Sadiq
c0be13c7d6 keyboard: shortcut-dialog: Fix search on swipe navigations
We were updating the state when the back button is pressed, not when
the pages were changed, and so the dialog state was broken if the
user went back by swipe (or means other than clicking the back button).

Fix it by handling updating state when the visible view changes.
2023-03-01 16:12:19 +00:00
Mohammed Sadiq
6a84e1eb83 keyboard: shortcut-dialog: Use AdwLeaflet for headerbar
So that users can swipe on headerbar to go back

Fixes #2202
2023-03-01 16:12:19 +00:00
Mohammed Sadiq
db82543a62 keyboard: shortcut-dialog: Focus search entry when the window is presented 2023-03-01 16:12:19 +00:00
Markus Göllnitz
0754e1ef13 mouse: add title to header bar
The header bar of the mouse panel can display a title, when
the stack only contains the mouse and the touchscreen subpanel.

This header bar, however, does not inherit the title widget from
the common CcPanel, as it contains the view switcher.

It is needed to add the correct title as a property to the switcher
to let it display this title, if no switcher is.

Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
2023-03-01 14:34:09 +00:00
Markus Göllnitz
8b4fbef678 mouse panel: add navigate back button
The mouse panel currently does not show a button to navigate back,
but should do so if the window is folded.

fixes #2363

Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
2023-03-01 13:58:19 +00:00
Felipe Borges
4e10ccb9ea mouse: Toggle visibility of Touchpad page based on device detection
Fixes #2355
2023-02-28 14:17:37 +00:00
Felipe Borges
5b4c9e16a8 mouse: Don't set arbitrary dimensions for mouse test window
As long as the picture's scrolled window can be larger than 440,
everything else should fit within the window's default size.

Fixes #2356
2023-02-28 14:16:49 +00:00
Bastien Nocera
2417cd5e6e wifi: Handle open networks in QR code
Fix empty dialogue when the current Wi-Fi network is an open network.

Closes: #2372
2023-02-27 20:00:15 +00:00
Hendrik Müller
0a5f0d16e3 wifi: Allow QR code dialog to be closed by pressing ESC
Being able to close the QR code dialog by pressing the ESC
key would be a handy feature.

By switching from GtkWindow to GtkDialog, the QR code
dialog is closed when pressing ESC.

Closes #2357
2023-02-25 13:00:15 +00:00
Lukáš Tyrychtr
1bfa4be664 info-overview: Actually don't show the firmware version row when in a VM
The previous logic was hiding the row when we were not under virtualization.
Fixes #2351
2023-02-21 10:04:27 +00:00
Nelson Benítez León
0cb4706b88 user-accounts: restore default cursor in CcCropArea dialog
The CcCropArea dialog fails to update cursor to 'default'
one when leaving the CcCropArea into the GtkHeaderBar.

Fix that by setting 'default' cursor in the "leave" event
of CcCropArea.

Closes #2359
2023-02-20 10:56:38 +00:00
Nelson Benítez León
d57e152f57 user-accounts: close CcAvatarChooser before showing GtkFileChooser
so that the first click on the FileChooser is not used to just
close the CcAvatarChooser dialog.

Close issue #2315
2023-02-20 09:04:19 +00:00
Nelson Benítez León
3fcf9aa7f1 user-accounts: disallow commas in real name
Because real name is stored in the GECOS field of
/etc/passwd, which is delimited by commas that
cannot be escaped, the user's full name must not
contain a comma. More info at:
https://gitlab.freedesktop.org/accountsservice/accountsservice/issues/83

Closes #888
2023-02-20 08:55:10 +00:00
Nelson Benítez León
947bb48985 users-account: fix CcCropArea dialog transient parent
the transient parent for the dialog was wrongly set to
its own window, causing following g_critical message:
Gtk-CRITICAL **: gtk_window_set_transient_for: assertion 'parent == NULL || GTK_IS_WINDOW (parent)' failed
2023-02-18 22:20:35 -04:00
Ray Strode
8a98497fb0 user-accounts: Don't access user before it's loaded
libaccountsservice documents that it is undefined to access an
ActUser object's properties before the 'is-loaded' property is
set to try.

Control-center unfortunately sometimes accesses objects that
aren't fully loaded, leading to log spew and memory corruption.

This commit fixes the problem by setting up a signal handler
to listen for the is-loaded notification when necessary.

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2348
Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2349
2023-02-17 09:45:18 +00:00
Jakub Steiner
2e9e87ad40 mouse: Update mouse video assets
- slight adjustments to layout and sizing of individual elements
- based on discussions with Allan & Tobias
2023-02-17 02:09:50 +00:00
Felipe Borges
75e92da6d2 common: Use GtkPicture for CcSplitRow and CcIllustrationRow videos
So we can preserve the aspect-ratio.

Fixes #2345
2023-02-17 02:09:50 +00:00
Felipe Borges
573428d006 mouse: Update mouse video assets
as of https://gitlab.gnome.org/Teams/Design/settings-mockups/-/commit/ad52c2617
2023-02-17 02:09:50 +00:00
Lukáš Tyrychtr
62708fc44f Add the label with the current alert sound as a description for the row, so a screen reader reads it 2023-02-17 02:08:47 +00:00
Felipe Borges
6b4e8ca316 common: Pause CcSplitRow/CcIllustrated videos when pointer leaves
Fixes #2346
2023-02-17 00:48:51 +00:00
Zdenek Dohnal
fb07b65cee printers: Use CUPS dest API for printing test page instead CUPS IPP API
The current usage of CUPS IPP API does not work for temporary queues, because the g-c-c sends the request without creating a local printer first, so the request is sent to non-existing printer.
If you use the destination from cupsGetNamedDest() for printing, CUPS library does the local printer creation internally and printing test page will work even for temporary queues.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2148481
2023-02-16 15:12:27 +00:00
Georges Basile Stavracas Neto
b2363b6847 network: Improve QR code appearance
Replace the 'frame' style class with 'card'.
2023-02-14 19:52:47 -03:00
Hendrik Müller
add2f0d2f7 wifi: Add QR code to share Wi-Fi networks
Many devices are able to scan a specifically formatted QR code to
connect to a wifi network.
To make sharing of wifi connections easier, it would be helpful to
display such a QR code in the wifi settings.

A button is added to the wifi connection row. This row is shown in
the general wifi settings panel, as well as in the "Known Wi-Fi Network"
dialog. Clicking the button opens an additional dialog, which shows the
QR code.
2023-02-14 19:11:07 -03:00
Alexander Mikhaylenko
e911f7defd mouse: Fix swapped scroll direction videos
It was showing the opposite direction for each of them.
2023-02-14 23:11:01 +04:00
Alessandro Bono
908cb548bf microphone: Make the switches toggleable when disabled
Allow to toggle the applications switches when the main permission
is disabled.
2023-02-14 18:15:33 +00:00
Alessandro Bono
eb4390c548 location: Make the switches toggleable when disabled
Allow to toggle the applications switches when the main permission
is disabled.
2023-02-14 18:15:33 +00:00
Alessandro Bono
fa821608b5 camera: Make the switches toggleable when disabled
Allow to toggle the applications switches when the main permission
is disabled.
2023-02-14 18:15:33 +00:00
Felipe Borges
ff6e104033 mouse: Redesign Mouse Test dialog
Per mockups
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/raw/0fa58be/mouse-and-touchpad/test-window.png
2023-02-14 18:10:46 +00:00
Felipe Borges
9e0e6253e4 mouse: Move Mouse Test into its own window
Per discussion at
https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2250#note_1631136

Fixes #2250
2023-02-14 18:10:46 +00:00
Felipe Borges
b5ce0f08b9 mouse: Redesign Mouse panel
See
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/raw/master/mouse-and-touchpad/mouse-and-touchpad.png
2023-02-14 13:31:23 -03:00
Felipe Borges
42cfa6dcb5 common: Introduce CcSplitRow 2023-02-14 13:31:23 -03:00
Felipe Borges
c4e569610d common, multitasking: Introduce CcIllustratedRow
The CcIllustratedRow is a generalization of CcMultitaskingRow to
be used later in the Mouse settings.
2023-02-14 13:31:23 -03:00
Felipe Borges
7ba1afc647 mouse: Add mouse "acceleration profile" row
Fixes #94
2023-02-14 12:13:30 +01:00