Commit d2474bf0 ("background: revert false indentation") fixed a warning
which sprung from improper indentation of a function call. To comply
with project style, the parameter list's indentation must also be
adjusted. This issue was pointed out by Georges (@fearanon).
This patch changes the indentation of the parameters in compliance.
Commit 46673670 ("Fix indentation") indented lines 160-163 of
cc-background-chooser.c to make them seem as if they were part of the
associated if statement. However, they are not, which causes confusion
as to the intention of the code. It appears as if the
gtk_accessible_update_property call is executed upon button being non-
null, but it is always executed due to the lack of an if block. For
clarity, and to resolve a compiler warning, this patch should be
reverted.
This patch reverts 46673670, changing the indentation back correctly.
This was mentioned in #1902 and received no objections, including
approval from Lukas.
Turns out drawing the whole light wallpaper and then half of the dark
wallpaper on top of it is leading to a case of
https://gitlab.gnome.org/GNOME/gtk/-/issues/3840
Draw half of each instead, so they don't overlap.
GtkWidget:text-direction doesn't exist. That's why we connect to the
::direction-changed signal instead, and this property binding was
just a leftover from c5792cfb00.
Rename the app-id to org.gnome.Settings since this is what
we've been calling it for many years now. Adjust all files
that derive from the app-id, such as the desktop file, D-Bus
service file names, search providers, GSettings schemas, to
match that.
Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/344
Ignored in Meson < 0.60.0, deprecated since 0.60.1 and fatal since 0.61.0.
panels/applications/meson.build:10:5: ERROR: Function does not take positional arguments.
panels/background/meson.build:10:5: ERROR: Function does not take positional arguments.
panels/camera/meson.build:10:5: ERROR: Function does not take positional arguments.
[...]
Make corners rounded.
Replace selected style with an overlay check, make the close button
smaller to match. Move slideshow indicator to the lower left corner.
Set margins in css.
Update the unused symbolic to match the svg with a baked-in shadow,
actually use it. Bundle it in gresources instead of installing, fix the
style class name. Fix margins - the close button was overriding them.
The code that uses Grilo to fetch the user's Flickr photos isn't
actually used by the Background panel, to the extent that the final
binary doesn't even link against Grilo. Getting rid of this unused code
will ensure that distributors aren't needlessly pulling in this
dependency.
https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1345
g_warning () is for environment errors. Additional tags than the
ones we require are not necessarily an error.
This behavior causes g-c-c to spam the journal with entries such
as:
Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
Where "license", "email", and "author" are valid tags that we just
don't use.
Without different lock-screen settings, there's little reason to
keep showing a lock-screen preview. So rather than updating the
preview to a blurred version of the regular background, just remove
it altogether.
https://gitlab.gnome.org/GNOME/gnome-control-center/issues/864
In 3.36, we will use a heavily blurred wallpaper on the lock screen.
As that wallpaper will be unrecognizable, there is no good reason to
pick a different one from the regular session. The shell will therefore
stop using the separate lock-screen settings.
The popover isn't needed anymore because it would only have one option:
to set the wallpaper. And an additional option for the recent section to
remove the wallpaper for the list, which can be done via a overlay
button.
https://gitlab.gnome.org/GNOME/gnome-control-center/issues/864
