2006-02-11 Theppitak Karoonboonyanan <thep@linux.thai.net>
* gnome-background-properties.glade: Add the missing translatable flag
in the Finish button.
2006-02-10 Rodney Dawes <dobey@novell.com>
* gnome-wp-capplet.c (wallpaper_properties_clicked): Add the missing
GTK_RESPONSE_DELETE_EVENT back in so that we exit properly with it
2006-02-09 Rodney Dawes <dobey@novell.com>
* gnome-background-properties.glade: Replace the Apply/Cancel/OK
buttons with a Finish button, using the stock apply icon
* gnome-wp-capplet.c (gnome_wp_props_wp_set): Don't need to check if
we are the same image as we were before now
(gnome_wp_props_revert): Remove this as it is no longer needed
(gnome_wp_props_wp_selected): Call the set function here
(gnome_wp_main_quit): Remove the freeing of capplet->old_item
(wallpaper_properties_clicked): Only handle GTK_RESPONSE_OK as an
action to close the dialog now, as we are instant apply again
(gnome_wp_scale_type_changed, gnome_wp_shade_type_changed):
(gnome_wp_color_changed): Set the appropriate gconf keys here
(gnome_wp_load_stuffs): Remove references to capplet->old_item
* gnome-wp-capplet.h (struct _GnomeWPCapplet): Remove old_item object
Fixes#327335, #330587 and #329818
Partially fixes#330168
2006-01-26 Rodney Dawes <dobey@novell.com>
* gnome-wp-capplet.c (gnome_wp_capplet_scroll_to_item): If we are
passed in a NULL just return rather than using g_return_if_fail to
do it, so that we can avoid the glib CRITICAL warning (#327327)
(gnome_wp_load_stuffs): If the settings are mangled some how, and
a valid item was not duplicated, duplicated the "No Wallpaper" item
Fixes#327327
2006-01-26 Rodney Dawes <dobey@novell.com>
* gnome-background-properties.glade: Add an Apply button
* gnome-wp-capplet.[ch]: Replace old_filename with an old_item struct
(gnome_wp_props_wp_set): Set the filename key to empty string when
setting the background to "No Wallpaper"
(gnome_wp_props_revert): New method to revert changes in the dialog
when the Cancel button is clicked
(gnome_wp_main_quit): Free the old_item structure
(wallpaper_properties_clicked): Handle the Apply button
Handle closing the dialog for OK separately from Cancel/delete_event
Revert the settings when Cancel or wm "x" or ESC are clicked
(gnome_wp_load_stuffs): Set the old_item to the currently selected
background setting, whether it be an image or "No Wallpaper"
* gnome-wp-info.c (gnome_wp_info_dup): If info is NULL, just return
NULL rather than trying to access members of an empty struct
* gnome-wp-item.[ch] (gnome_wp_item_dup): New method to create a
duplicate and newly allocated GnomeWPItem structure
Fixes#327335
2006-01-14 Rodney Dawes <dobey@novell.com>
* gnome-background-properties.glade: Set the visibility of the second
color chooser button to off by default
Fixes#319463
2006-01-14 Rodney Dawes <dobey@novell.com>
* *.[ch]: Update Copyright notice to include 2006 year
* gnome-background-properties.glade: Change the main dialog to use
explicit apply with OK and Cancel buttons
Remove the icons from the "Add Wallpaper" and "Remove" buttons
* gnome-wp-capplet.c (gnome_wp_props_wp_set): Add a new retval boolean
so that we can return whether or not we are trying to set the wallpaper
to the same image filename as before
Remove all the UI updating code from here
Fix a potential leak of the GConfChangeSet object
(gnome_wp_props_wp_selected): Update the UI whenever a different
wallpaper is selected in the list
Remove the timeout to update gconf, as we are using explicit apply now
(gnome_wp_main_quit): Free the old_filename variable
Update the indentation style to match the rest of the code
(wallpaper_properties_clicked): Handle setting the gconf keys when the
OK button is clicked, and fall through to the cancel/close code
(gnome_wp_scale_type_changed, gnome_wp_shade_type_changed):
Don't set the gconf strings from here, only update when OK is clicked
(gnome_wp_color_changed): Don't update gconf strings here
Don't generate miniature icon thumbnails for the drop-down menu
(gnome_wp_remove_wallpaper): Don't need to remove the idle id any more
(gnome_wp_load_stuffs): Set the old_filename variable to the current
setting that is stored in gconf for the wallpaper filename
(gnome_wp_delay_changed): Remove this unused method
(gnome_wp_icon_theme_changed): Don't need to update the icons in the
drop-down menu here, as they are being removed
(set_accessible_name): Don't need this any longer, as the drop-down
menu items are now standard label menu items, and don't have icons
(wallpaper_properties_init): No longer need the key repeat delay
Fix some style issues with the glade_xml_get_widget calls
Replace the menu items in the option menus with standard label items
* gnome-wp-capplet.h (_GnomeWPCapplet): Remove the no longer needed
Widget variables for updating the drop-down menu icons
Remove the no longer needed delay and idleid variables
Add an old_filename variable to compare against when OK is clicked
Also should fix#316697
2006-01-14 Alan Swanson <swanson@ukfsn.org>
* gnome-wp-capplet.c (gnome_wp_option_menu_set): Check for the scale
type being zoom in the config, to set the option menu
(gnome_wp_scale_type_changed): Update the options for zoom type
(gnome_wp_icon_theme_changed): Update the zoom icon in the menu
(wallpaper_properties_init): Add an item for Zoom to the scaling menu
* gnome-wp-capplet.h (_GnomeWPCapplet): Add a widget for the zoom item
(GnomeWPScaleType): Add an enumeration for the zoom type
* gnome-wp-item.c (gnome_wp_item_get_thumbnail): Add the code to
generate a proper thumbnail for the new zoom option
Fixes#105231
2005-10-01 Rodney Dawes <dobey@novell.com>
* gnome-wp-capplet.c (gnome_wp_add_image): Remove utf8 validate check
(gnome_wp_props_wp_set): If the filename we have for the image is not
valid utf8, convert it to utf8 before setting the key in gconf
(gnome_wp_load_stuffs, gnome_wp_file_changed): Make sure that the
filename is valid utf8 and the file exists with utf8 encoding, or fall
back to filename encoding as specified by the user with glib's
environment variables
* gnome-wpitem.c (gnome_wp_item_new): Make sure that the name field
is always utf8 for displaying to the user with the tree view
* gnome-wp-xml.c (gnome_wp_xml_load_xml): Make sure that the
filename is valid utf8 and the file exists with utf8 encoding, or fall
back to filename encoding as specified by the user with glib's
environment variables
(gnome_wp_xml_save_list): If the filename is not valid utf8, then
convert to utf8 for storing in the XML file
Fixes#168604
2005-09-06 Rodney Dawes <dobey@novell.com>
* gnome-wp-capplet.c (wallpaper_properties_init): Set the style
property "action-area-border" for the GtkDialogs here
"Fixes" #313680
2005-08-21 Rodney Dawes <dobey@novell.com>
* gnome-wp-capplet.c (gnome_wp_option_menu_set): If the value for
the "picture_options" key is set to "none", don't set the optin menu
for the scaling options to tiled
Fixes#313883
2005-08-17 Rodney Dawes <dobey@novell.com>
* gnome-wp-capplet.c (wallpaper_properties_init): Replace the changing
of some GtkDialog defaults through style properties with calls to
gtk_widget_ensure_style and gtk_container_set_border_width
Fixes#313680
2005-08-15 Veerapuram Varadhan <vvaradhan@novell.com>
* gnome-wp-capplet.c (gnome_wp_props_wp_set):
(gnome_wp_color[12]_changed, gnome_wp_options_changed):
(gnome_wp_shading_changed, wallpaper_properties_init):
Enable/disable the style-menu, shading-menu and color-picker
buttons w.r.t gconf-keys.
(gnome_wp_set_sensitivities): Utility function to take care of
enabling/disabling widgets w.r.t gconf-keys.
(gnome_wp_props_wp_set): Don't set the sensitivity of the remove and
style buttons here. Just call the new method to do it instead
2005-07-25 Sebastien Bacher <seb128@debian.org>
* gnome-wp-capplet.c (gnome_wp_{scale,shade}_type_changed):
Update for the changed signal of the option menus
(wallpaper_properties_init): Connect to the changed signal of
the scale and color style option menus
Fixes#157396
2005-07-25 Sebastien Bacher <seb128@debian.org>
* gnome-background-properties.glade: Replace GnomeColorPicker with
the GtkColorButton widget
Some properties were added by newer version of glade
* gnome-wp-capplet.c (gnome_wp_props_wp_set):
(gnome_wp_[s]color_changed, gnome_wp_color[12]_changed):
(gnome_wp_load_stuffs, wallpaper_properties_init):
Update to use the API for GtkColorButton instead of GnomeColorPicker
Fixes#171676
2005-07-14 Rodney Dawes <dobey@novell.com>
* gnome-wp-xml.c (gnome_wp_xml_load_xml): If xmlParseFile returns
NULL, then just return, rather than trying to parse the document
Fixes#310041
2005-07-13 Rodney Dawes <dobey@novell.com>
* gnome-wp-info.c (gnome_wp_info_new): Pass the md5sum to the call
to g_strconcat to create the path to the thumbnail file
Fixes#310293
2005-07-10 Rodney Dawes <dobey@novell.com>
* gnome-wp-capplet.[ch]:
(gnome_wp_icon_theme_changed):
(wallpaper_properties_init):
Update to use GtkIconTheme rather than GnomeIconTheme
Based on patch from Jan de Groot
Fixes#171677
2005-07-10 Rodney Dawes <dobey@novell.com>
* gnome-wp-info.c (gnome_wp_info_new): Fix some memory leaks by using
a separate variable to store the escaped path, and md5sum
* gnome-wp-item.c (gnome_wp_item_get_thumbnail): Fix a couple of
memory leaks by using a separate variable to store the escaped path
Don't unref the pixbuf from the thumbnail generation, and then try
to load it again after saving
2005-02-26 Rodney Dawes <dobey@novell.com>
* gnome-wp-capplet.c (gnome_wp_add_image): If the filename is not
encoded in UTF-8, we just ignore it for now to avoid crashing
* gnome-wp-xml.c (gnome_wp_xml_load_xml): Check to make sure that the
filename and name tags that we read in, aren't NULL
If the filename we read in is NULL, free the item, and continue on
Fixes#146130#146645 (resolving these as dups of #168604 )
Fixes#159441
2005-02-06 Rodney Dawes <dobey@novell.com>
* gnome-wp-capplet.c (wallpaper_properties_init): Force using the gtk+
backend for the file chooser since we don't support vfs yet
Fixes#154978
2005-02-06 Rodney Dawes <dobey@novell.com>
* gnome-wp-capplet.c (gnome_wp_color_changed): Change the API to use
the boolean argument to specify if we want to update gconf or not
Always get the colors for both primary and secondary and update the
thumbnail
Only set the keys in gconf if we have the update boolean argument
(gnome_wp_pcolor_changed): Removed this method, since we don't need
to differentiate between primary/secondary for updating the thumbnail
(gnome_wp_scolor_changed): When we change the color in the UI, we want
to update gconf, we use this method for both color picker buttons now
(gnome_wallpaper_properties_init): Use gnome_wp_scolor_changed for the
callback on both color picker button widgets now
Fixes#166486
2005-01-10 Rodney Dawes <dobey@novell.com>
* gnome-wp-xml.c (gnome_wp_xml_load_xml):
Fix compile warning for syslangs declaration
Wrap g_get_language_names in #if GLIB_CHECK_VERSION as it is 2.6 API
2005-01-09 Rodney Dawes <dobey@novell.com>
* gnome-wp-capplet.[ch] (gnome_wp_update_preview): Add new callback
routine for when the preview widget in the file chooser needs an update
(wallpaper_properties_init): Set the preview widget in the file chooser
to a GtkImage object and connect to the update-preview signal for when
the selected file changes
- Based on patch from Sebastien Bacher <seb128@debian.org>
Fixes#139714
2005-01-08 Rodney Dawes <dobey@novell.com>
* gnome-wp-capplet.c (wallpaper_properties_init): Preload the directory
rather than nothing when adding directories for gconf notification
2005-01-08 Rodney Dawes <dobey@novell.com>
* background.desktop.in.in: Add %F to Exec command line
* gnome-wp-capplet.[ch] (gnome_wp_remove_wp): Check that the tree path
is not NULL before removing items from the list store
(gnome_wp_load_stuffs): Don't duplicate the code from
gnome_wp_add_image/gnome_wp_capplet_scroll_to_item here
Load any images we were passed on the command line, and free the
GSList that they were stored in after doing so
(gnome_wp_file_changed): Clean up to just call gnome_wp_add_image and
gnome_wp_capplet_scroll_to_item rather than duplicating the code
(wallpaper_properties_init): Take a poptContext argument now
Parse the poptContext into a GSList for loading the images from
(main): Use a clearer variable name for the GnomeProgram object
Get the poptContext from the GnomeProgram object and pass it through
to wallpaper_properties_init
Fixes#120720
2005-01-08 Rodney Dawes <dobey@novell.com>
* gnome-wp-capplet.c (wallpaper_properties_init): Fix the leaks
in the scaling type option menu creation correctly
2004-12-11 Rodney Dawes <dobey@novell.com>
* gnome-wp-item.c (gnome_wp_item_update_description):
Fix the ngettext calling bit to actually work, and move the %d into
the format string for g_strdup_print, so we don't say "%d pixels"
2004-12-10 Rodney Dawes <dobey@novell.com>
* gnome-wp-item.c (gnome_wp_item_update_description):
Change the description to use "W pixels x H pixels" and ngettext for
each individual part, instead of just "W x H pixels" (#151425)
* gnome-wp-xml.c (gnome_wp_xml_load_xml): Don't duplicate check to
make sure that the root element is not NULL
2004-10-14 Rodney Dawes <dobey@novell.com>
* gnome-wp-item.c (gnome_wp_item_update_description):
Use g_markup_printf_escaped () to fill in the description
Fixes#155184
2004-09-29 Rodney Dawes <dobey@novell.com>
* gnome-wp-item.c (gnome_wp_item_new): Unescape the filename so that
we can laod the thumbnail and set the gconf key properly
Fixes#154003
2004-09-22 Rodney Dawes <dobey@novell.com>
* gnome-wp-item.c (gnome_wp_item_free):
Check that the colors aren't NULL before calling gdk_color_free
* gnome-wp-xml.c (gnome_wp_xml_load_xml):
Check that the item isn't already listed, before we try to add
the wallpaper to the list
(gnome_wp_xml_load_list): Load XML files from the correct directory
2004-08-16 Rodney Dawes <dobey@novell.com>
* gnome-wp-capplet.c (wallpaper_properties_clicked):
Handle the GTK_RESPONSE_DELETE_EVENT case as well
Fixes#150273
2004-08-15 Rodney Dawes <dobey@novell.com>
* gnome-wp-item.c (gnome_wp_item_update_description):
Add "W x H pixels" to description, and remove file size
Mark the description string for translation as well
2004-07-19 Rodney Dawes <dobey@novell.com>
* gnome-wp-item.c (gnome_wp_remove_wallpaper, gnome_wp_list_sort):
Free what we get with gtk_tree_model_get
Fixes#147403
2004-07-15 Rodney Dawes <dobey@novell.com>
* gnome-wp-item.c (gnome_wp_item_new):
Check that item->fileinfo is not NULL, before trying to use a
string variable inside the struct for a strncmp
Fixes#147373
2004-06-28 Rodney Dawes <dobey@novell.com>
* *.[ch]: Update copyright info to have correct years (2003-2004)
* gnome-wp-capplet.c (gnome_wp_capplet_scroll_to_item):
Abstract this code out so that we don't have to duplicated it every
time we want to scroll to a particular item in the list
(gnome_wp_add_image): Update this to return the new item that we
created, and don't scroll to or set as the wallpaper, every time we
call this function
Use the new gnome_wp_item_new () call to create items
(gnome_wp_add_images): Change the API to not use the files argument
any longer, as we don't need it without the GTK+ 2.2 compat code
Add all the items to the list and select the last one when finished
(gnome_wp_file_open_dialog): Update to not pass in the files argument
to gnome_wp_add_images () and free the GSList of filenames
(bg_add_multiple_files): merge this code into the normal callback for
when images are dragged to the dialog
(bg_properties_dragged_image): Don't check if the list is more than
1 or not here, and always call gnome_wp_add_images () with the full
list that we are given
Convert the GList of GnomeVFSURIs that we get from gnome-vfs to a
GSList of char * uris to pass into gnome_wp_add_images ()
(gnome_wp_load_stuffs, gnome_wp_file_changed):
Use the new gnome_wp_capplet_scroll_to_item () and gnome_wp_item_new ()
API calls instead of duplicating code
* gnome-wp-capplet.h: Remove the GConf key path defines from here
* gnome-wp-item.[ch]: Add the gnome_wp_item_new () call to create the
GnomeWPItem structure for storing wallpapers in
* gnome-wp-utils.h: Put the GConf key path defines in here
* gnome-wp-xml.c (gnome_wp_load_legacy): Use the gnome_wp_item_new ()
call to create items from the old legacy (XD2 capplet) list file
2004-04-27 Rodney Dawes <dobey@ximian.com>
* gnome-wp-capplet.c (gnome_wp_file_open_dialog):
(wallpaper_properties_init): Remove the #if checks for GTK+ 2.3.0 and
get rid of the compatibility code for building against 2.2
2004-04-24 Rodney Dawes <dobey@ximian.com>
* gnome-wp-capplet.c (wallpaper_properties_init): Use the more correct
"Add Wallpaper" term for the file chooser window title
Fixes#135084
2004-04-10 Rodney Dawes <dobey@ximian.com>
* gnome-wp-capplet.c (gnome_wp_list_sort): Use g_utf8_collate to sort
the descriptions, rather than a strcmp, so that we follow the locale
settings for LC_COLLATE
Fixes#139517
