Commit graph

8197 commits

Author SHA1 Message Date
Automeris naranja
8322ccf6c1 input-chooser: Rename "Add an Input Source" to "Add Input Source"
This will be consistent with the writing style used in Settings
(e.g. "Connect to Hidden Network" and "Add Printer" instead of
"Connect to a Hidden Network" and "Add a Printer" respectively).
2023-11-24 09:41:33 +00:00
Automeris naranja
3c0c5b7423 keyboard: Add missing mnemonics
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2049>
2023-11-24 00:23:21 +00:00
Automeris naranja
ea31bb091e keyboard-shortcut-editor: Add mnemonic to the "Set Shortcut" button
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2049>
2023-11-24 00:23:21 +00:00
Automeris naranja
c961832741 keyboard-shortcut-dialog: Add missing mnemonics
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2049>
2023-11-24 00:23:21 +00:00
Lukáš Tyrychtr
536612b00e keyboard: Add Insert as a choice for the compose key
Fixes #2765
2023-11-23 12:34:04 +00:00
Automeris naranja
b0a5c5e128 apps: Add missing mnemonics
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541
2023-11-23 08:55:39 +00:00
Automeris naranja
085553f4ce cc-info-row: Add use-underline property
Doing so, it won't be necessary to set
use-underline for every CCInfoRow.
2023-11-23 08:55:39 +00:00
Automeris naranja
3fa07eb97a sound: Add ellipsis to the Test button
"Use an ellipsis (…) at the end of a label if further
input or confirmation is required from the user before
the action can be carried out".

https://developer.gnome.org/hig/guidelines/writing-style.html

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2053>
2023-11-23 06:14:20 +00:00
Automeris naranja
b3fc842999 sound: Add missing mnemonics
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2053>
2023-11-23 06:14:20 +00:00
velsinki
7f79356ded system/region: Preview measurement format in current locale
The Formats preview tries to find the measurement format of the locale
to preview, and then displays it. However, it displays the text in the
default locale, instead of in the real current locale, as newlocale ()
with base = (locale_t) 0 will use the default locale.

This is fixed by switching back to the real locale before setting the
label text.

Fixes #2458

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2051>
2023-11-23 05:48:56 +00:00
Ondřej Pohořelský
8f3eee7ee1 wifi: hide QR code icon when connection not successful
Don't show QR code icon when there is no info about connection being
valid and successful. Also hide it when we are connecting and when WiFi
has no password.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2030>
2023-11-23 05:10:07 +00:00
Lukáš Tyrychtr
5d24919f14 common: Mark a string as not containing printf specifiers
The gettext heuristic was erroneously marking one of the date strings as
printf format ones, so it could not get translated properly.

Fixes #2761
2023-11-22 10:40:45 +01:00
Florian Müllner
38cac20497 network: Handle BT device connections ourselves
Bluetooth connections are among those that we still delegate to
nm-connection-editor. Luckily they are fairly simple connections
without any options on their own, so the built-in connection editor
can handle them just fine.

https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1157

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2044>
2023-11-21 13:38:32 +00:00
velsinki
34fe60fe03 applications: Fix File & Link Associations UI
When removing a File & Link Association from the dialog, or resetting
them, the UI does not update. Fix this by rebuilding the handler dialog
on both unset and reset.

Fixes #389
Fixes #2172
2023-11-21 02:46:08 +00:00
velsinki
1def49b62b applications: Fix terminal launch of application
Trying to launch the settings for a specific application from a terminal
using "gnome-control-center applications APP_ID" currently fails, as the
permission store async call is usually not done yet.

Fix this by re-activating the attempted app selection when the async
call finishes.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2034>
2023-11-21 02:21:19 +00:00
Automeris naranja
85403f7563 remote-desktop-page: Add link to instruct how to use remote desktop
As shown in the following mockups:
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/blob/master/remote-desktop/remote-desktop.png

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2045>
2023-11-20 02:43:46 +00:00
Automeris naranja
47a0caec34 privacy: Update Privacy panel description
As per suggestion of @aday in the following thread:
https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2026#note_1918621

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2043>
2023-11-20 02:23:01 +00:00
Maximiliano Sandoval R
6121bb0a49
input-chooser: Only capture input while visible
Otherwise writing in the dialog would filter it even if the search bar
is not visible.
2023-11-19 20:48:26 +01:00
Maximiliano Sandoval R
769287a59b
input-chooser: Port to AdwWindow 2023-11-19 20:48:26 +01:00
Felipe Borges
9040429105 system: The desktop file Keyword list must always end with a semicolon
The list MUST also end with a semicolon!

Credits to @ajonsson
91bf04f83b (note_1918135)
2023-11-16 10:09:09 +01:00
Automeris naranja
354b83880c apps: Use header capitalization in some row titles from Removable Media section
https://developer.gnome.org/hig/guidelines/writing-style.html
2023-11-16 09:04:40 +00:00
Automeris naranja
cdbbc01217 apps: Add mnemonic to Default Apps row 2023-11-16 09:04:40 +00:00
Automeris naranja
990146d512 apps: Avoid using repeated letters for mnemonics
Otherwise mnemonics of some rows won't work properly.

Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2673
2023-11-16 09:04:40 +00:00
Automeris naranja
33ed06a673 apps: Use activatable_widget property in several rows from Removable Media section
Otherwise, mnemonics won't trigger the widgets inside the rows.

Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2673
2023-11-16 09:04:40 +00:00
velsinki
9e207abee3 applications: Fix File & Link Associations crash
The selection of rows in the applications listbox is unreliable and
currently even disabled. This means that for File & Link Associations,
the unset and reset handlers crash because they try to retrieve the
currently selected row of the listbox, and dereference it.

Instead, we can use the current info that is always stored in self
anyways.

Fixes #2752
2023-11-16 09:03:49 +00:00
Felipe Borges
99459f879a privacy: Rename visible name to "Privacy & Security"
Fixes #2742
2023-11-16 08:45:51 +00:00
Allan Day
91bf04f83b system: Add missing panel metadata
Add keywords and update the description to be more meaningful.

Fixes #2753
2023-11-15 15:29:58 +00:00
Lukáš Tyrychtr
89e3041ebc sound: When setting mixer control for a stream row, update muted state as well
We were updating the volume state, but not the mute one, so, do both.

Fixes #2749
2023-11-15 15:28:20 +00:00
Automeris naranja
e39082fbc6 ua-seeing-page: Fix repeated mnemonics
"Screen Reader" and "Reduce Animation" rows
use the same mnemonic, which causes a
conflict when focusing them with the keyboard
2023-11-14 10:05:25 +00:00
Automeris naranja
a3e794a008 ua-typing-page: Add mnemonic to "Test Entry" row 2023-11-14 10:05:25 +00:00
Automeris naranja
f7b757044a ua-typing-page: Fix repeated mnemonics
"Screen Keyboard", "Sticky Keys", "Blink Speed" and
"Bounce Keys"  rows use the same mnemonic, which
causes a conflict when focusing them with the keyboard
2023-11-14 10:05:25 +00:00
Automeris naranja
d233aa4e8d ua-zoom-page: Add missing mnemonics
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541
2023-11-14 10:05:25 +00:00
Automeris naranja
95204b3bdd users: Set .pill style to the "Remove User" button
Follow-up from https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1950
2023-11-13 23:05:28 -03:00
Lukáš Tyrychtr
92b0d54f11 sound: Fix accessibility issues for the mute button
This does the following:
* Replaces the a11y label by a tooltip
* Reflects what will happen when the button is pressed

Fixes #2750
2023-11-13 12:49:04 +00:00
Felipe Borges
fd4b45c84e wifi: Close "Saved Wi-Fi Networks" dialog when last item is removed
Otherwise we are left with an empty dialog again.

Fixes #2715
2023-11-13 10:58:50 +00:00
Felipe Borges
7e7cb4a2de wifi: Don't show "Saved Wi-Fi Networks" row when there's nothing to show
Fixes #2715
2023-11-13 10:58:50 +00:00
Automeris naranja
b0ef5ac831 datetime-page: Add missing mnemonics in the Date & Time dialog
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541
2023-11-13 10:28:33 +00:00
Automeris naranja
99bf03a930 about-page: Add missing mnemonics
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541
2023-11-13 10:28:33 +00:00
Automeris naranja
1d5045a5b8 remote-desktop-page: Add tooltip to copy buttons 2023-11-13 10:28:33 +00:00
Automeris naranja
bbf3e35c4b remote-desktop-page: Add missing mnemonics
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541
2023-11-13 10:28:33 +00:00
Ondřej Pohořelský
7f104fb9c8 network: remove wpa-none from key_mgmt
Network Manager dropped `wpa-none` value from `key_mgmt` a while ago[0]
There is no need to test for this option anymore.

[0]c97e0ce30b
2023-11-13 10:02:31 +00:00
Automeris naranja
0a0a7bb881 cc-list-row: Add use-underline property 2023-11-13 09:55:36 +00:00
Automeris naranja
e01f49d11e net-proxy-page: Add use-underline property to the Network Proxy row
Otherwise the mnemonic won't work.
2023-11-13 09:52:29 +00:00
Automeris naranja
0a7dd110e1 multitasking: Use header capitalization in some workspace options
https://developer.gnome.org/hig/guidelines/writing-style.html
2023-11-13 09:51:38 +00:00
Automeris naranja
0190c3a89d power-profile-row: Remove periods from power profiles descriptions
"Text generally shouldn’t end with a period. This applies
to headings, descriptions, and includes text that is written
as a complete sentence".

https://developer.gnome.org/hig/guidelines/writing-style.html
2023-11-13 09:49:47 +00:00
Automeris naranja
0fb5767cb6 power-profile-row: Use "subtitle" style class for power profile descriptions
Doing this, the power profiles rows will look consistent
with other rows, such as the "Dynamic workspaces" and
"Fixed number of workspaces" from the Multitasking panel.

This also cleans the code a bit.
2023-11-13 09:49:47 +00:00
Automeris naranja
2c1ee740d7 datetime-page: Add description to the "Week Numbers" option
See https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2722#note_1912890

Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2722
2023-11-13 09:39:12 +00:00
Felipe Borges
91057652d4 system/remote-desktop: Initialize GCancellable and cancel it page dispose
Fixes #2733
2023-11-13 08:57:07 +00:00
Felipe Borges
bfe5dec52a user-accounts: Sync lock tooltip for the Avatar
We were adding the "Unlock" tooltip to the avatar widget but not
removing it when the panel was unlocked.

Fixes #2738
2023-11-10 11:09:27 +00:00
velsinki
88a582cbed privacy: Fix crash from free bug in cc-camera-page
The GVariant constructor g_variant_new () gives a floating reference,
which will be sunk by the g_dbus_..._call () methods. Unless the
constructed GVariant is manually referenced, it should not be used in a
g_autoptr () setting. Otherwise a use-after-free might occur in the
async g_dbus_..._call () methods.

This problem occurs here, which is simply prevented by not having the
g_autoptr () declaration for the GVariant.

Fixes #2647
Fixes #2704
Fixes #2635
Fixes #2706
2023-11-08 14:08:38 +01:00