Robert Ancell
9b1226aea5
network: Remove helper function with minimal value
...
This can be more easily optimised away in the modules that use it.
2019-10-22 20:11:45 +00:00
Robert Ancell
96585c1542
network: Remove unused hotspot connected label
2019-10-22 20:11:45 +00:00
Robert Ancell
4100c69d9c
network: Move panel properties into GtkBuilder files
2019-10-22 20:11:45 +00:00
Robert Ancell
708b1fdaf7
network: Use self variable name consistently
2019-10-22 20:11:45 +00:00
Robert Ancell
8b6e3fb736
network: Store widgets inside objects
...
This is a step towards replacing GtkBuilder with GtkTemplate
2019-10-22 20:11:45 +00:00
Robert Ancell
b331d75df5
network: Rename widget IDs to standard names
2019-10-22 20:11:45 +00:00
Robert Ancell
53f9249b83
network: Remove unused GtkBuilder IDs
2019-10-22 20:11:45 +00:00
Robert Ancell
927f0f7954
network: Remove unused widgets
2019-10-22 20:11:45 +00:00
Robert Ancell
879542d92b
network: Merge duplicate signal handlers
2019-10-22 20:11:45 +00:00
Robert Ancell
54f8fce47f
network: Connect signals in swapped form
2019-10-22 20:11:44 +00:00
Robert Ancell
d549c9e7bd
network: Move non-shared code into the one module that uses it
2019-10-22 20:11:44 +00:00
Robert Ancell
4b9d8ac058
network: Move non-shared code into the one module that uses it
2019-10-22 20:11:44 +00:00
Robert Ancell
8a3da8b36d
network: Remove shared callback and replace with a method
2019-10-22 20:11:44 +00:00
Robert Ancell
f556af6e67
network: Move includes to correct file locations
2019-10-22 20:11:44 +00:00
Robert Ancell
37187db328
network: Remove unused virtual method
2019-10-22 20:11:44 +00:00
Robert Ancell
150e7902e6
network: Refactor widget reference out using virtual method
2019-10-22 20:11:44 +00:00
Robert Ancell
4955371660
network: Pass widget references rather than relying on names
...
The existing code relied on using GtkBuilder, which will no longer work when we
switch to GtkTemplate.
2019-10-22 20:11:44 +00:00
Robert Ancell
823a1dbdaa
network: Make public struct private
2019-10-22 20:11:44 +00:00
Robert Ancell
bf43c64b63
network: Remove unused callback type
2019-10-22 20:11:44 +00:00
Robert Ancell
a41ad90671
network: Remove unused field
2019-10-22 20:11:44 +00:00
Robert Ancell
96bd167b77
network: Replace deprecated GtkTable with GtkGrid
2019-10-22 20:11:44 +00:00
Robert Ancell
84c53b01c5
network: Remove unused GtkNotebooks
...
The security widgets were inside GtkNotebooks, but only ever had one page and
tabs hidden. So they weren't doing anything.
2019-10-22 20:11:44 +00:00
Robert Ancell
e7cec00235
network: Remove unused wifi dialog
...
This seems to have been copied from the connection editor code, but is not
actually used.
2019-10-22 20:11:44 +00:00
Robert Ancell
ab0be62b78
network: Fix incorrect use of *_get_instance_private
...
These classes don't have a private structure, but the misuse didn't seem to be
causing a specific issue.
2019-10-22 20:11:44 +00:00
Robert Ancell
5183faea04
background: Fix crash if a BgRecentSource is unreffed during an async operation
...
The BG_RECENT_SOURCE (user_data) call was done before it was checked if is was
cancelled. At this point user_data is pointing to an object that has been deleted.
Fixes #729
2019-10-22 14:03:14 +00:00
Benjamin Berg
0fa4d11477
display: Use correct mode for supported scale checking
...
Monitors may not always have a mode. This means we cannot look up the
mode on the fly, but instead need to have a heuristic to select a mode
if there is none.
Everything was in place already for this, except that one location was
still doing a fresh lookup, possibly causing a crash.
Fixes : #675
2019-10-21 16:22:25 +13:00
Mohammed Sadiq
4fe618254e
applications: Fix a memory leak
2019-10-17 20:02:41 +00:00
Benjamin Berg
7631faa88f
region: Explicitly update LC_* even when matching LANG
...
localed will not update the LC_* variables if they are not given. This
means that should the user switch the formats away from LANG and then
back, they will not be reset appropriately.
Simply always setting the variables even if the match will fix this.
2019-10-17 00:32:34 +00:00
Andre Klapper
397a0ce673
Correct incorrect timezone on world map for North Korea
...
Fixes #713
2019-10-17 10:05:56 +13:00
Robert Ancell
6ac37bb182
applications: Remove unused variable
2019-10-15 09:31:30 +13:00
Andre Klapper
a3af25fd8a
Correct incorrect timezone on world map for Venezuela
...
Fixes #714
2019-10-14 20:12:26 +00:00
Niels De Graef
f83450cebf
Chain up to parent finalize()
...
This was forgotten in a few places, which means you have a memory leak
(albeit tiny).
2019-10-14 09:56:08 +02:00
Andre Klapper
e4b1df23a4
Correct incorrect timezone on world map for Sri Lanka
...
Fixes #709
2019-10-13 21:51:21 +00:00
Marek Kasik
923b726b3b
printers: Provide a scheme to address parser
...
Add a scheme to the address which we test for correctness
by g_network_address_parse_uri(). It does not work without it.
Use "none" scheme if user did not entered one.
Use port number 0 if user did not specify any.
Fixes #679
2019-10-08 18:05:56 +02:00
Iain Lane
e4508e0130
network: Accept empty values for the cloned mac address
...
Empty is a valid value here. It means the setting is not set. Two places
need to be updated:
- the validation function
- when retrieving the value from the combo, empty strings need to be
mapped to a setting value of NULL
Closes #677
2019-10-05 12:14:31 +01:00
Will Thompson
fd93886f6f
display: mark 3 missed translatable strings
...
"Primary Display" and "Contains top bar and Activities" are visible when
you have >1 display connected and the "Join Displays" option is
selected. I can't work out how to see the "Active Display" string but it
sure looks translatable to me.
2019-10-03 17:18:00 +01:00
Robert Ancell
9a2e821fe5
Initialize autoptr values to NULL.
...
These cases were safe, but if the code changed this risked freeing uninitialized
memory.
2019-10-03 10:58:38 +13:00
Felipe Borges
e497ad900d
printers: Check whether URI is valid while searching for printers
...
Fixes #679
2019-10-01 18:56:23 +02:00
Robert Ancell
bf8b8f52b7
network: Remove an unnecessary goto
2019-10-01 14:52:13 +13:00
Robert Ancell
57d7a79034
network: Pass widget references rather than relying on names
...
The existing code relied on using GtkBuilder, which will no longer work when we
switch to GtkTemplate.
2019-10-01 14:47:23 +13:00
Robert Ancell
1d43f4c0f5
network: Simplify function
2019-10-01 14:46:14 +13:00
Robert Ancell
3c32ee72ea
network: Remove two common functions that are more simply done inside the few cases that use them
...
The existing code relied on using GtkBuilder, which will no longer work when we
switch to GtkTemplate.
2019-10-01 12:52:42 +13:00
Robert Ancell
4ba3a2c3d1
network: Fix small memory leak
2019-10-01 12:52:23 +13:00
Robert Ancell
6211337ad6
network: Make function private
2019-10-01 12:31:05 +13:00
Robert Ancell
87f02de5b7
network: Remove unused functions
2019-10-01 12:28:35 +13:00
Robert Ancell
6691c4dfd3
applications: Use g_autofree for strings
2019-09-30 21:02:14 +00:00
Philip Chimento
ecd27846f8
background: Update clock in both preview modes
...
There is a clock widget both on the desktop preview and the lock screen.
Without this change, the clock on the desktop preview is always blank.
2019-09-30 11:08:13 -07:00
Robert Ancell
6d7e552ae1
network: Remove hidden notebook tabs from GtkBuilder files
...
These tabs are never shown and many were marked for translation.
2019-09-30 16:10:09 +13:00
Robert Ancell
74740f5001
info-overview: Use GTK widget types
2019-09-25 13:50:28 +00:00
Robert Ancell
6815787012
info-overview: Simplify UDisks code
...
The client was stored in the class, but only used once at the time it was
acquired. All calls are sync.
2019-09-25 13:50:28 +00:00