Commit graph

8 commits

Author SHA1 Message Date
Marek Kasik
b5b421288c printers: Fix setting of page size
Set 'PageSize' instead of 'media' for new printers since we use PPD
for construction of the combo for selecting of default paper size.
Previously, we've been setting 'media' attribute for new printers.
Attribute 'media' is used by IPP but we set paper size using 'PageSize'
which comes from PPD in the options dialog. Sometimes (quite often) IPP
gets priority over PPD in print systems. Therefore there was inconsistency
of what user set as default paper size on the options dialog and what was used.

Also don't mark IPP and user's local options as default in PpPPDOptionWidget
since it should use just PPD (we can change PPD values only in this widget).
Since we use PPD for setting of paper size in the options dialog, we shouldn't
show a value which user does not change actually (IPP's 'media' vs. PPD's
'PageSize').

https://bugzilla.gnome.org/show_bug.cgi?id=748569
2015-06-12 16:23:45 +02:00
Marek Kasik
2d2f20fe53 printers: Use correct type for window id
Window id should be unsigned int and not int. Also the default
value should be 0 instead of the 631 (a copy paste error).

https://bugzilla.gnome.org/show_bug.cgi?id=740115
2014-11-14 14:32:14 +01:00
Daniel Mustieles
2c5951819d Updated FSF's address 2014-01-29 11:27:38 +01:00
Marek Kasik
72d63e49d1 printers: Don't crash without system-config-printer
Fix error handling in addition of new printer.

https://bugzilla.gnome.org/show_bug.cgi?id=698642
2013-04-24 15:52:42 +02:00
Marek Kasik
9afed77bde printers: Avoid possible crash
Unlink given PPD file and free its filename
as soon as it is not required. This avoids
possible double free.

https://bugzilla.gnome.org/show_bug.cgi?id=690091
2012-12-12 13:34:58 +01:00
Marek Kasik
2bd01a70d3 printers: Make error messages clearer
Point to cups-pk-helper for errors originating from cups-pk-helper.

https://bugzilla.gnome.org/show_bug.cgi?id=689983
2012-12-10 17:05:56 +01:00
Marek Kasik
1eb906515f printers: Use GPLv2+ for files created by Marek Kasik
This commit is related to the bug #683420.
2012-09-11 15:02:26 +02:00
Marek Kasik
dea424dbee printers: Add PpNewPrinter object for installation of new printer
PpNewPrinter contains asynchronous method for installation of
new printer. The new printer is specified by given parameters (e.g. name,
device-id, device-uri, ppd-name, info, location, ...). (#683229)
2012-09-04 14:09:05 +02:00