Commit graph

8 commits

Author SHA1 Message Date
Marco Melorio
98c8a7787c sound: Move alert chooser to a separate window 2023-01-16 19:43:53 +00:00
Sebastian Keller
4f850f1b47 sound: Update sounds directory mtime when changing alert sound
The libcanberra event-sound-cache that stores the resolved paths for
sound names can get stuck with the fallback sound (bell) after trying to
play an invalid symlink, such as can happen after updating to 43 which
removed some sounds which might have been selected as alert sounds
before.

Neither changing the symlink nor touching the theme directory seems to
invalidate that cache, but touching the sounds directory does.

This now updates the sounds directory mtime before triggering purging
the sound sample cache in the sound server via g-s-d so libcanberra will
load the correct sounds when repopulating the sample cache afterwards.

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2277
2023-01-04 18:23:07 +00:00
Felipe Borges
ff904208cb sound: Fix sound alert selection
The mapping between sounds and the UI elements was wrong.

Fixes #2026
2022-08-25 16:08:24 +02:00
Felipe Borges
878171bd7c sound: Update sound alerts
Old sound alerts set by users will be migrated to the "click"
sound alert.

Fixes #264
2022-08-11 12:20:23 +00:00
Sebastian Keller
7b1af9c8ba sound: Update theme directory modification time after bell sound changes
The sound plugin of gnome-settings-daemon which flushes the pulseaudio
sample cache does non-recursive monitoring of the sounds directory. If
the custom theme directory used for switching between bell sounds
already exists due to previous bell sound changes, subsequent changes
within that directory will not be noticed. The old bell sample will thus
remain in the cache until the next session restart. Avoid this problem
by manually updating the modification time of the directory.

The alternative solution of adding recursive monitoring to the sound
plugin would require significantly more complicated code as there is no
support for this in glib itself. Given that sound themes never really
caught on and there is an ongoing discussion of removing support for
them entirely, going with this simple solution seems like the better
choice.

Fixes: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/-/issues/681
2022-05-10 04:05:44 +00:00
Michael Catanzaro
62bde81c54 sound: remove dog bark sound theme
You're welcome, internet.
2022-04-26 15:22:05 -03:00
Felipe Borges
9c593c5d7b sound: Remove CcSoundButton in favor of a simple GtkToggleButton
Without the custom image allocation, we can simply use a simple
button instead.

Fixes #1583
2022-02-04 18:03:38 +00:00
Robert Ancell
0799c864e8 sound: Rename new sound panel to replace old one 2019-02-07 09:31:18 +13:00
Renamed from panels/sound-new/cc-alert-chooser.c (Browse further)