Commit graph

258 commits

Author SHA1 Message Date
Automeris naranja
9b04a0e87c sharing: Use AdwButtonRow in the Media Sharing dialog
https://developer.gnome.org/hig/patterns/containers/boxed-lists.html#adding-buttons
2024-05-28 16:41:32 -03:00
Automeris naranja
7a210d3054 sharing: Make Orca to read the "Add Folder" row in Media Sharing
[1] replaced the "Add Folder" a11y label by a tooltip.
However, this doesn't work and Orca doesn't read the row
properly; it simply says "not selected". The a11y label
already didn't work prior to [1].

To fix this, transform the tooltip into a GtkLabel. Also,
make the row to have the same padding so it's consistent
with the "Add Input Source..." row from Keyboard > Input
Methods.

[1] 00d9cd012f
2024-05-28 11:02:16 +00:00
Automeris naranja
cd7575b780 sharing: Reuse "gtk_widget_get_root (GTK_WIDGET (self)"
"gtk_widget_get_root (GTK_WIDGET (self)" is used by both
"File Sharing" and "Media Sharing" dialogs, so there is
no need to create this method twice.
2024-05-28 09:40:28 +00:00
Automeris naranja
0f2b8afef3 sharing: Add "Security" heading in the "File Sharing" dialog
In the "File Sharing" dialog, add a "Security" heading
in the section that groups the "Require Password" and
"Password" rows.

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2583#note_2113966
2024-05-28 09:40:28 +00:00
Automeris naranja
90e7a9cfd3 sharing: Add shortcut to open the Public folder in the "File Sharing" dialog
Add a shortcut to open the Public folder in the File Sharing dialog,
as this folder is crucial for the file sharing functionality. Also,
this change improves the discoverability of that folder and offers a
convenience of opening it directly from the dialog.
2024-05-28 09:40:28 +00:00
Christopher Davis
73d60296d1 sharing-networks: Port to AdwPreferencesGroup
Also, make the list box to be a11y-labelled.

Partial rebase of https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1239
2024-05-17 08:50:58 +00:00
Automeris naranja
168e30a410 general: Don't set some "Copy" buttons as activatable widgets
In rows that have a "Copy" button that is set as activatable
widget, Orca doesn't the buttons a11y label/tooltip; instead,
it reads "[row title] push button".

To fix this, don't set these buttons as activatable widgets.
2024-05-13 23:13:55 -03:00
Automeris naranja
192d32926d sharing: Add DAV address row in the File Sharing dialog
Also:
- Remove the AdwPreferencesPage description, since
it's redundant with the explanatory text provided in
button from the "File Sharing" row.

Reference:
cfb7cae4a9
2024-05-14 01:07:22 +02:00
Automeris naranja
188b2d6769 sharing: Add explanatory text describing how sharing features work
In the File/Media Sharing dialogs, add a explanatory
text to the "File Sharing" and "Media Sharing" rows
explaining how these sharing features work.

Also, remove the AdwPreferencesPage description in
the "Media Sharing" dialog, since it's redundant
with the explanatory text provided in button from
the "Media Sharing" row.

Reference:
cfb7cae4a9
2024-05-14 01:07:22 +02:00
Automeris naranja
f56ca33a74 sharing: Add notice about shared files not being encrypted
Add an explanatory text to inform the user that sharing
files with encryption isn't supported.

Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2972
2024-05-03 09:37:39 +00:00
Sam Hewitt
1e56c48f33 Unify elements in the icon assets to shrink their file size 2024-04-29 11:01:18 -02:30
Sebastien Bacher
17f472fb2a sharing, system: ssh is under the system panel now, update the keywords
remove also the remove desktop items from sharing
2024-04-26 13:16:04 +00:00
Felipe Borges
b5768e4bf7 sharing, panel-loader: Hide "Sharing" panel when nothing to show
Since we started moving some settings from the Sharing panel to other
panels, we were left with only tree things in the Sharing panel for
gnome-46: hostname row, file sharing row, and media sharing row.

The hostname row is already in System ->About, so we should check
whether file-sharing or media-sharing are supported and show the panel
accordingly.

Fixes #2979
2024-04-18 10:26:17 +02:00
Felipe Borges
1b9e8a8a7a sharing: Don't pass a panel reference to schema check function
We don't need that here.
2024-04-18 10:25:36 +02:00
Felipe Borges
eb86eb11f1 sharing: Add mechanism to check availability of "Media Sharing"
So that we have a function to check whether we should show the "Media
Sharing" row.

This is going to be useful when we will try to hide the entire panel if
both "Media Sharing" and "File Sharing" aren't available.
2024-04-18 10:25:36 +02:00
Automeris naranja
22c0982349 sharing: Remove sharing.css
The .tls-cert-fingerprint style class is part of "Verify Encryption"
dialog from the Remote Desktop feature, which is now present in the
System panel. sharing.css isn't needed anymore.
2024-04-08 17:00:12 +02:00
Automeris naranja
19c3f3570d sharing: Port all dialogs to AdwDialog
Port the "File Sharing" and "Media Sharing" dialogs
to AdwDialog.
2024-04-08 13:47:02 +00:00
Automeris naranja
72abffe24e sharing: Minor tweaks to dialogs size
After the port to AdwPreferencesPage and the
main switch being moved out from the headerbar,
the content of the sharing dialogs got a bit hidden,
which requires more scrolling.

Fix such issue by removing the height-request
property, so the window height can follow the content
height. Do the same for the Media Sharing dialog
to keep consistency. Also, use the same window width
in both dialogs (to also keep consistency).
2024-02-14 12:32:40 +00:00
Matthijs Velsink
959f8afde8 sharing: Clean leftover "Remote Login" code
Commit c0c357c3 (!2211) moved the "Remote Login" code to the System
panel. There are some leftover bits of code in the sharing panel though.

This cleans that up.

Closes #2895
2024-02-13 13:06:38 +00:00
Automeris naranja
7009df80d0 sharing: Fix the networks section from the File/Media Sharing dialogs
- Remove the "Networks" title from CcSharingNetworks
and only use the titles from the AdwPreferencesGroups

- Remove the margins from CcSharingNetworks,
since AdwPreferencesGroup already has margins

- Remove unused `spacing` properties

- Replace the Media Sharing GtkGrid with a GtkBox,
like in the File Sharing dialog, and separate the
networks and folders section into their own
AdwPreferencesGroups

- Remove an unnecessary GtkListBox. It was added[1]
in order to make the "Require Password" and "Password"
rows to have the boxed-list style. Since the dialogs
from Sharing panel started to use AdwPreferencesPage/Group[2],
this GtkListBox is no longer necessary.

[1] 9a15a48d
[2] 45a5a1e0

Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2818
2024-02-12 09:07:30 +00:00
Felipe Borges
c0c357c3bc system: Move "Remote Login" from Sharing panel to System
Fixes #2836
2024-02-12 09:57:11 +01:00
Sam Hewitt
a5f6efaddb Update and clean up symbolic icon assets
- refresh the symbolic icons to sync some style changes and update the source sheet
- rename assets for the privacy subpanel's symbolic icons
- delete deprecated/unused symbolic icons
- add new icon for system panel
- add new icon for remote desktop so it isn't using displays icons
2024-02-10 16:17:35 +00:00
Brandon Nielsen
5da525773f Move cc_remote_login_get_enabled before connection to notify::active
This prevents an issue where the handler can be erroneously called
by opening the sharing panel.
2024-02-05 12:06:42 +01:00
Brandon Nielsen
944f415215 Drop dependency on pkexec
Based on discussion on fedora-devel[0][1] drop the use of pkexec. pkexec
was used only for starting / stopping / enabling / disabling the sshd
service via systemd.

This changes the "org.gnome.controlcenter.remote-login-helper" policy to
request the necessary systemd permissions, and changes to using polkit
to request the permission, then making the dbus calls once the
permission is acquired.

This also cleans up targets of the dialog response functions as
discussed in the MR[3].

[0] - https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/ZDZACAMG2E3P4K4P2CVBQ3XBBZ7CYSXA/
[1] - https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/WCZW4Y4ONV5ZXU4JUCQUS56F3R6GNGJF/
[2] - https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/F5INKYST7JUNU6FYKU5JJJWXCYOCM33I/
[3] - https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1179#note_1793602
2024-02-05 12:06:41 +01:00
Automeris naranja
f623feed0a cc-sharing-networks: Use edit-delete-symbolic
window-close-symbolic shouldn't be used in this case.
Use edit-delete-symbolic instead.

See https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2842
2024-02-05 10:58:49 +00:00
Monster
de5ab92975 sharing: Remove period in description 2024-02-05 10:57:33 +00:00
Felipe Borges
5ed0b3e1f8 sharing: Remove unused pwquality and pwd.h dependencies
Those were leftovers from when the Remote Desktop settings got moved
into the System panel.
2024-01-31 10:38:07 +01:00
Felipe Borges
dc514d3df1 sharing: Remove unused "gcr/gcr-base.h" include
This was part of the Remote Desktop code that now is part of the
System panel.
2024-01-31 10:38:07 +01:00
Automeris naranja
00d9cd012f sharing: Add tooltips to some icon-only buttons
Also, remove a11y labels from these buttons,
because a11y labels and tooltips are redundant
(Orca reads both).
2024-01-30 13:44:07 +00:00
Automeris naranja
2c04c9dfc9 sharing: Move switches out of the headerbar
In the "Media Sharing" and "File Sharing"
dialogs, move the main switches out of the
headerbar and show them in a row.

See https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1930
2024-01-30 13:33:35 +00:00
Automeris naranja
5ba750522c sharing: Add missing mnemonics
Add mnemonics to:
- Device Name entry row
- Remote Login row (from the Remote Login window)
2024-01-23 11:09:19 +00:00
Automeris naranja
50c413e6bb general: Use proper icon in remove buttons of some list rows
window-close-symbolic shouldn't be used in this case.
Use edit-delete-symbolic instead.

Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2842
2024-01-18 12:08:42 +00:00
Automeris naranja
45a5a1e0e7 sharing: Use AdwPreferencesPage/AdwPreferencesGroup in all dialogs 2024-01-04 11:31:04 +00:00
Bart Gravendeel
cacc2b5bef Remove use-underline property from all CCListRows 2024-01-04 10:11:35 +00:00
Maximiliano Sandoval R
9a15a48d50 sharing-panel: Modernize File Sharing dialog
Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1999>
2023-11-07 08:25:02 +00:00
Gotam Gorabh
34fcaa0654 system: Add 'Remote Desktop' panel to system panel
See #2241
2023-11-02 12:15:11 +00:00
Maximiliano Sandoval R
4209811f2f sharing-panel: Make adaptive
We allow the media sharing dialog to be resizable.

We wrap the content in a scrolled window containing a clamp.
2023-10-23 13:37:52 +00:00
Maximiliano Sandoval R
883a3d44ab sharing-networks: Make network row activatable 2023-10-23 13:37:52 +00:00
Maximiliano Sandoval R
77acfe3ebd sharing-networks: Set seleciton-mode=none
Using other selection modes is not supported with boxed-list and we
don't make use of it.
2023-10-23 13:37:52 +00:00
Maximiliano Sandoval R
a660cfa9ff sharing-network: Remove Glade lines 2023-10-23 13:37:52 +00:00
Maximiliano Sandoval R
8e0e3487cb sharing-network: Don't use GtkFrame 2023-10-23 13:37:52 +00:00
Maximiliano Sandoval R
949e850de6 sharing-panel: Use proper heading class 2023-10-23 13:37:52 +00:00
Maximiliano Sandoval R
d3f824e422 sharing-networks: Use proper heading class 2023-10-23 13:37:52 +00:00
Alice Mikhaylenko
4680f362f3 Port to AdwNavigationSplitView 2023-08-25 08:00:43 +00:00
Alice Mikhaylenko
b91859c4b3 sharing: Port dialogs to AdwWindow and AdwToolbarView
Normalize the fingerprint dialog: use a header bar, have esc-to-close, stop
leaking it
2023-08-25 08:00:43 +00:00
Alice Mikhaylenko
a96b5306a0 sharing: Port to AdwToolbarView 2023-08-25 08:00:43 +00:00
zalnaRs
67a9e9d2b3 Sharing: Replace Remote Login's GtkSwitch to AdwSwitchRow
Remote Login dialog used the old GtkSwitch.

Replaced the switch with AdwSwitchRow and wrapped it with AdwPreferencesGroup.

part of https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2290 and part of https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1930
2023-08-15 08:51:04 +00:00
Felipe Borges
52ca3bbf14 sharing: Remove placeholder strings from UI file
Those strings are set in the C file.
2023-08-11 12:05:39 +02:00
Robert Ancell
91fbc1b8df sharing: Connect signal handlers in swapped form 2023-06-07 09:12:54 +12:00
Maksym Hazevych
b5cee63632 Use page for description instead of single group
When there is only one AdwPreferencesGroup in a whole
AdwPreferencesPage, use "description" property of the latter.
2023-06-06 13:40:33 +00:00