Commit graph

4111 commits

Author SHA1 Message Date
Bastien Nocera
0d4b2bc49b sharing: Ensure Tracker rygel plugin is disabled
The Tracker plugin is enabled by default, and will replace the
MediaExport plugin is enabled. This means that instead of sharing files
listed in the paths set in the UI, we'd be sharing the user's files as
configured in the Search panel. Not what we want to do if this contains
private files.
2016-01-10 10:24:41 +01:00
Bastien Nocera
d98d42880d common: Update from gnome-settings-daemon 2016-01-10 10:24:41 +01:00
Bastien Nocera
5e8ca7dcb3 background: Port to new grilo 0.3.0 API
And fix the "fix" in commit 54d0cef51f
which would always fail to activate the Flickr plugin as it wasn't
loaded.

https://bugzilla.gnome.org/show_bug.cgi?id=759585
2015-12-17 13:34:02 +01:00
Olav Vitters
54d0cef51f Build fix: Update grl_registry_load_plugin_by_id API change
Grilo 0.3.0 renamed grl_registry_load_plugin_by_id to
grl_registry_activate_plugin_by_id.
2015-12-16 23:21:18 +01:00
Felipe Borges
07c6c4d3f7 mouse: Remove the two-finger scroll switch
The two-finger scroll method will be enabled in all cases
(see bgo#759304). When a touchpad without two-finger scrolling
support but with edge scrolling support is available, show the
switch.

Also bump the required gsettings-desktop-schemas version for
the new key.

https://bugzilla.gnome.org/show_bug.cgi?id=759307
2015-12-15 14:48:05 +01:00
Debarshi Ray
66c6975942 region: Silence a CRITICAL
Fall out from abb0592866

https://bugzilla.gnome.org/show_bug.cgi?id=758417
2015-11-23 11:38:57 +01:00
Debarshi Ray
be277759bb region: Use header bar in the input options dialog
https://bugzilla.gnome.org/show_bug.cgi?id=757516
2015-11-20 18:02:57 +01:00
Debarshi Ray
7d9f7f30bc region: Turn CcInputOptions into a templatized composite widget
This is a pre-requisite for using a header bar.
GtkDialog:use-header-bar is a construct-only property, and has no
effect when set from the XML. Therefore, the only option is to turn
the widget into a template and set use-header-bar from C.

There should be no behavioral changes due to this patch.

Bump required GLib version for the G_DECLARE_FINAL_TYPE macro.

https://bugzilla.gnome.org/show_bug.cgi?id=757516
2015-11-20 18:02:57 +01:00
Debarshi Ray
4261151f4d region: Remove unused variable
https://bugzilla.gnome.org/show_bug.cgi?id=757516
2015-11-20 18:02:57 +01:00
Bastien Nocera
dc49fb6bb9 power: Don't throw errors when D-Bus calls are cancelled
https://bugzilla.gnome.org/show_bug.cgi?id=757880
2015-11-13 16:21:36 +01:00
Bastien Nocera
3a3408040f power: Add configuration for Power Button
When running on something other than a VM or a tablet, which have
hard-coded actions when the power button is pressed, offer to configure
the power button to either suspend (default), hibernate, or do nothing.

https://bugzilla.gnome.org/show_bug.cgi?id=757880
2015-11-13 16:21:36 +01:00
Yosef Or Boczko
ac4e8fc774 Mouse: Mark two strings as translatable 2015-11-13 14:09:03 +02:00
Felipe Borges
c75fcf0198 mouse: make primary-buttons homogeneous and same size as mockups
https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-11-05 12:50:40 +01:00
Felipe Borges
311c54008e mouse: properly wrap and scale the row description texts
In the designs at https://wiki.gnome.org/Design/SystemSettings/Mouse,
the description texts of each row is slightly smaller than their
labels.
Besides, the description of the primary-button row has an arbitrary
line break.

https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-11-05 12:50:34 +01:00
Felipe Borges
723c7f5fdb mouse: primary buttons entry is now vertically centered in the row
https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-11-04 17:38:08 +01:00
Bastien Nocera
1f192985ef keyboard: Remove general tab
The cursor blinking and repeat keys configuration options have moved to
the Universal Access panel, with the shortcuts panel due for a
re-design.

See https://bugzilla.gnome.org/show_bug.cgi?id=757486
See https://bugzilla.gnome.org/show_bug.cgi?id=757464

https://bugzilla.gnome.org/show_bug.cgi?id=757489
2015-11-04 13:20:01 +01:00
Felipe Borges
e1fe43f62b universal-access: prevent the Repeat Keys switch from vexpanding
https://bugzilla.gnome.org/show_bug.cgi?id=757464
2015-11-04 12:51:56 +01:00
Felipe Borges
417ffaa014 universal-access: add Cursor Blinking settings to the Typing section
https://bugzilla.gnome.org/show_bug.cgi?id=757486
2015-11-04 10:03:55 +01:00
Felipe Borges
9e96750393 mouse: make the touchpad options separator non-selectable
Since the first entry in the Touchpad section causes the sensitive
of the items below to change, those items are in a diferent ListBox.
To make it look like it is all the same ListBox, we arbitrarily add
a separator between the first item and the items below.

https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-11-03 17:04:19 +01:00
Felipe Borges
918a0e2982 mouse: add a label description for the 'Natural Scrolling' entries
https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-11-03 16:38:59 +01:00
Bastien Nocera
752ed5c443 mouse: Make touchpad settings unsensitive when disabled
Rather than hiding all the settings.

https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-11-02 16:06:27 +01:00
Bastien Nocera
f945dabbe8 mouse: Style fixes
Fix grammar and coding style in a couple of places.
2015-11-02 16:06:27 +01:00
Felipe Borges
e96a2bf340 mouse: make all rows the same height
https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-11-02 15:05:26 +01:00
Felipe Borges
0b53a560db universal-access: add Repeat Keys to the Typing section
According to the new Keyboard panel design, this setting belongs
to the Universal Access panel.

https://bugzilla.gnome.org/show_bug.cgi?id=757464
2015-11-02 15:03:18 +01:00
Bastien Nocera
4ff7d6f671 mouse: Clean up resource files on "make clean"
The resource files are generated, so we'll need to clean them up.
2015-10-28 14:23:19 +01:00
Bastien Nocera
3d95415965 mouse: Remove default value marks on scales
They weren't that helpful.

https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-10-28 13:35:18 +01:00
Bastien Nocera
d6ed423f9c mouse: Fix "Primary button" description
https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-10-28 13:30:22 +01:00
Allan Day
f872293465 mouse: Tweak header spacing
There was slightly too much padding between the headings and the
list boxes below.

https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-10-28 13:28:11 +01:00
Bastien Nocera
1a76afe8ad mouse: Use GtkGesture to handle secondary button
Instead of hacking the release signal.

https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-10-28 13:26:24 +01:00
Bastien Nocera
1d952001f5 mouse: Change UI when mouse handedness when setting changes
This simplifies the way that we keep the settings and the UI in sync.

https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-10-28 13:01:18 +01:00
Bastien Nocera
d6970f1c58 mouse: Fix right-/left-handed buttons getting out of sync
Make the two independent buttons into a group of radio buttons without
an indicator to make sure they stay in sync (one enabled, one disabled).

https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-10-28 12:20:50 +01:00
Debarshi Ray
b37165de9c background: Fix a few memory leaks
https://bugzilla.gnome.org/show_bug.cgi?id=757189
2015-10-27 17:32:50 +01:00
Felipe Borges
40b769bd08 mouse: make the scale cursors point to the bottom to match the mockups
https://wiki.gnome.org/Design/SystemSettings/Mouse#Tentative_Design

https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-10-27 16:27:43 +01:00
Felipe Borges
beb8e9a945 mouse: handle better the visibility of scroll-method entries
Fixes the situation where you unplug a touchpad device which
supports two-finger-scrolling and plug in another one with
edge-scrolling only, we would have two switches. These entries
are mutually exclusive.

https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-10-27 16:27:43 +01:00
Felipe Borges
0fd9b483f5 mouse: make slow-to-fast in the speed sliders go from left-to-right
https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-10-27 16:27:43 +01:00
Felipe Borges
ad1c44fbad mouse: align the speed sliders in the same size group
https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-10-27 16:27:43 +01:00
Felipe Borges
c1318c634f mouse: decouple Natural Scrolling for mice and touchpads
Now each kind of device has its own entry.

https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-10-27 16:27:42 +01:00
Debarshi Ray
c66c73d6ec background: Fix a few memory leaks
https://bugzilla.gnome.org/show_bug.cgi?id=757189
2015-10-27 14:38:38 +01:00
Felipe Borges
1896fafef6 mouse: port panel to the new design
https://wiki.gnome.org/Design/SystemSettings/Mouse

https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-10-23 14:16:09 +02:00
Felipe Borges
e9413b4b6a printers: polish empty state
If you don't have any printers, the panel used to look rather bare.
There was also a "No printers available" label, which was confusing,
and the insensitive list might be hard to understand.

https://bugzilla.gnome.org/show_bug.cgi?id=690351
2015-10-22 16:40:19 +02:00
Felipe Borges
5cd231fd59 mouse: decouple the scroll-methods detection code from the UI file
https://bugzilla.gnome.org/show_bug.cgi?id=756863
2015-10-22 13:57:08 +02:00
Felipe Borges
0514006498 universal-access: make the Double-Click delay slider wider
https://bugzilla.gnome.org/show_bug.cgi?id=756872
2015-10-21 13:45:09 +02:00
Felipe Borges
87f3dfab02 universal-access: add Double-click delay to Pointing & Clicking section
According to the new Mouse & Touchpad panel designs at
https://wiki.gnome.org/Design/SystemSettings/Mouse, Double-click
delay belongs to the Universal Access panel.

https://bugzilla.gnome.org/show_bug.cgi?id=756872
2015-10-21 12:48:55 +02:00
Christophe Fergeau
99ef490875 keyboard: Fix leak in settings_get_binding()
This fixes:
==5944== 64,392 bytes in 4,223 blocks are definitely lost in loss record 16,020 of 16,045
==5944==    at 0x4C28C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5944==    by 0x1445EFCC: g_malloc (gmem.c:94)
==5944==    by 0x1445F2AE: g_malloc_n (gmem.c:330)
==5944==    by 0x144981DC: g_variant_get_strv (gvariant.c:1572)
==5944==    by 0x48FA45: settings_get_binding (cc-keyboard-item.c:369)
==5944==    by 0x48FA9D: binding_changed (cc-keyboard-item.c:384)
==5944==    by 0x141C3E2F: g_cclosure_marshal_VOID__STRINGv (gmarshal.c:1794)
==5944==    by 0x141BFBE3: _g_closure_invoke_va (gclosure.c:864)
==5944==    by 0x141DA3E7: g_signal_emit_valist (gsignal.c:3292)
==5944==    by 0x141DB55F: g_signal_emit (gsignal.c:3439)
==5944==    by 0x13EDC81D: g_settings_real_change_event (gsettings.c:386)

https://bugzilla.gnome.org/show_bug.cgi?id=756762
2015-10-19 11:19:17 +02:00
Christophe Fergeau
caacec3c86 keyboard: Fix leak when loading sections
This fixes:
==5944== 2,304 bytes in 5 blocks are definitely lost in loss record 15,724 of 16,045
==5944==    at 0x4C2AB9D: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5944==    by 0x1445F0B8: g_realloc (gmem.c:159)
==5944==    by 0x144217CF: g_array_maybe_expand (garray.c:779)
==5944==    by 0x14420C9F: g_array_append_vals (garray.c:418)
==5944==    by 0x48ACFA: append_sections_from_file (keyboard-shortcuts.c:558)
==5944==    by 0x48B4EE: reload_sections (keyboard-shortcuts.c:737)
==5944==    by 0x48EA22: keyboard_shortcuts_init (keyboard-shortcuts.c:2109)
==5944==    by 0x489236: cc_keyboard_panel_constructor (cc-keyboard-panel.c:133)
==5944==    by 0x141C7C3F: g_object_new_with_custom_constructor (gobject.c:1697)
==5944==    by 0x141C7E71: g_object_new_internal (gobject.c:1777)
==5944==    by 0x141C8ADA: g_object_new_valist (gobject.c:2038)
==5944==    by 0x141C7A85: g_object_new (gobject.c:1622)
==5944==    by 0x4547DF: cc_panel_loader_load_by_name (cc-panel-loader.c:213)
==5944==    by 0x44DFCB: activate_panel (cc-window.c:157)
==5944==    by 0x4504D6: cc_window_set_active_panel_from_id (cc-window.c:1036)
==5944==    by 0x44E6A6: item_activated_cb (cc-window.c:280)

https://bugzilla.gnome.org/show_bug.cgi?id=756762
2015-10-19 11:19:17 +02:00
Christophe Fergeau
e235a8a062 keyboard: Fix leak in find_free_settings_path()
==5944== 90 (16 direct, 74 indirect) bytes in 1 blocks are definitely lost in loss record 11,855 of 16,045
==5944==    at 0x4C28C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5944==    by 0x1445EFCC: g_malloc (gmem.c:94)
==5944==    by 0x1445F2AE: g_malloc_n (gmem.c:330)
==5944==    by 0x144982EC: g_variant_dup_strv (gvariant.c:1621)
==5944==    by 0x13EDF251: g_settings_get_strv (gsettings.c:2070)
==5944==    by 0x48D56E: find_free_settings_path (keyboard-shortcuts.c:1651)
==5944==    by 0x48D663: add_custom_shortcut (keyboard-shortcuts.c:1682)
==5944==    by 0x48DB04: add_button_clicked (keyboard-shortcuts.c:1788)

https://bugzilla.gnome.org/show_bug.cgi?id=756762
2015-10-19 11:19:17 +02:00
Christophe Fergeau
baff31f43e keyboard: Don't leak CcKeyboardItem::binding
It contains a strdup'ed string, but it's overwritten without being freed
first from cc_keyboard_item_load_from_gsettings_path() and
cc_keyboard_item_load_from_gsettings().

This fixes:
==5944== 976 bytes in 64 blocks are definitely lost in loss record 15,439 of 16,045
==5944==    at 0x4C28C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5944==    by 0x1445EFCC: g_malloc (gmem.c:94)
==5944==    by 0x1445F2AE: g_malloc_n (gmem.c:330)
==5944==    by 0x144981DC: g_variant_get_strv (gvariant.c:1572)
==5944==    by 0x48FA45: settings_get_binding (cc-keyboard-item.c:369)
==5944==    by 0x48FDDD: cc_keyboard_item_load_from_gsettings (cc-keyboard-item.c:438)
==5944==    by 0x489EB7: append_section (keyboard-shortcuts.c:249)
==5944==    by 0x48ADF6: append_sections_from_file (keyboard-shortcuts.c:578)
==5944==    by 0x48B4EE: reload_sections (keyboard-shortcuts.c:737)
==5944==    by 0x48EA22: keyboard_shortcuts_init (keyboard-shortcuts.c:2109)
==5944==    by 0x489236: cc_keyboard_panel_constructor (cc-keyboard-panel.c:133)
==5944==    by 0x141C7C3F: g_object_new_with_custom_constructor (gobject.c:1697)
==5944==    by 0x141C7E71: g_object_new_internal (gobject.c:1777)
==5944==    by 0x141C8ADA: g_object_new_valist (gobject.c:2038)
==5944==    by 0x141C7A85: g_object_new (gobject.c:1622)
==5944==    by 0x4547DF: cc_panel_loader_load_by_name (cc-panel-loader.c:213)
==5944==    by 0x44DFCB: activate_panel (cc-window.c:157)
==5944==    by 0x4504D6: cc_window_set_active_panel_from_id (cc-window.c:1036)

https://bugzilla.gnome.org/show_bug.cgi?id=756762
2015-10-19 11:19:17 +02:00
Christophe Fergeau
d289aa84e7 online-accounts: Remove unused private member
This fixes this leak:

==21491== 384 (40 direct, 344 indirect) bytes in 1 blocks are definitely lost in loss record 18,518 of 19,643
==21491==    at 0x8792D3A: g_type_create_instance (gtype.c:1848)
==21491==    by 0x8779AC5: g_object_new_internal (gobject.c:1774)
==21491==    by 0x8779FD4: g_object_newv (gobject.c:1921)
==21491==    by 0x8779676: g_object_new (gobject.c:1614)
==21491==    by 0x747DFFC: gtk_list_store_new (gtkliststore.c:424)
==21491==    by 0x49C781: goa_panel_add_account_dialog_init (cc-online-accounts-add-account-dialog.c:300)
==21491==    by 0x8792E7D: g_type_create_instance (gtype.c:1870)
==21491==    by 0x8779AC5: g_object_new_internal (gobject.c:1774)
==21491==    by 0x877A71A: g_object_new_valist (gobject.c:2033)
==21491==    by 0x87796C5: g_object_new (gobject.c:1617)
==21491==    by 0x49CC26: goa_panel_add_account_dialog_new (cc-online-accounts-add-account-dialog.c:380)
==21491==    by 0x49B162: get_all_providers_cb (cc-online-accounts-panel.c:701)
==21491==    by 0x8426107: g_simple_async_result_complete (gsimpleasyncresult.c:801)
==21491==    by 0x8426153: complete_in_idle_cb (gsimpleasyncresult.c:813)
==21491==    by 0x8A0C470: g_idle_dispatch (gmain.c:5397)
==21491==    by 0x8A09AB8: g_main_dispatch (gmain.c:3122)
==21491==    by 0x8A0A8FC: g_main_context_dispatch (gmain.c:3737)
==21491==    by 0x8A0AAE0: g_main_context_iterate (gmain.c:3808)
==21491==    by 0x8A0ABA4: g_main_context_iteration (gmain.c:3869)
==21491==    by 0x846EE55: g_application_run (gapplication.c:2311)
==21491==    by 0x44CA4B: main (main.c:57)

https://bugzilla.gnome.org/show_bug.cgi?id=756762
2015-10-19 11:19:17 +02:00
Bastien Nocera
43d4ae4bd4 background: Replace deprecated grilo function use
grl_operation_options_set_flags() was replaced, and bump the required
grilo version to 0.2.12

https://bugzilla.gnome.org/show_bug.cgi?id=756393
2015-10-11 17:41:04 +02:00
Bastien Nocera
9315eb0251 sharing: Fix crash when disabling sharing
Left-over code from 9d45904f3c meant that
we'd try to disable a non-existent switch.

https://bugzilla.gnome.org/show_bug.cgi?id=756391
2015-10-11 17:41:04 +02:00