Commit graph

5917 commits

Author SHA1 Message Date
Robert Ancell
148e4c8fd0 common: Use GtkTemplate for the language chooser dialog 2018-07-18 22:39:32 +00:00
Lubomir Rintel
3c61cee1bb network: use nm_device_get_description()
It's better for human-readable display than nm_device_get_product().
Unlike nm_device_get_product(), it never returns an empty string and
sanitizes the string.

With NM 1.12 it goes to great lengths to clean up the messy udev
strings.
2018-07-17 08:44:16 +02:00
Robert Ancell
17dbce362e notifications: Refactor app notifications dialog
The current widget has a very generic name "EditDialog" - rename it to something
that reflects better what it is for.

Implement it is as a full GtkWidget using GtkTemplate.

Move some of the logic from inside the dialog to the code that creates the dialog
so less data is passed around.

Store properties using functions instead of g_object_set_data - that passes
everything as a gpointer which is easy to make a mistake with.
2018-07-16 19:36:19 +00:00
Robert Ancell
0f60dd1b71 region: Use GtkTemplate for format chooser dialog 2018-07-14 16:14:57 +00:00
Ondrej Holy
1e769bb49d user-accounts: Use term "Confirm" instead of "Verify"
The Password dialog uses "Verify New Password" and Add User dialog
"Confirm". Let's use "Confirm New Password" as it is on mockups to
be consistent in terminology.
2018-07-12 10:11:25 +02:00
Ondrej Holy
833c18bce4 user-accounts: Use the same phrase when passwords do not match
Use "The passwords do not match." phrase in the Add User dialog and
Password dialog consistently.
2018-07-12 10:11:25 +02:00
Robert Ancell
5e91cc7140 user-accounts: Correctly hide password mismatch warnings
The logic for the password mismatch warnings didn't handle the case where
you deleted both the passwords - it would still show them as not
matching.

Fix this by handling the three cases:
- Passwords are different
- Passwords are the same
- No passwords entered
2018-07-11 16:19:54 +02:00
Ondrej Holy
525adcf10b user-accounts: Fix entry sensitivity after password generation
If a password is generated and prefilled in the corresponding entries,
the verify entry remains insensitive. Let's fix the sensitivity...

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/38
2018-07-11 10:38:57 +02:00
Ondrej Holy
d07a67fcb3 user-accounts: Validate password before moving focus
If <tab> is pressed and password is not yet validated (ie. the verify
entry is not sensitive), focus skips the verify entry, even if the
password is strong enough. Let's validate the password when <tab> is
pressed (ie. before focus change) to prevent this <tab> breakage...

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/38
2018-07-11 10:38:57 +02:00
Ondrej Holy
ae16a8e7a0 Revert "user-accounts: Don't disable the verify password entry"
This reverts commit 7b3746af23.

This is needed to make obvious that password is not yet strong
enough.

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/38
2018-07-11 10:38:57 +02:00
Sam Hewitt
e91208eeb5 printers: update pixel_size of icons to avoid aliasing 2018-07-10 18:04:32 -04:00
Sam Hewitt
e66ee02953 wacom: use dim-label class on icons instead of opacity for consistency 2018-07-10 17:53:56 -04:00
Sam Hewitt
24174173be common: update pixel_size values to base 16 for icon clarity 2018-07-10 17:52:08 -04:00
Jonas Ådahl
49ef965dc7 sharing: Enable settings widget for gnome-remote-desktop
Enable support for manipulating GNOME Remote Desktop settings. Settings
are done via the org.gnome.desktop.remote-desktop.vnc schema.
Configuring the VNC password is done via libsecret, thus libsecret is
added as a dependency.
2018-07-10 19:59:51 +00:00
Robert Ancell
b3ea72735a notifications: Use g_signal_connect_object to ensure handlers are not run after object destroyed
Fixes specific crash:
https://gitlab.gnome.org/GNOME/gnome-control-center/issues/75
2018-07-03 11:42:00 +12:00
Robert Ancell
556388f373 region: Fix small memory leak
Was introduced in 79e00c3
2018-07-02 21:52:03 +00:00
Robert Ancell
65c43b4fac common: Fix missing reference
Was introduced in 86d1d30
2018-07-02 21:11:42 +00:00
Philip Withnall
7b3cd630c0 info: Update gsd_should_ignore_unix_mount() from g-s-d master
• Use g_unix_is_system_fs_type() if a new enough GLib is available,
   rather than maintaining our own list of system file system types.
 • List network file systems separately, since GLib doesn’t ignore them.
 • Ignore some file systems by label too.

See
https://gitlab.gnome.org/GNOME/gnome-settings-daemon/merge_requests/24.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
2018-06-29 06:49:45 +00:00
Robert Ancell
3f5bc8369b printers: Fix warning about wrong data type 2018-06-26 15:57:20 +12:00
Robert Ancell
55d47bc83e printers: Plug memory leaks 2018-06-25 22:53:10 +00:00
Bastien Nocera
a30e5dbe72 wifi: Use g_debug() for a debug message
Rather than CC_TRACE_MSG() which is supposed to be used for debugging
timing related problems.
2018-06-20 12:53:11 +00:00
Bastien Nocera
0e2a4aa2d6 wacom: Hide Wacom panel when there are no tablets
Use GsdDeviceManager to monitor libwacom-supported tablets coming and
going. Hide the Wacom panel from the list when there's no supported
tablets plugged in.
2018-06-20 12:53:11 +00:00
Robert Ancell
67d39e497a region: Fix language search crash due to g_auto changes in 79e00c3 2018-06-20 17:07:08 +12:00
Robert Ancell
9ae5f9a667 Fix crash due to g_auto changes in 79e00c3 2018-06-20 16:44:36 +12:00
Robert Ancell
71383e8b50 power: Use GtkTemplate 2018-06-11 14:30:31 +00:00
Robert Ancell
014e572e9b universal-access: Use GtkTemplate 2018-06-11 14:11:47 +00:00
Jonathan Kang
ca15b9822d wifi: only manage Wi-Fi devices managed by NM
If a Wi-Fi device is unmanaged by NetworkManager, ignore it.
2018-06-08 13:03:53 +00:00
Robert Ancell
86d1d30c63 common: Use g_auto for variables 2018-06-07 01:08:07 +00:00
Robert Ancell
eff88ab2f1 sharing: Use GtkTemplate 2018-06-07 00:58:22 +00:00
Robert Ancell
122f997493 background: Replace deprecated GSimpleAsyncResult with GTask 2018-06-03 06:46:16 +04:00
Robert Ancell
3622c8ff14 power: Use g_auto for variables 2018-06-03 01:38:43 +00:00
Robert Ancell
3f9337da4e universal-access: Use g_auto for variables 2018-06-03 01:31:26 +00:00
Robert Ancell
a30f660db9 sharing: Use g_auto for variables 2018-06-03 01:11:17 +00:00
Robert Ancell
9a7850a7aa region: Move callbacks into .ui file 2018-06-03 00:41:58 +00:00
Robert Ancell
223087cf39 common: sharing: Replace ifdefs with #pragma once 2018-06-01 21:41:34 +00:00
Robert Ancell
42ea814d72 common: Replace GObject boilerplace with G_DECLARE_TYPE 2018-06-01 21:41:33 +00:00
Robert Ancell
a91ef6c7d7 sharing: Replace ifdefs with #pragma once 2018-06-01 21:21:05 +00:00
Robert Ancell
394797025f sharing: Replace GObject boilerplace with G_DECLARE_TYPE 2018-06-01 21:21:05 +00:00
Robert Ancell
a64ef75ad7 Simplify use of GCancellable
g_cancellable_cancell can be called without checking for a NULL value.
Use g_clear_object instead of g_object_unref
2018-06-01 21:03:19 +00:00
Robert Ancell
dd61d98ec5 datetime: Move callbacks into .ui file 2018-06-01 20:35:30 +00:00
Robert Ancell
c461e436b7 user-accounts: Replace ifdefs with #pragma once 2018-06-01 11:04:18 +00:00
Robert Ancell
678beb6712 user-accounts: Replace GObject boilerplace with G_DECLARE_TYPE 2018-06-01 11:04:18 +00:00
Robert Ancell
930aff4cc7 background: Fix compile warning about object type
[8/15] Compiling C object 'panels/background/panels@background@@background-chooser@sta/cc-background-xml.c.o'.
In file included from /usr/include/glib-2.0/gobject/gbinding.h:29:0,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from /usr/include/glib-2.0/gio/gioenums.h:28,
                 from /usr/include/glib-2.0/gio/giotypes.h:28,
                 from /usr/include/glib-2.0/gio/gio.h:26,
                 from ../panels/background/cc-background-xml.c:22:
../panels/background/cc-background-xml.c: In function ‘cc_background_xml_load_xml_internal’:
/usr/include/glib-2.0/gobject/gobject.h:512:32: warning: passing argument 2 of ‘emit_added_in_idle’ from incompatible pointer type [-Wincompatible-pointer-types]
 #define g_object_ref(Obj)      ((__typeof__(Obj)) (g_object_ref) (Obj))
                                ^
../panels/background/cc-background-xml.c:310:34: note: in expansion of macro ‘g_object_ref’
         emit_added_in_idle (xml, g_object_ref (item));
                                  ^~~~~~~~~~~~
../panels/background/cc-background-xml.c:138:1: note: expected ‘GObject * {aka struct _GObject *}’ but argument is of type ‘CcBackgroundItem * {aka struct _CcBackgroundItem *}’
 emit_added_in_idle (CcBackgroundXml *xml,
 ^~~~~~~~~~~~~~~~~~
2018-06-01 14:29:28 +12:00
Gunnar Hjalmarsson
0bd90ca34b region: Show scrollbars if needed
If we are initially showing more entries than can be fit, we should
scroll then too rather than deciding in code when to do this.

https://bugzilla.gnome.org/show_bug.cgi?id=793861
2018-05-31 12:36:54 +12:00
Robert Ancell
59e420b774 search: Fix crash introduced in 58a6432 2018-05-31 12:16:04 +12:00
Robert Ancell
233111b264 search: Use GtkTemplate 2018-05-30 23:40:00 +00:00
Robert Ancell
6b2ed3a4bc universal-access: Replace ifdefs with #pragma once 2018-05-30 23:33:25 +00:00
Robert Ancell
85eeebb5c5 universal-access: Replace GObject boilerplace with G_DECLARE_TYPE 2018-05-30 23:33:25 +00:00
Robert Ancell
58a64323c4 search: Use g_auto for variables 2018-05-30 23:24:21 +00:00
Robert Ancell
d2959e4fe7 power: Simplify GPtrArray memory management 2018-05-30 23:17:08 +00:00