Commit graph

4551 commits

Author SHA1 Message Date
Mohammed Sadiq
a09a5d7e9e search: Fix memory leak
g_variant_get_strv() returns newly allocated memory.
This should be freed when no longer required.

https://bugzilla.gnome.org/show_bug.cgi?id=782048
2017-05-02 12:54:37 +02:00
Georges Basile Stavracas Neto
dce6fe6add keyboard: Move Remove button to the header bar
According to the mockups [1], the Remove button should
be placed at the start of the header bar. Currently,
however, it is positioned below the custom shortcut edit
button.

Fix that by moving the remove button to the header bar.

[1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/keyboard/keyboard-wires.png

https://bugzilla.gnome.org/show_bug.cgi?id=777846
2017-05-02 07:20:29 -03:00
Georges Basile Stavracas Neto
5a01034dbd info: Improve translation of OS type
Instead of having a single translation using a
printf-formatted string, hardcode the 32- and
64-bit variants of the OS type to avoid any
translation problems.

https://bugzilla.gnome.org/show_bug.cgi?id=770593
2017-05-01 12:43:15 -03:00
Kalev Lember
5cc33d617c info: Rename "base system" to "OS name"
Using "OS name" is clearer than "Base system" when we want
to check what's the current OS/distribution combination is.

Fix that by renaming the label.

https://bugzilla.gnome.org/show_bug.cgi?id=770593
2017-05-01 12:43:15 -03:00
Kalev Lember
fb1291bc78 info: Use semicolon for separating build ID
Otherwise we can end up having "Fedora 25 (Workstation Edition) (Build ID:
asdf)", which looks awkward with multiple parenthesis.

https://bugzilla.gnome.org/show_bug.cgi?id=770593
2017-05-01 12:43:15 -03:00
Kalev Lember
439548b89f info: Split up "Base system" and "OS type" to separate lines
Having the OS name and architecture at the same place proved
to be harder to understand than having the processor arch.

Fix that by splitting the OS name and type labels in different
rows.

https://bugzilla.gnome.org/show_bug.cgi?id=770593
2017-05-01 12:43:15 -03:00
Kalev Lember
eeb5594d46 info: Improve fallbacks if PRETTY_NAME isn't set
Try to use NAME + VERSION_ID and fall back to "Unknown" if that didn't
work either.

https://bugzilla.gnome.org/show_bug.cgi?id=770593
2017-05-01 12:43:15 -03:00
Bastien Nocera
56a6654fd3 info: Update from gnome-settings-daemon 2017-04-29 14:30:32 +02:00
Ondrej Holy
b619f7c96a info: Fix total disc size for btrfs subvolumes
Total disc size may be wrong if something like btrfs subvolumes are
used. Do not count multiple mounts with same device_path, because
it is probably something like btrfs subvolume. Use only the first one
in order to count the real size.

https://bugzilla.gnome.org/show_bug.cgi?id=708786
2017-04-29 14:20:19 +02:00
Bastien Nocera
87928a5d6f network: Add hotspot setup debug 2017-04-29 14:11:22 +02:00
Felipe Borges
f14829c38c search: Use list box separators between entries
https://bugzilla.gnome.org/show_bug.cgi?id=775958
2017-04-29 13:39:22 +02:00
Felipe Borges
a0dccafaa2 search: Place the whole content in a scrolled window
A step towards the new panel design is to place all
the panel content inside of a scrolled window, instead
of just the list box.

The new panel mockups are available at
https://wiki.gnome.org/Design/SystemSettings/Search

https://bugzilla.gnome.org/show_bug.cgi?id=775958
2017-04-29 13:39:22 +02:00
Bastien Nocera
937a518889 network: Fix return value type
We're supposed to return a pointer to GBytes, not a boolean.
2017-04-27 19:44:05 +02:00
Mohammed Sadiq
eeddf497af keyboard: Discard the added shortcut on Escape
If the user press Escape key after the user have set some shortcut,
don't save the newly set shortcut, and close the dialog.

https://bugzilla.gnome.org/show_bug.cgi?id=778748
2017-04-27 10:20:56 -03:00
Jonathan Kang
bb8ca23701 network: Fix mobile broadband switch state
The switch was only reflecting the value of the WWAN killswitch instead
of both the WWAN killswitch and the state of the connection itself.

https://bugzilla.gnome.org/show_bug.cgi?id=690361
2017-04-13 15:51:51 +02:00
Bastien Nocera
5bb41f6d33 universal-access: Add Blink and Repeat to the keywords
https://bugzilla.gnome.org/show_bug.cgi?id=781245
2017-04-13 10:23:39 +02:00
Bastien Nocera
59cbe55db9 keyboard: Add many new keywords
Based on the keyboard shortcuts offered for customisation.

https://bugzilla.gnome.org/show_bug.cgi?id=781245
2017-04-13 10:23:39 +02:00
Bastien Nocera
b36924567e network: Remove support for firewalld zones
Firewalld is a Fedora-only daemon, and it doesn't integrate all that
well with Fedora Workstation, the version of Fedora that uses GNOME, so
remove the support.

In Fedora Workstation, firewalld only ever supports one zone, as the
other ones are badly defined, and not translatable or translated.
2017-04-13 10:23:39 +02:00
Emmanuele Bassi
e7d0716d14 display: Load appropriate assets for the night light panel
We hard-code a 16x16 asset for sunrise and sunset icons, which makes
them look blurry at higher scaling factors.

Let's look in the icon theme to see if there's an icon for sunrise and
sunset; if not, we can still use the assets we ship, but we also attempt
to load them from different resource paths, depending on the scale
factor.

We will need to update the assets to include a 32x32 rendering of the
sunrise and sunset icons.

https://bugzilla.gnome.org/show_bug.cgi?id=781029
2017-04-07 14:38:10 +01:00
Bastien Nocera
27a8ca6e02 sound: Memory leaks and Bluetooth handling fixes 2017-04-06 15:17:20 +02:00
Bastien Nocera
85cd910af5 datetime: 12h time format is now always available
Following a change in GDateTime, AM/PM format is now always available
even if the support is missing in the locale used.

Remove the code used to detect AM/PM support in the locale, and bump the
GLib requirements to the version that includes this GDateTime change.

See https://bugzilla.gnome.org/show_bug.cgi?id=761889

https://bugzilla.gnome.org/show_bug.cgi?id=780863
2017-04-03 11:32:43 +02:00
Mohammed Sadiq
fd5c0e8557 details: Split overview as a separate panel
The new shell design requires each panel to be separate.

This commit splits the overview page from details panel as a seperate
panel.

https://bugzilla.gnome.org/show_bug.cgi?id=779216
2017-03-29 17:36:02 -03:00
Felipe Borges
519e19f974 printers: Make actualize_printers_list cancellable
This way we can safely interrupt an update without crashing
g-c-c.

https://bugzilla.gnome.org/show_bug.cgi?id=780299
2017-03-28 18:04:56 +02:00
Rui Matos
3ab4b33390 keyboard: Fix check for existing shortcut settings
From a Coverity scan:

panels/keyboard/cc-keyboard-manager.c:208: unreachable: Since the loop
increment "i++;" is unreachable, the loop body will never execute more
than once.

This seems like a logic thinko introduced in commit
3207fe97ec . In practice it was unlikely
to be a problem since we don't have repeated shortcut gsettings key
names in all our KeyListEntries files.
2017-03-23 17:14:29 +01:00
Mario Sanchez Prada
b742936970 printers: Expose the newly added 'Clean' maintenance command to users
Add an extra button "Clean Print Heads" that will be shown when the relevant
maintenance command is available for a printer, to bring this feature back.

Additionally, this commit adds a 'parameters' attribute to PpMaintenanceCommand,
which is needed as the "Clean" command requires to at least be passed "all" as
its single parameter: https://www.cups.org/doc/spec-command.html#Clean

https://bugzilla.gnome.org/show_bug.cgi?id=764620
2017-03-23 13:30:22 +00:00
Ondrej Holy
c49d1ccb4a user-accounts: Fix widget alignment on add user dialog
Widgets on local and enterprise pages of add user dialog don't have
same width regardless of size groups. It is caused by different margins
and borders of various widgets. Let's change them to be like in mockup.

https://bugzilla.gnome.org/show_bug.cgi?id=778457
2017-03-22 14:49:45 +01:00
Ondrej Holy
a748d52b44 user-accounts: Unify row spacing
Commit 51a184b changed row spacing for local accounts, change that
also for enterprise part.

https://bugzilla.gnome.org/show_bug.cgi?id=778457
2017-03-22 14:37:44 +01:00
Ondrej Holy
932cdd38e9 user-accounts: Add missing widgets in size group
Some control widgets are missing in size group. Let's add them and also
allow hexpand for them.

https://bugzilla.gnome.org/show_bug.cgi?id=778457
2017-03-22 14:37:07 +01:00
Ondrej Holy
921ef1b1f6 user-accounts: Align "Enterprise login" toggle
The "Enterprise login" toggle should have bigger border as per mockup.
Let's increase it a bit.

https://bugzilla.gnome.org/show_bug.cgi?id=778457
2017-03-22 14:37:07 +01:00
Ondrej Holy
54c4dbb712 user-accounts: Align multiline labels
The multiline labels doesn't have xalign 0 and may look wrong. Align
the labels to reflect the mockup.

https://bugzilla.gnome.org/show_bug.cgi?id=778457
2017-03-22 14:35:26 +01:00
Bastien Nocera
7758b4258c privacy: Change references from xdg-app to flatpak 2017-03-18 03:36:42 +01:00
Bastien Nocera
6ab5552d59 network: Update wireless-security UI from network-manager-applet 2017-03-13 18:56:57 +01:00
Bastien Nocera
0470c040b1 network: Update wireless-security from network-manager-applet 2017-03-13 18:56:57 +01:00
Felipe Borges
909eb2ac31 printers: Make the dialogs independent of the PpPrinterEntry lifetime
https://bugzilla.gnome.org/show_bug.cgi?id=779846
2017-03-13 09:20:23 +01:00
Bastien Nocera
b4ac30b51e network: Simplify object destruction 2017-03-10 19:17:24 +01:00
Bastien Nocera
c7800dd22f network: Fix initial state of Wi-Fi device
This ensures that:
- the AP list shown on startup when the Hotspot is disabled on
  startup, or when disabling it at run-time
- the hotspot page is shown on startup when the Hotspot is enabled,
  or when it gets enabled at runtime

https://bugzilla.gnome.org/show_bug.cgi?id=705546
2017-03-10 19:17:19 +01:00
Bastien Nocera
7fbb1435a9 network: Remove use of temporary variable 2017-03-10 19:17:17 +01:00
Bastien Nocera
fe6e71198c network: Add checks for cancelled calls 2017-03-10 19:17:13 +01:00
Bastien Nocera
700e5e544c network: Save new SSID to disk before enabling the hotspot
Commit e824868 was supposed to do this, but needed to write the changes
out to disk before activating the hotspot.

https://bugzilla.gnome.org/show_bug.cgi?id=705546
2017-03-10 19:17:12 +01:00
Bastien Nocera
277ac7de02 network: Move hotspot connection search into a helper function
https://bugzilla.gnome.org/show_bug.cgi?id=705546
2017-03-10 19:17:08 +01:00
Allan Day
aa2b98b0ea printers: improve panel layout
Increase spacing in various places and reduce the icon size. This
makes spacing more even and makes the rows feels more open.

https://bugzilla.gnome.org/show_bug.cgi?id=779700
2017-03-10 16:22:08 +01:00
Bastien Nocera
5cccd1d544 universal-access: Handle "pixels" plural correctly
Using g_dngettext() as required.

https://bugzilla.gnome.org/show_bug.cgi?id=779798
2017-03-09 12:45:42 +01:00
Bastien Nocera
922c6588d3 universal-access: Add Cursor Size selection dialogue
The dialogue offers the 5 separate cursor sizes that adwaita's cursor
theme supports, aligned in a row.

The cursor sizes are described in a way that doesn't judge their
respective sizes, but simply describes them.

https://bugzilla.gnome.org/show_bug.cgi?id=608231
2017-03-08 14:47:52 +01:00
Bastien Nocera
75241454f0 universal-access: Add bits for glade to shut up 2017-03-07 12:04:00 +01:00
Bastien Nocera
e99d67442c universal-access: Don't use C++ style comments 2017-03-07 12:04:00 +01:00
Felipe Borges
1df4da54fc printers: Drop cups_get_jobs_async
pp_printer_get_jobs_async does the job with more modern GLib API
(GTask).

https://bugzilla.gnome.org/show_bug.cgi?id=779313
2017-03-06 16:07:07 +01:00
Felipe Borges
2ad93bc0b2 printers: Properly free pp_jobs_dialog
Since now we have proper async implementation for getting jobs, we
do not need to increment/decrement the objects ref_count manually.

https://bugzilla.gnome.org/show_bug.cgi?id=779313
2017-03-06 16:06:24 +01:00
Felipe Borges
c40772a862 printers: Port PpJobsDialog to pp_printer_get_jobs_async
https://bugzilla.gnome.org/show_bug.cgi?id=779313
2017-03-06 16:05:29 +01:00
Felipe Borges
1d0ae49685 printers: Introduce pp_printer_get_jobs_async ()
It is a PpPrinter method to query asychronously for printing jobs
information.

It should replace cups_get_jobs_async ()

https://bugzilla.gnome.org/show_bug.cgi?id=779313
2017-03-06 16:05:29 +01:00
Matthias Clasen
8b9be45cba notifications: Forward notification settings to portal
The flatpak notification portal reads permissions out
of the permission store, so forward the notification
permissions there in order to prevent sandboxed
applications from sending notifications.

The difference is a bit cosmetic, since the shell would
not show the notification anyway in this case, but it
is nicer to just cut off the calls and not let them
through the portal in the first place.

https://bugzilla.gnome.org/show_bug.cgi?id=778851
2017-03-02 16:40:33 -05:00