Commit graph

3654 commits

Author SHA1 Message Date
Bastien Nocera
a19c7ec977 network: Fix possible crash when wireless-enabled changes
The device we're handling might have disappeared already, but we're
listening on the NMClient object, which is still alive.

https://bugzilla.gnome.org/show_bug.cgi?id=735932
2014-09-03 18:04:58 +02:00
Bastien Nocera
15a98c3fd8 network: Show an error when we fail to turn off hotspot
And reset the switch as well. I don't know in which circumstance it
could happen, but it's all we can do for now.

https://bugzilla.gnome.org/show_bug.cgi?id=723643
2014-09-02 19:17:43 +02:00
Bastien Nocera
b108dedde6 network: Add hotspot_switch struct member
So we can access it directly when needed.
2014-09-02 19:17:43 +02:00
Bastien Nocera
cb93ad9782 network: Fix warning on startup with hotspot enabled
There's no back button anymore, so we shouldn't try to focus it.

Gtk-CRITICAL **: gtk_widget_grab_focus: assertion 'GTK_IS_WIDGET (widget)' failed
2014-09-02 19:11:43 +02:00
Bastien Nocera
df834ae74c network: Center "Wi-Fi hotspot" properties 2014-09-02 19:09:45 +02:00
Bastien Nocera
2ae2eabe2f datetime: Fix crash when setting year to 0
https://bugzilla.gnome.org/show_bug.cgi?id=735352
2014-09-01 14:43:51 +02:00
Bastien Nocera
4b04bc53fc privacy: Change the location label so it's short enough
And doesn't resize the shell width when switching panels.
2014-08-19 19:50:22 +02:00
Zeeshan Ali (Khattak)
7bcf4c189f privacy: Add location setting
For now its just a switch to enable/disable geolocation through
gnome-shell's setting. In future we'll hopefully at least have
controls to enable/disable geolocation for applications from here.

https://bugzilla.gnome.org/show_bug.cgi?id=731119
2014-08-19 19:03:52 +02:00
Christophe Fergeau
2dbcb26f16 keyboard: Use NULL rather than "" to disable keybindings
When disabling a keybinding, we set its value to { "", NULL } in gsettings
(bindings are stored as arrays of strings).
However, when a binding is disabled by default, its value is set to {
NULL }, not to the empty string.

The use of "" dates back to gconf where I think NULL was not a valid
value. Now that we have switched to gsettings, we can use NULL rather
than an artificial "".

https://bugzilla.gnome.org/show_bug.cgi?id=732383
2014-08-17 20:16:27 +02:00
Christophe Fergeau
ba9a8bc8ff keyboard: Add support for hidden keybinding XML data
If a KeyListEntry has a hidden="true" attribute, then the corresponding
binding information will be loaded as usual, but the binding won't be
displayed in the user interface.

This is useful as the keyboard panel will take into account hidden
keybindings when detecting conflicting shortcuts, or to suggest to set a
reverse shortcut.

For now, this will be used for the various reverse mutter keybindings
({switch,cycle}.*-backward) as they should not be shown in the UI, but
we still want the keyboard panel to know about them.

https://bugzilla.gnome.org/show_bug.cgi?id=731618
2014-08-17 20:16:27 +02:00
Christophe Fergeau
5572fb9a75 region: Remove "Shift" hack from region panel
The region panel hardcodes that to switch input source backward, one
uses the shift modfier with the shortcut to switch input source forward.

https://bugzilla.gnome.org/show_bug.cgi?id=731618
2014-08-17 20:16:27 +02:00
Christophe Fergeau
c77d164aa9 keyboard: Add 'reverse' metadata to switch-input-source shortcuts
Now that the keyboard panel knows how to handle reverse shortcuts, we
can start annotating the existing ones with the needed XML attributes.
This commit does that with switch-input-source{-backward}.
Note that some changes in some modules are needed for this to work
correctly.
In this case, a default value needs to be set for
switch-input-source-backward in gsettings-desktop-schemas, and the
Meta.KeyBindingFlags.REVERSED flag needs to be removed from the
shortcuts defined in gnome-shell source. Instead of having
mutter handle the reversion with 'shift' by itself, it's now handled
explicitly through gsettings keys.

https://bugzilla.gnome.org/show_bug.cgi?id=731618
2014-08-17 20:16:26 +02:00
Christophe Fergeau
5147cf2502 keyboard: Suggest to automatically set reverse bindings
Since we now know when a binding has a 'reverse' binding, we can now
suggest to update the 'reverse' shortcut when the user set a shortcut
for one of them.

https://bugzilla.gnome.org/show_bug.cgi?id=731618
2014-08-17 20:16:26 +02:00
Christophe Fergeau
f7c095bfe2 keyboard: Parse 'reverse' and 'is-reversed'
This commit adds support for 'reverse' and 'is-reversed' attributes when
parsing the KeyListEntry XML node.

https://bugzilla.gnome.org/show_bug.cgi?id=731618
2014-08-17 20:16:26 +02:00
Christophe Fergeau
f059f42487 keyboard: Add 'reverse' helpers to CcKeyboardItem
In order to handle shortcuts which can be reversed (for example,
super-space and shift-super-space to switch input methods
forward/backward), we are going to add new attributes to the xml files
describing the keyboard shortcuts to show in the panel.

This commit is a first step towards that and adds the notion of
'reverse' items to CcKeyboardItem.

We will then indicate in the xml description files that
'switch-input-source' is reversed by 'switch-input-source-backward' and
that 'switch-input-source-backward' reverses 'switch-input-source'.

https://bugzilla.gnome.org/show_bug.cgi?id=731618
2014-08-17 20:16:26 +02:00
Christophe Fergeau
10fd199b02 keyboard: Split accel_edit_callback
This function is getting a bit big, and the next commits will add more
code to it.

https://bugzilla.gnome.org/show_bug.cgi?id=731618
2014-08-17 20:16:26 +02:00
Ondrej Holy
3695f858dd user-accounts: use GtkStack instead of GtkNotebook in Add user dialog
https://bugzilla.gnome.org/show_bug.cgi?id=734422
2014-08-15 17:21:40 +02:00
Ondrej Holy
ed4653627b cc-editable-button: use GtkStack instead of GtkNotebook
https://bugzilla.gnome.org/attachment.cgi?bugid=694325
2014-08-15 17:12:30 +02:00
Bastien Nocera
71c76e9688 background: Make switcher button as tall as other buttons
https://bugzilla.gnome.org/show_bug.cgi?id=734803
2014-08-15 16:49:43 +02:00
Bastien Nocera
e397a8ab4e network: Build fixes
The WPA key size was missing, and we were comparing strings by pointer
address.
2014-08-15 16:18:47 +02:00
Stanislaw Gruszka
03bacf6f2c network: Create WPA protected AP hotspot if supported
Check if device supports AP mode hotspot with WPA/RSN (WPA2)
ciphers and set such mode and encryption if so.

http://bugzilla.gnome.org/show_bug.cgi?id=719852
2014-08-15 15:57:20 +02:00
Giovanni Campagna
9b364dfdfc search: add support for default disabled search providers
Search providers that should be disabled by default come with
a DefaultDisabled=true key in their keyfile, and are enabled
with the "enabled" whitelist, not with the "disabled" blacklist.

https://bugzilla.gnome.org/show_bug.cgi?id=734109
2014-08-15 14:46:47 +02:00
Kalev Lember
c5c870a558 keyboard: Port shortcuts tab to GtkGrid
https://bugzilla.gnome.org/show_bug.cgi?id=709057
2014-08-15 14:45:31 +02:00
Kalev Lember
c3d2631a9a keyboard: Port typing tab to GtkGrid
https://bugzilla.gnome.org/show_bug.cgi?id=709057
2014-08-15 14:45:31 +02:00
Kalev Lember
34d145b40d keyboard: Port custom shortcut dialog to GtkGrid
https://bugzilla.gnome.org/show_bug.cgi?id=709057
2014-08-15 14:45:31 +02:00
Ondrej Holy
0f3575b317 user-accounts: avoid removing non-existent GSources
Source id have to be zeroed correctly.

https://bugzilla.gnome.org/show_bug.cgi?id=734548
2014-08-14 13:51:56 +02:00
Bastien Nocera
d9d5124997 network: Don't stop validating when we get an error
The previous code would stop validating when an error occurred which
meant that when a page contained multiple errors, only the first one(s)
to be checked would appear in red.

Now, all the errors will appear in red.

https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 18:38:31 +02:00
Bastien Nocera
117cf30500 network: Fix compile-time warning
Missing include.

https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 18:38:31 +02:00
Debarshi Ray
fabc31b447 background: Clean up uses of GIcon
Now that we are compositing our own emblems, there is no need to use
GIcon. We can directly use GdkPixbufs everywhere.

https://bugzilla.gnome.org/show_bug.cgi?id=732375
2014-08-12 23:48:46 +02:00
Ondrej Holy
e4efd5eafd user-accounts: prefill domain entry
If we already have any configured realm, prefill one.

https://bugzilla.gnome.org/show_bug.cgi?id=711675
2014-08-09 14:33:16 +02:00
Ondrej Holy
608fa9609c user-accounts: fix enterprise toggle
Enterprise toggle isn't shown due to header bar buttons. Don't add
the toggle in to the dialog action area to fix the bug.

https://bugzilla.gnome.org/show_bug.cgi?id=734422
2014-08-09 14:33:12 +02:00
Bastien Nocera
62db29b387 network: Make broken configuration entries red
When a configuration setting is wrong, set the entry or file chooser
that contains the incorrect information to be surrounded by red.

This makes it easier for users to find where the error was made that
disallows them to click the "Apply" button.

https://bugzilla.gnome.org/show_bug.cgi?id=734446
2014-08-08 12:00:40 +02:00
Ondrej Holy
0002313af8 user-accounts: Add restart notification
Show restart notification when language is changed.

https://bugzilla.gnome.org/show_bug.cgi?id=703392
2014-08-07 13:55:37 +02:00
Felix Zhang
064cb89675 network: Fix typo in NetworkManager version checking
The code is meant to work with NetworkManager of version 0.9.0+ or 0.8.992+

https://bugzilla.gnome.org/show_bug.cgi?id=733309
2014-08-07 13:05:09 +02:00
Bastien Nocera
884bf3b2dc sharing: Make it possible to share remote folders
rygel can actually share media if the remote folder is mounted.
2014-08-07 13:05:01 +02:00
Ondrej Holy
08a00388be user-accounts: fix warning caused by invalid signal 2014-08-07 11:55:43 +02:00
Ondrej Holy
0aff10e509 user-accounts: allow password changing if old password is empty
https://bugzilla.gnome.org/show_bug.cgi?id=733619
2014-08-07 11:50:32 +02:00
Ondrej Holy
f904756f74 user-accounts: allow password changing if old password isn't set
https://bugzilla.gnome.org/show_bug.cgi?id=733619
2014-08-07 11:50:23 +02:00
Marek Kasik
4b64a64124 printers: Add test for canonicalize_device_name()
Add a test which tests function canonicalize_device_name() which
canonicalize name of printer model so it doesn't contain
unwanted strings/characters.
Test data are in canonicalization-test.txt file.

https://bugzilla.gnome.org/show_bug.cgi?id=695564
2014-07-31 11:44:17 +02:00
Marek Kasik
994bc0735a printers: Strip redundant strings from found devices
Remove strings like "foomatic", "series" from names of found devices.
Remove leading, trailing and recurrent dashes.

https://bugzilla.gnome.org/show_bug.cgi?id=695564
2014-07-31 11:44:17 +02:00
Marek Kasik
88fa618aca printers: Add function shift_string_left() and its test
shift_string_left() shifts given string by 1 character to the left.
test-shift.c tests whether function shift_string_left() works correctly.

https://bugzilla.gnome.org/show_bug.cgi?id=695564
2014-07-31 11:44:17 +02:00
Marek Kasik
b43f05f740 printers: Allow adding of JetDirect and LPD printers manually
Check the entered address for AppSocket/HP JetDirect and LPD printers.
If there is a printer found, it has a default name which
will be changed right after user selects model of the printer
in the PPD selection dialog.

https://bugzilla.gnome.org/show_bug.cgi?id=695564
2014-07-31 11:44:16 +02:00
Marek Kasik
7eded1afa5 printers: Add functions for searching for LPD printers
Add pp_host_get_lpd_devices_async() and
pp_host_get_lpd_devices_finish() functions to PpHost class.
pp_host_get_lpd_devices_async() starts searching for LPD printer
on given address.
The test consist in connection to the default port 515 (or the one
given by creator of PpHost) of the address and sending a print job
to it, which in turn returns a status (we test several standard
queue names).
We suppose that there is a LPD printer on the address if a buffer
with zero length is returned (rfc 1179 5.2).

https://bugzilla.gnome.org/show_bug.cgi?id=695564
2014-07-31 11:44:16 +02:00
Marek Kasik
89fe4eda12 printers: Allow to add AppSocket/HP JetDirect printers
Add pp_host_get_socket_devices_async() and
pp_host_get_socket_devices_finish() functions to PpHost class.
pp_host_get_socket_devices_async() starts searching for socket printer
on given address.
The test consist in connection to the default port 9100 (or the one
given by creator of PpHost) of the address.
We suppose that there is an AppSocket/HP JetDirect printer on the address
if the connection succeeds.

See these links for additional info:
http://en.wikipedia.org/wiki/JetDirect
http://www.cups.org/documentation.php/network.html

https://bugzilla.gnome.org/show_bug.cgi?id=695564
2014-07-31 11:44:16 +02:00
Marek Kasik
6576db1a16 printers: Make pp_devices_list_free() generally available
Move pp_devices_list_free() to pp-utils.h and optimize it
using g_list_free_full().

https://bugzilla.gnome.org/show_bug.cgi?id=695564
2014-07-31 11:44:16 +02:00
Marek Kasik
a15c2f831a printers: Don't request port during creation of PpHost
This allows us to distinguish between situations when the port
was specified and when it was not.

https://bugzilla.gnome.org/show_bug.cgi?id=695564
2014-07-31 11:44:16 +02:00
Marek Kasik
8331c88bcd printers: Export name of selected PPD from PPD dialog
Add pp_ppd_selection_dialog_get_ppd_display_name() function
which returns human-readable name of selected PPD.

https://bugzilla.gnome.org/show_bug.cgi?id=695564
2014-07-31 11:44:16 +02:00
Marek Kasik
375c5b0086 printers: Separate canonicalization of device name
Move code for canonicalization of device names to
a separate function for reusability.

https://bugzilla.gnome.org/show_bug.cgi?id=695564
2014-07-31 11:44:16 +02:00
Marek Kasik
190d27b8aa printers: Merge TDevice into PpPrintDevice
PpPrintDevice has grown quite a lot since its introduction.
It contains almost all members of TDevice now.
Merging members of TDevice into PpPrintDevice saves us some work
and allows us to process TDevice's data out of pp-new-printer-dialog.c.

https://bugzilla.gnome.org/show_bug.cgi?id=695564
2014-07-31 11:44:16 +02:00
Richard Hughes
e9b0527b4b color: Do not set the 'Details' button for virtual profiles
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1119408
2014-07-29 19:46:22 +01:00