When a new account is successfully added, simply close the dialog,
revealing it to be in the list of accounts, rather than showing
the account details.
closes#3067
Doing, so this will improve consistency as other places in
Settings use property rows [1]. This also ensures that the
network name doesn't get ellipsized if it's long when using
a narrow window width.
[1]
- feb2c8c514
- 5cd300c65a
- d5c66d25a0
Now that the search entry was put in a GtkSearchBar in [1],
the search entry got a bit smaller, breaking a little what
[2] fixed.
To fix this, remove the "maximum-size" and the
"tightening-threshold" from the AdwClamp that contains the
search entry. This will also make the search entry size to
be consistent with the one from cc-keyboard-shortcut-dialog,
which is also a top child of AdwToolbarView.
[1] cd97e4f518
[2] ec01b9d629
When the entry changes, it triggers the callback dance to store the
values in the backend. Causing `gtk_editable_set_text` to be essentially
called every REMOTE_DESKTOP_STORE_CREDENTIALS_TIMEOUT_S seconds (2
seconds) even when credentials have changed. This call has visual
effects, such as moving the cursor caret and changing the entry
selection state.
Fixes#3077
Also:
- Remove "select_from_database_button" and "install_ppd_button"
object IDs, as they are unused by the C code.
- Remove the default-height from the window to avoid showing an
unnecessary scrollbar now that the AdwButtonRows takes more vertical
space
The goal here is to avoid the dialog and follow a pattern of subpages we
have in other panels.
This dialog is often launched from Nautilus over the
`gnome-control-center search locations` launching argument, making it
even worse as a dialog.
[1] replaced the "Add Folder" a11y label by a tooltip.
However, this doesn't work and Orca doesn't read the row
properly; it simply says "not selected". The a11y label
already didn't work prior to [1].
To fix this, transform the tooltip into a GtkLabel. Also,
make the row to have the same padding so it's consistent
with the "Add Input Source..." row from Keyboard > Input
Methods.
[1] 00d9cd012f
Add a shortcut to open the Public folder in the File Sharing dialog,
as this folder is crucial for the file sharing functionality. Also,
this change improves the discoverability of that folder and offers a
convenience of opening it directly from the dialog.
AdwStatusPage can't be used with other widgets because it
contains a GtkScrolledWindow, so mimic AdwStatusPage to
show Wi-Fi Hotspot status.
Also:
- Add a mnemonic to the "Turn Off Hotspot..." button.
- Use the new strings from the latest mockups [1]
[1] cfb7cae4a9
When closing the lid on a laptop, the number of active monitors drops to
zero. However, `monitor_labeler_show()` always assumes at least one
monitor is active, as it unconditionally closes the `GVariantBuilder`.
This causes a crash when there is no monitor added to the
`GVariantBuilder`, however, as no value was added to it.
Instead, only close the `GVariantBuilder` when we're actually going to
use it and know a value was added.
Commit ca9228bb fixed a similar crash for when there are no outputs at
all. But in this case, there is still an output, it is just not active,
only with the active UI number as 0.
Fixes#3058
When resizing the parent window to its minimum size, the QR
code from the Share Network dialog becomes so small that it
can't be read. This regression appeared with the port to
AdwDialog.
To fix this, add min-width/height properties to the QR code
image and use a GtkScrolledWindow to make the dialog contents
scrollable.
Both AdwStatusPage and AdwPreferencesPage have a GtkScrolledWindow.
This can cause scrolling to break. To fix this, separate both widgets
into their own stack pages.
Also, remove "app_search_stack_page" object ID, as it's unused by the
C code.
Doing so, the search entry won't get hidden when scrolling
through the app list. This is neeeded to stop using the
"No Apps Found" together with AdwPreferencesPage, because
both widgets have a GtkScrolledWindow; this can cause
scrolling to break.
- Use modern widgets like AdwPreferencesPage/Group,
AdwEntryRow and AdwPropertyRow
- Set a minimum size for the window
- Add .error class to the printer name entry
when the name is invalid
- Restyle the printer name error message
- Add missing mnemonics
- Remove the "run_warning" method, as it's no longer needed
now that all AdwAlertDialogs are located in the .ui file
- Remove "clear_recent_button" object ID, as it's unused by
the C code
Also:
- Move the dialog to the .ui file, as this dialog is UI-related
- Don't destroy/force close the dialog, as it will be closed
automatically after the responses are triggered
Also:
- Move the dialog to the .ui file, as this dialog is UI-related
- Don't destroy/force close the dialog, as it will be closed
automatically after the responses are triggered
Also:
- Move the dialog to the .ui file, as this dialog is UI-related
- Don't destroy/force close the dialog, as it will be closed
automatically after the responses are triggered
Require the use of <child type="subpage"> for when an AdwNavigationPage
is expected to be added to CcPanel.navigation.
This way we can avoid programming errors when a child widget is wrongly
packed in the navigation view.
See also https://gitlab.gnome.org/GNOME/gnome-control-center/-/wikis/shell/CcPanel#child-packing
Co-authored-by: Matthijs Velsink <mvelsink@gnome.org>
