Commit graph

573 commits

Author SHA1 Message Date
Bastien Nocera
e397a8ab4e network: Build fixes
The WPA key size was missing, and we were comparing strings by pointer
address.
2014-08-15 16:18:47 +02:00
Stanislaw Gruszka
03bacf6f2c network: Create WPA protected AP hotspot if supported
Check if device supports AP mode hotspot with WPA/RSN (WPA2)
ciphers and set such mode and encryption if so.

http://bugzilla.gnome.org/show_bug.cgi?id=719852
2014-08-15 15:57:20 +02:00
Bastien Nocera
d9d5124997 network: Don't stop validating when we get an error
The previous code would stop validating when an error occurred which
meant that when a page contained multiple errors, only the first one(s)
to be checked would appear in red.

Now, all the errors will appear in red.

https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 18:38:31 +02:00
Bastien Nocera
117cf30500 network: Fix compile-time warning
Missing include.

https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 18:38:31 +02:00
Bastien Nocera
62db29b387 network: Make broken configuration entries red
When a configuration setting is wrong, set the entry or file chooser
that contains the incorrect information to be surrounded by red.

This makes it easier for users to find where the error was made that
disallows them to click the "Apply" button.

https://bugzilla.gnome.org/show_bug.cgi?id=734446
2014-08-08 12:00:40 +02:00
Felix Zhang
064cb89675 network: Fix typo in NetworkManager version checking
The code is meant to work with NetworkManager of version 0.9.0+ or 0.8.992+

https://bugzilla.gnome.org/show_bug.cgi?id=733309
2014-08-07 13:05:09 +02:00
Bastien Nocera
36dc06fd97 network: Add DNS to the keywords
https://bugzilla.gnome.org/show_bug.cgi?id=733763
2014-07-26 15:56:25 +02:00
Bastien Nocera
1fe3d1fe1c network: Remove "..." from dialogue titles
https://bugzilla.gnome.org/show_bug.cgi?id=696845
2014-07-24 13:19:09 +02:00
Bastien Nocera
3de071f8e3 network: Fix network icon names for newer versions
network-wireless-signal-excellent and network-cellular-signal-excellent
don't exist in non-symbolic variants anymore, so use the fallback
names instead.

https://bugzilla.gnome.org/show_bug.cgi?id=695480
2014-07-24 13:00:35 +02:00
Christophe Fergeau
32d2058ecd network: Use AM_CPPFLAGS rather than INCLUDES
This is deprecated in newer automake versions, and this causes warnings
with automake 1.14:
panels/printers/Makefile.am:3: warning: 'INCLUDES' is the old name for
AM_CPPFLAGS' (or '*_CPPFLAGS')

https://bugzilla.gnome.org/show_bug.cgi?id=732189
2014-06-25 12:32:28 +02:00
Bastien Nocera
55fe239e99 network: Use new listbox helpers
https://bugzilla.gnome.org/show_bug.cgi?id=732106
2014-06-24 11:35:31 +02:00
Giovanni Campagna
39857522e7 network: fix invalid GSettings path
GSettings/dconf paths must end with a slash.

https://bugzilla.gnome.org/show_bug.cgi?id=731775
2014-06-17 17:55:58 +02:00
Bastien Nocera
ddc35609bd network: Hide the Virtualisation bridge
There's no need for anyone to poke at the libvirt bridge that's not an
admin. It should probably be locked down more as well, but that would be
NetworkManager's business.
2014-05-19 17:55:47 +02:00
Bastien Nocera
b98f29d1a9 network: Fix warning on startup
c5b70a7876 removed all the unused top
level windows in the UI files, but net-virtual-device.c was forgotten.
2014-04-29 11:09:03 +02:00
Matthias Clasen
4ad99703ac network: don't pretend we can overrule hw rfkill
If the airplane mode is forced by the hw switch, make the switch
in the network panel insensitive, so we don't give the wrong
impression.

https://bugzilla.gnome.org/show_bug.cgi?id=728511
2014-04-22 09:53:56 -04:00
Giovanni Campagna
41b33dc839 network: allow an empty gateway address in the connection editor
It appears that this has always been the intention of the code,
but the check was incomplete.

https://bugzilla.gnome.org/show_bug.cgi?id=724312
2014-02-18 09:48:17 +01:00
Giovanni Campagna
8b6f9afb72 network: don't warn for invalid settings
g_warning() is for environment errors, not user errors. Not being
able to click OK is enough to understand that something is wrong,
and if not we should highlight the faulty setting, not spam the logs,
expecially in the middle of digitation. Keep a log anyway, for
debugging.

https://bugzilla.gnome.org/show_bug.cgi?id=724312
2014-02-18 09:48:17 +01:00
Bastien Nocera
f31dbd0271 network: Fix build with NM 0.9.8.x
Team support was only added in the 0.9.9.x branch for the 0.9.10
stable release. It's not available in any releases (beta or stable
ones) yet.

https://bugzilla.gnome.org/show_bug.cgi?id=723769
2014-02-18 09:48:17 +01:00
Giovanni Campagna
741f09f6f4 network: handle argv after cold-plugging connections
To pick up show-device with a connection path (VPN or virtual),
we need to handle the arguments again after the connections are
read.

https://bugzilla.gnome.org/show_bug.cgi?id=724547
2014-02-17 21:02:17 +01:00
Giovanni Campagna
10ffa301b7 network: allow selecting a specific VPN or virtual interface
Overload the show-device operation to accept paths to NMConnections,
which can be matched to VPN connections or unadopted virtual
interfaces.
This will be used by gnome-shell to implement the VPN Settings
menu item.

https://bugzilla.gnome.org/show_bug.cgi?id=724547
2014-02-17 21:02:17 +01:00
Daniel Mustieles
2c5951819d Updated FSF's address 2014-01-29 11:27:38 +01:00
Jiří Klimeš
db34d8af63 network: make "(none)" slaves (bond, team, bridge) translatable
Signed-off-by: Jiří Klimeš <jklimes@redhat.com>

https://bugzilla.gnome.org/show_bug.cgi?id=720312
2014-01-10 15:14:12 +01:00
Jiří Klimeš
c2c3ccb04e network: add Team to connection editor (rh #1040525)
https://bugzilla.redhat.com/show_bug.cgi?id=1040525
Signed-off-by: jirka <jirka@localhost.localdomain>

https://bugzilla.gnome.org/show_bug.cgi?id=720312
2014-01-10 15:14:12 +01:00
Frédéric Péters
5e35864e28 network: hide hotspot dialog on Escape
https://bugzilla.gnome.org/show_bug.cgi?id=721163
2014-01-08 14:23:02 +01:00
Frédéric Péters
cde472b6b2 network: give an empty title to the hotspot dialog
The hotspot dialog didn't specify a title at all, and that meant
"gnome-control-center" displayed was used as title.

https://bugzilla.gnome.org/show_bug.cgi?id=721162
2014-01-08 14:23:02 +01:00
Bastien Nocera
40f10f13e6 network: Fix warnings setting mnemonics
Introduced in b5d03b42a0
2013-12-17 11:37:15 +01:00
Vadim Rutkovsky
b5d03b42a0 networking: set mnemonic widget for labels and values in connection details
https://bugzilla.gnome.org/show_bug.cgi?id=719986
2013-12-09 13:45:36 +01:00
Yosef Or Boczko
d4ef801743 network: Use margin-start/end instead of margin-left/right
https://bugzilla.gnome.org/show_bug.cgi?id=712661
2013-11-19 22:26:49 +02:00
Jasper St. Pierre
dd52ac9417 Add NoDisplay to all gnome-control-center panel .desktop files
These aren't apps -- they're simply launchers for gnome-control-center.
They should not be shown as apps in the UI at all.

https://bugzilla.gnome.org/show_bug.cgi?id=712246
2013-11-15 08:44:53 -05:00
Bastien Nocera
b921ce215f network: Only start the spinner when we can stop it
https://bugzilla.gnome.org/show_bug.cgi?id=709555
2013-10-07 18:31:59 +02:00
Bastien Nocera
57b64368ef network: Merge two similar functions
Merge connection_add_activate_cb() and connection_activate_cb(),
the code is too similar.

https://bugzilla.gnome.org/show_bug.cgi?id=709555
2013-10-07 16:58:19 +02:00
Bastien Nocera
3c1b58ab2a network: Fix warnings when clicking Wi-Fi network
Those 2 widgets (the edit page, and the spinner) might be available
but we need to read about them from the correct widget, eg. the
GtkListBoxRow, not the GtkBox it contains.

https://bugzilla.gnome.org/show_bug.cgi?id=709555
2013-10-07 16:51:03 +02:00
Bastien Nocera
ce8c2eb6f6 network: Fix run-time warning
The "edit" widget is only set as data when there is a connection
(in make_row) so only hide it when there is a connection.

https://bugzilla.gnome.org/show_bug.cgi?id=709555
2013-10-07 16:51:03 +02:00
Gary Ching-Pang Lin
fc181a2d64 network: Use the parameters property for 8021x
The argv property was deprecated. This commit converts the 8021x
settings to the parameters property so that the user is able to
setup the 8021x connections.

https://bugzilla.gnome.org/show_bug.cgi?id=709545
2013-10-07 16:50:13 +02:00
Rui Matos
fb9d98bff1 network: Update forget button sensitivity when rows are destroyed
Doesn't make sense to keep it sensitive after the dialog returns OK.

This also avoids using finalized objects if the forget button is
clicked after some previously checked rows were destroyed because
their connection got removed elsewhere.

https://bugzilla.gnome.org/show_bug.cgi?id=709118
2013-10-01 15:09:38 +02:00
Rui Matos
22ff598b78 network: Destroy connection row widget when connection is removed
Otherwise all sorts of crashes may happen if it's interacted with.

https://bugzilla.gnome.org/show_bug.cgi?id=709104
2013-10-01 15:09:37 +02:00
Rui Matos
1650293719 network: Get the correct widget holding the "connection" object data
The check button isn't a direct child of the GtkListBoxRow instance
that contains the "connection" object data so we are adding the wrong
widget to the "rows" list which then gives us a NULL for "connection"
in really_forget() and making us fail to remove the connection.

https://bugzilla.gnome.org/show_bug.cgi?id=709091
2013-10-01 15:09:36 +02:00
Rui Matos
b68f7421c6 network: Just dismiss forget dialog if response is not OK
If the dialog is deleted, for instance, we don't want to take that as
OK.

https://bugzilla.gnome.org/show_bug.cgi?id=709091
2013-10-01 15:09:34 +02:00
Rui Matos
e0583d0c0a network: Remove an unused dialog
https://bugzilla.gnome.org/show_bug.cgi?id=708286
2013-10-01 10:05:03 +02:00
Rui Matos
2d18798d79 network: Don't leak a builder instance
https://bugzilla.gnome.org/show_bug.cgi?id=708286
2013-10-01 10:05:03 +02:00
Rui Matos
db62c4f8e6 network: Don't leak a couple of dialogs
https://bugzilla.gnome.org/show_bug.cgi?id=708286
2013-10-01 10:05:03 +02:00
Rui Matos
c5b70a7876 network: Remove unused toplevel windows from .ui files
https://bugzilla.gnome.org/show_bug.cgi?id=708286
2013-10-01 10:05:02 +02:00
Rui Matos
fecc2eca87 network: Correctly unref NetDevice instances when needed
We have to take the GtkListStore own reference into account.

https://bugzilla.gnome.org/show_bug.cgi?id=708468
2013-10-01 10:01:24 +02:00
Rui Matos
d8bfc9e937 network/net-device-ethernet: Disconnect from NMConnection signals
Otherwise we'll crash in our handler if the signal fires after we're
finalized i.e. user leaves the network panel.

https://bugzilla.gnome.org/show_bug.cgi?id=708468
2013-10-01 10:01:24 +02:00
Rui Matos
0f64dd1a11 network: Fix empty ignore-hosts setting
If the ignore-hosts setting is set to an empty array we were using
unintialized memory.

This also now ignores zero length strings if there are any in the
array.

https://bugzilla.gnome.org/show_bug.cgi?id=707966
2013-09-13 13:22:58 +02:00
Rui Matos
fb74444eec network: Don't include spaces in proxy's ignore-hosts setting
We should also ignore any zero length strings resulting from
g_strsplit_set().

https://bugzilla.gnome.org/show_bug.cgi?id=707966
2013-09-13 13:22:56 +02:00
Rui Matos
aee3f9d82d network: Remove a spurious signal handler
https://bugzilla.gnome.org/show_bug.cgi?id=707906
2013-09-11 16:46:35 +02:00
Kalev Lember
f8f420256b network: Fix a possible crash with no active connections
As a precaution, check the return value of get_active_connections to
avoid dereferencing a NULL pointer.

https://bugzilla.redhat.com/show_bug.cgi?id=990196
https://bugzilla.gnome.org/show_bug.cgi?id=707906
2013-09-11 16:22:01 +02:00
Dan Winship
fea9da1b2e network: don't show unmanaged devices
And in particular, in NM 0.9.10, don't show NM_DEVICE_TYPE_GENERIC
devices.

https://bugzilla.gnome.org/show_bug.cgi?id=706868
2013-09-10 15:54:30 -04:00
Debarshi Ray
0c1ac731ff network: Silence compiler warning
Use an explicit typecast from gpointer to const gchar **.
2013-09-09 16:17:56 +02:00