Commit graph

43 commits

Author SHA1 Message Date
Robert Ancell
7d9d4d4289 network: Convert WirelessSecurity objects into GtkTemplates 2020-01-31 14:13:15 +00:00
Robert Ancell
d4ec8a570b network: Convert WirelessSecurity into an interface 2020-01-31 14:13:15 +00:00
Robert Ancell
b964283fb0 network: Refactor how username/passwords are retained when switching EAP methods
This was previously done by storing the value inside the WirelessSecurity class.
This stopped the subclasses from becoming Gtk widgets.

The "always_ask" code was removed as it didn't seem to actually retain when
switching. This might need to be fixed at a later time.
2020-01-31 14:13:15 +00:00
Robert Ancell
bd7491bc5c network: Move common code to common location
Remove duplicate header file for these functions
2019-11-27 22:05:46 +00:00
Robert Ancell
f63ac35b41 network: Remove unnecessary nm-default.h 2019-11-27 22:05:46 +00:00
Robert Ancell
8bcc2f811a network: Move helper function with other helper code 2019-11-27 22:05:46 +00:00
Robert Ancell
f75affbfe0 network: Copy shared functions into the two cases it is used
This does increase duplication, but should be reduced in following refactoring.
2019-11-27 22:05:46 +00:00
Robert Ancell
737e5829d6 network: Move private defines out of public header 2019-11-27 22:05:46 +00:00
Robert Ancell
f806854560 network: Remove a helper function
This makes more sense to be in the two cases it is used. It should be refactored away in the future.
2019-11-27 22:05:46 +00:00
Robert Ancell
131e89e690 network: Split up a combined setter into multiple methods 2019-11-27 22:05:46 +00:00
Robert Ancell
e5ae62a6a3 network: Convert WirelessSecurity property to a virtual method 2019-11-27 22:05:46 +00:00
Robert Ancell
125d971ebe network: Replace a callback with a signal 2019-11-27 22:05:46 +00:00
Robert Ancell
3d06da2d30 network: Convert WirelessSecurity into a GObject 2019-11-27 22:05:46 +00:00
Robert Ancell
4b182dd7c0 network: Move GtkBuilder code from WirelessSecurity to subclasses 2019-11-27 22:05:46 +00:00
Robert Ancell
0f1cff9130 network: Convert EAPMethod classes to GtkTemplates 2019-11-27 22:05:46 +00:00
Robert Ancell
2e8226a09c network: Move EAPMethod property to a virtual method 2019-11-27 22:05:46 +00:00
Robert Ancell
b936955ff3 network: Access widgets via a virtual method, not the GtkBuilder IDs 2019-11-27 22:05:46 +00:00
Robert Ancell
6d35ec3160 network: Fix up header includes 2019-11-27 22:05:46 +00:00
Robert Ancell
0478abe46c network: Remove unused hotspot_compatible property 2019-11-27 22:05:46 +00:00
Robert Ancell
08b922f09d network: Merge public method that is only used internally once 2019-11-27 22:05:46 +00:00
Robert Ancell
ac566aaaf3 network: Remove unused function 2019-11-27 22:05:46 +00:00
Robert Ancell
1c2d2ca79b network: Simplify helper 2019-11-27 22:05:46 +00:00
Robert Ancell
08b26a93a7 network: Simplify helper functions 2019-11-27 22:05:46 +00:00
Robert Ancell
69a5b8750b network: Simplify helper function 2019-11-27 22:05:46 +00:00
Robert Ancell
f2111a85f5 network: Simplify helper function 2019-11-27 22:05:46 +00:00
Robert Ancell
0189d5001f network: Make function for common code 2019-11-27 22:05:46 +00:00
Robert Ancell
6ab75da5c6 network: Use g_clear_pointer 2019-11-06 10:16:20 +13:00
Robert Ancell
708b1fdaf7 network: Use self variable name consistently 2019-10-22 20:11:45 +00:00
Robert Ancell
8a3da8b36d network: Remove shared callback and replace with a method 2019-10-22 20:11:44 +00:00
Robert Ancell
37187db328 network: Remove unused virtual method 2019-10-22 20:11:44 +00:00
Robert Ancell
150e7902e6 network: Refactor widget reference out using virtual method 2019-10-22 20:11:44 +00:00
Robert Ancell
4955371660 network: Pass widget references rather than relying on names
The existing code relied on using GtkBuilder, which will no longer work when we
switch to GtkTemplate.
2019-10-22 20:11:44 +00:00
Robert Ancell
823a1dbdaa network: Make public struct private 2019-10-22 20:11:44 +00:00
Robert Ancell
a41ad90671 network: Remove unused field 2019-10-22 20:11:44 +00:00
Robert Ancell
e70610fe74 network: Use g_autoptr for unref code 2019-09-13 14:20:50 +12:00
Robert Ancell
01190db349 network: Use g_autoptr for GError handling 2019-09-13 14:20:50 +12:00
Bastien Nocera
7289e21ef1 network: Fix crash due to object name clashes in NM and g-c-c
1. open Wi-Fi Settings
2. Menu -> Known Wi-fi Networks
3. Click settings of some Wi-Fi network listed there.
4. Press escape twice to close all the dialogs
5. Menu -> Connect to Hidden network..,

Fix crashes when some object type names (WirelessSecurity and
EAPMethod in this case) are duplicated across the Network
panel and libnma.

Fixes a regression in commit 0470c04

https://bugzilla.gnome.org/show_bug.cgi?id=785099
2018-03-12 14:27:18 +01:00
Georges Basile Stavracas Neto
21943a42bf network: Ensure WirelessSecurity type is initialized
When calling for the wireless security widgets, the code
simply assumes that the corresponding GType is initialized.
This may not always be true, which leads to a nasty crash
every time e.g. we open the network connection editor dialog.

This commit fixes that by introducing a new standard macro
wrapping wireless_security_get_type(), and ensuring the type
is initializing when calling wireless_security_init(), thus
protecting every code path from this crash.

This commit also makes CePageSecurity use the new macro for
better legibility.

https://bugzilla.gnome.org/show_bug.cgi?id=785581
2017-08-09 19:32:43 +02:00
Bastien Nocera
0470c040b1 network: Update wireless-security from network-manager-applet 2017-03-13 18:56:57 +01:00
Bastien Nocera
92b044ba7f network: Update wireless-security from network-manager-applet 2016-06-07 13:11:07 +02:00
Bastien Nocera
9183d34947 network: Port to libnm 1.2
We also remove support for WiMAX (now unsupported by NetworkManager),
and InfiniBand (Enterprise feature), and the use of
the deprecated NM_SETTING_WIRELESS_SEC property.

With help from network-manager-applet patches by Jiří Klimeš and
Dan Winship.

https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-05-27 18:23:33 +02:00
Giovanni Campagna
d59a1b068f network: properly namespace wireless security boxed types
These types appear with the same name in libnm-gtk, but they're
not shared because they come from different code, so they
need namespacing.
This prevents a crash that happens if you open a wifi property
dialog and then click "Connect to hidden network"

https://bugzilla.gnome.org/show_bug.cgi?id=700137
2013-05-13 21:42:09 +02:00
Matthias Clasen
e5cc7d8011 network: Break out wifi details code and add editing support
This code is fairly independent of the rest, and we don't want
net-device-wifi.c to become too massive and unmaintainable.

The code in connection-editor/ is fairly similar to
nm-connection-editor, with some simplification because we
currently only edit wireless connections.

The code in wireless-security/ is almost a straight copy
of the same code in nm-connection-editor, with some changes
to the .ui files to make them fit better in the new design.
2013-01-30 13:05:33 -05:00