There's only one instance of this pattern - make the function specific
to that case rather than generic.
The current code is leaking the Label2Data struct and the GSettings
signal connection. The leak of the signal connection was causing a crash
in case the callback was called after the label was destroyed. Instead
of just directly fixing these problems, let's eliminate the intermediate
struct and just support the specific case we're interested in directly.
The location support in flatpak is changing with the
next releases of geoclue and xdg-desktop-portal, and
the permission table is changing as well. Adapt to these
changes.
This may need some version check, or migration.
Switch from GtkBuilder to using GtkTemplate.
Rename widget IDs to be more readable.
Drop widget IDs that are not used.
Move code into the .ui file that can be.
Doing:
typedef struct _NMClient NMClient;
when there's no NMClient available barely makes the code more readable,
and doesn't clear show when it would be used.
https://bugzilla.gnome.org/show_bug.cgi?id=737362
NetworkManager supports toggling the periodic network check,
a check that by itself can be a security threat since it leaks
information about the host.
This patch adds a periodic network check toggle to the Privacy
panel. This is only enabled when a recent enough NetworkManager
is supported.
https://bugzilla.gnome.org/show_bug.cgi?id=737362
While it isn't possible, or even advisable, to make all the list
box rows the same height, using a number of standard heights will
make the control center feel more harmoneous.
Adust the height of the list box rows in Color, Date & Time,
Mouse & Touchpad, Network, Privacy, Region & Language, Sharing
and Universal Access. Makes standard rows that contain labels
and/or controls 58px tall. Some other rows, such as those which
contain two lines of text, are allowed to be taller.
https://bugzilla.gnome.org/show_bug.cgi?id=786384
Unquote the distribution name and the privacy policy url in
the Problem Reporting dialogue, as those can be shell-quoted (the format
used by /etc/os-release is "shell-compatible").
https://bugzilla.gnome.org/show_bug.cgi?id=770260
Currently if control-center is already running with privacy panel in
foreground and user authorizes a new application to gain access to
location information from gnome-shell dialog, this change doesn't get
reflected in the privacy panel to user until they exit privacy panel.
This change fixes this by reacting to changes to permissions store.
https://bugzilla.gnome.org/show_bug.cgi?id=765006
Latest gnome-shell (3.19.91) now asks user if they'd want to allow the
application to gain access to their location information when an
application tries to access this information. The user's choice is saved
in xdg-app's permission store and user can no longer can change their
mind about this later on. Hence the need to provide these per-application
controls in control-center.
https://bugzilla.gnome.org/show_bug.cgi?id=761245
For now its just a switch to enable/disable geolocation through
gnome-shell's setting. In future we'll hopefully at least have
controls to enable/disable geolocation for applications from here.
https://bugzilla.gnome.org/show_bug.cgi?id=731119
Our loop to set the combo box to the current value of
recent-files-max-age didn't work properly for the negative (and default)
-1 value that means "Forever". This fixes the default display value.
https://bugzilla.gnome.org/show_bug.cgi?id=703359