Commit graph

55 commits

Author SHA1 Message Date
Robert Ancell
b331d75df5 network: Rename widget IDs to standard names 2019-10-22 20:11:45 +00:00
Robert Ancell
53f9249b83 network: Remove unused GtkBuilder IDs 2019-10-22 20:11:45 +00:00
Robert Ancell
879542d92b network: Merge duplicate signal handlers 2019-10-22 20:11:45 +00:00
Robert Ancell
54f8fce47f network: Connect signals in swapped form 2019-10-22 20:11:44 +00:00
Robert Ancell
4b9d8ac058 network: Move non-shared code into the one module that uses it 2019-10-22 20:11:44 +00:00
Robert Ancell
8a3da8b36d network: Remove shared callback and replace with a method 2019-10-22 20:11:44 +00:00
Robert Ancell
f556af6e67 network: Move includes to correct file locations 2019-10-22 20:11:44 +00:00
Robert Ancell
37187db328 network: Remove unused virtual method 2019-10-22 20:11:44 +00:00
Robert Ancell
150e7902e6 network: Refactor widget reference out using virtual method 2019-10-22 20:11:44 +00:00
Robert Ancell
4955371660 network: Pass widget references rather than relying on names
The existing code relied on using GtkBuilder, which will no longer work when we
switch to GtkTemplate.
2019-10-22 20:11:44 +00:00
Robert Ancell
823a1dbdaa network: Make public struct private 2019-10-22 20:11:44 +00:00
Robert Ancell
bf43c64b63 network: Remove unused callback type 2019-10-22 20:11:44 +00:00
Robert Ancell
a41ad90671 network: Remove unused field 2019-10-22 20:11:44 +00:00
Robert Ancell
96bd167b77 network: Replace deprecated GtkTable with GtkGrid 2019-10-22 20:11:44 +00:00
Robert Ancell
84c53b01c5 network: Remove unused GtkNotebooks
The security widgets were inside GtkNotebooks, but only ever had one page and
tabs hidden. So they weren't doing anything.
2019-10-22 20:11:44 +00:00
Robert Ancell
6d7e552ae1 network: Remove hidden notebook tabs from GtkBuilder files
These tabs are never shown and many were marked for translation.
2019-09-30 16:10:09 +13:00
Robert Ancell
e70610fe74 network: Use g_autoptr for unref code 2019-09-13 14:20:50 +12:00
Robert Ancell
1083368008 network: Fix NetworkManager includes 2019-09-13 14:20:50 +12:00
Robert Ancell
de84f7e344 network: Use g_autofree for strings 2019-09-13 14:20:50 +12:00
Robert Ancell
01190db349 network: Use g_autoptr for GError handling 2019-09-13 14:20:50 +12:00
Robert Ancell
c27d26e0eb network: Fix GError leaks 2019-09-13 14:15:19 +12:00
Jonathan Kang
6f3c3f6f6d network: disable the "Apply" button until a change has been made
Previously, when you open the connection editor dialog for each
connection, no matter whether you've made any changes or not, the
"Apply" button became sensetive, which is not what we expected.

Fix that by removing the unnecessary call to password_storage_changed()
while constructing the security tab.
2019-09-09 22:38:44 +00:00
Markus Theil
04f3264c6a network/eap-method-ttls: add domain match
As it is often not sufficient to only check against
a set of known CA certificates, add a domain suffix
check for Wi-Fi connections.

Signed-off-by: Markus Theil <theil.markus@gmail.com>
2019-07-15 15:02:32 +12:00
Bastien Nocera
4663ba2fac network: Fix crash opening "Hidden network" dialogue
Both the Network panel and libnma expect UI resources in the
same location, which will cause problems when the Network panel loads
its own version that doesn't quite match up to the code used in libnma.

This fixes a crash when nma_wifi_dialog_new_for_hidden() is called and
libnma expects a domain widget to be present, which it isn't in our
version of the UI files.

https://bugzilla.gnome.org/show_bug.cgi?id=785099
2018-03-12 14:39:10 +01:00
Bastien Nocera
7289e21ef1 network: Fix crash due to object name clashes in NM and g-c-c
1. open Wi-Fi Settings
2. Menu -> Known Wi-fi Networks
3. Click settings of some Wi-Fi network listed there.
4. Press escape twice to close all the dialogs
5. Menu -> Connect to Hidden network..,

Fix crashes when some object type names (WirelessSecurity and
EAPMethod in this case) are duplicated across the Network
panel and libnma.

Fixes a regression in commit 0470c04

https://bugzilla.gnome.org/show_bug.cgi?id=785099
2018-03-12 14:27:18 +01:00
Georges Basile Stavracas Neto
a124a233ea network: Replace GtkVBox with GtkBox
GtkVBox is deprecated, and GtkBox with the vertical
orientation has the exact same layout.
2018-01-26 22:25:18 -02:00
Georges Basile Stavracas Neto
dc5bf7e658 network: Undo accidentally changed string
A colon was added but not spotted on time.

https://bugzilla.gnome.org/show_bug.cgi?id=787882
2018-01-26 22:19:11 -02:00
Jonathan Kang
81b68bc6ed wifi: Use GtkGrid for Wi-Fi Security settings page
GtkTable is deprecated. Use GtkGrid instead.

https://bugzilla.gnome.org/show_bug.cgi?id=787882
2018-01-26 21:17:47 -02:00
Iñigo Martínez
dc0988d47c build: Remove autotools
To avoid the burden of maintaining multiple build systems, this
patch removes autotools support.

https://bugzilla.gnome.org/show_bug.cgi?id=785414
2018-01-18 12:20:08 +01:00
Iñigo Martínez
32edd6789e build: Port to meson build system
Meson is a build system focused on speed an ease of use, which
helps speeding up the software development. This patch adds meson
support along autotools.

https://bugzilla.gnome.org/show_bug.cgi?id=785414
2018-01-17 20:09:35 -02:00
Rui Matos
8ae6950248 network/eap-method-tls: Don't require a private key password
The private key may be unencrypted or we might want to enable "always
ask".

https://bugzilla.gnome.org/show_bug.cgi?id=789660
2017-10-30 18:16:43 +01:00
Georges Basile Stavracas Neto
21943a42bf network: Ensure WirelessSecurity type is initialized
When calling for the wireless security widgets, the code
simply assumes that the corresponding GType is initialized.
This may not always be true, which leads to a nasty crash
every time e.g. we open the network connection editor dialog.

This commit fixes that by introducing a new standard macro
wrapping wireless_security_get_type(), and ensuring the type
is initializing when calling wireless_security_init(), thus
protecting every code path from this crash.

This commit also makes CePageSecurity use the new macro for
better legibility.

https://bugzilla.gnome.org/show_bug.cgi?id=785581
2017-08-09 19:32:43 +02:00
Bastien Nocera
6ab5552d59 network: Update wireless-security UI from network-manager-applet 2017-03-13 18:56:57 +01:00
Bastien Nocera
0470c040b1 network: Update wireless-security from network-manager-applet 2017-03-13 18:56:57 +01:00
Bastien Nocera
8386631dcd network: Update wireless-security from network-manager-applet
To replace the WIP code that landed earlier.
2016-06-07 18:50:38 +02:00
Bastien Nocera
b9d619fb54 network: Update the script to update from nm-applet again
Separating out the UI from the backend code.
2016-06-07 18:50:38 +02:00
Bastien Nocera
764208d8e9 network: Add missing nm-default.h file 2016-06-07 14:38:27 +02:00
Bastien Nocera
c316e301ce network: Separate UI changes from code changes 2016-06-07 14:25:20 +02:00
Bastien Nocera
27c9aff3af network: Update wireless-security UI from network-manager-applet
The list of changes compared to the nm-connection-editor code is:
- Remove ":" from the control labels
- Right-justify the control labels
- Shrink the column spacing to 6
2016-06-07 14:21:36 +02:00
Bastien Nocera
92b044ba7f network: Update wireless-security from network-manager-applet 2016-06-07 13:11:07 +02:00
Bastien Nocera
e6bccd6646 network: Update wireless-security patch 2016-06-07 13:11:07 +02:00
Bastien Nocera
25feb13ee9 network: Remove nag-user-dialog.ui
It's now unused.
2016-06-07 13:11:07 +02:00
Bastien Nocera
7cc463a067 network: Automate updating wireless-security UI files
from network-manager-applet.
2016-06-07 13:10:55 +02:00
Bastien Nocera
280cff67db network: Add utils from network-manager-applet
The minimum necessary utilities from
network-manager-applet/src/utils/utils.[ch]
for the wireless-security rebase.
2016-06-07 13:10:10 +02:00
Bastien Nocera
9183d34947 network: Port to libnm 1.2
We also remove support for WiMAX (now unsupported by NetworkManager),
and InfiniBand (Enterprise feature), and the use of
the deprecated NM_SETTING_WIRELESS_SEC property.

With help from network-manager-applet patches by Jiří Klimeš and
Dan Winship.

https://bugzilla.gnome.org/show_bug.cgi?id=765910
2016-05-27 18:23:33 +02:00
Sebastian Keller
81e89fb7f8 network: Fix unintentionally centered checkbutton labels
See https://bugzilla.gnome.org/show_bug.cgi?id=732361

https://bugzilla.gnome.org/show_bug.cgi?id=732374
2015-07-27 00:00:43 +02:00
Bastien Nocera
d9d5124997 network: Don't stop validating when we get an error
The previous code would stop validating when an error occurred which
meant that when a page contained multiple errors, only the first one(s)
to be checked would appear in red.

Now, all the errors will appear in red.

https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 18:38:31 +02:00
Bastien Nocera
117cf30500 network: Fix compile-time warning
Missing include.

https://bugzilla.gnome.org/show_bug.cgi?id=734472
2014-08-13 18:38:31 +02:00
Bastien Nocera
62db29b387 network: Make broken configuration entries red
When a configuration setting is wrong, set the entry or file chooser
that contains the incorrect information to be surrounded by red.

This makes it easier for users to find where the error was made that
disallows them to click the "Apply" button.

https://bugzilla.gnome.org/show_bug.cgi?id=734446
2014-08-08 12:00:40 +02:00
Bastien Nocera
1fe3d1fe1c network: Remove "..." from dialogue titles
https://bugzilla.gnome.org/show_bug.cgi?id=696845
2014-07-24 13:19:09 +02:00