Commit graph

6549 commits

Author SHA1 Message Date
Felipe Borges
93bbd53bca network/connection-editor: Fix focus chain to allow keyboard navigation
Otherwise tabbing will never focus in the inner widgets.
2021-05-07 04:06:35 +00:00
Felipe Borges
afe1c35c57 network: Indicate the maximum password length accepted for wifi hotspots
The Wifi Hotspot setup dialog will error "Must have a minimum of 8 characters"
for all the situations in which nm_utils_wpa_psk_valid and nm_utils_wep_key_valid
report a given password to be invalid.

The case when this error is most obvious is when you enter a very lengthy password
and the dialog shows the very same error about the minimum password length.

These changes make the dialog account for the Maximum password length as well. It
assumes 16 characters for WEP and 63 characters for WPA/WPA2.
2021-05-07 04:02:51 +00:00
Jan Kot
df9c4d726f info-overview: Hide software_updates_row when allow-updates is false. 2021-05-07 03:56:48 +00:00
Mohammed Sadiq
8318d94e2f info: Use 'content' style for listboxes
Which results in rounded corners for the list box, which matches
the latest design.
2021-05-07 03:52:37 +00:00
Benjamin Berg
3bf6ea7794 datetime: Improve NTP switch handling fixing update loop
We cannot simply set the state/active property of the switch without
also triggering the notify:: or state-set signals at the same time. As
such, we need to block the "set-state" handler when we update the
"state" of the switch.

Also, while at it, change the switch to react to "state-set" and only
update the "state" after we received the response from the system.

Fixes: #1299
2021-05-07 03:46:13 +00:00
Nishal Kulkarni
df8eb92efc cc-avatar-chooser.c: Enable remote file selection
Currently user can choose avatar only from local files.

This prevents users from loading a file at a remote location.

Changes made include:

1. Setting local-only property to false in `cc_avatar_chooser_select_file`
2. Getting file uri and creating a GFile from it.
3. Reading the GFile into an input stream.
4. Loading image from this stream.

Closes: #813
2021-05-07 03:37:01 +00:00
Ian Douglas Scott
5e858826c5 user-accounts: Use HdyClamp 2021-05-07 03:23:31 +00:00
Ian Douglas Scott
aff0b446bc user-accounts: Use HdyActionRow 2021-05-07 03:23:31 +00:00
Ian Douglas Scott
3a50deb431 keyboard: Update panel layout with descriptions for sections
Changes based on mockup by @aday:
https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1222#note_1017128
2021-05-07 03:08:11 +00:00
Adrien Plazas
2925509472 power: Ellipsize the labels of the battery row
This helps the window fit any size, including the narrow one of phones.
2021-05-07 02:50:40 +00:00
Adrien Plazas
97ba14e002 power: Hide the icon of the battery row when unused
This gives more room to the label.
2021-05-07 02:50:40 +00:00
Adrien Plazas
a75a0f0384 power: Fix the indentation
The indentation was purposefully left incorrect in the previous commits
to ease the review of the actual changes, this fixes it.
2021-05-07 02:50:40 +00:00
Adrien Plazas
a5c0934b4d power: Use HdyPreferencesGroup 2021-05-07 02:50:40 +00:00
Adrien Plazas
6c8307faf4 power: Use HdyActionRow to simplify the code 2021-05-07 02:50:40 +00:00
Adrien Plazas
4cc4b91b4e power: Use HdyComboRow for the Power Button Behavior row
This simplifies the code a bit and modernizes the UI.
2021-05-07 02:50:40 +00:00
Adrien Plazas
3069dc84c8 power: Use HdyComboRow for the Blank Screen row
This simplifies the code a bit and modernizes the UI.
2021-05-07 02:50:40 +00:00
Adrien Plazas
f986fedf49 power: Don't set the vadjustment
This is useless as GtkScrolledwindow already does it on the viewport it
creates.
2021-05-07 02:50:40 +00:00
Adrien Plazas
5168e924cf power: Simplifies keyboard navigation
This drops the ability to loop through the page but significantly
simplifies the code. I think this is a good tradeoff as looping is a
rather unexpected behavior.
2021-05-07 02:50:40 +00:00
Bastien Nocera
2052c91f8f bluetooth: Add debug for rfkill calls 2021-04-22 12:47:24 +02:00
Debarshi Ray
f85750274c background: Drop the unused build dependency on Grilo
The code that uses Grilo to fetch the user's Flickr photos isn't
actually used by the Background panel, to the extent that the final
binary doesn't even link against Grilo. Getting rid of this unused code
will ensure that distributors aren't needlessly pulling in this
dependency.

https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1345
2021-04-20 23:04:10 +02:00
Felipe Borges
d980e0ffee mouse: Prevent direction change for primary mouse button box
In Right-to-left locales GNOME Settings presents a button on the
left with the translated label "Right" and a button on the right
with the translated label "Left".

These changes prevent the flip of the direction buttons in RTL
locales.

Fixes #1101
2021-04-13 10:36:10 +02:00
Claude Paroz
d0d44dd6cd keyboard: Use g_dngettext to allow pluralized 'modified' string 2021-04-13 01:31:13 +00:00
Kalev Lember
a64bb833ee info-overview: Don't show GNOME micro version
With the new versioning scheme, GNOME just has major.minor versions
(e.g. 40.rc, 40.0) and micro versions are no longer used. Even if
gnome-desktop happens to get a micro version to fix a bug, it's not
something we should show in the UI.
2021-04-13 01:26:22 +00:00
Felipe Borges
4fa6852cdc online-accounts: Present all supported providers at once
Instead of having the "more" button which reveals more items to the
providers list.

We still list branded providers above non-branded providers in the
list.

Fixes #1072
2021-04-08 12:34:44 +00:00
Bastien Nocera
9acaa10567 power: Fix possible assertion on startup
When opening the Power panel, and if power-profiles-daemon isn't already
started, we'll be autostarting it, making it send signals about all the
changed properties, including "PerformanceInhibited" even if we
don't have a Performance row.

Ignore the property change if we don't have a row for it rather than
asserting.

 #0  0x00007f73916bc292 in raise () from /lib64/libc.so.6
 #1  0x00007f73916a58a4 in abort () from /lib64/libc.so.6
 #2  0x00007f7393203ccc in g_assertion_message.cold () from /lib64/libglib-2.0.so.0
 #3  0x00007f739325f22f in g_assertion_message_expr () from /lib64/libglib-2.0.so.0
 #4  0x000055a4099e28ae in performance_profile_set_inhibited (self=0x55a40b37e320, self=0x55a40b37e320, performance_inhibited=<optimized out>) at ../panels/power/cc-power-panel.c:1366
 #5  power_profiles_properties_changed_cb (self=0x55a40b37e320, changed_properties=<optimized out>, invalidated_properties=<optimized out>, proxy=<optimized out>) at ../panels/power/cc-power-panel.c:1425
 #6  0x00007f7393332c2f in g_closure_invoke () from /lib64/libgobject-2.0.so.0
 #7  0x00007f739334eea6 in signal_emit_unlocked_R () from /lib64/libgobject-2.0.so.0

1362	{
1363	  CcPowerProfileRow *row;
1364
1365	  row = self->power_profiles_row[CC_POWER_PROFILE_PERFORMANCE];
1366	  g_assert (row != NULL);
1367	  cc_power_profile_row_set_performance_inhibited (row, performance_inhibited);
1368	}
2021-03-31 11:12:17 +02:00
Guido Günther
3ac2804868 location-panel: Allow label to wrap
Otherwise the panel overflows when enabling location services.
2021-03-12 14:16:31 +00:00
Igor Raits
f966c99409 network/connection-editor: Fixup creation of the netmask widget
Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1274
Signed-off-by: Igor Raits <igor.raits@gmail.com>
2021-03-09 00:43:08 +00:00
Alexander Mikhaylenko
13ffacb083 background: Fix thumbnail size on hidpi
Use GIcon GtkImage API instead lf GdkPixbuf. The latter treats pixbufs as
always being in 1x scale and upscales them to compensate, while in our case
they are pre-scaled.

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/787
2021-03-04 13:29:27 +00:00
Georges Basile Stavracas Neto
9fc0a4c2b1 common/language-chooser: Center More row icon
Otherwise it gets pushed to the start of the row.
2021-03-04 09:33:44 -03:00
Georges Basile Stavracas Neto
c223ba2554 common/language-chooser: Make "More" rows visible by default
The inner box of the More row is visible, but the row itself isn't.
Make the row visible too.

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1273
2021-03-04 09:33:40 -03:00
Georges Basile Stavracas Neto
af5d13e7b5 common: Rename 'check' to 'check_image'
The C code tries to fetch and use 'check_image', but the UI definition
calls it 'check', which throws a few warnings. Renaming it in the UI file
is easier than in the C file, so I went with the former.
2021-02-23 10:28:22 -03:00
Georges Basile Stavracas Neto
7167019522 common: Add missing <child> tag to CcLanguageChooser
The UI file is not wrapping the <object> tag with <child>, which
fails to parse and blanks the dialog.

Add the missing <child>  tag around the "More" row object.

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1270
2021-02-23 10:28:15 -03:00
Felipe Borges
b813866a63 mouse: Allow horizontal scroll in mouse test page
This allows the panel to shrink further than the test image's
width.

Fixes #1046
2021-02-23 12:14:39 +00:00
Felipe Borges
540f6edff3 panels: Align dialog labels with their respective listbox below
Both the "Storage" and "Built-in Permissions" dialogs.
2021-02-23 11:55:56 +01:00
Benjamin Berg
a87dee7911 sound: Update mute button icon when volume changes
The icon on the mute button needs to be updated whenever the volume is
changed (externally). Add the appropriate call too notify_volume_cb.

Fixes: #1268
2021-02-21 15:30:40 +00:00
Benjamin Berg
4b8ff9f6f3 sound: Include zero volume in lowest volume icon
If changed externally at least, the volume can be zero while unmuted.
Just use the lowest volume icon in that case by including it in the
range.

It does not make sense to use the muted icon, as we are not technically
muted and the toggle button is not active.
2021-02-21 15:30:39 +00:00
Carlos Garnacho
d7db0faa4e universal-access: Look up double-click setting in the right schema
This was changed in commit 006d0e6a63, and wrongly made to look on the
wrong schema. Fix it up so double-click setting lookup happens on
org.gnome.desktop.peripherals.mouse.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1256
2021-02-18 16:08:53 +01:00
Benjamin Berg
58c4a39af1 power: Fix crash when power proxy becomes ready after finalize
While the code was using the pattern to cancel the operation, it was
still resolving the user_data pointer even in the case the operation has
been cancelled.

Fix this by simply moving the initialization.

Fixes: #1260
2021-02-16 15:44:22 +01:00
Robert Ancell
2ee5f1422a printers: Ensure PPD copy is always deleted 2021-02-15 10:34:32 +13:00
Robert Ancell
81392210f2 printers: Add note about callback that passed ownership 2021-02-15 10:34:32 +13:00
Robert Ancell
797c36dc0a printers: Improve memory management of backend list 2021-02-15 10:34:32 +13:00
Robert Ancell
5b086c44e8 printers: Don't pass ownership in get_all_ppds_async callback 2021-02-15 10:34:32 +13:00
Robert Ancell
98fd38278a printers: Don't pass ownership in get_ipp_attributes_async callback 2021-02-15 10:34:32 +13:00
Robert Ancell
d970ae48b4 printers: Don't pass ownership in get_ppd_names_async callback 2021-02-15 10:34:32 +13:00
Robert Ancell
0d913f7283 printers: Remove use of goto 2021-02-15 10:34:32 +13:00
Robert Ancell
cede2f5a81 printers: Use g_autoptr for utility functions 2021-02-15 10:34:32 +13:00
Robert Ancell
005b18f2f1 printers: Make helper functions for callback data 2021-02-15 10:34:32 +13:00
Rachit Keerti Das
fccfb52cad keyboard: Improve Empty Search State.
The empty search state looks out-of place due to it being nested inside
a listbox. This is because we can only detect empty states through
gtk_list_filter_func().

Refine it by making the empty search placeholder a child of the main stack.
Introduce an additional helper function to detect when all the listbox
rows would be hidden by the filter.

As a part of https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1222
2021-02-12 15:41:10 +13:00
Javier Fernández
f39cd5a93b info-overview: Implements usage of os-release to search for the OS logo
By default info-overview panel shows the Gnome logo from a static
resource, currently every distro patches this component to show their logos

info-overview panel could use `/etc/os-release` file to fetch the OS logo
instead this static resource
2021-02-11 14:04:14 +01:00
Robert Ancell
cbb2d31a38 user-accounts: Add missing GTK_WIDGET cast
Was missing in 77df081fec
2021-02-11 16:14:47 +13:00