Mohammed Sadiq
8dc39c8831
wwan: Remove a never reached code
...
Since we return early, the code followed is never run.
Also, the password for GSM APNs are not actually sensitive
secrets. So Remove the lines that are never reached.
2022-02-15 16:34:30 +00:00
Alessandro Bono
10489fb208
net-vpn: Don't append VPN
in the title of the editor dialog
...
We don't do anything similar for other connections editors (wired and WiFi).
We alredy know that we are modifying a VPN, no need to repeat ourself.
2022-02-15 14:42:13 +00:00
Alessandro Bono
ce1c00be5d
net-vpn: Don't append VPN
to each row
...
We don't do anything similar for other connections rows (wired and WiFi).
All the rows are VPNs. No need to repeat ourself.
2022-02-15 14:42:13 +00:00
Pablo Correa Gómez
fcbe0c039b
user-accounts: Try non TRANSLIT conversion if TRANSLIT conversion fails
...
This fixes a crash in musl-based systems, where TRANSLIT is not
implemented. I followed musl-maintainer recommendation[1] of doing
a run-time check to verify the behavior under these circumstances.
[1] https://github.com/akrennmair/newsbeuter/issues/364#issuecomment-250208235
2022-02-15 14:08:04 +00:00
Felipe Borges
1f693be757
user-accounts: Reset avatar widget when changing user pages
...
Otherwise the same source image is going to be used for other users
that don't have their own avatar image set.
2022-02-15 13:57:55 +00:00
Pablo Correa Gómez
c5ca6717e5
wwan: Make sure secrets are set when querying connection APN password
...
Otherwise the comparison in wwan_data_apn_are_same will always be False
due to nm_setting_gsm_get_password always returning NULL.
Helps #1468
Relates !1059
2022-02-15 13:46:48 +00:00
Christopher Davis
9a2cd1b5d2
keyboard: Don't dim input chooser icons
...
We generally don't dim icons in rows anymore.
2022-02-13 13:33:25 +00:00
Christopher Davis
4ccf6e670b
keyboard: Adjust input chooser widgetry
...
Adjusts the widgetry of the input chooser to clamp
the list and add a separator between the search bar
and the list.
The list's shadow is no longer clipped, and keyboard
navigation now scrolls.
2022-02-13 13:33:25 +00:00
Christopher Davis
cd4dd18f52
keyboard: Handle keynav-failed
on input source list
...
Fixes keynav with arrows between the input list
group and other groups.
2022-02-13 13:33:25 +00:00
Christopher Davis
1a3971fdbe
keyboard: Allow input list rows to manage their own size
...
Using GtkSizeGroup causes weird jumping,
and size groups generally should not be used for
boxed list rows.
2022-02-13 13:33:25 +00:00
Christopher Davis
ced8c1cb99
keyboard: Use GAction and GMenuModel for input row popovers
...
Gives these menus proper styling without having to
roll our own widgets.
Also removes the Remove button when the action is
disabled.
2022-02-13 13:33:25 +00:00
Christopher Davis
530fbac68e
keyboard: Subclass AdwActionRow for InputRow
2022-02-13 13:33:25 +00:00
Christopher Davis
485dd456bb
keyboard: Use AdwActionRow for input switch rows
2022-02-13 13:33:25 +00:00
Christopher Davis
84becfbd80
keyboard: Use AdwPreferences{Page,Group}
2022-02-13 13:33:25 +00:00
Christopher Davis
328da2fa14
diagnostics: Use AdwPreferences{Page,Group}, AdwActionRow
2022-02-13 13:26:43 +00:00
Rafael Fontenelle
fafd093fbd
usage: fix typo
2022-02-12 23:27:05 +00:00
Rafael Fontenelle
ba3410f380
microphone: remove extra newline and spaces
...
The extra line was causing newline chars and whitespaces to be added
to translation strings
2022-02-12 22:37:31 +00:00
Mohammed Sadiq
0452e9eb4d
network: Fix a possible memory leak in QR code
...
It's possible that the QR code for the same text has been requested,
but for a different size. Fix a memory leak that would happen
in those cases.
2022-02-12 21:47:07 +00:00
Christopher Davis
7c9c42fb65
usage: Use AdwComboRow for "File History Duration"
2022-02-12 13:32:22 -08:00
Christopher Davis
a95b57061b
usage: Use AdwComboRow for "Automatically Delete Period"
2022-02-12 13:32:22 -08:00
Christopher Davis
a3c31fcda3
usage: Use AdwPreferences{Page,Group}, AdwActionRow
...
Uses AdwPreferencesPage and AdwPreferencesGroup for
consistency with the rest of the application. The
combo rows now use AdwActionRow so they can be
included in the AdwPreferencesGroup without
a custom list box.
2022-02-12 13:32:22 -08:00
Carlos Garnacho
7371dbb35c
wacom: Explicitly discard input from touchscreens
...
Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1612
2022-02-12 16:03:37 +00:00
Carlos Garnacho
57e5144f41
wacom: Avoid reset on spurious size changes
...
This is a possible reason for undesired calibration resets.
Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1613
2022-02-12 16:03:37 +00:00
Carlos Garnacho
3f12a7d2cb
wacom: Allow NULL monitors in calibration
...
Unfortunately, this may be the case, it is better to show wonky UI
than no UI at all.
2022-02-12 16:03:37 +00:00
Carlos Garnacho
6c6499e23e
wacom: Pass GdkMonitor directly to calibrator object
...
Instead of figuring out a monitor number from a GdkMonitor, and
look the GdkMonitor back up, pass the GdkMonitor directly.
2022-02-12 16:03:37 +00:00
Carlos Garnacho
6756710996
wacom: Make calibrator retrieve dimensions from window
...
So we can fullscreen on a monitor and forget.
2022-02-12 16:03:37 +00:00
Carlos Garnacho
ec5ad4d3e4
wacom: Turn CcCalibArea into a window subclass
...
Modernize a bit the code, since it will be easier to do some things
as a window subclass.
2022-02-12 16:03:37 +00:00
Carlos Garnacho
fce8b631cc
wacom: Rename calibrator API
...
Add "Cc" prefix so it's more consistent with the rest of the project.
2022-02-12 16:03:37 +00:00
Carlos Garnacho
1777a42aef
wacom: Update/unbreak calibrator
...
It got to a building state in the GTK4 port, but was broken at
runtime. Update event handlers and builder objects so it works again.
2022-02-12 16:03:37 +00:00
Carlos Garnacho
e26ea4e6d1
wacom: Drop dead code
...
These dimensions are no longer used.
2022-02-12 16:03:37 +00:00
Carlos Garnacho
3d4d785588
wacom: Drop unused API
...
This function was only used for logging purposes, we can do
without it.
2022-02-12 16:03:37 +00:00
Ivan Molodetskikh
3ecc151061
keyboard: Remove 01-screenshot.xml
...
Move this to gnome-shell where it belongs. See
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2107
2022-02-12 12:18:29 +00:00
Christopher Davis
3f851bd793
microphone: Use AdwActionRow
2022-02-12 11:51:21 +00:00
Christopher Davis
ab950bbfb5
microphone: Use AdwPreferences{Page,Group}
2022-02-12 11:51:21 +00:00
Christopher Davis
c2c9334a59
microphone: Use AdwStatusPage
2022-02-12 11:51:21 +00:00
Alexander Mikhaylenko
c932168462
background: Trigger screen transition when changing style
...
See https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2070
2022-02-11 22:12:49 +00:00
Mohammed Sadiq
15df3bc494
network: Fix QR code with dark theme
...
Explicitly set white background for the image so that white border
is shown around the QR code in dark themes too.
2022-02-11 17:24:52 +00:00
Marek Kasik
8fe87ac6ef
printers: Use bold font for title of details dialog
...
All other dialogs have bold titles, this should too.
Issue #1587
2022-02-11 13:18:15 +01:00
Marek Kasik
2a2d7ec111
printers: Make search entry symetric
...
Allow search entry of new printer dialog to expand so that it fills
the available area. It does not fill it now so there is more free
space on the right than on the left.
Issue #1587
2022-02-11 13:18:15 +01:00
Marek Kasik
cc75a07a69
printers: Fix blurred icons of printers
...
Change align of the printers icons to CENTER from FILL so that the icons
are not stretched.
Issue #1587
2022-02-11 13:18:15 +01:00
Christopher Davis
4f2aa07ff5
thunderbolt: Use AdwStatusPage for empty state
...
Make use of libadwaita's provided widget for status pages
instead of rolling our own.
2022-02-10 14:01:18 -08:00
Felipe Borges
37ee555c44
network: Show configuration button only for active/connecting connections
...
In commit c7bd442839
we started to
show the configuration button for all rows, which fixes the original
issue of not being able to tweak a connection during association but
also introduces a regression of not having connection data to show
for other connections in the list. This way, the configuration
button will fail to create a net_connection_editor interface for
rows that aren't associated with an active connection.
Let's only show the configuration button when the NMActiveConnectionState
is either NM_ACTIVE_CONNECTION_STATE_ACTIVATING or
NM_ACTIVE_CONNECTION_STATE_ACTIVATED.
Fixes #1494
2022-02-10 15:05:08 +00:00
Alexander Mikhaylenko
eca4c0a370
background-paintable: Clip light wallpapers as well
...
Turns out drawing the whole light wallpaper and then half of the dark
wallpaper on top of it is leading to a case of
https://gitlab.gnome.org/GNOME/gtk/-/issues/3840
Draw half of each instead, so they don't overlap.
2022-02-10 05:11:30 +05:00
Felipe Borges
26cc82c754
user-accounts: Always populate other users list
...
We were not re-populating the list when switching panels.
Related #1631
2022-02-09 15:04:32 +00:00
Christopher Davis
770da3788a
notifications: Remove redundant haligns
2022-02-09 14:33:17 +00:00
Christopher Davis
a8bc1a222e
notifications: Make dialog resizeable, adjust default size
...
We can't use flat headerbars here because we need to
be able to scroll the dialog at smaller sizes. We
also need for the dialog to be able to reach smaller
sizes.
2022-02-09 14:33:17 +00:00
Christopher Davis
17d3a297ae
notifications: Handle keynav-failed
on app list
...
Fixes keyboard navigation with arrow keys
2022-02-09 14:33:17 +00:00
Christopher Davis
2f00725af8
notifications: Remove options_listbox
...
Since CcListRow is now an AdwActionRow subclass,
we don't need to have a custom listbox for the top
group.
2022-02-09 14:33:17 +00:00
Alexander Mikhaylenko
24311b6ebd
background-chooser: Remove a leftover binding
...
GtkWidget:text-direction doesn't exist. That's why we connect to the
::direction-changed signal instead, and this property binding was
just a leftover from c5792cfb00
.
2022-02-09 14:23:29 +00:00
Christopher Davis
0e2531f500
search: Activate results row switch on click
2022-02-09 13:53:17 +00:00