Commit graph

7360 commits

Author SHA1 Message Date
Marco Melorio
be89d7df88 sound: Format sound-panel.ui 2023-01-30 10:49:09 +00:00
Marco Melorio
29514add66 sound: Remove the nested GtkListBox
See the previous commit for more info.

The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in the next commit.
2023-01-30 10:49:09 +00:00
Marco Melorio
ec9a0052ba sound: Move the "No Devices" rows in different groups
Previously this was problematic because the current layout is a bit
messy. The reasoning is a bit complex, but I'll try to explain below.

Basically the AdwPreferencesGroup has an integrated GtkListBox where the
rows should normally be added to it by declaring AdwPreferencesRow
subclasses as its direct children in the UI file. This is not currently
done in the sound panel and we instead have another GtkListBox as its
direct child, while the "No Devices" row is actually a AdwPreferencesRow
subclass, so we end up with two listboxes with .boxed-list style. The
problem is that we hide the "No Devices" row when there are devices
available, but the internal listbox is still there, so we still see its
shadows.

This commit just separates the "No Devices" row in a separate group so
that we are sure to hide everything correctly.
2023-01-30 10:49:09 +00:00
Marco Melorio
fc3580f2f2 sound: Fix warning about missing measure in output test
Just measure the label to make GTK not complain about allocating
children without measuring anything. Measuring all the buttons is an
overkill because we expect this widget to have the minimum size
overwritten by CSS either way.
2023-01-27 17:46:58 +00:00
Dylan Van Assche
571a69d36e
network: fix tabs/spaces mixing
Some functions were using tabs instead of spaces, unify the file to use spaces everywhere.
2023-01-27 18:39:19 +01:00
Dylan Van Assche
9b08433599
network: add missing cancellable
Add missing GCancellables to resolve the FIXME statements and
avoid possible crashes if the properties in NetConnectionEditor
outlive themselves.
2023-01-27 18:39:12 +01:00
Dylan Van Assche
3c4939bdbd
network: reapply connection on device
Changing an active connection applies the changes onto the
NetworkManager connection, but not on the device. This is because
NetworkManager clones the connection when it is applied on a device.
This behavior is expected and documented in the NetworkManager
documentation [1]. To effectively apply the connection changes onto a
device, a reapply operation must be performed. This will make NetworkManager
apply the new connection onto the active device without having to
disable and re-enable the device.

Perform this reapply operation when the Apply button is pressed in the
Connection Editor so the changes effectively propagate to the network
device.

[1] https://networkmanager.dev/docs/api/1.32.10/gdbus-org.freedesktop.NetworkManager.Device.html#gdbus-method-org-freedesktop-NetworkManager-Device.Reapply
2023-01-27 18:39:07 +01:00
Mohammed Sadiq
8857a6b2e6 build: Update G_LOG_DOMAIN
When run with -vvv, we log domains prefixed with cc- by default.
So set G_LOG_DOMAIN appropriately so that logs are shown when
run in verbose mode.
2023-01-25 09:55:34 +00:00
Bastien Nocera
11ae5d11d1 background: Remove unused thumbnail factory 2023-01-25 09:54:10 +00:00
Jake Dane
37a579b6b0 Replace "application" with "app"
This is part of an initiative to use "app" instead of "applications",
see: https://gitlab.gnome.org/Teams/Design/initiatives/-/issues/123

Redo of !1539 that was closed by a ghosting user.

Replaces "application" with "app" in user facing strings in these
panels:

- applications
- camera, location, microphone
- default-apps
- multitasking
- notifications
- removable-media
- search
- usage
- user-accounts

Fixes: #2208.
2023-01-23 11:10:28 +00:00
Hari Rana
b1c14df48b user: Remove duplicate group property 2023-01-23 11:03:50 +00:00
sunflowerskater
82e873f9cc bluetooth: Tweak AdwStatusPage design
Some AdwStatusPage changes to follow HIG:

- Apply .suggested-action style class to the button
- Ditch period from the description

- https://developer.gnome.org/hig/patterns/controls/buttons.html
- https://developer.gnome.org/hig/guidelines/writing-style.html
2023-01-18 11:56:51 +01:00
Christian Glombek
fcc092430f network: Mark imported VPN conn as private to user, and non-autoconnect 2023-01-16 20:35:02 +00:00
Christian Glombek
475faaf26b network: Add support for WireGuard (GNOME/gnome-control-center#982)
Adds support for managing WireGuard VPN connections:

- Listing WireGuard connections as VPN connections
- Toggling connection state
- Creating, updating and deleting WireGuard connections
- Creating, updating and deleting WireGuard peers
- Importing WireGuard config files

Co-authored-by: Nathan-J. Hirschauer <nathanhi@deepserve.info>
2023-01-16 20:35:02 +00:00
Marco Melorio
8dbf562276 sound: Remove stray character in UI file 2023-01-16 20:53:57 +01:00
Marco Melorio
ea0e2cf308 sound: Remove modelines at the top of the files
They are not even correct and make GNOME Builder to use 8 space
identation by default.
2023-01-16 20:53:56 +01:00
Marco Melorio
866b08b4e8 sound: Hide controls when there are no devices
Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1221
and https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1575.
2023-01-16 20:53:15 +01:00
Marco Melorio
ba2a71fb44 sound: Cleanup and reorganize variables in CcSoundPanel
Remove unused ones and keep the same order as the UI hierarchy.
2023-01-16 20:52:14 +01:00
Marco Melorio
9e85ff5547 sound: Clamp level bars to avoid overflowing
Apparently the level value is not clamped by pulseaudio/gvc, so the
level bar can overflow when the value is greater than 1.
2023-01-16 20:51:12 +01:00
Marco Melorio
b3d99f281a sound: Add a "None" option to the alert chooser
Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2251.
2023-01-16 19:43:53 +00:00
Marco Melorio
98c8a7787c sound: Move alert chooser to a separate window 2023-01-16 19:43:53 +00:00
Marek Kasik
092cef515d printers: Fix deleting of printers when exiting
Call sync method to remove a printer when exiting Printers panel.
The deletion could not pass otherwise.

Fixes #2174
2023-01-16 14:32:01 +00:00
Marco Melorio
2fbbe0f60d sound: Use a microphone icon for input in CcVolumeSlider
There was some code that attempted to do that, but was incorrect.

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1762.
2023-01-15 20:07:04 +01:00
Marco Melorio
ca553bd377 sound: Make mute button in CcVolumeSlider more consistent
When pressing the mute button after the volume slider is manually moved
to 0 (and so the GVS "is-muted" property is still FALSE), set the volume
to 25% instead of actually muting the stream.

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/520.
2023-01-15 19:56:10 +01:00
Marco Melorio
7fddfa363f sound: Port the mute button in the CcVolumeSlider to GtkButton
The logic inside it is a bit reworked to make it more consistent. The
mute button and the slider now only communicate directly with GVC. The
notify callbacks are now used to change the UI states.

This fixes the UI problem of the mute button being "raised" when pressed
(see https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/520).
2023-01-15 19:44:23 +01:00
Marco Melorio
7556aef2aa sound: Add level bars to the stream rows
Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1303.
2023-01-12 13:25:27 +00:00
Marco Melorio
1950d1d7b5 sound: Move the mute buttons to the left side of the sliders 2023-01-12 13:25:27 +00:00
Marco Melorio
24ff4bd402 sound: Rename input volume label to match mockup
Rename "Volume" to "Input Volume", to match the mockup and the output
volume label.
2023-01-12 13:25:27 +00:00
Marco Melorio
fd3e7e478a sound: Move output volume slider in the "Output" section 2023-01-12 13:25:27 +00:00
Marco Melorio
5c07348fb9 sound: Move stream list in a separate window
Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/501.
2023-01-12 13:25:27 +00:00
Marco Melorio
458d8b53a2 sound: Use a model-based approach for the stream list box
This is useful for the next commit because the stream list will be moved
in a separate window and to do that we need an always-updated list of
the playing streams. Without this approach, we would lose all the
streams that played before the user opens the stream list window. Also,
this allows us to decuple data and UI, which is definitely not  a bad
thing.
2023-01-12 13:25:27 +00:00
Marco Melorio
034171a8e1 sound: Simplify icon theme check
Use the gtk_icon_theme_has_icon API which is definitely more appropriate
for this task.
2023-01-12 13:23:14 +00:00
Marco Melorio
8bf20930c2 sound: Fix custom icon for speech dispatcher not being used 2023-01-12 13:23:14 +00:00
Marco Melorio
6b726791bf sound: Stop using symbolic icons for stream rows 2023-01-12 13:23:14 +00:00
Marco Melorio
bb7fdec253 sound: Cleanup CcVolumeSlider XML 2023-01-09 21:03:41 +00:00
Marco Melorio
5c3cb3042d sound: Cleanup CcSubwooferSlider XML 2023-01-09 21:03:41 +00:00
Marco Melorio
2fee8bf0fa sound: Cleanup CcFadeSlider XML and remove marks 2023-01-09 21:03:41 +00:00
Marco Melorio
3295d2a5b3 sound: Cleanup CcBalanceSlider XML and remove marks 2023-01-09 21:03:41 +00:00
Marco Melorio
62ae77ce29 sound: Make CcVolumeSlider subclass from GtkWidget 2023-01-09 21:03:41 +00:00
Marco Melorio
a5833612b8 sound: Make CcSubwooferSlider subclass from GtkWidget 2023-01-09 21:03:41 +00:00
Marco Melorio
4ab73ad337 sound: Make CcFadeSlider subclass from GtkWidget 2023-01-09 21:03:41 +00:00
Marco Melorio
c7e14e5ee4 sound: Make CcBalanceSlider subclass from GtkWidget 2023-01-09 21:03:41 +00:00
sunflowerskater
6bcfb28f67 wi-fi: Use AdwStatusPage for "Airplaine On" and "Wi-Fi off" states
Currently, the "Airplaine Mode On" and "Wi-Fi Off" status messages don't use AdwStatusPage.

This commit makes these messages to use AdwStatusPage.

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2217
2023-01-09 14:48:53 +00:00
sunflowerskater
1be44da216 screen: Add subtitle for the "Automatic Screen Lock" row
The "Automatic Screen Lock" row doesn't have a subtitle.

This commit adds the subtitle suggested by Allan Day in:
https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1553#note_1636628
2023-01-09 14:46:44 +00:00
sunflowerskater
34bbc50870 screen: Make some strings shorter
The strings related to screen blank are long and cumbersome.

This commit makes these strings shorter, following the advice from:
https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1433#note_1607990
2023-01-09 14:46:44 +00:00
Marco Melorio
ff151bef43 sound: Don't flip the balance and fade sliders in RTL
Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1067.
2023-01-09 12:09:55 +00:00
raihan2000
1250b0f4d7 file-history:Added dialog on Clear History button
- Rewrite clear_recent function to show dialog.
- Added on_clear_recent_warning_response_cb function
- to show warning on clicking Clear History button.
This commit fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1952
2023-01-09 11:25:10 +00:00
Lukáš Tyrychtr
cb333cd59c Fix accessibility of the buttons in the test sound output dialog
They had only icons, so name them for screen readers.
2023-01-06 09:56:09 -03:00
sunflowerskater
c5c64f2b7d keyboard: Add "Hotkey" keyword
Currently, it's not possible to find the Keyboard panel by searching for "hotkey".

This commit adds the "hotkey" word to the *.desktop.in file.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/283
2023-01-06 12:40:19 +00:00
sunflowerskater
8e43d2c53d wi-fi: Rename "Known Networks" to "Saved Networks"
This change follows the latest mockups, which use the term "Saved Networks":
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/blob/master/network/wifi-settings.png
2023-01-06 12:26:37 +00:00