Commit graph

144 commits

Author SHA1 Message Date
Automeris naranja
47a0caec34 privacy: Update Privacy panel description
As per suggestion of @aday in the following thread:
https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2026#note_1918621

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2043>
2023-11-20 02:23:01 +00:00
Felipe Borges
99459f879a privacy: Rename visible name to "Privacy & Security"
Fixes #2742
2023-11-16 08:45:51 +00:00
velsinki
88a582cbed privacy: Fix crash from free bug in cc-camera-page
The GVariant constructor g_variant_new () gives a floating reference,
which will be sunk by the g_dbus_..._call () methods. Unless the
constructed GVariant is manually referenced, it should not be used in a
g_autoptr () setting. Otherwise a use-after-free might occur in the
async g_dbus_..._call () methods.

This problem occurs here, which is simply prevented by not having the
g_autoptr () declaration for the GVariant.

Fixes #2647
Fixes #2704
Fixes #2635
Fixes #2706
2023-11-08 14:08:38 +01:00
Automeris naranja
a910730a76 screen: Add missing mnemonics
Add mnemonics to the following rows
- Restrict Viewing Angle
- Blank Screen Delay

Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541
2023-11-05 17:39:31 -03:00
Automeris naranja
21af56aa9c screen-page: Fix mnemonic of the "Lock Screen Notifications" row
It was using the letter L, which is also used by the
"Automatic Screen Lock" row.
2023-11-05 17:39:31 -03:00
Automeris naranja
0d48055f9f firmware-security-page: Add tooltip to fw_help_button
"Controls in the header bars of primary windows should all have tooltips".

https://developer.gnome.org/hig/patterns/feedback/tooltips.html
2023-10-23 13:46:34 +00:00
Automeris naranja
f813d0d1d4 screen: Rename "Forbid new USB devices" to "Forbid New USB Devices"
Header capitalization needs to be used.

https://developer.gnome.org/hig/guidelines/writing-style.html
2023-10-23 13:45:21 +00:00
Marco Melorio
cd5a80c268 privacy: Fix crash in the firmware security page
Make sure the timeouts are stopped when the page is finalized.
2023-09-22 10:41:14 +00:00
Alice Mikhaylenko
4680f362f3 Port to AdwNavigationSplitView 2023-08-25 08:00:43 +00:00
Felipe Borges
6585bba6ec privacy: Fix typo in UI file property parameter 2023-08-15 14:13:54 +02:00
Felipe Borges
0c9498d1f8 Mark some strings as translatable
These are strings that are presented in the UI that were not marked
for translation.

Fixes #2596
2023-08-11 12:07:00 +02:00
Marco Melorio
cdea4b4503 privacy: Make security dialogs consistent
Port them to AdwWindow and AdwToolbarView, simplify the widgetry and use
a consistent styling and window size.
2023-08-06 14:11:08 +00:00
Marco Melorio
49f037595d privacy-panel: Improve subpage row descriptions 2023-08-06 14:11:08 +00:00
Marco Melorio
a2f65a0471 privacy-panel: Group the subpage rows 2023-08-06 14:11:08 +00:00
Marco Melorio
287e2371a4 firmware-security: Simplify widgetry
Use a GtkStack instead of a AdwLeaflet in the security and heavily
simplify the security dialog, because it contained a lot of misued
widgets and also a page that was never made visible.
2023-08-03 08:42:10 +00:00
Marco Melorio
0dcebeee9d privacy: Format all UI files 2023-08-03 08:42:10 +00:00
Marco Melorio
5c75c03b52 privacy: Add thunderbolt page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
71349d80d9 privacy: Add device security page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
8ea49662d6 privacy: Add microphone page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
4eefc51dd2 privacy: Add camera page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
6dac508732 privacy: Add location page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
ef58f0e097 privacy: Add diagnostics page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
c94afe06a8 privacy: Add usage page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
b2eaa54d7d privacy: Add screen lock page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
81dd3de928 panels: Add empty Privacy panel with navigation
It will be filled in later commits.
2023-08-03 08:42:10 +00:00
Matthias Clasen
a4bdc37760 Remove the privacy panel
It has been turned into a herd of panels.
2019-11-07 14:40:07 +13:00
Robert Ancell
97985a664e Remove unused GNOMELOCALEDIR defines 2019-09-09 21:45:53 +00:00
Robert Ancell
1752cf3bb5 Make /etc/os-release support common
The existing code is used in multiple places with slightly different
implementations.
2019-09-09 21:42:10 +00:00
Bastien Nocera
f9d0dc9795 privacy: Rename "Show Notifications" label
To be clearer.

https://bugzilla.gnome.org/show_bug.cgi?id=743307
2019-03-29 17:12:20 +00:00
Iain Lane
39e31e912f
privacy: Remove {get,set}_on_off_label2
There's only one instance of this pattern - make the function specific
to that case rather than generic.

The current code is leaking the Label2Data struct and the GSettings
signal connection. The leak of the signal connection was causing a crash
in case the callback was called after the label was destroyed. Instead
of just directly fixing these problems, let's eliminate the intermediate
struct and just support the specific case we're interested in directly.
2019-02-19 11:04:07 +00:00
Matthias Clasen
c41071f997
privacy: Use the location portal permissions
The location support in flatpak is changing with the
next releases of geoclue and xdg-desktop-portal, and
the permission table is changing as well. Adapt to these
changes.

This may need some version check, or migration.
2019-01-07 10:59:30 -02:00
Matthias Clasen
2950debe18
privacy: handle microphone and camera
This is just adding switches for these new settings
to the panel, no changes to the design.
2019-01-07 10:59:30 -02:00
Adrien Plazas
063656de0d privacy: Ellipsize the labels
This will help the window to fit narrow screens.
2018-11-29 00:48:16 +00:00
Adrien Plazas
e9a5f87080 privacy: Simplify the rows' margins and spacing
Simplify the margins of the rows' items and diminish the spacing between
the elements of a row. This will help the window to fit narrow screens.
2018-11-29 00:48:16 +00:00
Adrien Plazas
7437ac1fd1 privacy: Use a HdyColumn
This better adapts the panel's size to the window's size, allowing it to
look good on both large and narrow windows.
2018-11-29 00:48:16 +00:00
Robert Ancell
33c91ce738 privacy: Use GtkTemplate
Switch from GtkBuilder to using GtkTemplate.
Rename widget IDs to be more readable.
Drop widget IDs that are not used.
Move code into the .ui file that can be.
2018-10-18 01:01:07 +00:00
Robert Ancell
bb7e0e71e1 privacy: Don't use gtk_widget_show_all
It is removed in GTK+ 4
2018-10-11 22:21:34 +00:00
Marek Cernocky
0a2b55d2f2 Added translation context for "1 hour" in Screen Lock dialog 2018-10-11 12:08:17 +02:00
Robert Ancell
442a7b62bb Remove invalid tag in GtkBuilder file
This was introduced in commit fa08a3b
2018-10-11 16:09:14 +13:00
Marek Cernocky
fa08a3bfe6 Added a translation context for the time options in Power and Privacy panels 2018-10-10 20:56:14 +00:00
Georges Basile Stavracas Neto
a44d395804 Revert "privacy: Cache D-Bus proxies"
This reverts commit 754434fa0d.
2018-08-27 12:56:20 +00:00
Robert Ancell
389bb1b87c privacy: Replace ifdefs with #pragma once 2018-05-29 10:47:48 +12:00
Robert Ancell
b81b93193a privacy: Replace GObject boilerplace with G_DECLARE_TYPE 2018-05-29 10:47:48 +12:00
Benjamin Berg
c2f601a9d4 Move common panel code from shell/ to panel/common
This creates a new static library called libwidget which the shell links
against.
2018-04-17 15:26:59 +02:00
Georges Basile Stavracas Neto
754434fa0d privacy: Cache D-Bus proxies 2018-04-06 22:23:39 -03:00
Piotr Drąg
7265bd53a0 Add translator comments to .desktop files
Icons are confusing translators, and gettext
is unlikely to get fixed any time soon.
2018-02-23 18:49:35 +01:00
Felipe Borges
d14e1b830a privacy: Add link to Location Services privacy policy
Just as available in gnome-initial-setup. Points to
https://location.services.mozilla.com/privacy

https://bugzilla.gnome.org/show_bug.cgi?id=793032
2018-02-01 15:02:56 +01:00
Georges Basile Stavracas Neto
f52d038283 Revert "panels/privacy: add network connectivity checking toggle"
This reverts commit dbbea7ddcb.
2018-01-26 16:24:15 -02:00
Georges Basile Stavracas Neto
d3097ee60e Revert "privacy: Don't define structs defined in unavailable libraries"
This reverts commit 484b83f821.
2018-01-26 16:24:03 -02:00
Bastien Nocera
484b83f821 privacy: Don't define structs defined in unavailable libraries
Doing:
typedef struct _NMClient NMClient;
when there's no NMClient available barely makes the code more readable,
and doesn't clear show when it would be used.

https://bugzilla.gnome.org/show_bug.cgi?id=737362
2018-01-26 15:14:14 +01:00