Commit graph

6861 commits

Author SHA1 Message Date
Jonas Ådahl
e8d574883a sharing/remote-desktop: Add copy buttons 2022-02-26 18:19:14 +00:00
Jonas Ådahl
1436dc8120 sharing/remote-desktop: Use systemd directly to manage service
This means we no longer rely on gsd-sharing to disable/enable the remote
desktop service depending on the current connected network.
2022-02-26 18:19:14 +00:00
Jonas Ådahl
5829e397f2 sharing/systemd-service: Add is_active() helper
Checks whether a service is both enabled and running.
2022-02-26 18:19:14 +00:00
Jonas Ådahl
81d3d16a67 sharing/remote-login: Move systemd unit management into helper
This will make it possible to reuse elsewhere, including for user
services.
2022-02-26 18:19:14 +00:00
Jonas Ådahl
3631338676 sharing: Generate RDP TLS certificates when missing
This also hooks up the certificate verification dialog to the configured
TLS certificate.
2022-02-26 18:19:14 +00:00
Jonas Ådahl
2f298c1cb2 sharing/tls: Change expiration timeout to 2 years
It was 5 years; shorten it to 2 years.
2022-02-26 18:19:14 +00:00
Jonas Ådahl
5eb46ec1b7 sharing: Add TLS certificate generation implementation
This copies TLS certificate generation implementation from
https://gitlab.gnome.org/chergert/bonsai. No changes were made other
than ones required for making it build as part of gnome-control-center's
sharing panel. It's currently not suitable to depend on libbonsai, as it
will likely see big changes before seeing a release.
2022-02-26 18:19:14 +00:00
Felipe Borges
0ae59467fb sharing: Port Screen Sharing dialog to RDP
Also following the guidelines at
https://gitlab.gnome.org/Teams/Design/settings-mockups/-/raw/master/remote-desktop/remote-desktop.png

Fixes #1413
2022-02-26 18:19:14 +00:00
Dor Askayo
9401881a38 common: Add a missing dependency on cc-common-resources.h
cc-common-resources.h is used by both libwidgets and liblanguage, and
so must be generated before they build. However, Meson wasn't aware
of this dependency which resulted in a race condition during build.

Conveniently, "generates_sources_dep" already contains other generated
sources used by these two libraries, so adding cc-common-resources.h
to this list is enough to declare the dependency.
2022-02-25 16:10:58 +00:00
Brandon Nielsen
18b7f6f026 Simplify callback logic in ppd_selection_cb.
This ensures user_callback does not get called twice when cancelling out
of the ppd selection dialog. Fixes #1599, introduced with 179bda1b / MR: 1011.
2022-02-25 11:44:14 +00:00
Ana Cabral
43bb1d9200 network: Fix OWE settings
Enhanced Open (OWE) is not being saved properly from connection-editor.
When we create a Wi-Fi connection using Enhanced Open (OWE) Security
from nm-connection-editor and save it, it was not being saved and the
security was being set as "None", with Wireless Security Setting
being discarded. This is fixed by this commit. The fix is also being
done in libnma (implementing OWE in libnma,
https://gitlab.gnome.org/GNOME/libnma/-/issues/9), but this commit
fixes meanwhile it gets ready.

It was solved by adding treatment for the case in which owe was set.
OWE is not treated anymore in the same case as None.

https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1521
2022-02-24 12:56:43 +01:00
Felipe Borges
28edca0f16 sound: Connect to "clicked" signal for the sound alert buttons
The sound alert buttons are grouped GtkToggleButtons, and for some
reason they won't get activated in the right order when tapping to
the "toggled" event. Connecting to "clicked" makes the signal order
emission correctly.

Fixes #1655
2022-02-23 11:17:50 +01:00
Marek Kasik
f7bd51e812 printers: Remove authentication-dialog.ui
The dialog was removed in 2016 but we forgot to remove the UI file.

Fixes #1650
2022-02-22 12:44:12 +01:00
Bastien Nocera
0947ae2557 power: Fix scenario tester running upowerd under jhbuild
A logic error meant that the systemd upowerd would always be used.
2022-02-17 14:55:13 +00:00
Georges Basile Stavracas Neto
dddd3f62c3 display: Box Night Light temperature vertically
Instead of being in the horizontal end of the row, move
the temperature scale to a second row.

Related: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1587
2022-02-15 19:35:18 +00:00
Georges Basile Stavracas Neto
8b05bc91d3 display: Remove labels from Night Light temperature scale
As per mockups.
2022-02-15 19:35:18 +00:00
Mohammed Sadiq
8dc39c8831 wwan: Remove a never reached code
Since we return early, the code followed is never run.
Also, the password for GSM APNs are not actually sensitive
secrets.  So Remove the lines that are never reached.
2022-02-15 16:34:30 +00:00
Alessandro Bono
10489fb208 net-vpn: Don't append VPN in the title of the editor dialog
We don't do anything similar for other connections editors (wired and WiFi).
We alredy know that we are modifying a VPN, no need to repeat ourself.
2022-02-15 14:42:13 +00:00
Alessandro Bono
ce1c00be5d net-vpn: Don't append VPN to each row
We don't do anything similar for other connections rows (wired and WiFi).
All the rows are VPNs. No need to repeat ourself.
2022-02-15 14:42:13 +00:00
Pablo Correa Gómez
fcbe0c039b user-accounts: Try non TRANSLIT conversion if TRANSLIT conversion fails
This fixes a crash in musl-based systems, where TRANSLIT is not
implemented. I followed musl-maintainer recommendation[1] of doing
a run-time check to verify the behavior under these circumstances.

[1] https://github.com/akrennmair/newsbeuter/issues/364#issuecomment-250208235
2022-02-15 14:08:04 +00:00
Felipe Borges
1f693be757 user-accounts: Reset avatar widget when changing user pages
Otherwise the same source image is going to be used for other users
that don't have their own avatar image set.
2022-02-15 13:57:55 +00:00
Pablo Correa Gómez
c5ca6717e5 wwan: Make sure secrets are set when querying connection APN password
Otherwise the comparison in wwan_data_apn_are_same will always be False
due to nm_setting_gsm_get_password always returning NULL.

Helps #1468
Relates !1059
2022-02-15 13:46:48 +00:00
Christopher Davis
9a2cd1b5d2 keyboard: Don't dim input chooser icons
We generally don't dim icons in rows anymore.
2022-02-13 13:33:25 +00:00
Christopher Davis
4ccf6e670b keyboard: Adjust input chooser widgetry
Adjusts the widgetry of the input chooser to clamp
the list and add a separator between the search bar
and the list.

The list's shadow is no longer clipped, and keyboard
navigation now scrolls.
2022-02-13 13:33:25 +00:00
Christopher Davis
cd4dd18f52 keyboard: Handle keynav-failed on input source list
Fixes keynav with arrows between the input list
group and other groups.
2022-02-13 13:33:25 +00:00
Christopher Davis
1a3971fdbe keyboard: Allow input list rows to manage their own size
Using GtkSizeGroup causes weird jumping,
and size groups generally should not be used for
boxed list rows.
2022-02-13 13:33:25 +00:00
Christopher Davis
ced8c1cb99 keyboard: Use GAction and GMenuModel for input row popovers
Gives these menus proper styling without having to
roll our own widgets.

Also removes the Remove button when the action is
disabled.
2022-02-13 13:33:25 +00:00
Christopher Davis
530fbac68e keyboard: Subclass AdwActionRow for InputRow 2022-02-13 13:33:25 +00:00
Christopher Davis
485dd456bb keyboard: Use AdwActionRow for input switch rows 2022-02-13 13:33:25 +00:00
Christopher Davis
84becfbd80 keyboard: Use AdwPreferences{Page,Group} 2022-02-13 13:33:25 +00:00
Christopher Davis
328da2fa14 diagnostics: Use AdwPreferences{Page,Group}, AdwActionRow 2022-02-13 13:26:43 +00:00
Rafael Fontenelle
fafd093fbd usage: fix typo 2022-02-12 23:27:05 +00:00
Rafael Fontenelle
ba3410f380 microphone: remove extra newline and spaces
The extra line was causing newline chars and whitespaces to be added
to translation strings
2022-02-12 22:37:31 +00:00
Mohammed Sadiq
0452e9eb4d network: Fix a possible memory leak in QR code
It's possible that the QR code for the same text has been requested,
but for a different size.  Fix a memory leak that would happen
in those cases.
2022-02-12 21:47:07 +00:00
Christopher Davis
7c9c42fb65 usage: Use AdwComboRow for "File History Duration" 2022-02-12 13:32:22 -08:00
Christopher Davis
a95b57061b usage: Use AdwComboRow for "Automatically Delete Period" 2022-02-12 13:32:22 -08:00
Christopher Davis
a3c31fcda3 usage: Use AdwPreferences{Page,Group}, AdwActionRow
Uses AdwPreferencesPage and AdwPreferencesGroup for
consistency with the rest of the application. The
combo rows now use AdwActionRow so they can be
included in the AdwPreferencesGroup without
a custom list box.
2022-02-12 13:32:22 -08:00
Carlos Garnacho
7371dbb35c wacom: Explicitly discard input from touchscreens
Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1612
2022-02-12 16:03:37 +00:00
Carlos Garnacho
57e5144f41 wacom: Avoid reset on spurious size changes
This is a possible reason for undesired calibration resets.

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1613
2022-02-12 16:03:37 +00:00
Carlos Garnacho
3f12a7d2cb wacom: Allow NULL monitors in calibration
Unfortunately, this may be the case, it is better to show wonky UI
than no UI at all.
2022-02-12 16:03:37 +00:00
Carlos Garnacho
6c6499e23e wacom: Pass GdkMonitor directly to calibrator object
Instead of figuring out a monitor number from a GdkMonitor, and
look the GdkMonitor back up, pass the GdkMonitor directly.
2022-02-12 16:03:37 +00:00
Carlos Garnacho
6756710996 wacom: Make calibrator retrieve dimensions from window
So we can fullscreen on a monitor and forget.
2022-02-12 16:03:37 +00:00
Carlos Garnacho
ec5ad4d3e4 wacom: Turn CcCalibArea into a window subclass
Modernize a bit the code, since it will be easier to do some things
as a window subclass.
2022-02-12 16:03:37 +00:00
Carlos Garnacho
fce8b631cc wacom: Rename calibrator API
Add "Cc" prefix so it's more consistent with the rest of the project.
2022-02-12 16:03:37 +00:00
Carlos Garnacho
1777a42aef wacom: Update/unbreak calibrator
It got to a building state in the GTK4 port, but was broken at
runtime. Update event handlers and builder objects so it works again.
2022-02-12 16:03:37 +00:00
Carlos Garnacho
e26ea4e6d1 wacom: Drop dead code
These dimensions are no longer used.
2022-02-12 16:03:37 +00:00
Carlos Garnacho
3d4d785588 wacom: Drop unused API
This function was only used for logging purposes, we can do
without it.
2022-02-12 16:03:37 +00:00
Ivan Molodetskikh
3ecc151061 keyboard: Remove 01-screenshot.xml
Move this to gnome-shell where it belongs. See
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2107
2022-02-12 12:18:29 +00:00
Christopher Davis
3f851bd793 microphone: Use AdwActionRow 2022-02-12 11:51:21 +00:00
Christopher Davis
ab950bbfb5 microphone: Use AdwPreferences{Page,Group} 2022-02-12 11:51:21 +00:00