The language chooser dialog is used in the users panel repeatedly.
When we click to show more languages and/or select language, close
the dialog and show it again e.g. for different user, the chooser
isn't in an original state. So filter entry isn't hidden (and all
languages are shown) and/or the last selected language is focused.
But the dialog should be in the original state when it is open.
This patch changes cc_language_chooser_clear_filter to clear the
dialog into the original state that we can reuse the dialog later.
https://bugzilla.gnome.org/show_bug.cgi?id=738077
Cheese has an internal copy of UmCropArea, and exports the corresponding
um_crop_area_get_type() as part of libcheese-gtk. This leads to a crash
when taking a photo in the avatar chooser, as the control center copy of
the get_type() function is used. Renaming the function in Cheese would
be an ABI break, so at this stage it is best to do the rename in the
control center instead.
https://bugzilla.gnome.org/show_bug.cgi?id=697039
This lines are dead code, because act_user_get_language() returns empty
string if language isn't set. We don't want to fix the condition, because
cc_common_language_get_current_language is wrong for other users.
https://bugzilla.gnome.org/show_bug.cgi?id=737216
If language is unknown and language chooser is cancelled, panel crash
with the following error:
(gnome-control-center:24952): Gtk-CRITICAL **: gtk_list_store_get_path:
assertion 'iter->stamp == priv->stamp' failed
(gnome-control-center:24952): Gtk-CRITICAL **: gtk_list_store_get_value:
assertion 'iter_is_valid (iter, list_store)' failed
(gnome-control-center:24952): GLib-GObject-WARNING **: gtype.c:4221:
type id '0' is invalid
(gnome-control-center:24952): GLib-GObject-WARNING **:
can't peek value table for type '<invalid>' which is not currently referenced
Segmentation fault (core dumped)
https://bugzilla.gnome.org/show_bug.cgi?id=738002
If the language chooser is confirmed and no language is selected,
"Other..." is shown as user's language and the following error is printed:
(gnome-control-center:14608): AccountsService-CRITICAL **:
act_user_set_language: assertion 'language != NULL' failed
Autologin widgets are different in height as compared with other widgets,
which looks odd. Put all the widgets in the sizegroups, to have same
height.
https://bugzilla.gnome.org/show_bug.cgi?id=737343
The notification is wider then window for some languages (e.g.
France). This patch allows wrapping, limits chars and changes
margin as a result of discussion on #gnome-design.
https://bugzilla.gnome.org/show_bug.cgi?id=703392
Making containers take focus is almost never right. In this
case, it disrupts the focus chain in the dialog, because the
focus gets stuck on the stack.
https://bugzilla.gnome.org/show_bug.cgi?id=736223
Instead of using a GtkGrid and GtkBox to mimic what GtkStack and
GtkStackSwitcher already does for us, let's just use the latter. As a
result each source now has its separate GtkIconView. The pictures
source has a nested GtkStack to switch between the 'empty' box and the
view, which should simplify size-related issues.
https://bugzilla.gnome.org/show_bug.cgi?id=736366
When the GrlSourceResultCb callback is called, the media's ownership is
given to the callback function (as per documentation that says "media"
is "transfer full").
There are three cases which affect our size calculation:
- When the dialog is without a parent in the test application.
- When the dialog is maximized on small screens.
- When the dialog is used with an unmaximized parent.
The width of the chooser is much more than half the width of the parent
in the third case. So there is no point in doing it.
The width that we set for the grid in the content area is actually what
is useful.
https://bugzilla.gnome.org/show_bug.cgi?id=736366
By stopping watching for WM changes when leaving the shortcuts panel.
#0 reload_sections
#1 wm_window_event_filter
#2 gdk_event_apply_filters at gdkeventsource.c:81
#3 gdk_event_source_translate_event at gdkeventsource.c:195
#4 _gdk_x11_display_queue_events at gdkeventsource.c:338
#5 gdk_display_get_event at gdkdisplay.c:313
#10 g_main_context_iteration at gmain.c:3766
#11 g_application_run at gapplication.c:1623
See https://bugzilla.redhat.com/show_bug.cgi?id=1094480https://bugzilla.gnome.org/show_bug.cgi?id=736117
And virtual devices. Again, listening on the long-lasting client
object but expecting the user_data (the object) to be around when
it might have been destroyed already.
https://bugzilla.gnome.org/show_bug.cgi?id=735932
For now its just a switch to enable/disable geolocation through
gnome-shell's setting. In future we'll hopefully at least have
controls to enable/disable geolocation for applications from here.
https://bugzilla.gnome.org/show_bug.cgi?id=731119
When disabling a keybinding, we set its value to { "", NULL } in gsettings
(bindings are stored as arrays of strings).
However, when a binding is disabled by default, its value is set to {
NULL }, not to the empty string.
The use of "" dates back to gconf where I think NULL was not a valid
value. Now that we have switched to gsettings, we can use NULL rather
than an artificial "".
https://bugzilla.gnome.org/show_bug.cgi?id=732383
If a KeyListEntry has a hidden="true" attribute, then the corresponding
binding information will be loaded as usual, but the binding won't be
displayed in the user interface.
This is useful as the keyboard panel will take into account hidden
keybindings when detecting conflicting shortcuts, or to suggest to set a
reverse shortcut.
For now, this will be used for the various reverse mutter keybindings
({switch,cycle}.*-backward) as they should not be shown in the UI, but
we still want the keyboard panel to know about them.
https://bugzilla.gnome.org/show_bug.cgi?id=731618
Now that the keyboard panel knows how to handle reverse shortcuts, we
can start annotating the existing ones with the needed XML attributes.
This commit does that with switch-input-source{-backward}.
Note that some changes in some modules are needed for this to work
correctly.
In this case, a default value needs to be set for
switch-input-source-backward in gsettings-desktop-schemas, and the
Meta.KeyBindingFlags.REVERSED flag needs to be removed from the
shortcuts defined in gnome-shell source. Instead of having
mutter handle the reversion with 'shift' by itself, it's now handled
explicitly through gsettings keys.
https://bugzilla.gnome.org/show_bug.cgi?id=731618
