Commit graph

7876 commits

Author SHA1 Message Date
Felipe Borges
ae98f7d834 user-accounts: Turn "no-users-box" into an error page
We only have no users when we are unable to connect to accountsservice.
2023-08-14 07:55:45 +00:00
Felipe Borges
d7ba866f01 user-accounts: Port GtkMessageDialogs in user deletion to AdwMessageDialog 2023-08-14 07:55:45 +00:00
Felipe Borges
84d3d8dc59 user-accounts: Remove MessageDialog for deleting own account
Our UI doesn't expose the Delete button when the current logged user
is the one viewing its account settings. So there's no need to have
this dialog since it never gets shown.
2023-08-14 07:55:45 +00:00
Felipe Borges
24f50295c4 user-accounts: Port CcAddUserDialog away from deprecated GtkDialog
This is a bare minimum to get rid of GtkDialog. There are upcoming
changes to modernize the dialog.
See https://gitlab.gnome.org/Teams/Design/settings-mockups/-/raw/master/users/add-user.png
2023-08-14 07:55:45 +00:00
Felipe Borges
f5a008ce74 info-overview: Make System Details dialog more compact
Following the mockups at
https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2573#note_1805506

Fixes #2573
2023-08-14 06:34:03 +00:00
Felipe Borges
0c9498d1f8 Mark some strings as translatable
These are strings that are presented in the UI that were not marked
for translation.

Fixes #2596
2023-08-11 12:07:00 +02:00
Felipe Borges
52ca3bbf14 sharing: Remove placeholder strings from UI file
Those strings are set in the C file.
2023-08-11 12:05:39 +02:00
Automeris naranja
63c15f8641 a11y: Improve "Locate Pointer" setting discoverability
Make easier to find the "Locate Pointer" setting using
the search function by adding new keywords to the *.desktop.in file:
"locate", "find" and "pointer".

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2581
2023-08-09 22:51:40 +00:00
Markus Göllnitz
3fb3f547c7 sound: make output test wheel smaller
The output test wheel is fixed size with a size of 300px
and a margin of 60px on both sides. Decreasing each value
by 20px, makes it fit a width (and height) of 360px.

see: !1563

Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
2023-08-07 10:54:16 +00:00
Markus Göllnitz
f7f6139e83 sound: ellipsize in profile combo box
While the combo box for devices can get ellipsized labels,
the one for the profile cannot. For Bluetooth profiles
with long descriptive names, this can lead to large
minimal widths for the combo box, the row, and the panel.

Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
2023-08-07 10:54:16 +00:00
Automeris naranja
8a8973f860 datetime: Explain that Clock & Calendar settings affect the date & time info from Shell's top bar
The Clock & Calendar settings are a bit vague.
Add an explanation to inform that these settings will affect the
date & time information from Shell's top bar.

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2592
2023-08-07 10:28:17 +00:00
Felipe Borges
fc9251c880 Revert "cc-power-panel: add battery health section"
This reverts commit 4a0d924afd.

There are some rough edges to be polished before this is ready for
prime time.

UPower battery health capacity reporting can often be inconsistent
across vendors, and we don't want to expose unreliable information
on the UI without proper sanitization.
2023-08-07 12:18:33 +02:00
Marco Melorio
cdea4b4503 privacy: Make security dialogs consistent
Port them to AdwWindow and AdwToolbarView, simplify the widgetry and use
a consistent styling and window size.
2023-08-06 14:11:08 +00:00
Marco Melorio
49f037595d privacy-panel: Improve subpage row descriptions 2023-08-06 14:11:08 +00:00
Marco Melorio
a2f65a0471 privacy-panel: Group the subpage rows 2023-08-06 14:11:08 +00:00
Eric Daigle
4a0d924afd cc-power-panel: add battery health section
As described in #2554, it would be useful to be able to see battery health information
such as charge capacity in Settings. This commit implements the proposed design for
battery health information, adding this functionality to the power panel.

Closes #2554
2023-08-04 09:40:07 +00:00
Marco Melorio
287e2371a4 firmware-security: Simplify widgetry
Use a GtkStack instead of a AdwLeaflet in the security and heavily
simplify the security dialog, because it contained a lot of misued
widgets and also a page that was never made visible.
2023-08-03 08:42:10 +00:00
Marco Melorio
0dcebeee9d privacy: Format all UI files 2023-08-03 08:42:10 +00:00
Marco Melorio
5c75c03b52 privacy: Add thunderbolt page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
71349d80d9 privacy: Add device security page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
8ea49662d6 privacy: Add microphone page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
4eefc51dd2 privacy: Add camera page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
6dac508732 privacy: Add location page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
ef58f0e097 privacy: Add diagnostics page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
c94afe06a8 privacy: Add usage page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
b2eaa54d7d privacy: Add screen lock page
The UI file is not formatted on purpose to facilitate the review. It
will be reformatted in a later commit.
2023-08-03 08:42:10 +00:00
Marco Melorio
81dd3de928 panels: Add empty Privacy panel with navigation
It will be filled in later commits.
2023-08-03 08:42:10 +00:00
Marco Melorio
31a91a221c shell: Disable privacy panels temporarely
It will be reimplemented in a single panel in later commits.
2023-08-03 08:42:10 +00:00
Alice Mikhaylenko
d2ebbf1fec region: Fix preview buttons in the format chooser
This never worked.
2023-08-02 12:52:01 +00:00
Alice Mikhaylenko
ee4c5f8115 search: Stop using AdwPreferencesWindow for search locations window
That's not what it's for.
2023-08-02 12:51:48 +00:00
Alice Mikhaylenko
52f4919c94 network: Stop using AdwPreferencesWindow for the saved networks dialog 2023-08-02 12:51:48 +00:00
Alice Mikhaylenko
f3640d83d3 network: Consistently make options buttons flat 2023-08-02 12:51:48 +00:00
Alice Mikhaylenko
8df9709240 info-overview: Add mnemonic to the copy button 2023-08-02 12:51:48 +00:00
Alice Mikhaylenko
3535479c23 info-overview: Use AdwButtonContent for the copy button 2023-08-02 12:51:48 +00:00
Alice Mikhaylenko
232d4e6ff5 printer-entry: Use a card for the printer rows 2023-08-02 12:51:48 +00:00
Alice Mikhaylenko
81a3c3dd15 network: Fix up proxy page and port to AdwSpinRow 2023-08-02 12:51:48 +00:00
Marcos Miller
61955e46d0 general: replace gtk_widget_translate_coordinates
The method gtk_widget_translate_coordinates is deprecated in gtk 4.12.
Use a new method gtk_widget_compute_point instead.

general: Apply suggestions graphene point
2023-07-21 09:14:20 +00:00
Markus Göllnitz
c26c52aaee usage: make file history's buttons shrinkable
The homogeneous on their boxes has no visible effect, as
the buttons lack hexpand. It, however, still influences
the box's minimal width unnecessarily. Thus, removing it
decreases the panel's minimal and natural width without a
visible change otherwise.

Making those buttons can-shrink also decreases their and
henceforth the panel's minimal width. With this change,
the panel can shrink to a width of 360px, with a natural
width not far from it.

Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
2023-07-19 10:23:33 +00:00
Cyber Phantom
aec265db7d user-accounts: Only show Other Users row when there is at least one other user 2023-07-19 08:44:16 +00:00
Felipe Borges
cc5b7c14c3 info-overview: Hide entire software updates group instead of row
We were only hiding the updates row, leaving its AdwPreferencesGroup
visible with no rows.

Let's hide the entire group instead.
2023-07-19 08:38:26 +00:00
Lukáš Tyrychtr
8c361e28cc info-overview: Label the system details that they make sense with a screen reader
Before this, the user could easily only access the property values,
not te names or group titles.
2023-07-18 13:51:31 +00:00
Lukáš Tyrychtr
ba79d849af displays: Use an AdwComboRow for the schedule type of the night light page
GtkComboBox is deprecated and not accessible, so this one is definitely better from this point of view.
2023-07-18 08:29:43 +00:00
Cyber Phantom
32f2d9ea8d info-overview: Style the system information output as markdown 2023-07-17 09:25:26 +00:00
Cyber Phantom
27a20b026d info-overview: Show a toast notification when copying system report
It helps to imply that the copy action has completed.
2023-07-17 09:25:26 +00:00
Cyber Phantom
e90321f89b info-overview: Make the "Copy" button functional
The copy button now generates a system information report with all the system information.
The information is generated by calling the same methods used when populating the System Information window.
2023-07-17 09:25:26 +00:00
Cyber Phantom
b9a905f298 info-overview: Create dbus proxy inside get_gnome_version
get_gnome_version() relies on shell_proxy_ready() to provide it with shell proxy.
This means that we cant call get_gnome_version() without providing proxy as an argument which is fine normally but becomes tedious if we want to call this function multiple times in different scopes.

Fix this by creating the shell proxy inside get_gnome_version() function instead.
2023-07-17 09:25:26 +00:00
Cyber Phantom
2a1e5a5de8 info-overview: Remove unused gpu_data_free function
Since we're no longer processing the list of graphics devices inside of get_renderer_from_switcheroo, there's no need for this function
as the the list now gets passed around to a different function and automatically freed once it goes out of scope.
2023-07-17 09:25:26 +00:00
Cyber Phantom
f4bc3efb0f info-overview: Reverse the weights of default and non default GPUs in gpu_data_sort
Default and non default GPUs were associated with a weight of 1 and -1 respectively which meant default gpus were treated
as a "bigger" entity than non default ones. It meant that when sorting a list of GpuData, the default gpu would end up
at the end of the list since it was treated as the biggest. The resultant list after sorting would end up something like

our pointer
  |
  |
<gpu>, <gpu>, <gpu>, <gpu>, <default gpu>

With this change the weights of these gpus have been exchanged, making the default gpu to be treated as "smaller" this
changing the order of the sorted list into something like

our pointer
  |
  |
<default gpu>, <gpu>, <gpu>, <gpu>, <gpu>

This is pretty useful because when creating the gpu information row entries in create_graphics_rows, the default gpu is processed first so it becomes the first element added to the gpu entry list which is how we would expect it to be.
2023-07-17 09:25:26 +00:00
Cyber Phantom
7883b8e200 info-overview: Don't put an index at the end of default graphics device
This change brings it more inline with the mockup and it makes sense to not have a number for the default graphics device as that
s always going to be the first device.
2023-07-17 09:25:26 +00:00
Cyber Phantom
9b6993607f info-overview: Show each graphics device in it's own row
Part 1:

Currently all graphics devices have to share a single row for their names, this method doesn't pretty well for devices with long names or computers that may have multiple GPUs.
The new mockup fixes this by having a separate entry for each graphics device.

This commit turns graphics_row into a GtkBox, graphics_row is going to act like a space where gpu entries will be placed.
graphics_row will be populated in the code using create_graphics_row() to have separate entries for each graphics device

Part 2:

Currently all graphics devices have to share a single row for their names, this method doesn't pretty well for devices with l>
The new	mockup fixes this by having a separate entry for each graphics device.

This commit adds a method to popuplate graphics_row with GPU information entries.
It uses the existing logic from get_renderer_from_switcheroo to iterate over a list of graphics devices and build a CcInfoEntry for each device.
It finally appends the widget to graphics_row

Part 3:

Currently all graphics devices have to share a single row for their names, this method doesn't pretty well for devices with l>
The new mockup fixes this by having a separate entry for each graphics device.

The list of graphics devices is now processed in create_graphics_rows function, so remove that logic from get_renderer_from_switcheroo () and return a GSList instead of a string.
graphics_hardware_string has been renamed to graphics_hardware_list to imply the change.
Since create_graphics_rows expects a list, get_graphics_hardware method has been modified to create a renderer list from the outputs of get_renderer_from_session or get_renderer_from_helper in case that get_renderer_from_switcheroo fails.
2023-07-17 09:25:26 +00:00