We can use this from the different NetDevice types, and once all the devices are
converted to actual NetDeviceFoo-style objects we can remove the legacy code in
cc-network-panel.c
A source file with 4k lines of code is not understandable, and the glade file
was becoming quite a challenge for glade.
To add more features we need to split things up just to keep them maintainable.
This is the first patch that just splits out the proxy bits. Other device types
will follow in the next few days.
Keep the active network at the top, and 'Other' at the bottom.
the other access points are sorted by strength now.
https://bugzilla.gnome.org/show_bug.cgi?id=678505
Signed-off-by: Richard Hughes <richard@hughsie.com>
The libnm objects can survive the disposal of the network panel.
If we don't disconnect the signal handlers on them, bad things
can happen. Use g_signal_connect_object to tie the life-cycle
of the signal handlers to the panel.
https://bugzilla.gnome.org/show_bug.cgi?id=677969
Signed-off-by: Richard Hughes <richard@hughsie.com>
When switching between devices, the Options buttons were jumping
up and down. This patch makes them stay put in the lower right corner.
The patch also removes a bunch of glade placeholder gunk from the
ui file.
https://bugzilla.gnome.org/show_bug.cgi?id=677054
Signed-off-by: Richard Hughes <richard@hughsie.com>
Sort the strength and security indicators in the combo box
popup to be in the same order as the shell menu.
https://bugzilla.gnome.org/show_bug.cgi?id=677788
Signed-off-by: Richard Hughes <richard@hughsie.com>
This is the most common case, and is the page we want to end up
on when we're coming from the shell menu.
https://bugzilla.gnome.org/show_bug.cgi?id=677791
Signed-off-by: Richard Hughes <richard@hughsie.com>
APs that don't broadcast their SSID will return NULL from
nm_access_point_get_ssid() (since that's easier to check in C
using an if statement than returning a zero-length GByteArray).
Thus the code shouldn't try to dereference the SSID byte array
since it could be NULL.
But in fact, the panel shouldn't be showing hidden APs anywhere
in the UI, since the user needs to manually enter the SSID to
connect to it anyway. So just ignore hidden APs like nm-applet
does.
Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: Richard Hughes <richard@hughsie.com>
This prevents the chicken-and-egg problem as described in #653296 by launching
nm-connection-editor for the inactive connection for the device.
This only works when there is one possible connection for the device, which is
helpfully typical for wired ethernet devices.
Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=653296
