Commit graph

5130 commits

Author SHA1 Message Date
Sebastien Bacher
be90d59991 privacy: use the correct gsd housekeeping bus name
https://bugzilla.gnome.org/show_bug.cgi?id=737624
2017-11-01 17:05:45 +01:00
Rui Matos
cb4a7e1773 network: Avoid crashing if NM reports no devices or no connections
Seems like NM changed behavior recently but, in any case, better safe
than sorry.

https://bugzilla.gnome.org/show_bug.cgi?id=788716
2017-11-01 16:47:36 +01:00
Robert Ancell
6723ff4d2b background: Drop dead background screenshot code
The screenshot was only trying to capture gnome-shell's top bar to
overlay on the background preview but now on 3.26 the top bar might be
transparent which obviously wouldn't work at all for previewing a
different wallpaper.

https://bugzilla.gnome.org/show_bug.cgi?id=788206
2017-11-01 16:09:22 +01:00
Xiang Fan
959d841713 network/proxy: destroy dialog with the class
The dialog has several bindings to proxy settings, so it shouldn't
outlive the proxy class.

https://bugzilla.gnome.org/show_bug.cgi?id=788776
2017-11-01 16:08:45 +01:00
Rui Matos
8ae6950248 network/eap-method-tls: Don't require a private key password
The private key may be unencrypted or we might want to enable "always
ask".

https://bugzilla.gnome.org/show_bug.cgi?id=789660
2017-10-30 18:16:43 +01:00
Andrea Azzarone
dc46487081 sound: Discard selection-changed events that are not triggered by the user
The tree view in the input and the output tab uses the "selection-changed"
signal. This implies that when a row is removed (e.g. when unplugging heaphones) g-c-c
will receive the signal and try to change the active port. G-c-c should not be the one
deciding deciding which port should be active, the user or PA are smart enough. We
should descard selection-changed events that are not triggered by an user interaction.

https://bugzilla.gnome.org/show_bug.cgi?id=789551
2017-10-30 16:49:26 +01:00
Debarshi Ray
5a04e40fef Revert "online-accounts: Accept requests for account creation on ..."
It's been more than four years and nobody ended up using this feature.
However, the extra cookie management that's necessary to implement this
feature has now exposed code, which people actually use, to a
WebKitGTK+ bug that's taking quite some time to be fixed. Therefore,
this is a good an excuse as any to remove this code.

This reverts commit 8762e2f8dc

https://bugzilla.gnome.org/show_bug.cgi?id=789469
2017-10-25 12:34:45 +02:00
Jeremy Bicha
eefc10dbe5 notifications: Add help link
https://bugzilla.gnome.org/show_bug.cgi?id=789321
2017-10-24 11:42:31 -04:00
Jeremy Bicha
c9c1ba5f11 wifi: Fix help link
https://bugzilla.gnome.org/show_bug.cgi?id=789321
2017-10-24 11:42:31 -04:00
Felipe Borges
614fb9e27a printers: Make sure IPP_STATE_IDLE is defined
This changes are necessary because we don't require cups >= 1.4,
due to downstreams still shipping old cups versions.

The IPP_STATE_IDLE symbol has been introduced in cups 1.7. The
IPP_IDLE constant has been deprecated.

https://bugzilla.gnome.org/show_bug.cgi?id=789397
2017-10-24 12:34:54 +02:00
Jakub Steiner
8bfd0b97d6 sound: update artwork
- restyle all assets symbolic
- add missing mono speaker

https://bugzilla.gnome.org/show_bug.cgi?id=775170
2017-10-17 23:54:28 +02:00
Philip Withnall
be135e6263 info: Ignore more virtual file systems
Signed-off-by: Philip Withnall <withnall@endlessm.com>

https://bugzilla.gnome.org/show_bug.cgi?id=788878
2017-10-12 14:47:20 +01:00
Jeremy Bicha
6d1c5dbf4d info: Fix .desktop for About
https://bugzilla.gnome.org/show_bug.cgi?id=788608
2017-10-09 17:13:08 -04:00
Rui Matos
338719a876 network/wifi: Use cancellables for NM async operations
Our NM async callbacks already handle being cancelled and we already
have a cancellable in the base NetObject class, we just weren't wiring
it up to the async calls. Do that to prevent use after free crashes.

https://bugzilla.gnome.org/show_bug.cgi?id=787010
2017-10-03 19:18:59 +02:00
Robert Ancell
43129a1cfd sound: Use G_DEFINE_TYPE 2017-09-26 21:09:56 -04:00
Robert Ancell
e779a30927 datetime: Use G_DEFINE_TYPE 2017-09-26 20:20:45 -04:00
Robert Ancell
999226832c info: Use G_DEFINE_TYPE 2017-09-25 16:11:32 -04:00
Robert Ancell
88bf8cfc57 bluetooth: Use G_DEFINE_TYPE 2017-09-25 16:04:21 -04:00
Robert Ancell
378e837a06 background: Use G_DEFINE_TYPE 2017-09-25 14:16:09 -04:00
Ondrej Holy
51c9a3235b user-accounts: Fix password strenght check
It is possible to use weak passwords in dialogs currently, which is
not intentional and leads to problems in case of changing password of
current user. This regression was introduced by Bug 780002, which added
new strength level for weak passwords. Let's reflect the new level also
when setting sensitivity...

https://bugzilla.gnome.org/show_bug.cgi?id=788122
2017-09-25 14:23:24 +02:00
Volodymyr Buell
daec536e25 background: Reduce the number of pixbuf creation by caching
https://bugzilla.gnome.org/show_bug.cgi?id=765887
2017-09-22 15:25:04 +02:00
Sebastien Bacher
12ddb730d6 color: set min-content-height on the profiles list
otherwise there is only space for one line to be displayed
https://bugzilla.gnome.org/show_bug.cgi?id=787931
2017-09-20 10:29:37 -03:00
Georges Basile Stavracas Neto
5a3b19ef33 network: Don't unref device after when parsing arguments
When we add the NetDevice pointer to the GPtrArray, we have
a single reference owned by the panel. When iterating over
this GPtrArray, no reference is taken.

The problem is that the code to handle command-line arguments
was unreferencing the NetDevices when iterating over it,
creating a disparity in the ref/unref pairs.

Fix that by simply not unreferencing the NetDevice instance
when iterating over it.

https://bugzilla.gnome.org/show_bug.cgi?id=786514
2017-08-29 18:11:30 -03:00
Rui Matos
2556fd5e2c sharing: Make use of the cancellable for async hostname calls
We have it initialized and disposed and the async calls already handle
being cancelled. We just forgot to actually use it.

https://bugzilla.gnome.org/show_bug.cgi?id=786984
2017-08-29 19:26:58 +02:00
Rui Matos
94045b8418 sharing: Remove an unused variable
https://bugzilla.gnome.org/show_bug.cgi?id=786984
2017-08-29 19:26:58 +02:00
Rui Matos
f959b9127b sharing: Make panel initialization asynchronous
https://bugzilla.gnome.org/show_bug.cgi?id=786984
2017-08-29 19:26:58 +02:00
Rui Matos
58bad723ee sharing: Show the networks widget in the screen sharing dialog
The way it works is independent of the service so there's no reason
not to show it. We should also hide the remote-control-box widget
hierarchy since those can't be used here.

https://bugzilla.gnome.org/show_bug.cgi?id=786565
2017-08-29 19:26:58 +02:00
Jonas Ådahl
ecb0e6dd23 sharing: Add Wayland screen sharing support
This allows enabling screen sharing support under Wayland, as long as
the org.gnome.Mutter.RemoteDesktop D-Bus name is exported by mutter /
gnome-shell. That name will currently only be exported if the
corresponding experimental features has been added to mutter.

So far nothing is configurable, as gnome-remote-desktop is yet to be
configureable.

https://bugzilla.gnome.org/show_bug.cgi?id=786565
2017-08-29 18:55:42 +02:00
Rui Matos
99f26e4d0b search: Set a minimum height to avoid toplevel being resized too small 2017-08-28 18:58:05 +02:00
Jonathan Kang
a108ee19b9 search: don't allow horizontal scrolling
Set hscrollbar_policy property of GtkScrolledWindow to never to
disable horizontal scrolling.

https://bugzilla.gnome.org/show_bug.cgi?id=785397
2017-08-28 18:58:05 +02:00
Rui Matos
23d5ea29aa display: Round the displayed scale values logically
Mutter currently generates 4 scales per integer scale. Knowing that,
we can nicely "round" the values we display to what the ideal scales
are even though the real values might be skewed since mutter creates
scale values close to the ideal ones that yield integer logical sizes.

https://bugzilla.gnome.org/show_bug.cgi?id=786922
2017-08-28 18:58:05 +02:00
Rui Matos
bbccf27488 display: Simplify scale filtering
This is prone to miss intermediate values that users might actually
want to use so, for now, just show the 5 first scales.
2017-08-28 18:58:05 +02:00
Rui Matos
a4a243cee4 display: Round scaled logical monitor sizes the same way mutter does
Mutter uses round() while we are just truncating via the implicit
double -> int type conversion, meaning that mutter will reject some
configurations that should work. Fix that by using the same rounding
as mutter.

https://bugzilla.gnome.org/show_bug.cgi?id=786919
2017-08-28 18:58:05 +02:00
Rui Matos
5622704b74 info: Avoid a crash when we're cancelled
If we're cancelled, the panel is being finalized so return immediately
instead of iterating further and crashing.

https://bugzilla.gnome.org/show_bug.cgi?id=786097
2017-08-28 18:58:05 +02:00
Rui Matos
6ee793118a info: Don't leak GUnixMountEntry instances if we're cancelled
If we're cancelled the mount entries list might not have been totally
consumed so free it on finalize if needed.

https://bugzilla.gnome.org/show_bug.cgi?id=786097
2017-08-28 18:58:05 +02:00
Rui Matos
546752f79e info: Don't leak GCancellables
We were just plainly leaking them and there's really no need since
GCancellable instances can be re-used.

https://bugzilla.gnome.org/show_bug.cgi?id=786097
2017-08-28 18:58:05 +02:00
Alexandre Franke
9db096e6e6 Add translator comment 2017-08-27 14:19:50 +02:00
Rui Matos
7ed4efef50 display: Show refresh rates with two digits after the radix
One digit isn't enough to distinguish between some modes. We probably
should do better mode filtering and/or grouping but that needs to
happen in mutter.
2017-08-25 16:49:02 +02:00
Rui Matos
6a9274a165 display: Don't show inactive monitors in the arrangement widget
Inactive monitors are not part of the configuration global geometry,
i.e. they don't have a position set, so it doesn't make sense to show
them.
2017-08-25 16:49:02 +02:00
Rui Matos
dae238cc5f display: Avoid crashing when a monitor doesn't have a mode set
In this case just avoid showing information we don't have.
2017-08-25 16:49:02 +02:00
Rui Matos
337802315c display: Ensure we generate the UI initially on two output mode
We rely on visible-child-name notifications to generate the
appropriate UI, unfortunately it doesn't happen for the first added
stack page if the widget is already visible. Work around this by
adding a dummy page first.
2017-08-25 16:49:02 +02:00
Rui Matos
6c4eb9fc86 display: Fix the two output UI to start with the current configuration
gtk_stack_set_visible_child_name() doesn't actually make a child
visible if the child widget isn't visible already which means we'd
always start in the first ("join") stack page even if the currently
applied configuration is one of the others.

https://bugzilla.gnome.org/show_bug.cgi?id=786767
2017-08-25 15:17:12 +02:00
Felipe Borges
c776ab1808 printers: Apply the vertical spacing standard
Settings panels are given 32px above and below their content
and 32px vertical space between major sections. 12px space is
placed below headings.

https://bugzilla.gnome.org/show_bug.cgi?id=786384
2017-08-24 15:23:41 +02:00
Felipe Borges
6a6f4b71d9 printers: Wrap GtkListBox inside a GtkBox
In order to vertically align the printers panel content by the
same standards as the other panels, we should set the GtkListBox
top and bottom margins to 32px.

This commit wraps GtkListBox inside a GtkBox to handle the Gtk+
issues discussed in Bug 773459 regarding the background of ListBox
margins.

This commit can be cleanly reverted once the issue is fixed in
Gtk+.

https://bugzilla.gnome.org/show_bug.cgi?id=786384
2017-08-24 15:23:41 +02:00
Rui Matos
57a82a89cd display: Cancel pending changes on Escape key press 2017-08-23 18:32:28 +02:00
Rui Matos
566d2cf6ac display: Add mnemonics to Cancel and Apply buttons 2017-08-23 18:32:28 +02:00
Rui Matos
a8071322a7 display: Move scale row above refresh rate
It's a bit closer to the mockups, in spirit at least.
2017-08-23 18:32:28 +02:00
Rui Matos
566b0c137c display: Make rows created for a new current output be the same size
We need the rows size group to exist when creating output UIs.
2017-08-23 18:32:27 +02:00
Rui Matos
0a0ac31b51 display: Handle lid being closed a bit better
If the lid is closed we shouldn't allow the builtin display to be
configured.
2017-08-23 18:32:27 +02:00
Rui Matos
088f35617c display: Make scale row be the same height as others 2017-08-23 18:32:27 +02:00