Commit graph

5 commits

Author SHA1 Message Date
Bastien Nocera
b36924567e network: Remove support for firewalld zones
Firewalld is a Fedora-only daemon, and it doesn't integrate all that
well with Fedora Workstation, the version of Fedora that uses GNOME, so
remove the support.

In Fedora Workstation, firewalld only ever supports one zone, as the
other ones are badly defined, and not translatable or translated.
2017-04-13 10:23:39 +02:00
Michael Catanzaro
5036ff0f80 network: Hide firewall zone combo when firewalld is not running
Currently, if firewalld is not running, then the firewall zone combo is
always insensitive. This would make sense if firewalld was great and we
were to consider it a distro bug to not have firewalld running and
enabled, then users would be able to see the option is disabled and
think "maybe my distro has done something wrong."

But in actuality, firewalld is not really great, only Fedora ships it
and we're not really recommending it to other distros. So hide the combo
if it's not running, else it's just broken on $NOTFEDORA.

https://bugzilla.gnome.org/show_bug.cgi?id=763477
2016-04-11 14:53:08 -05:00
Bastien Nocera
3b283b78b0 network: Fix freeing const pointer
From coverity:
gnome-control-center-3.14.5/panels/network/connection-editor/firewall-helpers.c:75:9: warning: passing argument 1 of 'g_free' discards 'const' qualifier from pointer target type [enabled by default]

https://bugzilla.gnome.org/show_bug.cgi?id=749897
2015-05-27 11:06:02 +02:00
Tim Waugh
dba40e1301 network: Allocate storage for zone name during D-Bus call
The call to nm_setting_connection_get_zone() returns a pointer to
memory that will be freed before the D-Bus reply handler is called.
Make sure to take a copy of the string, and free it when finished.

https://bugzilla.gnome.org/show_bug.cgi?id=739971
2015-02-10 12:40:28 +01:00
Matthias Clasen
844ca77921 network: Add firewall helper functions
This code will be used in subsequent commits to add
firewall zone support to connections.

https://bugzilla.gnome.org/show_bug.cgi?id=694577
2013-03-04 21:45:48 -05:00