Commit graph

23204 commits

Author SHA1 Message Date
Jonathan Kang
f0d04a180f network-connection-editor: Close the editor when nm-connection-editor exits
Previously, when editing a connection that doesn't have native editor
support, nm-connection-editor is spawned to do the work. But after
closing nm-connection-editor, an empty editor dialog still exists.

Fix that in this commit.
2023-11-29 10:28:18 +00:00
Felipe Borges
1c9c6805a5 privacy: Make firmware page visibility check cancellable
So that the page doesn't crash when closing the panel before the
firmware page visibility has been set.
2023-11-29 10:23:51 +00:00
Felipe Borges
0263993642 privacy: Make Bolt page visibility check cancellable
When the Bolt page gets disposed before it finishes initializing
its client object we get a crash. See #2700

A way to trigger the crash is to switch panels fast enough so that
the sync dbus call is not finished by the time the panel is disposed.

This is not a guaranteed fix since I can't reproduce the issue
consistently.
2023-11-29 10:23:51 +00:00
Automeris naranja
c3bcaa4559 style: Add styling for custom status page 2023-11-29 10:17:47 +00:00
Automeris naranja
1ae2c5295c apps: Mimic AdwStatusPage when showing "No Apps Found"
AdwStatusPage can't be used here, because an
unwanted scrollbar would appear inside of it.
See https://gitlab.gnome.org/GNOME/libadwaita/-/issues/697
2023-11-29 10:17:47 +00:00
Automeris naranja
3feeb4c6f0 printer-entry: Add tooltip to the ellipsis button 2023-11-29 10:12:30 +00:00
Automeris naranja
7094bf5b13 search-panel-row: Add tooltip to the ellipsis button 2023-11-29 10:12:30 +00:00
Automeris naranja
f15d260323 input-row: Add tooltip to the ellipsis button from CCInputRow
Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/605
2023-11-29 10:12:30 +00:00
Automeris naranja
3febca7bb2 cc-list-row-info-button: Add tooltip to the "More Information" button 2023-11-29 10:12:30 +00:00
Automeris naranja
dff589a6c7 background-chooser: Add tooltip to the remove background button 2023-11-29 10:12:30 +00:00
Automeris naranja
d975dd335c network: Add tooltip to some buttons 2023-11-29 10:12:30 +00:00
Felipe Borges
71ea77dc2d shell: Check for unsupported environments after handling --version
So that remote connections can run gnome-control-center --version for
debugging purposes.

Fixes #2739
2023-11-29 10:07:47 +00:00
velsinki
96a0b79a15 background: Improve chooser performance
The size of the background item is currently never used, but setting it
using `gnome_bg_get_image_size ()` is expensive, since that actually
does a thumbnail retrieval.

Instead, we can retrieve the size of the background file directly,
improving the rendering performance of the chooser significantly.
2023-11-28 13:43:06 +00:00
velsinki
798eb78023 background: Improve preview performance
Since 7cef6dc5, the background previews are rendered at the full
resolution. However, this is expensive and causes considerable lag,
especially for resizes. Since then, the thumbnail size has doubled to
256 pixels, making the previews sharper even at larger sizes.

So, to improve performance, let's effectively revert 7cef6dc5. The
revert is not possible without disabling frame = 0 retrieval, since that
is broken for non-slideshow backgrounds and was not used before anyways
with force_size = TRUE.

Related to #674
Related to #704
Related to #2448
2023-11-28 13:43:06 +00:00
Felipe Borges
af6da7f7fa mouse: Prevent arrows in Test window from interfering with mouse events
Fixes #2769
2023-11-28 09:30:36 +00:00
Artur S0
acb5724f3c Update Russian translation 2023-11-27 16:31:30 +00:00
Ismael
9ed28e9c27 network: Share WPA3 (SAE) networks with QR Code 2023-11-27 12:15:20 +01:00
Felipe Borges
0c1c964a8f universal-access: Make the crosshair_overlap_mouse_row follow sensitivity 2023-11-27 11:03:48 +00:00
Automeris naranja
0f6c1cca07 ua-zoom-page: Make crosshair options grayed out when crosshairs are disabled 2023-11-27 11:03:48 +00:00
Automeris naranja
3f78abad08 ua-zoom-page: Use an AdwSwitchRow to enable crosshairs
Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2744
2023-11-27 11:03:48 +00:00
Automeris naranja
52a5afcc28 ce-page-details: Add ellipsis to labels of forget_button
"Use an ellipsis (…) at the end of a label if
further input or confirmation is required from
the user before the action can be carried out".

https://developer.gnome.org/hig/guidelines/writing-style.html
2023-11-27 10:36:00 +00:00
Automeris naranja
1093f2993f connection-editor: Set .pill style to forget_button 2023-11-27 10:36:00 +00:00
Automeris naranja
a0d7c2b13f keyboard-shortcut-dialog: Make search entry smaller
The search entry is way too big, even more than
all shortcut category rows; this makes the UI
to look unbalanced. Make the search entry smaller
to fix that.
2023-11-27 09:54:02 +00:00
Automeris naranja
3416dab979 keyboard-shortcut-dialog: Tweak reset shortcuts confirmation dialog
Properly explain what resetting shortcuts actually does.
String reference:
https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2669#note_1921867

Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2669
2023-11-27 09:54:02 +00:00
Automeris naranja
5611dd2fc5 keyboard-shortcut-dialog: Tweak Reset button
Move the Reset button to the bottom add
.pill and .destructive-style classes to it. Also,
remove its tooltip.

Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2669
2023-11-27 09:54:02 +00:00
Automeris naranja
f588b1ce3f night-light-page: Add missing mnemonics
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541
2023-11-27 09:51:46 +00:00
Automeris naranja
33b45a6bf7 display-settings: Add missing mnemonics
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541
2023-11-27 09:51:46 +00:00
Automeris naranja
c2a7e2e4ab display: Add missing mnemonics
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541
2023-11-27 09:51:46 +00:00
Maximiliano Sandoval R.
00f1a19739 application-panel: Don't hardcode dialog height
The storage dialog has a well defined size, therefore we can let the
toolkit determine the perfect height.

We also set the minimum size for the dialog.
2023-11-27 09:38:06 +00:00
Andre Klapper
2bec830c05 DOAP: Replace defunct mailing list with Discourse support forum 2023-11-26 12:32:18 +01:00
Milo Casagrande
8490f17cac Update Italian translation
(cherry picked from commit 8c6e673c94)
2023-11-24 15:02:28 +00:00
Marcos Miller
2e96b6d8cd keyboard: port ShortcutEditor from GtkDialog for AdwWindow/AdwToolbarView
See https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2624
2023-11-24 10:26:31 +00:00
Marcos Miller
5e27373700 network: Show top buttons on unsupported network daemon page
When entering the network panel without the network daemon,
the window decoration buttons do not appear because the whole panel
content was overwritten by an AdwStatusPage.

Now only the content of the AdwToolbarView is changed, preserving
the AdwHeaderBar and buttons.

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2695
2023-11-24 10:49:08 +01:00
Maximiliano Sandoval R
52a78a5404 window: Set the main window height request to 294
This is the size you get on a mobile screen on landscape mode. See
https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/migrating-to-breakpoints.html.
2023-11-24 09:42:17 +00:00
Automeris naranja
8322ccf6c1 input-chooser: Rename "Add an Input Source" to "Add Input Source"
This will be consistent with the writing style used in Settings
(e.g. "Connect to Hidden Network" and "Add Printer" instead of
"Connect to a Hidden Network" and "Add a Printer" respectively).
2023-11-24 09:41:33 +00:00
Automeris naranja
3c0c5b7423 keyboard: Add missing mnemonics
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2049>
2023-11-24 00:23:21 +00:00
Automeris naranja
ea31bb091e keyboard-shortcut-editor: Add mnemonic to the "Set Shortcut" button
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2049>
2023-11-24 00:23:21 +00:00
Automeris naranja
c961832741 keyboard-shortcut-dialog: Add missing mnemonics
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2049>
2023-11-24 00:23:21 +00:00
Lukáš Tyrychtr
536612b00e keyboard: Add Insert as a choice for the compose key
Fixes #2765
2023-11-23 12:34:04 +00:00
Lukáš Tyrychtr
318c78cea0 po: Fix missing closing tag in pt_BR locale
Fixes #2766
2023-11-23 10:36:13 +00:00
Automeris naranja
b0a5c5e128 apps: Add missing mnemonics
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541
2023-11-23 08:55:39 +00:00
Automeris naranja
085553f4ce cc-info-row: Add use-underline property
Doing so, it won't be necessary to set
use-underline for every CCInfoRow.
2023-11-23 08:55:39 +00:00
Automeris naranja
3fa07eb97a sound: Add ellipsis to the Test button
"Use an ellipsis (…) at the end of a label if further
input or confirmation is required from the user before
the action can be carried out".

https://developer.gnome.org/hig/guidelines/writing-style.html

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2053>
2023-11-23 06:14:20 +00:00
Automeris naranja
b3fc842999 sound: Add missing mnemonics
Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2541

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2053>
2023-11-23 06:14:20 +00:00
velsinki
7f79356ded system/region: Preview measurement format in current locale
The Formats preview tries to find the measurement format of the locale
to preview, and then displays it. However, it displays the text in the
default locale, instead of in the real current locale, as newlocale ()
with base = (locale_t) 0 will use the default locale.

This is fixed by switching back to the real locale before setting the
label text.

Fixes #2458

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2051>
2023-11-23 05:48:56 +00:00
Sabri Ünal
018a56aa83 data: Add missing files to POTFILES.in
Add missing files containing translatable strings to POTFILES.in

- panels/network/connection-editor/bluetooth-page.ui
- panels/network/connection-editor/ce-page-bluetooth.c
- panels/network/net-device-bluetooth.c

Fixes: #2762
Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2050>
2023-11-23 05:31:22 +00:00
Ondřej Pohořelský
8f3eee7ee1 wifi: hide QR code icon when connection not successful
Don't show QR code icon when there is no info about connection being
valid and successful. Also hide it when we are connecting and when WiFi
has no password.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/2030>
2023-11-23 05:10:07 +00:00
Boyuan Yang
5bf0b2ccff Update Chinese (China) translation 2023-11-22 20:40:20 +00:00
Hugo Carvalho
e3755309f4 Update Portuguese translation
(cherry picked from commit 39f12a7d1b)
2023-11-22 13:33:40 +00:00
Lukáš Tyrychtr
5d24919f14 common: Mark a string as not containing printf specifiers
The gettext heuristic was erroneously marking one of the date strings as
printf format ones, so it could not get translated properly.

Fixes #2761
2023-11-22 10:40:45 +01:00