Commit graph

23204 commits

Author SHA1 Message Date
Michael Catanzaro
48d0aed598 network: unset DNS entry errors when entry is empty
When the entry is initially empty, there is no error. If you enter
anything and then delete it, the entry is left in the error state. Empty
should not be an error.
2023-10-27 12:56:27 +00:00
Michael Catanzaro
08bff2ee18 Revert "network: Disable DNS entry if the automatic option is enabled"
This reverts commit 8a4a80b7b2.

This is a manual revert, because the code changed considerably in
a2b9620b1b. Anyway, although this seemed
like a good idea, problem is it clobbers the original state of the
connection without any explicit user action if the connection is
configured to use both manual and auto DNS. And this happens in practice
for imported Wireguard connections, which uselessly have auto DNS
enabled due to this NetworkManager bug:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1399

Additional discussion:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1745#note_2112420

The simplest solution is to not try to prevent the user from configuring
both manual and auto DNS. Instead, let's just warn the user that this
configuration may not be intended in a follow-up commit.

Fixes #2617
2023-10-27 12:56:27 +00:00
Automeris naranja
20fe6f3895 input-list-box: Add ellipsis to add_input_row label
"Use an ellipsis (…) at the end of a label if further input or
confirmation is required from the user before the action can be carried out".

https://developer.gnome.org/hig/guidelines/writing-style.html
2023-10-27 12:55:49 +00:00
Automeris naranja
b87909e3a7 users: Tweak add_unlock_tooltip to follow HIG guidelines
This tooltip doesn't follow HIG guidelines because is too long
and doesn't use header capitalization.

https://developer.gnome.org/hig/guidelines/writing-style.html
2023-10-27 12:55:49 +00:00
velsinki
ef644deb3d network-connection-editor: Align Routes labels
Even though the routes_metric_label is in a GtkSizeGroup with the
GtkEntry for the metric, its size was set too big after adding the entry
to the size group. To fix this, add all the other labels and
corresponding entries to size groups as well. The hexpand can then be
removed as well on the labels.

Fixes #1235
2023-10-27 00:54:55 +00:00
Maximiliano Sandoval R
549496f68f
keyboard: Add back close buttons to dialogs 2023-10-26 18:00:20 +02:00
Felipe Borges
958024a7ec meson: Replace deprecated meson.{source|build}_root functions
https://mesonbuild.com/Reference-manual_builtin_meson.html#mesonbuild_root
2023-10-25 15:49:13 +02:00
Felipe Borges
952ce58079 meson: Bump meson dependency to >= 0.58
Since we are about to use meson.get_variable to replace now deprecated
meson.get_pkgconfig_variable
2023-10-25 15:49:13 +02:00
Felipe Borges
6fb324634a apps: Workaround AdwComboRow item selection at startup
Our callback handler for the AdwComboRow::selected-item property
changes gets called at startup, resulting in a slow and unnecessary
default app change.

This is a workaround to avoid calling g_app_info_set_as_default_for_type
without user input.

Fixes #2626
Fixes #2683
2023-10-25 11:23:22 +00:00
Felipe Borges
7e7f6cf5c5 build, meson: Bump GLib dep version to 2.76.6 2023-10-25 12:42:13 +02:00
Felipe Borges
9880569714 ci: Stop building GLib from the source 2023-10-25 12:42:00 +02:00
Марко Костић
f8e10afcb6 Update Serbian translation
(cherry picked from commit 076e4f46f0)
2023-10-25 06:04:28 +00:00
Jakub Steiner
d9b4903baf wacom: Update illustration style
- refresh the style to fit with the new libadwaita/gtk4 style

Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1616
2023-10-24 14:38:00 +00:00
Maximiliano Sandoval R
8aaa6dd542 tz-row: Ellipsize timezone name
Otherwise the size of the window jumps while scrolling through it, since
we don't want to actually ellipsize them by default we increase a bit
the default width of the dialog, which used to be 360.
2023-10-24 14:35:14 +00:00
Maximiliano Sandoval R
d1cf51fcae tz-row: Specify encoding
Random note: Some Emacs setups won't load it as a xml without this.
2023-10-24 14:35:14 +00:00
Maximiliano Sandoval R
1db401351d tz-dialog: Set height-request to 294
This is the size of a mobile device in landscape mode.
2023-10-24 14:35:14 +00:00
Maximiliano Sandoval R
ef645563a7 tz-dialog: Allow closing with Escape
The search bar consumes escape key presses, we tell it what to do.
2023-10-24 14:35:14 +00:00
Lukáš Tyrychtr
7c14fc9ac6 network: Use better labels for the peer row
Namely use three dots for the options button as it opens a label,
and use Remove instead of Delete, as Remove is already used and has a translation.
2023-10-24 09:17:00 +00:00
Lukáš Tyrychtr
e55a4feefe network: Add mnemonic widgets to the Wireguard peer list row, fixing label reading 2023-10-24 09:17:00 +00:00
Lukáš Tyrychtr
caa7650081 network: Add mnemonic widgets to the wireguard editor page, fixing reading of the labels of the fields 2023-10-24 09:17:00 +00:00
Sabri Ünal
28d6b61b4c info-overview: Mark two strings translatable
- Hardware Information
- Software Information

These strings are visible on the copied text of the About dialog.
2023-10-23 14:25:45 +00:00
Maximiliano Sandoval R
4ee4fa3428 network: Port connection editor to AdwWindow
GtkDialog is deprecated. We also took the opportunity to use AdwToolbarView.

See https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2624.
2023-10-23 14:25:12 +00:00
Maximiliano Sandoval R
92d0a5d50c network: Port add VPN connection to action rows
By using action rows we can actually use the boxed-list class.
2023-10-23 14:25:12 +00:00
Maximiliano Sandoval R
77090f4ccd network: Define margins in the UI file 2023-10-23 14:25:12 +00:00
Maximiliano Sandoval R
5cd582bef6 network: Remove orientation=vertical from box
These boxes cannot have more than a single child.
2023-10-23 14:25:12 +00:00
Allan Day
a75cdb2c46 power: Adjust section titles
Use the section titles from the latest mockups. Also remove the unused
title from the .ui file.
2023-10-23 14:04:22 +00:00
Automeris naranja
0d48055f9f firmware-security-page: Add tooltip to fw_help_button
"Controls in the header bars of primary windows should all have tooltips".

https://developer.gnome.org/hig/patterns/feedback/tooltips.html
2023-10-23 13:46:34 +00:00
Automeris naranja
f813d0d1d4 screen: Rename "Forbid new USB devices" to "Forbid New USB Devices"
Header capitalization needs to be used.

https://developer.gnome.org/hig/guidelines/writing-style.html
2023-10-23 13:45:21 +00:00
Eric Daigle
b0b0d177be apps: Make Other Media row consistent
As described in #2688, the Other Media row in the Removeable Media section
of the new apps panel currently uses a Configure Action button to open a
modal dialog. This is inconsistent with other rows in Settings than open a
subpage or modal dialog, which all use CcListRows with right arrows.

This MR changes the Other Media row to a CcListRow with a right arrow, making
it consistent with other such rows in Settings. It also moves the "Select how
other media should be handled" text from the modal dialog to the CcListRow tooltip.

Closes #2688
2023-10-23 13:43:26 +00:00
Maximiliano Sandoval R
527942fd9b password-dialog: Remove unneded visible=True 2023-10-23 13:41:53 +00:00
Maximiliano Sandoval R
2267c3662f password-dialog: Set minimum size. 2023-10-23 13:41:53 +00:00
Maximiliano Sandoval R
25797ff1c1 password-dialog: Remove text-button classes
These are automatically added by GtkLabel, if needed.
2023-10-23 13:41:53 +00:00
Maximiliano Sandoval R
c72c4eb5a6 password-dialog: Use AdwToolbarView
See https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2624
2023-10-23 13:41:53 +00:00
Maximiliano Sandoval R
4209811f2f sharing-panel: Make adaptive
We allow the media sharing dialog to be resizable.

We wrap the content in a scrolled window containing a clamp.
2023-10-23 13:37:52 +00:00
Maximiliano Sandoval R
883a3d44ab sharing-networks: Make network row activatable 2023-10-23 13:37:52 +00:00
Maximiliano Sandoval R
77acfe3ebd sharing-networks: Set seleciton-mode=none
Using other selection modes is not supported with boxed-list and we
don't make use of it.
2023-10-23 13:37:52 +00:00
Maximiliano Sandoval R
a660cfa9ff sharing-network: Remove Glade lines 2023-10-23 13:37:52 +00:00
Maximiliano Sandoval R
8e0e3487cb sharing-network: Don't use GtkFrame 2023-10-23 13:37:52 +00:00
Maximiliano Sandoval R
949e850de6 sharing-panel: Use proper heading class 2023-10-23 13:37:52 +00:00
Maximiliano Sandoval R
d3f824e422 sharing-networks: Use proper heading class 2023-10-23 13:37:52 +00:00
Hari Rana
1c62c25907 wifi-connection-row: Add tooltip texts
Co-authored-by: Automeris naranja <104251-automerisnaranja@users.noreply.gitlab.gnome.org>
2023-10-23 13:31:32 +00:00
Maximiliano Sandoval R
abab4956ad
xkb-modifier-dialog: Port to AdwWindow
We add a toolbar view containing a scrolled window.

- We set the margins to 12 instead of 18
- Use AdwHeaderBar
- Set minimum size and default size
- Make resizable so it fits on small screens

See https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2624
2023-10-22 10:19:39 +02:00
Felipe Borges
270e943ed2 universal-access: Add a few comments to translatable strings
This should help translators contextualize some of the strings we
display in the Zoom page of the Accessibility settings.

Fixes #2702
2023-10-20 16:19:21 +02:00
Felipe Borges
7ffdb1c5b9 appdata: Update contact url to point users to Discourse
The mailing list is now dead.

See #1158
2023-10-20 12:58:49 +02:00
Sabri Ünal
30eed4a66e appdata: add vcs-browser support and more
vcs-browser URL is visible on Flathub and GNOME Control Center.

Also:
- Update donation URL
- Add a homepage

More information: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-url
2023-10-20 12:57:31 +02:00
Maximiliano Sandoval R
526217badb keyboard-shortcut-dialog: Allow escape to close
At the moment the search entry is consuming the Escape key press, so we
have to manually tell it what to do with it.

We clear the search on the first press, if there is input, and close the
window otherwise.
2023-10-20 10:55:01 +00:00
Automeris naranja
759eccf61b printers: Add tooltip to the search button
"Controls in the header bars of primary windows should all have tooltips".

https://developer.gnome.org/hig/patterns/feedback/tooltips.html
2023-10-20 10:49:48 +00:00
Marco Melorio
dccaf98135 mouse-panel: Increase AdwBreakpoint width to avoid videos being blurry
When reducing the window width, CCSplitRow won't have enough width
to display videos without blurriness. This change increases the
AdwBreakpoint width so CCSplitRow shows vertically before that problem
described earlier happens.

See also: https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1960#note_1869031

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1960>

Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2631
2023-10-20 10:24:27 +00:00
Marco Melorio
b136406210 cc-split-row: Reduce GtkPicture horizontal margins to avoid blurriness
There is a difference between the aspect ratio of the CCSplitRow widget
and the videos from the Mouse & Touchpad panel, which causes the videos
to appear blurry.

This change reduces the video margins so they can better align with the pixel grid.
See also: https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1960#note_1869031

Part-of: <https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1960>

Partially fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2631
2023-10-20 10:24:27 +00:00
Maximiliano Sandoval R
2e12bf3bbe input-list-box: Add a label to the add button
This way it looks a bit more full and helps with a11y. Values taken from
the app Secrets.
2023-10-20 08:58:35 +00:00