Make the panel class provide a cancellable that will be cancelled when the panel
is destroyed. Panel implementations can use this and not have to mangage the
cancellable themselves. Consolidate cases where panels had multiple cancellables
that were all being used for this behaviour.
When adding a Shared Folder row to the listbox, we were not settings
it to visible. Causing it to be hidden until the next time the panel
gets populated.
Fixes#580
The warning is:
(gnome-control-center:29760): Gtk-CRITICAL **: 11:45:48.076: gtk_widget_is_visible: assertion 'GTK_IS_WIDGET (widget)' failed
This is due to the code trying to disable switches that only exist if support
for that feature is available.
Since the switches for media, personal file, and screen sharing are in the header bar of the
respective dialogs, they are not visible when we click on the master switch. This caused the
check in OFF_IF_VISIBLE to always fail.
Fix it by checking if the corresponding button in the main list box is visible, instead.
Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/240
The entry was not bound. Due to this we could run into a segfault trying
to query the hostname_entry. This would only happen if avahi is not
running.
Fixes#178
Enable support for manipulating GNOME Remote Desktop settings. Settings
are done via the org.gnome.desktop.remote-desktop.vnc schema.
Configuring the VNC password is done via libsecret, thus libsecret is
added as a dependency.
The way it works is independent of the service so there's no reason
not to show it. We should also hide the remote-control-box widget
hierarchy since those can't be used here.
https://bugzilla.gnome.org/show_bug.cgi?id=786565
This allows enabling screen sharing support under Wayland, as long as
the org.gnome.Mutter.RemoteDesktop D-Bus name is exported by mutter /
gnome-shell. That name will currently only be exported if the
corresponding experimental features has been added to mutter.
So far nothing is configurable, as gnome-remote-desktop is yet to be
configureable.
https://bugzilla.gnome.org/show_bug.cgi?id=786565
* Add label-for/labelled-by AtkRlation pair between the "Computer Name"
label and its entry.
* Give an accessible name to the switch in the header bar. In order to
not break string freeze, used "Sharing" since that's what's shown in
the header bar.
* Fix the incorrect mnemonic widget for media sharing so that Orca speaks
the label in the main sharing panel, and the name in the media sharing
dialog
https://bugzilla.gnome.org/show_bug.cgi?id=746759
E.g. selecting a folder and then dismissing the dialog via the cancel
button or by pressing escape would still add the folder to the shared
folders list.
GtkListBox doesn't implement GtkScrollable so it needs to be added to
a GtkViewport. Instead of having to do this in all .ui files, add a
new helper function to setup the widget tree correctly.
https://bugzilla.gnome.org/show_bug.cgi?id=732175
