Commit graph

4395 commits

Author SHA1 Message Date
Bastien Nocera
2fbac9b23b bluetooth: More tweaks to "off mode" pages
Some small changes labels, spacing and icons changes.
2015-07-31 15:08:17 +02:00
Bastien Nocera
15c8f0d012 bluetooth: Better UI when Bluetooth is disabled
We now offere separate "Bluetooth is off" and "Airplane mode is on"
pages. The "Airplane mode is on" offers to turn off airplane mode
altogether.

We also have better explanations for all the other modes, and a filler
Bluetooth logo to make the page seem less empty.

https://bugzilla.gnome.org/show_bug.cgi?id=751483
2015-07-30 20:13:29 +02:00
Bastien Nocera
e59e43b242 bluetooth: Add Obex sharing keywords
https://bugzilla.gnome.org/show_bug.cgi?id=740369
2015-07-30 20:13:29 +02:00
Bastien Nocera
9d45904f3c sharing: Remove "Bluetooth" (Obex) sharing
It will be moved to the Bluetooth panel instead.

https://bugzilla.gnome.org/show_bug.cgi?id=740369
2015-07-30 20:13:29 +02:00
Bastien Nocera
8d6bdda036 bluetooth: Remove useless FIXME
Who knows what that was for...
2015-07-30 20:13:29 +02:00
Marek Kasik
60bf057bab printers: Merge device-class and is-network-device properties
'device-class' property of PpPrintDevice can contain "network"
or "direct" values. This information can be stored in already
present property 'is-network-device' as well.

https://bugzilla.gnome.org/show_bug.cgi?id=749830
2015-07-30 16:28:09 +02:00
Marek Kasik
7b21b22eef printers: Make PpPrintDevice a regular class
Create class PpPrintDevice with properties taken
from the original PpPrintDevice structure.

https://bugzilla.gnome.org/show_bug.cgi?id=749830
2015-07-30 16:28:06 +02:00
Marek Kasik
48ef91a0b9 printers: Fix compile-time warning
pp-new-printer-dialog.c:673:18: warning: 'device' may be used uninitialized
in this function [-Wmaybe-uninitialized]
2015-07-29 15:48:08 +02:00
Joanmarie Diggs
cfb12e4e22 sharing: Accessibility improvements
* Add label-for/labelled-by AtkRlation pair between the "Computer Name"
  label and its entry.
* Give an accessible name to the switch in the header bar. In order to
  not break string freeze, used "Sharing" since that's what's shown in
  the header bar.
* Fix the incorrect mnemonic widget for media sharing so that Orca speaks
  the label in the main sharing panel, and the name in the media sharing
  dialog

https://bugzilla.gnome.org/show_bug.cgi?id=746759
2015-07-27 19:48:49 +02:00
Marek Kasik
68e92988a8 printers: Cache pointer to devices-treeview
Store device-treeview in PpNewPrinterDialogPrivate so we
don't need to search for it each time we need it.

https://bugzilla.gnome.org/show_bug.cgi?id=749830
2015-07-27 16:28:39 +02:00
Marek Kasik
c26553ed3e printers: Use macro for getting widgets from builder
Use macro for getting widgets from builder in the New printer dialog.

https://bugzilla.gnome.org/show_bug.cgi?id=749830
2015-07-27 16:28:36 +02:00
Marek Kasik
087c4ff208 notifications: Don't crash because of zero-length string
Check whether given application child is at least 1 character
long to avoid crash which can happen as a result of creating
of GDesktopAppInfo with NULL desktop file id.
To reproduce this run "gnome-control-center notifications" and
"gsettings set org.gnome.desktop.notifications application-children "['']"".

https://bugzilla.gnome.org/show_bug.cgi?id=752525
2015-07-27 16:23:19 +02:00
Sebastian Keller
81e89fb7f8 network: Fix unintentionally centered checkbutton labels
See https://bugzilla.gnome.org/show_bug.cgi?id=732361

https://bugzilla.gnome.org/show_bug.cgi?id=732374
2015-07-27 00:00:43 +02:00
Bastien Nocera
50d4cc2263 network: Rename hotspot security key to "Password"
https://bugzilla.gnome.org/show_bug.cgi?id=735909
2015-07-26 23:58:17 +02:00
Martin Hatina
000dae6e98 printers: Replace deprecated widgets
Replace some deprecated widgets.

https://bugzilla.gnome.org/show_bug.cgi?id=723378
2015-07-26 23:49:39 +02:00
Bastien Nocera
557dc46d97 datetime: Load backward file from GResource
So it doesn't warn when not installed in the target prefix yet.

https://bugzilla.gnome.org/show_bug.cgi?id=752831
2015-07-26 23:48:48 +02:00
Rui Matos
66604d4ae6 region: Don't ever show all input sources in the chooser
While filtering we're adding all the input source rows to the
GtkListBox. This is a performance issue since GtkListBox doesn't
really cope with a big number of rows.

Instead, we'll filter the locale rows in a way such that we'll show a
locale row for which any input source name matches. From this filtered
locales view, users will still need to activate a locale row to get to
the input source rows view.

https://bugzilla.gnome.org/show_bug.cgi?id=752383
2015-07-22 16:10:27 +02:00
Bastien Nocera
f7467d2175 datetime: Make it possible to focus the time spin buttons
https://bugzilla.gnome.org/show_bug.cgi?id=752609
2015-07-20 12:08:59 +02:00
Christophe Fergeau
c84722248e shell: Revert "Let panels have their own commandline flags"
This reverts commit 31a8a99440.

This was meant for bgo#695885 which has stalled for a while, so this
feature has no in-tree user. This commit removes it for now, this can be
readded when users for it materialize.

https://bugzilla.gnome.org/show_bug.cgi?id=751597
2015-07-16 11:49:34 +02:00
Ondrej Holy
7ce6ce6807 user-accounts: Fix enterprise user login permitting
Commit 3e6b741a introduced check for NULL on um_realm_object_get_common.
Unfortunatelly one check is wrong and breaks the login permitting.
The patch fixes the wrong check.

https://bugzilla.gnome.org/show_bug.cgi?id=752405
2015-07-15 17:34:49 +02:00
Rui Matos
f2f4626f64 region: Avoid overly long labels causing horizontal scrolling
Just ellipsize them instead.

https://bugzilla.gnome.org/show_bug.cgi?id=752383
2015-07-15 15:24:27 +02:00
Rui Matos
c8986f602a network/net-device-ethernet: Re-work how we keep track of connections
When we're finalizing, the remote settings instance might already be
gone and thus we can't list connections. In particular this happens at
panel finalization resulting in the following warning:

libnm-glib-CRITICAL **: nm_remote_settings_list_connections: assertion
'NM_IS_REMOTE_SETTINGS (settings)' failed

because cc_network_panel_dispose() unrefs the remote settings object
before all the NetDevice instances are finalized.

Since we only need to list connections on finalize to disconnect a
signal we can instead use g_signal_connect_object() and keep the
connections that we're keeping track of in a hash table instead of
g_object_set_data().

https://bugzilla.gnome.org/show_bug.cgi?id=749850
2015-07-15 15:24:21 +02:00
Marek Kasik
880cc01550 printers: Don't show the same device multiple times
Pass all discovered devices to 'GroupPhysicalDevices' instead of just
the devices already present in the list and the newly discovered ones.
Replace an existing device in the list if there is a better device
(e.g. replace 'usb:' by 'hp:' device).

https://bugzilla.gnome.org/show_bug.cgi?id=693186
2015-07-13 12:07:59 +02:00
Marek Kasik
b02f7722dd printers: Check whether we have a device name
Check whether we've been able to find a usable name of given device
to avoid dereference of NULL in canonicalize_device_name().

https://bugzilla.gnome.org/show_bug.cgi?id=749896
2015-07-13 11:21:53 +02:00
Bastien Nocera
ac59708d3f datetime: Fix incorrect sensitivity when permission is missing
When the permission is missing, we shouldn't make the rows sensitive.

https://bugzilla.gnome.org/show_bug.cgi?id=709774
2015-07-10 17:14:02 +02:00
Matthias Clasen
83a55046ca power: Make the automatic suspend row accessible
Orca was not reading this row at all - since the row is
clickable (role 'push button'), orca expects it to have
an accessible name. So, lets set one.

https://bugzilla.gnome.org/show_bug.cgi?id=746756
2015-07-10 13:06:51 +02:00
Rui Matos
ae7b1a97eb common: Tick an unselected row when enter is pressed
This makes the dialog easier to use via keyboard navigation since
otherwise we would just dismiss the dialog with the current selection
on enter when the user actually intended to change the selection.

https://bugzilla.gnome.org/show_bug.cgi?id=752001
2015-07-07 18:48:56 +02:00
Rui Matos
7916040cea region: Tick an unselected row when enter is pressed
This makes the dialog easier to use via keyboard navigation since
otherwise we would just dismiss the dialog with the current selection
on enter when the user actually intended to change the selection.

https://bugzilla.gnome.org/show_bug.cgi?id=752001
2015-07-07 18:48:56 +02:00
Rui Matos
73644fdecc region: Dismiss dialog if the activated row was already ticked
This makes the dialog a bit friendlier to use.

https://bugzilla.gnome.org/show_bug.cgi?id=752001
2015-07-07 18:48:56 +02:00
Rui Matos
32653a0a65 common: Dismiss dialog if the activated row was already ticked
This makes the dialog a bit friendlier to use.

https://bugzilla.gnome.org/show_bug.cgi?id=752001
2015-07-07 18:48:56 +02:00
Ondrej Holy
f290d71e9a mouse: Adapt to changes in gsd-input-helper
Redundant code can be removed from mouse panel thanks to changes
in gsd-input-helper.

https://bugzilla.gnome.org/show_bug.cgi?id=749818
2015-07-02 15:51:04 +02:00
Rui Matos
912e78d896 common: Update from gnome-settings-daemon 2015-07-02 15:17:28 +02:00
Jason Gerecke
ae11d34c60 wacom: Fix window decorations being visible in calibrator window
The 'on_fullscreen' function which handles the 'window-state-event'
signal should be returning a gboolean value. Fix the function
signature and have it return FALSE to allow the event to continue to
propagate.

https://bugzilla.gnome.org/show_bug.cgi?id=751129
2015-07-01 11:42:45 +02:00
Dave Airlie
0005c32ded display: Fix making a tiled monitor primary again
Don't break out of loop if we weren't primary, as this
is stopping the user swapping back and forward between
primary and secondary with a tiled monitor.

i.e. user sets monitor to secondary and attempts to
go back to primary and it fails to move it.

https://bugzilla.gnome.org/show_bug.cgi?id=751680
2015-07-01 10:49:12 +02:00
Dave Airlie
458cebb26d display: Add support for tiled monitors
The display panel needs to ask libgnome-desktop in a few places
whether the panel is tiled.

https://bugzilla.gnome.org/show_bug.cgi?id=751680
2015-07-01 10:49:06 +02:00
Bastien Nocera
6279dcd0a6 datetime: Respect the date endianess
When the user changes the date, order the widgets in the same order as
how the date is printed in that locale.

https://bugzilla.gnome.org/show_bug.cgi?id=750799
2015-06-30 15:00:07 +02:00
David Henningsson
c4b4b8bdc5 sound: Support more channels in speaker test
Add support for mono, front-left-of-center and
right-left-of-center channels in speaker test dialogue.

https://bugzilla.gnome.org/show_bug.cgi?id=750324
2015-06-30 14:55:24 +02:00
Bastien Nocera
e9294e5cc7 network: Fix possible crash when changing airplane mode
When changing the airplane mode, either from the Bluetooth panel, or
through gnome-shell's status menu, we would receive signals from the
Rfkill gnome-settings-daemon service, even after the network panel was
closed, as we didn't unref' it. Except that the panel was mostly gone.
So splat.

https://bugzilla.gnome.org/show_bug.cgi?id=751482
2015-06-29 17:49:04 +02:00
Mathieu Bridon
df54973136 network: Only share a new wifi connection if the user is allowed to
Making a new connection available to other users requires being an
admin, or entering an admin password.

If we enable that option by default for new connections, we effectively
prevent non-admin users from connecting to new networks when they go to
the coffee shop without their laptop admin.

https://bugzilla.gnome.org/show_bug.cgi?id=751378
2015-06-29 17:49:04 +02:00
Bastien Nocera
d2c0b66275 power: Fix possible crash if up_client_get_devices() fails
up_client_get_devices() can fail if upower crashes or isn't available.
Make sure not to crash ourselves by handling NULL return values as we do
later in the loop.

See https://bugzilla.redhat.com/show_bug.cgi?id=1175421

https://bugzilla.gnome.org/show_bug.cgi?id=751095
2015-06-29 17:49:04 +02:00
Rui Matos
dbe6eb9bbf common: Update from gnome-settings-daemon 2015-06-29 16:12:57 +02:00
Michael Biebl
1f4f6ded0f Make it possible to override SSHD_SERVICE
Upstream of openssh does not yet ship a systemd service file, so distros
add them downstream and unfortunately use different names: E.g. on
Fedora the unit is called sshd.service, on Debian/Ubuntu it is called
ssh.service.

Therefore make it possible to override SSHD_SERVICE via CFLAGS.

https://bugzilla.gnome.org/show_bug.cgi?id=751326
2015-06-28 23:20:03 +02:00
Marek Kasik
ed50357f82 printers: Show border around 'No printers detected' text
The GtkStack page which shows the label 'No printers detected' in the
'New printer dialog' misses border.
This commit places the GtkLabel into a GtkFrame to achieve that.

https://bugzilla.gnome.org/show_bug.cgi?id=749883
2015-06-16 16:35:48 +02:00
Marek Kasik
fb49b256f5 printers: Don't expand search entry
Don't expand search entry when device detection ends.
Place the GtkSpinner into a GtkFixed to achieve that.

https://bugzilla.gnome.org/show_bug.cgi?id=749883
2015-06-16 16:35:45 +02:00
Mathieu Bridon
623abfb428 datetime: Fix date endianess for en_HK
Hong Kong people expect to use a little endian date in English. (and a
big endian date in Chinese)

The D_FMT format string for en_HK is '%A, %B %d, %Y', which the current
code parses as middle endian.

This commit makes the code parse it as little endian, that is it doesn't
ignore the %A formatter any more.

en_HK is the only UTF-8 locale with this D_FMT format string, so this
shouldn't change anything for other locales.

https://bugzilla.gnome.org/show_bug.cgi?id=750781
2015-06-15 17:27:34 +02:00
Mathieu Bridon
8b2d6b7afe datetime: Support new date endianess for ce_RU
https://bugzilla.gnome.org/show_bug.cgi?id=749438
2015-06-15 17:23:36 +02:00
Mathieu Bridon
71d5be4cf2 datetime: Fix comment
https://bugzilla.gnome.org/show_bug.cgi?id=749438
2015-06-15 17:23:36 +02:00
Dave Airlie
3d8cd197c9 display: Use correctly typed pointer
We already assign list->data to output.

https://bugzilla.gnome.org/show_bug.cgi?id=750312
2015-06-15 16:18:33 +02:00
Dave Airlie
4c7189d1b4 display: Refactor get_geometry helper
This moves the two functions to the top of the file, changes the
get_geometry to return x/y if requested, and refactors the callers to
use it.

It also refactors some code that open coded the same basic code.

https://bugzilla.gnome.org/show_bug.cgi?id=750312
2015-06-15 16:16:16 +02:00
Marek Kasik
b5b421288c printers: Fix setting of page size
Set 'PageSize' instead of 'media' for new printers since we use PPD
for construction of the combo for selecting of default paper size.
Previously, we've been setting 'media' attribute for new printers.
Attribute 'media' is used by IPP but we set paper size using 'PageSize'
which comes from PPD in the options dialog. Sometimes (quite often) IPP
gets priority over PPD in print systems. Therefore there was inconsistency
of what user set as default paper size on the options dialog and what was used.

Also don't mark IPP and user's local options as default in PpPPDOptionWidget
since it should use just PPD (we can change PPD values only in this widget).
Since we use PPD for setting of paper size in the options dialog, we shouldn't
show a value which user does not change actually (IPP's 'media' vs. PPD's
'PageSize').

https://bugzilla.gnome.org/show_bug.cgi?id=748569
2015-06-12 16:23:45 +02:00