Commit graph

9 commits

Author SHA1 Message Date
Yuri Chornoivan
e7050ab6f4 Fix minor typos 2020-07-20 10:38:09 +03:00
Robert Ancell
100d3684f2 user-accounts: Connect signals with g_signal_connect_object in swapped form 2020-03-30 16:18:50 +13:00
Philip Withnall
6284162a1d user-accounts: Fix use of an uninitialised variable in the carousel
`dest_x` is not set if `gtk_widget_translate_coordinates()` fails, which
it can do before the widget is realised.

This fixes a valgrind warning, but doesn’t change any user-visible
behaviour as far as I can tell.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
2020-01-29 17:43:24 +00:00
Ondrej Holy
7611e07e3f user-accounts: Prevent usage of uninitialized value
gtk_widget_translate_coordinates() doesn't have to always set the
dest_x argument. Let's initialize the argument before use to prevent
usage of uninitialized value, which also prevents "Conditional jump
or move depends on uninitialised value(s)" messages from valgrind.
2020-01-13 16:20:01 +00:00
Philip Withnall
8052466726 user-accounts: Fix a leak on destruction of CcCarousel
Signed-off-by: Philip Withnall <withnall@endlessm.com>
2020-01-13 11:50:40 +00:00
Philip Withnall
b2d607df44 user-accounts: Fix carousel arrow location when animations are disabled
When animations are disabled, the @keyframes CSS rule doesn’t work, and
neither does animation-name — so we need to set the margin-left to the
arrow’s final location directly.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
2019-12-11 14:23:36 +00:00
Robert Ancell
36645259fd user-accouts: Don't use page names for CcCarousel
Ultimately the code was just trying to access the nth entry.
2019-12-10 09:54:27 +00:00
Robert Ancell
bf0a757c7f user-accounts: Fix small memory leak 2019-12-10 09:54:27 +00:00
Robert Ancell
262baed6a1 user-accounts: Rename UmCarousel to CcCarousel
Um is a naming hangover from before this was part of g-c-c.
2018-11-14 10:06:15 +13:00
Renamed from panels/user-accounts/um-carousel.c (Browse further)