A crash possibility has been fixed in libgnome-volume-control!25.
A similar crash was reported on the Settings side, so update to the
latest gvc commit to hopefully prevent further crashes.
Related: gnome-shell#7173
Related: #2924
Unfortunately I sneaked in a move of the gvc_mixer_control_open() call from
earlier in the function to the end of the function with commit 2152899354.
That change didn't actually move the call though, but introduced a second
call instead, leading to a critical error on opening of the sound panel.
Fix it by removing the first call to gvc_mixer_control_open() and keeping
the second one around. We want to keep the second one instead of the earlier
one because the signal handlers should be connected before we initialize gvc
and it connects to pulse, emitting all the input/output-added signals etc.
The reason why this wasn't broken before was likely because the connection
to pulse happens async, and therefore the initial emission of the signals
would effectively still have happened after we connected our handlers.
Fwiw, calling gvc_mixer_control_open() after
cc_volume_slider_set_mixer_control(), cc_subwoofer_slider_set_mixer_control()
and cc_device_combo_box_set_mixer_control() is not a problem, as those
functions all call into gvc to get static values (and as explained above,
at this point gvc wouldn't have established connection to pulse anyway).
Reported-by: Matthijs Velsink <mvelsink@gnome.org>
Fixes: 2152899354 ("sound: Listen to signals from GvcMixerControl only in sound panel")
Each page had its AdwNavigationPage tag updated in [1],
but the tags in the Privacy panel main page weren't
updated, which made all the subpages fail to open.
[1] 917248d7bf
In the File & Link Associations dialog (handler_dialog),
the remove button from list rows doesn't have a tooltip;
also, Orca doesn't read this button properly, since there
is no a11y label.
Fix that by adding a tooltip, which also acts as an a11y
label.
Unlike other rows from the app page, the
"Storage" row subtitle states a value
instead of showing the row description.
Also, the description ends with a period,
which isn't necessary acc. to HIG.
Show the disk space as a secondary label,
so the "Storage" row can have a consistent
subtitle like other rows.
Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2777
Secure Shell and Software Updates rows are
using the letters R and U, respectively, for
their mnemonics. However, these letters are
already taken by other rows (Region & Language
and Users).
Fix that by choosing different letters.
When there's no active input or output device, the input/output meter shouldn't
have a stream set, so call set_input_stream() with a NULL stream
(cc_volume_slider_set_stream() and cc_level_bar_set_stream() are already handling
NULL as expected) in case there's no active input or output device.
This fixes a bug where the input/output meter doesn't get updated when the active
input or output device gets unset.
When gvc gives us an active-input/output-device ID we don't know or sets the ID
to 0, that means there's no device currently active. While this seems unlikely
to be the case without the device getting removed at the same time, it can happen:
When the bluetooth profile gets changed from handset (input+output) to
headphone (output only), the input device remains available, but there's no
more active-input-device anymore.
In this case, we shouldn't leave the active entry on the device combo box as-is,
instead we should set it to NULL to indicate that no input device is set.
This fixes a bug where the input switcher is not updated when there's no
internal microphone but there's a bluetooth headset connected, and the
bluetooth profile gets switched from Handset to Headphone.
Gvc is the actual "source of truth" when it comes to the currently active input
or output device, so we should update widget visibility and the input/output
meter stream based on the information from gvc, not on changes to the combo box.
The flow when the selects a different device in the combo box now is:
"user change" -> gvc_mixer_control_change_output() -> receive
"active-output-changed" signal from gvc -> update active device and get it
using the DeviceComboBox -> set widget visibility and update stream based
on this device.
This fixes a few bugs where the stream for the input/output meter wouldn't
get updated properly on active device changes.
When we get notified of an "active-input/output-device" change by gvc, we have
to update our respective combo box to reflect that change. Obviously, this in
turn shouldn't trigger our own signal handler for changes on that combo box,
that signal handler is only meant to handle the user interacting with the combo
box.
So block our signal handlers when we update the combo box to respond to changes
from the gvc side.
This fixes a recursive call to gvc_mixer_control_change_input/output() when we
get notified about an input/output change from gvc itself.
We should only listen to "active-input-update" and "active-output-update" in
one place, and then update the combo box from there. This way we can block our
own signal handler for input/output device changes on the combo box, which
we'll do in the next commit.
Make this dialog design closer to what mockups
show[1] by:
- Removing window default-width/height,
so the window size follows the content size
- Using a compact AdwStatusPage
- Using larger fingerprint label horizontal margins
and reducing vertical ones
Also:
- Port the window to AdwToolbarView, which
makes the close button position to be consistent
with other windows
- Allow closing the window with ESC
- Add window size request properties to improve
adaptiveness
[1] cbb4810936
Unlike tip erasers, styli with eraser buttons (which is the vast
majority anyway) have the same tool ID as the pen so the first
matching stylus we find is the right one.
This avoid a warning when a AES stylus is connected - we're constructing
the stylus based on our cache information which is just ID and serial
but no device - meaning the device lookup cannot work.
Fixes: 42b39cb956 ("wacom: Prefer the stylus over the eraser")
These are styli like the Dell Active Pen and most of the styli supplied
with laptops with built-in tablets. We don't always know how many
buttons these have so the SVG has just one large button. They're
typicall slimmer and less rounded than the Wacom pens so let's reflect
this here too.
This requires libwacom 1.4 released June 2020
"Computer" isn't a suitable term for other device
form factors. Also, there are several strings in
Settings that already use "device", and cc-color-panel.ui
uses a mix of "computer" and "device" strings, which is
weird.
Tweak the writing style of the problem reporting text
with the following changes:
- Use an en dash to separate the "learn more" link
- Use a period at the end of the phrase
When the privacy policy link from the distro isn't
available when calling G_OS_INFO_KEY_PRIVACY_POLICY_URL,
"gnome.org/privacy-policy" is used instead. However,
GNOME doesn't have any infrastructure for automatic
problem reporting; also, that link doesn't even mention
about problem reporting, so it's completely unrelated.
Fix by removing not setting any link if
G_OS_INFO_KEY_PRIVACY_POLICY_URL doesn't return any URL.
Closes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2926
When the Users panel got moved to System, the original .desktop file was
also moved. However, that is now obsolute with
`panels/system/users/gnome-users-panel.desktop.in`. This old file is
also not referenced in any `meson.build` and contains an outdated `Exec`
line.
So, remove it.
