Commit graph

6186 commits

Author SHA1 Message Date
Robert Ancell
93b14a4339 panel: Move shared GCancellable code into panel class
Make the panel class provide a cancellable that will be cancelled when the panel
is destroyed. Panel implementations can use this and not have to mangage the
cancellable themselves. Consolidate cases where panels had multiple cancellables
that were all being used for this behaviour.
2020-02-03 09:36:24 +13:00
Robert Ancell
0aad22079f background: Remove unused GCancellable 2020-02-03 09:35:15 +13:00
Robert Ancell
42c8e63b1e thunderbolt: Fix GCancellable leak 2020-02-03 09:35:15 +13:00
Matthias Clasen
266ccac6ca applications: Add a 'set desktop background' switch
This is backed by the 'wallpaper' permission that
the flatpak portal uses.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/808
2020-02-02 12:44:13 -03:00
Georges Basile Stavracas Neto
c114828ec3 trivial: Replace g_memmove by memmove 2020-02-02 12:25:42 -03:00
Georges Basile Stavracas Neto
4bef33781c network: Fix ws_wpa_psk_new call
Introduced by d168eee5cd.
2020-02-02 12:24:23 -03:00
Felipe Borges
c9eb8ebf41 printers: Use CcPermissionInfobar
This makes the Printers panel consistent with the mockups at
https://gitlab.gnome.org/Teams/Design/settings-mockups/blob/master/users/users.png

See #685, #771 and !671
2020-01-31 14:28:01 +00:00
Robert Ancell
4897c6d8e3 network: Handle case where GtkComboBox has no active iter 2020-01-31 14:13:15 +00:00
Robert Ancell
6bb77ec1e2 network: Fix GError being overwritten 2020-01-31 14:13:15 +00:00
Robert Ancell
099b58a8c9 network: Remove constant password_flags_name property 2020-01-31 14:13:15 +00:00
Robert Ancell
a99cafbdb4 network: Simplify EapMethodSimple constructor
We don't need an enum and a lookup table, just send the string directly.
2020-01-31 14:13:15 +00:00
Robert Ancell
37f5c37261 network: Simplify autheap_allowed logic
Instead of checking later if this should be enabled, only enable it for methods
that can do it.
2020-01-31 14:13:15 +00:00
Robert Ancell
d168eee5cd network: Remove WirelessSecurity constructor parameters that were never changed 2020-01-31 14:13:15 +00:00
Robert Ancell
4bc58cac44 network: Remove EAP constructor parameters that were never changed 2020-01-31 14:13:15 +00:00
Robert Ancell
7d9d4d4289 network: Convert WirelessSecurity objects into GtkTemplates 2020-01-31 14:13:15 +00:00
Robert Ancell
d4ec8a570b network: Convert WirelessSecurity into an interface 2020-01-31 14:13:15 +00:00
Robert Ancell
b964283fb0 network: Refactor how username/passwords are retained when switching EAP methods
This was previously done by storing the value inside the WirelessSecurity class.
This stopped the subclasses from becoming Gtk widgets.

The "always_ask" code was removed as it didn't seem to actually retain when
switching. This might need to be fixed at a later time.
2020-01-31 14:13:15 +00:00
Robert Ancell
7f4eaf5eec network: Remove unused parameter 2020-01-31 14:13:15 +00:00
Robert Ancell
cec32ae47e network: Fix type in EAPMethod interface 2020-01-31 14:13:15 +00:00
Marek Kasik
c54db039f8 printers: Avoid read of freed memory
This fixes an issue when on_get_job_attributes_cb()
was called after Printers panel has been finished.
It adds a GCancellable to pp_job_get_attributes_async()
calls.
2020-01-31 14:06:32 +00:00
Felipe Borges
8a1c6f696e user-accounts: Rename "Last Login" entry to "Account Activity"
According to the mockups at
https://gitlab.gnome.org/Teams/Design/settings-mockups/raw/master/users/users.png

Other than renaming the label, we prepend "Last login" to the
date-time string.

Fixes #771
2020-01-30 08:04:09 +00:00
Felipe Borges
6db4d9e933 user-account: Add border around user image button
According to the mockups at
https://gitlab.gnome.org/Teams/Design/settings-mockups/raw/master/users/users.png

Fixes #771
2020-01-30 08:04:09 +00:00
Felipe Borges
05313d35e2 user-accounts: UI style improvements
According to the mockups at
https://gitlab.gnome.org/Teams/Design/settings-mockups/raw/master/users/users.png

Fixes #771
2020-01-30 08:04:09 +00:00
Felipe Borges
43b41cb1fa user-accounts: Make the full_name_entry and editable widget
According to the mockups at
https://gitlab.gnome.org/Teams/Design/settings-mockups/blob/master/users/users.png

Fixes #771
2020-01-30 08:04:09 +00:00
Philip Withnall
6284162a1d user-accounts: Fix use of an uninitialised variable in the carousel
`dest_x` is not set if `gtk_widget_translate_coordinates()` fails, which
it can do before the widget is realised.

This fixes a valgrind warning, but doesn’t change any user-visible
behaviour as far as I can tell.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
2020-01-29 17:43:24 +00:00
Robert Ancell
4fe973022a printers: Simplify function 2020-01-28 14:46:53 +00:00
Robert Ancell
c0cd99d2a8 printers: Convert jobs dialog to use GtkTemplate 2020-01-28 14:46:53 +00:00
Robert Ancell
d03da03ee9 printers: Set transient window externally to dialog code 2020-01-28 14:46:53 +00:00
David Bauer
da0c45f2ab ce-connection-row: add SAE support 2020-01-27 23:11:30 +00:00
David Bauer
97f6c8f53c ce-page-details: add SAE support 2020-01-27 23:11:30 +00:00
David Bauer
2e79c53194 ce-page-security: add SAE support 2020-01-27 23:11:30 +00:00
Mohammed Sadiq
68c4023f06 power: Hide power button when chassis is handset
Just like tablets, handset power key is often handled differently
2020-01-27 21:20:29 +00:00
Allan Day
90e0774a19 notifications: Change switch label to Do Not Disturb
!97 added a do not disturb switch to GNOME Shell. This works by
changing the org.gnome.desktop.notifications.show-banners setting.
The switch that controls this setting in the control center should
therefore use the same Do Not Disturb label as the switch in the
shell.
2020-01-27 17:58:17 +00:00
Ondrej Holy
7f010f3138 users: Show username hint immediately
Changes made by GNOME/gnome-control-center!359 caused that the username
hint ("This will be used to name your home folder and can’t be changed.")
is not shown immediately after opening the "Add User" dialog. This change
was unwanted. Let's show the hint immediately after opening the dialog as
it was before.
2020-01-22 10:55:13 +01:00
Robert Ancell
181a496a4e printers: Return a GPtrArray instead of GList
This makes the memory able to be managed with g_autoptr.
This fixes a memory leak where the job list was leaked if the operation was cancelled.
2020-01-21 23:12:14 +00:00
Robert Ancell
baed38e31c background: Fix CI build breaking on gnome-desktop API change
The change was added in feeee1c. For now we will handle the old and the new API
until this can be built.
2020-01-22 12:01:22 +13:00
Robert Ancell
70f8f74765 background: Move gnome-desktop-thumbnail.h includes
Remove one that wasn't needed, add in two in files that don't include it.
2020-01-22 11:40:42 +13:00
Robert Ancell
179eac628c background: Remove unused include 2020-01-22 11:40:39 +13:00
Javier Jardón
feeee1c744 Adapt to new gnome-desktop API changes 2020-01-16 13:55:40 +00:00
Ondrej Holy
7611e07e3f user-accounts: Prevent usage of uninitialized value
gtk_widget_translate_coordinates() doesn't have to always set the
dest_x argument. Let's initialize the argument before use to prevent
usage of uninitialized value, which also prevents "Conditional jump
or move depends on uninitialised value(s)" messages from valgrind.
2020-01-13 16:20:01 +00:00
Philip Withnall
8052466726 user-accounts: Fix a leak on destruction of CcCarousel
Signed-off-by: Philip Withnall <withnall@endlessm.com>
2020-01-13 11:50:40 +00:00
Mike Gorse
901ef8b0ff Thunderbolt: make BoltError enum a typedef
Fixes error when compiled with -fno-common
2020-01-09 21:34:12 +00:00
Philip Withnall
ef21229a5b network: Tweak wording of metered data checkbox in connection dialog
Make it clearer in two ways:
 • Explicitly mention ‘metered data’, as that’s a commonly used phrase.
 • Explicitly mention automatic software updates as being disabled on
   metered connections, to make the implications of this checkbox a
   little clearer.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Helps: https://gitlab.gnome.org/GNOME/gnome-software/merge_requests/339
2020-01-08 15:46:22 +00:00
Robert Ancell
cc4478d4f8 sound: Add missing subwoofer icons
These were accidentally dropped in the migration from the old panel to the new one.

Fixes #825
2020-01-07 20:49:12 +00:00
Mohammed Sadiq
eb4fe4fc42 region: Implement new design for ‘Formats’ dialog
https://gitlab.gnome.org/GNOME/gnome-control-center/issues/635
2020-01-07 14:53:23 +13:00
Robert Ancell
96b1052bcd network: Remove markup from translatable strings 2020-01-06 16:57:43 +00:00
Robert Ancell
df71952112 keyboard: Remove markup from translatable strings 2020-01-06 16:57:43 +00:00
Robert Ancell
d2e96ff90f online-accounts: Remove markup from translatable strings 2020-01-06 16:57:43 +00:00
Robert Ancell
01fea23df1 sharing: Remove markup from translatable strings 2020-01-06 16:57:43 +00:00
Georges Basile Stavracas Neto
86a8ecb705 panel-list: Temporarily move the Network panel to below Wi-Fi
This is until we merge the Network, Wi-Fi, and Mobile Broadband
panels.
2020-01-06 15:15:30 +00:00