Commit graph

4631 commits

Author SHA1 Message Date
Georges Basile Stavracas Neto
1e580c679b online-accounts: Add an offline message label
When offline, we currently block the new accounts listbox
so that users can't add new accounts. There is, however,
no visual indication that we're offline, besides the listbox.

Fix that by adding a descriptive label that's only visible
when offline.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-22 23:00:49 -03:00
Georges Basile Stavracas Neto
e9198bdb4d online-accounts: Add a bottom row to display non-branded providers
As per the mockups, and mimicking the dialog behavior, add a bottom
row that shows non-branded providers.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-22 23:00:49 -03:00
Felipe Borges
ca30e0ead9 printers: Use async rename method
pp_printer_rename_async is better than the old printer_rename
utility.

The PpDetailsDialog doesn't need to do anything in the callback
since we are emiting the "printer-changed" signal when the dialog
is closed.

https://bugzilla.gnome.org/show_bug.cgi?id=769114
2017-02-22 17:05:50 +01:00
Felipe Borges
5fa1dede21 printers: Do not apply rename/location changes in focus-out-event
Since we are already applying the changing in the PpDetailsDialog
when it gets closed, there's no need to apply these changes in
the focus-out-event of its respective GtkEntries.

https://bugzilla.gnome.org/show_bug.cgi?id=769114
2017-02-22 17:05:50 +01:00
Georges Basile Stavracas Neto
13da84e451 online-accounts: Add margins to the rows' icons
Per Allan's request, add more margin to the rows' icons.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-17 17:23:59 +01:00
Georges Basile Stavracas Neto
1f1f2e2b1f online-accounts: Always keep editor dialog size the minimum
When adding and editing accounts, the different options that Online
Accounts provides may require different sizes of the dialog. There is,
however, a specific issue where the dialog can't resize because a
provider widget is interefering with the others.

Fix that by making the dialog's stack non-homogeneous, and making sure
to always reset the dialog size before showing it.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-17 17:19:45 +01:00
Richard Hughes
9725efd3e4 display: Tweak night light dialog UI to match latest mockups 2017-02-16 19:56:51 +00:00
Ondrej Holy
60c315b53b user-accounts: Fix crash when name is changed and dialogue closed
Wrong variables are used to store timeout id, consequently, the sources
are not properly removed in all cases. Then the dialog may crash in certain
cases if it is closed before the source functions are called.

https://bugzilla.gnome.org/show_bug.cgi?id=778595
2017-02-16 09:21:42 +01:00
Felipe Borges
6bfc60b779 printers: Make the printer address always sensitive
This patch individually updates the sensitivity of the
PpDetailsDialog child widgets, so we can leave the printer
address label always sensitive.

https://bugzilla.gnome.org/show_bug.cgi?id=778682
2017-02-15 15:56:32 +01:00
Jeremy Bicha
86f131a1cb display: Really fix typo in "Tomorrow"
Spelled correctly in the commit message, but not in the code itself.
Yay! :(

https://bugzilla.gnome.org/show_bug.cgi?id=778513
2017-02-15 11:58:54 +01:00
Jeremy Bicha
22daedad49 privacy: Set destructive-action for confirmation buttons only
https://bugzilla.gnome.org/show_bug.cgi?id=778567
2017-02-15 11:48:26 +01:00
Jeremy Bicha
5bbb097035 privacy: Use "destructive-action" style for delete buttons
https://bugzilla.gnome.org/show_bug.cgi?id=778567
2017-02-14 19:11:34 +01:00
Jeremy Bicha
02e556cfb3 privacy: Use ellipses for btns that require confirmation
https://bugzilla.gnome.org/show_bug.cgi?id=778568
2017-02-14 19:09:33 +01:00
Jeremy Bicha
479f04904c printers: Use ellipsis for "Add a Printer"
https://bugzilla.gnome.org/show_bug.cgi?id=778568
2017-02-14 19:09:33 +01:00
Jeremy Bicha
681f40ca09 keyboard: Use ellipsis for "Reset All"
https://bugzilla.gnome.org/show_bug.cgi?id=778568
2017-02-14 19:09:33 +01:00
Ondrej Holy
9440035560 user-accounts: Don't modify pre-filled username
If user type custom username, don't modify it automatically when
changing fullname.

https://bugzilla.gnome.org/show_bug.cgi?id=778555
2017-02-14 18:44:52 +01:00
Richard Hughes
2f1af82a4e display: Only show the sunset/sunrise icons when not manually specified 2017-02-14 11:20:08 +00:00
Jeremy Bicha
206310e9fb user-accounts: Use ellipsis for "Remove User"
https://bugzilla.gnome.org/show_bug.cgi?id=778568
2017-02-13 19:56:07 +01:00
Felipe Borges
ae17ba1f47 printers: Set min-content-height on the scrolled window
Set a minimum content height of 490px for the panel when the
allocated height is smaller than 490px.

490 is an estimated value for the panels to properly fit on netbook
screens. See https://wiki.gnome.org/Design/SystemSettings#Notes

https://bugzilla.gnome.org/show_bug.cgi?id=767600
2017-02-13 19:45:35 +01:00
Felipe Borges
378e04125d printers: Make the printers panel a single column
This patch purges all the former TreeView machinery and makes the
Printers panel have the printers listed in a scrolled window, as
designed at https://wiki.gnome.org/Design/SystemSettings/Printers

https://bugzilla.gnome.org/show_bug.cgi?id=767600
2017-02-13 19:45:35 +01:00
Felipe Borges
7e3d89e13a printers: Introduce PpDetailsDialog
This dialog handles the editing of printer properties such as
name, location, automatic discovery of driver, manual selection
of printer driver, and manual selection of ppd file.

https://bugzilla.gnome.org/show_bug.cgi?id=767600
2017-02-13 19:40:09 +01:00
Felipe Borges
37e37961e5 printers: introduce PpPrinterEntry widget
This commit introduces the following regressions:
- no possibility of renaming properties such as printer names,
location, or changing model/driver. This issue is going to be
solved nextly by the introduction of the PpDetailsDialog.

https://bugzilla.gnome.org/show_bug.cgi?id=767600
2017-02-13 19:27:49 +01:00
Felipe Borges
51a184b1b7 user-accounts: Align the elements of "Add User" dialog
https://bugzilla.gnome.org/show_bug.cgi?id=778457
2017-02-13 19:15:05 +01:00
Georges Basile Stavracas Neto
6c633621a4 online-accounts: Drop GoaAddAccountDialog
The dialog is not used anymore, and can be safely removed.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-13 16:00:53 +01:00
Georges Basile Stavracas Neto
a6858fff62 online-accounts: Hide remove button when account is locked
https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-13 15:09:26 +01:00
Georges Basile Stavracas Neto
5807bb4cc3 online-accounts: Add separators between listbox rows
https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-13 14:59:14 +01:00
Georges Basile Stavracas Neto
7d852bfab0 online-accounts: Small UI improvement
Add more margin to the lists.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-13 14:56:31 +01:00
Georges Basile Stavracas Neto
14d0988208 online-accounts: Bring back account removal
Following the previous commit, this commit effectively brings
back the account removal feature that was temporarily removed
by 4e197b491f.

This is now reimplemented as an in-app notification, and users
now have the option to undo an accidentally removed account.

Some changes by Debarshi Ray.

https://bugzilla.gnome.org/show_bug.cgi?id=774222
2017-02-13 14:37:08 +01:00
Ondrej Holy
8e6fccc8c4 user-accounts: Make user icon bigger
User icon should be bigger as per mockup.

https://bugzilla.gnome.org/show_bug.cgi?id=778458
2017-02-13 14:09:09 +01:00
Allan Day
05f675a037 user-accounts: Give user image button a raised appearance
So it looks clickable.

https://bugzilla.gnome.org/show_bug.cgi?id=778458
2017-02-13 12:22:04 +00:00
Allan Day
e84b10a4a2 user-accounts: Add space above settings
The settings were a bit tightly placed to the top of the panel.
This looks more balanced.

https://bugzilla.gnome.org/show_bug.cgi?id=778458
2017-02-13 12:13:20 +00:00
Felipe Borges
da997dc2ce user-accounts: Save vertical space in the alignment of widgets
Compensate border-width changes with respective margins.

https://bugzilla.gnome.org/show_bug.cgi?id=778458
2017-02-13 12:03:25 +01:00
Ondrej Holy
b4c26363d8 user-accounts: Disable animations when reloading users
Animations cause unwanted effects when reloading users, disable them.

https://bugzilla.gnome.org/show_bug.cgi?id=778405
2017-02-13 11:58:42 +01:00
Ondrej Holy
c8b535007f user-accounts: Don't move with arrow during animations
Don't move with the arrow during the stack animation in order to avoid
some ugly movements...

https://bugzilla.gnome.org/show_bug.cgi?id=778405
2017-02-13 11:58:42 +01:00
Felipe Borges
b8983f906f user-accounts: Animate the Carousel Arrow
https://bugzilla.gnome.org/show_bug.cgi?id=778405
2017-02-13 11:58:42 +01:00
Felipe Borges
bce05cb8bd user-accounts: Animate page transitions in the Carousel
https://bugzilla.gnome.org/show_bug.cgi?id=778405
2017-02-13 11:58:42 +01:00
Felipe Borges
c1f56c3e4a user-accounts: Re-label "Remove Account" button to "Remove User"
"Remove User" matches better to "Add User" than "Remove Account".

https://bugzilla.gnome.org/show_bug.cgi?id=778458
2017-02-13 11:55:32 +01:00
Felipe Borges
92e99f677f user-account: Use a stack in user-icon to keep the same size
This fixes the undesired jumps (resizes) while switching between
"Your Account" and any other account.

https://bugzilla.gnome.org/show_bug.cgi?id=778458
2017-02-13 11:55:32 +01:00
Felipe Borges
ffb2aaabe7 user-accounts: Drop the user photo selector arrow
https://bugzilla.gnome.org/show_bug.cgi?id=778458
2017-02-13 11:55:32 +01:00
Jeremy Bicha
a916552933 display: Add Night Light keywords to .desktop
https://bugzilla.gnome.org/show_bug.cgi?id=778461
2017-02-13 05:26:37 -05:00
Bastien Nocera
5c5d608730 user-accounts: Fix button sensitivity in photo dialogue
g_file_info_get_content_type() returns an internal string, and we were
freeing the file_info we got it from in the next line, so it's a miracle
that the mime_type was ever not garbage.

https://bugzilla.gnome.org/show_bug.cgi?id=778424
2017-02-12 20:09:44 +01:00
Bastien Nocera
d2fc99a6d7 display: Fix typo in "Tomorrow"
Re-spotted by Anders Jonsson <anders.jonsson@norsjovallen.se>. First
spotted on IRC, but not fixed.

https://bugzilla.gnome.org/show_bug.cgi?id=778513
2017-02-12 16:14:47 +01:00
Piotr Drąg
555e230508 Remove no longer necessary contexts from translatable strings
These strings changed recently and now their contexts don't disambiguate
anything.
2017-02-12 16:02:22 +01:00
Richard Hughes
2d176bee27 display: Fix up padding in new Night Light dialog 2017-02-10 17:05:37 +00:00
Richard Hughes
fdbd788b96 display: Rename 'Natural Light Filter' to 'Night Light' 2017-02-10 16:32:24 +00:00
Richard Hughes
8c93ec478f display: Update the disabled banner when the interface changes
GNOME Shell is setting this D-Bus property from the status menu when the
natural light filter is disabled.
2017-02-10 13:42:48 +00:00
Richard Hughes
090316deea display: Update the enabled switch when the setting changes
GNOME Shell is setting this settings key from the status menu when the natural
light filter is turned off.
2017-02-10 13:42:48 +00:00
Jeremy Bicha
c08bdf04a5 display: Fix typo in translator message
https://bugzilla.gnome.org/show_bug.cgi?id=778443
2017-02-10 07:37:49 -05:00
Richard Hughes
ef4dfe8896 display: Add natural light UI to the display panel
https://bugzilla.gnome.org/show_bug.cgi?id=778326
2017-02-10 09:07:24 +00:00
Felipe Borges
1610fe581f user-accounts: Make the UmCarouselItems look the same on hover
UmCarouselItem is a button, but since we have now the arrow which
points to the selected item, we don't need any other visual
feedback (such as hover border/background).

https://bugzilla.gnome.org/show_bug.cgi?id=767065
2017-02-09 19:25:28 +01:00