Commit graph

100 commits

Author SHA1 Message Date
Jake Dane
89443fe550 desktop: Remove obsolete Bugzilla entries
The `X-GNOME-Bugzilla-*` entries were for use by bug-buddy, a GNOME 2
technology that's been gone for over a decade. These entries are
obsolete and can be removed from all desktop files.

The `X-GNOME-Settings-Panel` entry is also obsolete as far as I can
tell and only these panels had it in their desktop file: notifications,
sharing, sound and user-accounts. These entries can also be removed.

After removing the `X-GNOME-Bugzilla-*` entries, the desktop files have
no more variables in them. The meson `configure_file` step is therefor
pointless—there are no variables to configure. As such the
`*.desktop.in.in` files are renamed to `*.desktop.in` to reflect this
and `meson.build` files are modified to remove `configure_file` step.
2022-10-20 13:20:09 +00:00
Georges Basile Stavracas Neto
0aed0c5ecd applications: Tweak screenshot description
As per design feedback, tweak the screenshot description text to
"Take pictures of the screen at any time."
2022-08-10 16:50:41 -03:00
Georges Basile Stavracas Neto
17b018a9fb applications: Add support for the screenshot permission
Add support for managing the screenshot permission, used by apps
who request non-interactive screenshots from the portal.

See also https://github.com/flatpak/xdg-desktop-portal/pull/851
2022-08-10 19:03:15 +00:00
Georges Basile Stavracas Neto
6fd7164837 Revert "applications: Add support for the screenshot permission"
This reverts commit 49486dba68.
2022-08-08 17:24:42 -03:00
Georges Basile Stavracas Neto
78434394b2 applications: Add missing end period to Storage row 2022-08-08 19:32:20 +00:00
Georges Basile Stavracas Neto
94b591ac42 applications: Fix header capitalization of background row 2022-08-08 19:32:20 +00:00
Georges Basile Stavracas Neto
49486dba68 applications: Add support for the screenshot permission
Add support for managing the screenshot permission, used by apps
who request non-interactive screenshots from the portal.

See also https://github.com/flatpak/xdg-desktop-portal/pull/851
2022-08-08 19:32:20 +00:00
Robert Ancell
99f27e802f applications: Update snap permissions code to recent changes
Fixes #1845
2022-05-25 23:02:46 +00:00
Robert Ancell
fc1b750f19 applications: Fix CcInfoRow having the wrong parent.
Introduced in 9e38b89752
2022-05-17 12:14:56 +12:00
lsnow
1523ab6c6b applications: crash when switching between two apps
The GIcon returned by g_app_info_get_icon() does
not need to be freed.

See: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1817
2022-05-11 12:39:39 +08:00
Marco Trevisan (Treviño)
adffd7a2df Panels: Update Privacy panels keywords to match specific contents
Ensure we use more specialized keywords for privacy panels, without
repeating the unneeded ones.
2022-05-10 04:18:20 +00:00
Georges Basile Stavracas Neto
bbe3ae4a91 Switch to 'main' everywhere 2022-04-26 14:43:01 -03:00
Christopher Davis
3250b3fab5 applications: Use AdwPreferences{Page,Group} for Built-in Permissions dialog, make it resizable 2022-02-01 14:56:14 +00:00
Christopher Davis
f2d7f5de40 applications: Make handler dialog resizable 2022-02-01 14:56:14 +00:00
Christopher Davis
65b939ad38 applications: make storage dialog resizable and use AdwPreferences{Page,Group}
The dialog needs to be resizeable in order to work on mobile.
For that reason, it also needs scrolling. Because it needs
scrolling, we can't have the flat headerbar without custom
behavior.

For now, use a regular headerbar and AdwPreferences{Group,Page}
2022-02-01 14:56:14 +00:00
Jakub Steiner
13376ecb8b Add individual app icons 2022-01-31 14:08:22 +00:00
Georges Basile Stavracas Neto
77b1821a1d applications: Switch to g_spawn_check_wait_status()
It's the undeprecated version of g_spawn_check_exit_status().
2022-01-20 18:55:44 -03:00
Georges Basile Stavracas Neto
00cb6386e4 applications: Properly protect against NULL app_id
The 'app_id' variable can be NULL, and g_str_has_prefix() does
not particularly enjoy that.
2022-01-20 18:55:03 -03:00
Georges Basile Stavracas Neto
de26f9a8f5 applications: Remove CcActionRow
This class is now unused.
2022-01-20 17:30:45 -03:00
Georges Basile Stavracas Neto
750c4fc5a6 applications: Add descriptions to permission rows
As per mockups.
2022-01-20 17:30:45 -03:00
Georges Basile Stavracas Neto
53d3b9a70e applications: Merge permissions and integration sections
As per mockups
2022-01-20 17:30:45 -03:00
Georges Basile Stavracas Neto
25e0605f54 applications: Polish the Storage dialog
As per mockups, make the headerbar flat, add more spacings
and margins.
2022-01-20 17:30:45 -03:00
Georges Basile Stavracas Neto
4bd4a6e1fe applications: Split file & link handlers
As per mockups, split file and link handlers in the dialog.
2022-01-20 17:30:45 -03:00
Georges Basile Stavracas Neto
28212c77a7 applications: Move handlers section into a dialog
Add a new row in the usage section, like Built-in and Disk
Usage. Move the file handler widgetry into this new dialog.
2022-01-20 17:24:25 -03:00
Georges Basile Stavracas Neto
e1088495d0 applications: Remove integration_list and usage_list
Now that the rows are derivated from AdwPreferencesRow, we can
add them directly into the corresponding preferences groups.

Other groups can't benefit from this cleanup yet because they
have custom widgets.
2022-01-20 17:24:25 -03:00
Georges Basile Stavracas Neto
795cdfd06d applications: Remove section titles
Latest  mockups don't have them. There's still some more
shuffling to do, so let's remove the titles now to help
with that.
2022-01-20 17:24:25 -03:00
Georges Basile Stavracas Neto
1b0d1566c6 applications: Add header with app icon, name, and buttons
This moves the header button into the Applications panel itself,
and adds some fancy header information.
2022-01-20 17:24:25 -03:00
Georges Basile Stavracas Neto
c6b35b7732 applications: Set subtitle of storage row
Set the subtitle of the storage row, instead of the secondary
label, as per latest designs.
2022-01-20 17:24:25 -03:00
Georges Basile Stavracas Neto
187a6f6d48 applications: Set subtitle in built-in row
As per latest design.
2022-01-20 17:24:25 -03:00
Georges Basile Stavracas Neto
dc4d8e262f applications: Group built-in row with storage
As per latest mockup
2022-01-20 17:24:25 -03:00
Georges Basile Stavracas Neto
9e38b89752 applications: Make CcInfoRow subclass AdwActionRow
Same case as previous commit
2022-01-20 17:24:25 -03:00
Georges Basile Stavracas Neto
0bab8a6217 applications: Make CcToggleRow subclass AdwActionRow
Makes paddings, margins, behavior consistent with other panels.
2022-01-20 17:24:25 -03:00
Georges Basile Stavracas Neto
1b42b854c2 applications: Remove CSS file
It is now unused
2022-01-20 17:24:25 -03:00
Georges Basile Stavracas Neto
20bb6d8046 applications: Switch to AdwPreferencesPage & family
This brings a good cleanup in the UI file.
2022-01-20 17:24:25 -03:00
Georges Basile Stavracas Neto
f7d6c102c9 applications: Use AdwStatusPage for the empty page
Make it streamlined with other panels
2022-01-20 17:24:25 -03:00
Georges Basile Stavracas Neto
2c3477176c applications: Switch ti AdwWindowTitle
It's generally a better widget to use in the headerbar, as
it takes care of styling for us.
2022-01-20 02:23:42 +00:00
Georges Basile Stavracas Neto
82c87578cd window: Install action to navigate main leaflet
This allows implementing the back button of panel titlebars
trivially, which is also done in this commit.
2022-01-20 02:23:42 +00:00
Georges Basile Stavracas Neto
4300a4a290 panels: Use new CcPanel helpers for title widgets
This should significantly simplify these panels, by not forcing
them to override GObject.constructed all the time. Most panels
were quite straightfoward.
2022-01-20 02:23:42 +00:00
Georges Basile Stavracas Neto
0ab20af9ba panels: Switch to CcPanel content
Start porting panels to the new panel format. This commit
temporarily makes panels have two titlebar, which will be
fixed soon.
2022-01-20 02:23:42 +00:00
Felipe Borges
c15fb46c42 applications: Fix typo in key name in the desktop file
Regression introduced by commit 9a3cb6ab4.

Reported at 9a3cb6ab44 (note_1356724)
2022-01-17 10:52:38 +01:00
Felipe Borges
9a3cb6ab44 applications: Set the Icon key in desktop file to a icon that exists
While we dynamically append --symbolic to the icons while creating
the sidebar model in
https://gitlab.gnome.org/GNOME/gnome-control-center/-/blob/master/shell/cc-shell-model.c#L270
There are automation tools (such as rpmdiff) that parse desktop files
and verify whether their Icon= matches to an existing file in the
icon theme package.

preferences-desktop-apps doesn't exist in adwaita-icon-theme but
preferences-desktop-apps-symbolic does.
2022-01-14 13:28:24 +01:00
Jan Beich
37b29c32cb meson: drop unused argument for i18n.merge_file()
Ignored in Meson < 0.60.0, deprecated since 0.60.1 and fatal since 0.61.0.

panels/applications/meson.build:10:5: ERROR: Function does not take positional arguments.
panels/background/meson.build:10:5: ERROR: Function does not take positional arguments.
panels/camera/meson.build:10:5: ERROR: Function does not take positional arguments.
[...]
2022-01-07 17:22:43 +00:00
Christopher Davis
7f601f4698 applications: Remove use of sidebar-icon style 2021-12-17 21:36:54 +00:00
Christopher Davis
897c641549 panels: Replace .view.frame with .boxed-list 2021-12-16 16:32:21 -08:00
Christopher Davis
981a8cea7b panels: Use .boxed-list instead of .content
The `.content` style class is deprecated in favor
of the `.boxed-list` style class, which is named
after the design pattern it's used for.
2021-12-16 12:52:44 -08:00
Georges Basile Stavracas Neto
696ed350bb applications: Port to GTK4 2021-12-14 22:34:21 -03:00
Philip Withnall
a9d7b085df applications: Fix selecting an app using the command line
If I run `gnome-control-center applications org.freedesktop.Bustle`
while g-c-c is already running and a different app is shown, Bustle will
be selected in the list box, but the details panel won’t be updated to
show it.

Fix that by emitting the `activate` signal on the row, as is done
everywhere else in `cc-applications-panel.c` when selecting a row.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
2021-08-18 12:48:49 +00:00
Guido Günther
a2cfd2b341 applications: Ellipsize title label
This makes long appliation names fit on narrow displays without pushing
the "Open in Software" button out.
2021-07-28 11:34:02 +00:00
Felipe Borges
540f6edff3 panels: Align dialog labels with their respective listbox below
Both the "Storage" and "Built-in Permissions" dialogs.
2021-02-23 11:55:56 +01:00
Robert Ancell
b259d5207b applications: Fix NULL hash table being unreffed.
When clicking away from the applications panel you can see:
(gnome-control-center:95304): GLib-CRITICAL **: 09:12:52.941: g_hash_table_unref: assertion 'hash_table != NULL' failed
2020-11-10 02:08:35 +00:00