Commit graph

139 commits

Author SHA1 Message Date
Robert Ancell
90c7311664 sharing: Make .ui filename match the .c filename 2019-09-09 21:58:00 +00:00
Mohammed Sadiq
faf305772c sharing: Allow dialogs to have smaller width
Reduce margins on either side, and allow the texts to be
wrapped early, so that it works well on smaller screens
2019-07-23 06:54:50 +05:30
Robert Ancell
a57a85a1db sharing: Fix warning when disabling sharing
The warning is:
(gnome-control-center:29760): Gtk-CRITICAL **: 11:45:48.076: gtk_widget_is_visible: assertion 'GTK_IS_WIDGET (widget)' failed

This is due to the code trying to disable switches that only exist if support
for that feature is available.
2019-07-15 14:38:52 +12:00
Stefano Facchini
b47ada9b76 sharing: Fix master switch
Since the switches for media, personal file, and screen sharing are in the header bar of the
respective dialogs, they are not visible when we click on the master switch. This caused the
check in OFF_IF_VISIBLE to always fail.

Fix it by checking if the corresponding button in the main list box is visible, instead.

Closes: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/240
2019-07-15 00:05:23 +00:00
Georges Basile Stavracas Neto
75f150d5a2 shell: Add position to cc_shell_embed_widget_in_header()
So we can control where the widget should be added to. The
main window only supports left and right positions.

https://gitlab.gnome.org/GNOME/gnome-control-center/issues/528
2019-05-21 12:59:36 -03:00
Adrien Plazas
39ed06188a sharing: Ellipsize the labels
This helps ensuring the panel fits in narrow windows.
2019-03-29 18:20:56 +00:00
Adrien Plazas
b73213ebaf sharing: Adapt the indentation
This adapts the indentation of the children of HdyColumn, which were
deliberately left intact in the previous commit to make it more
readable.
2019-03-29 18:20:56 +00:00
Adrien Plazas
5be6fc4d1f sharing: Use a HdyColumn and a GtkScrolledWindow
Put the widget's content into a HdyColumn, itself into a
GtkScrolledWindow. This allows the panel to reach narrower sizes.

This deliberately doesn't adapt the indentation of the contained widget
to help this commit to be more readable and easier to review, it will be
adapted in the next commit.
2019-03-29 18:20:56 +00:00
Robert Ancell
41d2eff314 sharing: Make .ui filename match the .c filename 2018-11-12 16:41:01 +00:00
Robert Ancell
c058f15d10 sharing: Don't use gtk_widget_show_all
It is removed in GTK+ 4
2018-10-18 01:18:57 +00:00
Benjamin Berg
2bd03bbb6d sharing: Bind hostname_entry from UI
The entry was not bound. Due to this we could run into a segfault trying
to query the hostname_entry. This would only happen if avahi is not
running.

Fixes #178
2018-09-21 16:59:25 +00:00
Jonas Ådahl
49ef965dc7 sharing: Enable settings widget for gnome-remote-desktop
Enable support for manipulating GNOME Remote Desktop settings. Settings
are done via the org.gnome.desktop.remote-desktop.vnc schema.
Configuring the VNC password is done via libsecret, thus libsecret is
added as a dependency.
2018-07-10 19:59:51 +00:00
Robert Ancell
eff88ab2f1 sharing: Use GtkTemplate 2018-06-07 00:58:22 +00:00
Robert Ancell
a30f660db9 sharing: Use g_auto for variables 2018-06-03 01:11:17 +00:00
Robert Ancell
a91ef6c7d7 sharing: Replace ifdefs with #pragma once 2018-06-01 21:21:05 +00:00
Robert Ancell
394797025f sharing: Replace GObject boilerplace with G_DECLARE_TYPE 2018-06-01 21:21:05 +00:00
Jonathan Kang
00a74afc20 sharing: set end margin for labels in Networks list box
Currently if a network connection's name is long enough, there will
be no space between the name label widget and the switch button widget
next to it.

Fix that by setting the end margin of label widget as 6 to keep some
space between those two widgets.
2018-04-26 16:32:25 +00:00
Benjamin Berg
c2f601a9d4 Move common panel code from shell/ to panel/common
This creates a new static library called libwidget which the shell links
against.
2018-04-17 15:26:59 +02:00
Piotr Drąg
7265bd53a0 Add translator comments to .desktop files
Icons are confusing translators, and gettext
is unlikely to get fixed any time soon.
2018-02-23 18:49:35 +01:00
Felipe Borges
5796d83ccd sharing: Move the "Remote Login" dialog Switch into the dialog
https://bugzilla.gnome.org/show_bug.cgi?id=786650
2018-01-25 23:42:02 -02:00
Iñigo Martínez
0dd386f405 build: Migrate from Intltool to Gettext
Recent versions of Gettext are able to translate several formats
that are used in GNOME applications. This patch migrates from
Intltool to Gettext by using meson's i18n features.

https://bugzilla.gnome.org/show_bug.cgi?id=787588
2018-01-23 10:49:31 +01:00
Jeremy Bicha
40fe964a65 sharing: Drop the "Personal" from "Personal File Sharing" description
https://bugzilla.gnome.org/show_bug.cgi?id=772355
2018-01-21 12:37:01 -02:00
Piotr Drąg
3807e45755 sharing: add XML declaration to the .policy file
Without it, gettext mangles UTF-8 characters.

See https://savannah.gnu.org/bugs/?52932

https://bugzilla.gnome.org/show_bug.cgi?id=787588
2018-01-19 16:41:25 +01:00
Iñigo Martínez
dc0988d47c build: Remove autotools
To avoid the burden of maintaining multiple build systems, this
patch removes autotools support.

https://bugzilla.gnome.org/show_bug.cgi?id=785414
2018-01-18 12:20:08 +01:00
Piotr Drąg
b65e31323a panels: Remove soft hyphens from .desktop files
With the old shell gone, there is no need to work around cut off panel
names (bug #647087). As it stands now, it only confuses translators
(invisible characters are hard to, well, see).

https://bugzilla.gnome.org/show_bug.cgi?id=792629
2018-01-18 00:12:04 -02:00
Felipe Borges
afbdddc2ed sharing: properly resize listbox rows
https://bugzilla.gnome.org/show_bug.cgi?id=767646
2018-01-17 23:54:33 -02:00
Georges Basile Stavracas Neto
eca7f39782 sharing: Use gtk_menu_popup_at_pointer
Instead of the deprecated gtk_menu_popup().
2018-01-17 23:23:59 -02:00
Georges Basile Stavracas Neto
0af9a5ad64 sharing: Ensure CcHostnameEntry GType before initialization
The exact same reasoning of 35e670c6da.
2018-01-17 23:18:37 -02:00
Iñigo Martínez
32edd6789e build: Port to meson build system
Meson is a build system focused on speed an ease of use, which
helps speeding up the software development. This patch adds meson
support along autotools.

https://bugzilla.gnome.org/show_bug.cgi?id=785414
2018-01-17 20:09:35 -02:00
Georges Basile Stavracas Neto
b23ef59926 shell-model: Remove old categories
Since we don't maintain two different shells anymore, there
is no need to maintain the two different sets of categories
in the desktop files.

This commit also drops the "#ifdef CC_ENABLE_ALT_CATEGORIES"
blocks, since the previous commit removed that define.

https://bugzilla.gnome.org/show_bug.cgi?id=790923
2017-11-28 17:03:51 -02:00
Rui Matos
2556fd5e2c sharing: Make use of the cancellable for async hostname calls
We have it initialized and disposed and the async calls already handle
being cancelled. We just forgot to actually use it.

https://bugzilla.gnome.org/show_bug.cgi?id=786984
2017-08-29 19:26:58 +02:00
Rui Matos
94045b8418 sharing: Remove an unused variable
https://bugzilla.gnome.org/show_bug.cgi?id=786984
2017-08-29 19:26:58 +02:00
Rui Matos
f959b9127b sharing: Make panel initialization asynchronous
https://bugzilla.gnome.org/show_bug.cgi?id=786984
2017-08-29 19:26:58 +02:00
Rui Matos
58bad723ee sharing: Show the networks widget in the screen sharing dialog
The way it works is independent of the service so there's no reason
not to show it. We should also hide the remote-control-box widget
hierarchy since those can't be used here.

https://bugzilla.gnome.org/show_bug.cgi?id=786565
2017-08-29 19:26:58 +02:00
Jonas Ådahl
ecb0e6dd23 sharing: Add Wayland screen sharing support
This allows enabling screen sharing support under Wayland, as long as
the org.gnome.Mutter.RemoteDesktop D-Bus name is exported by mutter /
gnome-shell. That name will currently only be exported if the
corresponding experimental features has been added to mutter.

So far nothing is configurable, as gnome-remote-desktop is yet to be
configureable.

https://bugzilla.gnome.org/show_bug.cgi?id=786565
2017-08-29 18:55:42 +02:00
Allan Day
87568e9250 Harmonize list box row layouts
While it isn't possible, or even advisable, to make all the list
box rows the same height, using a number of standard heights will
make the control center feel more harmoneous.

Adust the height of the list box rows in Color, Date & Time,
Mouse & Touchpad, Network, Privacy, Region & Language, Sharing
and Universal Access. Makes standard rows that contain labels
and/or controls 58px tall. Some other rows, such as those which
contain two lines of text, are allowed to be taller.

https://bugzilla.gnome.org/show_bug.cgi?id=786384
2017-08-20 18:38:48 +02:00
Allan Day
8a8e53ab8a Standardize vertical spacing of panels
Ensure that the vertical spacing inside each panel is similar.
This makes the transition between each panel smoother and makes
the control center feel more cohesive.

Settings panels are given 32px above and below their content
and 32px vertical space between major sections. 12px space is
placed below headings.

Bluetooth, displays and printers are not addressed.

https://bugzilla.gnome.org/show_bug.cgi?id=786384
2017-08-20 18:38:42 +02:00
Georges Basile Stavracas Neto
f7bdd3c969 panels: Minor adjustments for the new shell 2017-08-09 19:31:41 +02:00
Mohammed Sadiq
4c0928f324 sharing: Don't leak path
g_file_get_path() allocates new memory for path.
So using g_strdup() later would leak the previous allocation.

https://bugzilla.gnome.org/show_bug.cgi?id=782045
2017-05-02 12:55:26 +02:00
Felipe Borges
02ab69bd8f sharing: Hide Vino when using Wayland
Since we don't support "Screen Sharing" under Wayland yet.

https://bugzilla.gnome.org/show_bug.cgi?id=774553
2016-11-17 16:04:32 +01:00
Felipe Borges
da1d8f0d39 sharing: Update "Remote Login" dialog description
To match the new designs at
https://wiki.gnome.org/Design/SystemSettings/Sharing

https://bugzilla.gnome.org/show_bug.cgi?id=767646
2016-06-15 14:19:36 +02:00
Felipe Borges
f3b7c16132 sharing: Drop the "Personal" from "Personal File Sharing"
According to the new designs at
https://wiki.gnome.org/Design/SystemSettings/Sharing

https://bugzilla.gnome.org/show_bug.cgi?id=767646
2016-06-15 11:20:56 +02:00
Georges Basile Stavracas Neto
2777fd583d panels: use the new categories
Following the previous patch, this patch adds the new alternative
categories to the panels' Desktop files. These alternative categories
are only relevant for the alternative Shell, and do not break the
current Shell in any way.

https://bugzilla.gnome.org/show_bug.cgi?id=767301
2016-06-14 12:16:43 -03:00
Felipe Borges
8e414f88b1 sharing: Move "Remote Login" switch to headerbar
According to the new designs at
https://wiki.gnome.org/Design/SystemSettings/Sharing

https://bugzilla.gnome.org/show_bug.cgi?id=767646
2016-06-14 16:00:54 +02:00
Felipe Borges
8b68961431 sharing: Use a checkbutton in the "Screen Sharing" dialog
According to the new designs at
https://wiki.gnome.org/Design/SystemSettings/Sharing
We should use a checkbutton instead of a switch for
the "Allow connections to control the screen" option.
Also, this commit changes this option label accordingly.

https://bugzilla.gnome.org/show_bug.cgi?id=767646
2016-06-14 16:00:01 +02:00
Felipe Borges
612ac49205 sharing: Update "Screen Sharing" dialog description
To match the new designs at
https://wiki.gnome.org/Design/SystemSettings/Sharing

https://bugzilla.gnome.org/show_bug.cgi?id=767646
2016-06-14 15:59:19 +02:00
Felipe Borges
4d001f7989 sharing: Update "Media Sharing" dialog description
To match the new designs at
https://wiki.gnome.org/Design/SystemSettings/Sharing

https://bugzilla.gnome.org/show_bug.cgi?id=767646
2016-06-14 15:58:55 +02:00
Bastien Nocera
5c10ce45b8 panels: Fix translators comments being truncated
Commit b3be076 added soft hyphens along with a comment for translators
to use those soft hyphens. Except that gettext would only grab the one
line out of the four we wrote for translators to read. Put them all on
the same line so that gettext actually extracts those.

https://bugzilla.gnome.org/show_bug.cgi?id=765778
2016-04-28 23:38:00 +02:00
Bastien Nocera
b3be07609a panels: Fix truncated panel names for larger fonts
Note that this fix will not automatically fix translations, which will
need to add soft-hyphens (U+00AD) to their translations themselves, and
will not fix larger fonts for which the split up syllables end up
being bigger than the maximum text width.

It's the best we can do without redesigning the Settings shell, which is
already something planned.

https://bugzilla.gnome.org/show_bug.cgi?id=647087#c13
2016-04-07 16:06:35 +02:00
Bastien Nocera
70672c3658 sharing: Fix "format not a string literal" error
https://bugzilla.gnome.org/show_bug.cgi?id=764150
2016-03-24 17:01:37 +01:00