Commit graph

992 commits

Author SHA1 Message Date
Robert Ancell
a7e3f314e6 network: Rename NetDeviceSimple to NetDeviceBluetooth
It's only being used for bluetooth connections.
2019-11-06 10:16:39 +13:00
Robert Ancell
e90ed2df8a network: Stop NetDeviceEthernet deriving from NetDeviceSimple
It overrode everything anyway.
2019-11-06 10:16:39 +13:00
Robert Ancell
9327a5f4d1 network: Remove unused function 2019-11-06 10:16:20 +13:00
Robert Ancell
d68cb14837 network: Remove unused virtual method 2019-11-06 10:16:20 +13:00
Robert Ancell
0c92c7b461 network: Replace g_object_new with constructors 2019-11-06 10:16:20 +13:00
Robert Ancell
0b481bfb83 network: Remove if statement that is always true 2019-11-06 10:16:20 +13:00
Robert Ancell
6c473c2e14 network: Remove unused net_device_new function 2019-11-06 10:16:20 +13:00
Robert Ancell
6ab75da5c6 network: Use g_clear_pointer 2019-11-06 10:16:20 +13:00
Robert Ancell
8f722a31de network: Fix missing GtkWidget cast 2019-11-06 10:16:18 +13:00
Robert Ancell
d61d13d4e3 network: Hide edit connection buttons if nm-connection-editor not installed 2019-10-31 01:46:19 +00:00
Robert Ancell
4afbeff6ed network: Drop broken patches to import code from network-manager-applet
They are disabled, and aren't going to work due to other changes we have landed.
2019-10-24 08:02:43 +00:00
Robert Ancell
a1439b32b1 network: Remove unused virtual method 2019-10-22 20:11:45 +00:00
Robert Ancell
62af171d8b network: Remove net_object_edit virtual method
It didn't need to be virtual and was only used in two cases
2019-10-22 20:11:45 +00:00
Robert Ancell
926063acb3 network: Remove unused GObject property 2019-10-22 20:11:45 +00:00
Robert Ancell
0e10d2cab4 network: Drop class method for signals
These weren't used and contained a copy/paste error.
2019-10-22 20:11:45 +00:00
Robert Ancell
87b98346df network: Remove virtual method
Nothing ever overrode it; just convert to a normal method.
2019-10-22 20:11:45 +00:00
Robert Ancell
4dbea87109 network: Remove unused includes 2019-10-22 20:11:45 +00:00
Robert Ancell
7f410ee1c6 network: Remove helper functions
They're not complex enough or used in enough places to warrant keeping.
They can be better refactored in the classes that use them.
2019-10-22 20:11:45 +00:00
Robert Ancell
75b4e5e061 network: Simplify helper function 2019-10-22 20:11:45 +00:00
Robert Ancell
f03ae7ff93 network: Move common code UI into each widget using it
It was only used twice and better managed in the actual widgets.
2019-10-22 20:11:45 +00:00
Robert Ancell
9b1226aea5 network: Remove helper function with minimal value
This can be more easily optimised away in the modules that use it.
2019-10-22 20:11:45 +00:00
Robert Ancell
96585c1542 network: Remove unused hotspot connected label 2019-10-22 20:11:45 +00:00
Robert Ancell
4100c69d9c network: Move panel properties into GtkBuilder files 2019-10-22 20:11:45 +00:00
Robert Ancell
708b1fdaf7 network: Use self variable name consistently 2019-10-22 20:11:45 +00:00
Robert Ancell
8b6e3fb736 network: Store widgets inside objects
This is a step towards replacing GtkBuilder with GtkTemplate
2019-10-22 20:11:45 +00:00
Robert Ancell
b331d75df5 network: Rename widget IDs to standard names 2019-10-22 20:11:45 +00:00
Robert Ancell
53f9249b83 network: Remove unused GtkBuilder IDs 2019-10-22 20:11:45 +00:00
Robert Ancell
927f0f7954 network: Remove unused widgets 2019-10-22 20:11:45 +00:00
Robert Ancell
879542d92b network: Merge duplicate signal handlers 2019-10-22 20:11:45 +00:00
Robert Ancell
54f8fce47f network: Connect signals in swapped form 2019-10-22 20:11:44 +00:00
Robert Ancell
d549c9e7bd network: Move non-shared code into the one module that uses it 2019-10-22 20:11:44 +00:00
Robert Ancell
4b9d8ac058 network: Move non-shared code into the one module that uses it 2019-10-22 20:11:44 +00:00
Robert Ancell
8a3da8b36d network: Remove shared callback and replace with a method 2019-10-22 20:11:44 +00:00
Robert Ancell
f556af6e67 network: Move includes to correct file locations 2019-10-22 20:11:44 +00:00
Robert Ancell
37187db328 network: Remove unused virtual method 2019-10-22 20:11:44 +00:00
Robert Ancell
150e7902e6 network: Refactor widget reference out using virtual method 2019-10-22 20:11:44 +00:00
Robert Ancell
4955371660 network: Pass widget references rather than relying on names
The existing code relied on using GtkBuilder, which will no longer work when we
switch to GtkTemplate.
2019-10-22 20:11:44 +00:00
Robert Ancell
823a1dbdaa network: Make public struct private 2019-10-22 20:11:44 +00:00
Robert Ancell
bf43c64b63 network: Remove unused callback type 2019-10-22 20:11:44 +00:00
Robert Ancell
a41ad90671 network: Remove unused field 2019-10-22 20:11:44 +00:00
Robert Ancell
96bd167b77 network: Replace deprecated GtkTable with GtkGrid 2019-10-22 20:11:44 +00:00
Robert Ancell
84c53b01c5 network: Remove unused GtkNotebooks
The security widgets were inside GtkNotebooks, but only ever had one page and
tabs hidden. So they weren't doing anything.
2019-10-22 20:11:44 +00:00
Robert Ancell
e7cec00235 network: Remove unused wifi dialog
This seems to have been copied from the connection editor code, but is not
actually used.
2019-10-22 20:11:44 +00:00
Robert Ancell
ab0be62b78 network: Fix incorrect use of *_get_instance_private
These classes don't have a private structure, but the misuse didn't seem to be
causing a specific issue.
2019-10-22 20:11:44 +00:00
Iain Lane
e4508e0130
network: Accept empty values for the cloned mac address
Empty is a valid value here. It means the setting is not set. Two places
need to be updated:

  - the validation function
  - when retrieving the value from the combo, empty strings need to be
    mapped to a setting value of NULL

Closes #677
2019-10-05 12:14:31 +01:00
Robert Ancell
9a2e821fe5 Initialize autoptr values to NULL.
These cases were safe, but if the code changed this risked freeing uninitialized
memory.
2019-10-03 10:58:38 +13:00
Robert Ancell
bf8b8f52b7 network: Remove an unnecessary goto 2019-10-01 14:52:13 +13:00
Robert Ancell
57d7a79034 network: Pass widget references rather than relying on names
The existing code relied on using GtkBuilder, which will no longer work when we
switch to GtkTemplate.
2019-10-01 14:47:23 +13:00
Robert Ancell
1d43f4c0f5 network: Simplify function 2019-10-01 14:46:14 +13:00
Robert Ancell
3c32ee72ea network: Remove two common functions that are more simply done inside the few cases that use them
The existing code relied on using GtkBuilder, which will no longer work when we
switch to GtkTemplate.
2019-10-01 12:52:42 +13:00